From patchwork Tue Mar 1 16:54:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 108449 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 369DCA034C; Tue, 1 Mar 2022 17:54:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA88541163; Tue, 1 Mar 2022 17:54:18 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 734C940DF6 for ; Tue, 1 Mar 2022 17:54:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646153656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GUFG9fARGZiCN21RE/HBEIWzPxX64SFniFIFCwpGTPI=; b=I/fSZXtmAi3U8q0hyiGYFAQq9C/BmilAkuSxrclcA7QI0KD8kQH42RszJsBVn17kO6wYcB VcMvdqV09lS6BhL6CEFcYNfv6tvro9HpiV8BpsqLb1R9w+pg9rGy/5O6oZGE1YSA8Wu+xX 4DXC6mR4Oa3V20RlG6Imn9jdyT8kS1c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-260-1R4FjvdfP-WrmY0pNeZ3CA-1; Tue, 01 Mar 2022 11:54:15 -0500 X-MC-Unique: 1R4FjvdfP-WrmY0pNeZ3CA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1DA1F1091DA0; Tue, 1 Mar 2022 16:54:14 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.192.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C89B8395D; Tue, 1 Mar 2022 16:54:12 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, stable@dpdk.org, Ray Kinsella , Ferruh Yigit Subject: [PATCH 1/2] devtools: remove event/dlb exception in ABI check Date: Tue, 1 Mar 2022 17:54:03 +0100 Message-Id: <20220301165404.18936-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The event/dlb driver exception can be removed, as this rule made sense for changes in DPDK_21 ABI and is obsolete for DPDK_22. Fixes: fdab8f2e1749 ("version: 21.11-rc0") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Ray Kinsella --- devtools/check-abi.sh | 4 ---- 1 file changed, 4 deletions(-) diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh index 675f10142e..033f6252d0 100755 --- a/devtools/check-abi.sh +++ b/devtools/check-abi.sh @@ -44,10 +44,6 @@ for dump in $(find $refdir -name "*.dump"); do echo "Skipped glue library $name." continue fi - if grep -qE "\ X-Patchwork-Id: 108450 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFB1AA034C; Tue, 1 Mar 2022 17:54:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1C9041177; Tue, 1 Mar 2022 17:54:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 06C72426D2 for ; Tue, 1 Mar 2022 17:54:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646153664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oNXCCxaptl7oZ2BrqFOUgHRU3+ois22V11HkGFWPkU8=; b=WoEdMr2loQTlNnIh17Z44bczVci6sKsz+ES4uq50rxMyFzI+F3ovR5M90Zqb5/G6H4ctSh NOThbQTMXRV144/hdCuIQ6kmdcYA+r55wFwVXJ/gFsaU/Bu01/w5yQMisZfhp2PCmaHsaj Ii9QwZGbrOBDPITxvyELNET0PCuBVzU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-478-zaLBfIFHOfivHYd4R8F3ow-1; Tue, 01 Mar 2022 11:54:19 -0500 X-MC-Unique: zaLBfIFHOfivHYd4R8F3ow-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DA6161091DA4; Tue, 1 Mar 2022 16:54:17 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.192.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 67164837BB; Tue, 1 Mar 2022 16:54:16 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, Ray Kinsella Subject: [PATCH 2/2] devtools: use libabigail rule for mlx glue drivers Date: Tue, 1 Mar 2022 17:54:04 +0100 Message-Id: <20220301165404.18936-2-david.marchand@redhat.com> In-Reply-To: <20220301165404.18936-1-david.marchand@redhat.com> References: <20220301165404.18936-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Convert the existing exception in the ABI script into a libabigail suppression rule. Note: file_name_regexp could be used to achive the same with versions of libabigail < 1.7 but soname_regexp has been preferred here since it is already used with a recent change on common/mlx5. While at it, fix indent from a recent change. Signed-off-by: David Marchand Acked-by: Ray Kinsella --- devtools/check-abi.sh | 7 ------- devtools/libabigail.abignore | 8 ++++++-- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh index 033f6252d0..64e148070d 100755 --- a/devtools/check-abi.sh +++ b/devtools/check-abi.sh @@ -37,13 +37,6 @@ fi error= for dump in $(find $refdir -name "*.dump"); do name=$(basename $dump) - # skip glue drivers, example librte_pmd_mlx5_glue.dump - # We can't rely on a suppression rule for now: - # https://sourceware.org/bugzilla/show_bug.cgi?id=25480 - if grep -qE "\