From patchwork Fri Mar 18 15:03:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 108779 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 933E4A034C; Fri, 18 Mar 2022 16:03:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6990340E28; Fri, 18 Mar 2022 16:03:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5D75A4068A for ; Fri, 18 Mar 2022 16:03:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647615824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=c6q2eK6TFXLxjRmPM0cNeBf1XMLlEPEBRv6LOugDKdM=; b=hh7O4wxcjk2hDM5M9fTmz10V436N4q1ci/xU5vmqWT9w5CyraF35Vx2QINJILg7zYu7NWf eM9CmNaAb6lMaBkPXdJt/Uv4WpYgYw3zvYxOGMFUxs6kCUHp7dFYf9HDsz9XcOk1O0Ikgk TMc6+TQ03tUOF9jIJMGfHzmbTbmxUMI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-241-kJ8zYq_FPfeUNVx929NJEg-1; Fri, 18 Mar 2022 11:03:42 -0400 X-MC-Unique: kJ8zYq_FPfeUNVx929NJEg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A5693811E75; Fri, 18 Mar 2022 15:03:41 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.195.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 61A9D405EC16; Fri, 18 Mar 2022 15:03:40 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Ajit Khaparde , Somnath Kotur , Randy Schacher , Kalesh AP Subject: [PATCH] net/bnxt: fix compatibility with some old firmwares Date: Fri, 18 Mar 2022 16:03:31 +0100 Message-Id: <20220318150331.1650-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975. Reported by Red Hat QE: with older firmware versions (at least versions 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this change. Revert it for now, waiting for a more complete fix. Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index b4aeec593e..bff73a9566 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -1244,11 +1244,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) else HWRM_CHECK_RESULT(); - if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) { - rc = -EAGAIN; - goto error; - } - PMD_DRV_LOG(INFO, "%d.%d.%d:%d.%d.%d.%d\n", resp->hwrm_intf_maj_8b, resp->hwrm_intf_min_8b, resp->hwrm_intf_upd_8b, resp->hwrm_fw_maj_8b, @@ -6149,10 +6144,6 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp) rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB); HWRM_CHECK_RESULT_SILENT(); - - if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) - rc = -EAGAIN; - HWRM_UNLOCK(); return rc;