From patchwork Mon Apr 18 11:05:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raja Zidane X-Patchwork-Id: 109773 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58328A00C4; Mon, 18 Apr 2022 13:05:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F11B040150; Mon, 18 Apr 2022 13:05:32 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2060.outbound.protection.outlook.com [40.107.244.60]) by mails.dpdk.org (Postfix) with ESMTP id 596074014F for ; Mon, 18 Apr 2022 13:05:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oLU7nTD9sNPywFCIBQtFROMAn9iJKxePae+AdScI0VblExNJVM9+hUJDJXzd9u3JyJB3ep3OEKs05fgvUHRhM4NPCfSaPRpWhDunoIPIwd0pZsKnYZzdu/ZPvIuMQuKMcIh+fVWj20WHam27dMjNYx2spXxKNqn5FNRnqk/AAD8+ZwNSZ8QWsFXgwwuwh/6LyMhRmkSl9a9+MNOMxahSgdB0mAPtyVdkV37fejJ0bTBRQN1BRPcJpEyymF3Kyd9KoCDdXyqY36VXMwyxuDXodZSx27SDzra2VkkOYSiRkWh2ke42EFfAQfjwt9rRmw6KkSysaO7GAiSANLMaM5JI9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vQXqsVJPxeMdDN+qS+o/1qTZNka6I4OuMgKw0vY8+yk=; b=finVS/9G07ug5FfR1Q6gfit0wA0WiwBMH4QPFn3IF9H1/UDqtfV7nfIWj+vuHVzLpwS/cNPrc0oV7wHoHDCVWOJM9pyBDqzQTRAjJVFFPm37f7FdqUiiC0IXXoBp9snCJW7Iq2ZZn1kR8JIJaSJk4VwKXqmucZF0VnHt9wPcLtDHI83SBbft2QeeiSpPZZ1ZPc5+ZD9dLLCcVoeocW+LnX5HBsb7X9/n1oLVAc6PwMm64a4frhePo6Ci4NfzNFyH2Kb+oeN/Gy4mdt7tPo0M0WaWGDD2nxSwPM1TO0qQkU4hsqCS38auKT9Fu7z4/OCN+HENf+7Vg7MGqwOJGGNVng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.236) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vQXqsVJPxeMdDN+qS+o/1qTZNka6I4OuMgKw0vY8+yk=; b=A68tR4CeloLgSRY0pqmmSTSXHJyATtQpSGJsVwUSUdBJ7fDMPzis7Af0+GFLM+6TFXgKIGB1mP5Z41XUY3qhUrabkcmJjLtjtrdONGw5rvnnbT3IxNJn32Aie1C7iNekFz1ZSh07phBU5nIkw2zmOPdwAfuvmZ7ciMeF4xSmjb+HiJ45YaxJU9iaKMGcjDI9R60Phs3S0ig/ejNytCcTzBs3PkM/1bBezszHhFkYWAPO8aE9JK6LC3B9vnISb+wf/iMTaIsHBUYVNVQfAkxHgHaArCModbNMimu/7YGntPfHXpM7Xlms/0zqEJ6HaevHSXNQZe4veyuWg5eXg/jEdw== Received: from MW4P222CA0029.NAMP222.PROD.OUTLOOK.COM (2603:10b6:303:114::34) by BL1PR12MB5873.namprd12.prod.outlook.com (2603:10b6:208:395::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr 2022 11:05:29 +0000 Received: from CO1NAM11FT052.eop-nam11.prod.protection.outlook.com (2603:10b6:303:114:cafe::dd) by MW4P222CA0029.outlook.office365.com (2603:10b6:303:114::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend Transport; Mon, 18 Apr 2022 11:05:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.236) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.236 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.236; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.236) by CO1NAM11FT052.mail.protection.outlook.com (10.13.174.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 11:05:28 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL109.nvidia.com (10.27.9.19) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Mon, 18 Apr 2022 11:05:28 +0000 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 18 Apr 2022 04:05:26 -0700 From: Raja Zidane To: CC: Subject: [PATCH] crypto/mlx5: fix login cleanup Date: Mon, 18 Apr 2022 14:05:16 +0300 Message-ID: <20220418110516.2105-1-rzidane@nvidia.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fe58150a-e063-40ee-0fe3-08da212b590c X-MS-TrafficTypeDiagnostic: BL1PR12MB5873:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ji9hyNZoAF84B5LsruPccfIvB8zd/5lU70z5T7v9QVMnrASm8/OoTOrYM0rYw0G/ByaB2mIkyTwkdOUAjQw7OekzKkcGynSvYnJPFhjO10j461KH940GxQ4dgyQ8l+sG6nHfuAy8UNqsMMijLdVTMsyOG8RJVFkUI4JceRM/E5OfvdhtNlh4EVNmhIQ0yYd75PBxNnsSJ5HrY1zdoeGRwS4lW1iH29b3nblmJDCDfILOVoHYL7pAtecP1z3O5Zf2/tCKkR3aZU4ZI2seQ6XSDbhmYiMVNdzLf65bWI/K7XT5eKlH/gq3dMFep6oLzCiOUVSXajBwcjBZIUS7sDIFThVBr6hIqzYRTbkFi+WjSzEcUAOvpse2RSD6JHIjroA8Y+nxmbUI5zBVx079jMhQuJuPi7sU3kNw+K5LiXYjpN/feM+Qvvggza8zMczjkbZI09T6lsQS3i1ZKY02Ro2TqNeYzX+XJXBMHcFjq9aX6HCFm/5BfURjMTjuoncS/CRo5ko9XLeC8xelvGeuEnSkQzoQa9LxVF5tdAeLdbD4x4dYUfyj5ek7czPnAqqDx/COFrpim8QtZa3UH5+qg0rb5A5oduKW744Y1grxwSaLWFXAwSFErl4NlcjsXtQt7fOz5ZvKqQIR9EXVkM9zBt6c22OzWvGCOH1AO+bJ4g/wFbScTTiz8I8xAHPk7Hj9IsBE7tGO2st9QsPO6dFCV8kQEQ== X-Forefront-Antispam-Report: CIP:12.22.5.236; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(2906002)(47076005)(16526019)(186003)(2616005)(8936002)(107886003)(86362001)(55016003)(26005)(83380400001)(6286002)(6666004)(7696005)(508600001)(40460700003)(426003)(1076003)(336012)(36756003)(4744005)(4326008)(36860700001)(356005)(70206006)(70586007)(5660300002)(316002)(81166007)(8676002)(82310400005)(6916009)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 11:05:28.6525 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fe58150a-e063-40ee-0fe3-08da212b590c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.236]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT052.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5873 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In case of a probing failure caused by wrong devarg provided, login isn't destroyed when exiting. Destroy login on failure. Fixes: ba707cdb6da2 ("crypto/mlx5: fix queue size configuration") Signed-off-by: Raja Zidane Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index e14f867797..d0901f3b7c 100644 --- a/drivers/crypto/mlx5/mlx5_crypto.c +++ b/drivers/crypto/mlx5/mlx5_crypto.c @@ -947,6 +947,7 @@ mlx5_crypto_dev_probe(struct mlx5_common_device *cdev, ret = mlx5_crypto_configure_wqe_size(priv, cdev->config.hca_attr.max_wqe_sz_sq, devarg_prms.max_segs_num); if (ret) { + claim_zero(mlx5_devx_cmd_destroy(priv->login_obj)); mlx5_devx_uar_release(&priv->uar); rte_cryptodev_pmd_destroy(priv->crypto_dev); return -1;