From patchwork Tue Apr 19 06:43:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jiang, Cheng1" X-Patchwork-Id: 109834 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4F61A00C3; Tue, 19 Apr 2022 09:12:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4816A40687; Tue, 19 Apr 2022 09:12:48 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id A1B1740150 for ; Tue, 19 Apr 2022 09:12:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650352366; x=1681888366; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tqtrJw8WxiCHtHqWj/D/Slhjl86oNLpxjtCPoiSDT90=; b=MTf04yZuSogoS3xAF6K5dYvfQfntb0bWdUMrlTLq6LMVHnEdLjx1u1yA FfVqNR8+OGuAYoZGoRcyrqAa3k8qXfbKMqNP19fAmXGmVnAUxMYP5OsRp odH7S/NhWiDs3wBsh+QYu8w+Ve/B4fAza4AQOhq1CE+is+W3xLYBS26ps QShyC0V43Rs7HIJbI81mY524Vp6S58/xF071uULoeHtXl/AT9TBvEZMDX /owEoMnApgC9Gt2QRBVicawaDnjaG2v8RbVMOggGANkh7i/JB1RyOc7Jo 7y0a/lIZ0u3mKeNVFrALoMuCGvAXqB+c8z8pfxLJu56PMslrafp08aYbj g==; X-IronPort-AV: E=McAfee;i="6400,9594,10321"; a="245589589" X-IronPort-AV: E=Sophos;i="5.90,272,1643702400"; d="scan'208";a="245589589" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 00:12:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,272,1643702400"; d="scan'208";a="726951243" Received: from dpdk_jiangcheng.sh.intel.com ([10.67.119.26]) by orsmga005.jf.intel.com with ESMTP; 19 Apr 2022 00:12:42 -0700 From: Cheng Jiang To: maxime.coquelin@redhat.com, chenbo.xia@intel.com Cc: dev@dpdk.org, jiayu.hu@intel.com, xuan.ding@intel.com, wenwux.ma@intel.com, yuanx.wang@intel.com, yvonnex.yang@intel.com, Cheng Jiang Subject: [RFC v2] add support for async vhost packed ring dequeue Date: Tue, 19 Apr 2022 06:43:46 +0000 Message-Id: <20220419064346.7360-1-cheng1.jiang@intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This RFC patch implements packed ring dequeue data path for asynchronous vhost. Signed-off-by: Cheng Jiang --- It's based on the patch set: http://patchwork.dpdk.org/project/dpdk/cover/20220419034323.92820-1-xuan.ding@intel.com/ lib/vhost/virtio_net.c | 219 ++++++++++++++++++++++++++++++++++++----- 1 file changed, 193 insertions(+), 26 deletions(-) -- 2.35.1 diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c index 514315ef50..26143344bc 100644 --- a/lib/vhost/virtio_net.c +++ b/lib/vhost/virtio_net.c @@ -3168,7 +3168,7 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id, } static __rte_always_inline uint16_t -async_poll_dequeue_completed_split(struct virtio_net *dev, uint16_t queue_id, +async_poll_dequeue_completed(struct virtio_net *dev, uint16_t queue_id, struct rte_mbuf **pkts, uint16_t count, uint16_t dma_id, uint16_t vchan_id, bool legacy_ol_flags) { @@ -3186,7 +3186,7 @@ async_poll_dequeue_completed_split(struct virtio_net *dev, uint16_t queue_id, from = start_idx; while (vq->async->pkts_cmpl_flag[from] && count--) { vq->async->pkts_cmpl_flag[from] = false; - from = (from + 1) & (vq->size - 1); + from = (from + 1) % vq->size; nr_cpl_pkts++; } @@ -3194,7 +3194,7 @@ async_poll_dequeue_completed_split(struct virtio_net *dev, uint16_t queue_id, return 0; for (i = 0; i < nr_cpl_pkts; i++) { - from = (start_idx + i) & (vq->size - 1); + from = (start_idx + i) % vq->size; pkts[i] = pkts_info[from].mbuf; if (virtio_net_with_host_offload(dev)) @@ -3203,10 +3203,14 @@ async_poll_dequeue_completed_split(struct virtio_net *dev, uint16_t queue_id, } /* write back completed descs to used ring and update used idx */ - write_back_completed_descs_split(vq, nr_cpl_pkts); - __atomic_add_fetch(&vq->used->idx, nr_cpl_pkts, __ATOMIC_RELEASE); - vhost_vring_call_split(dev, vq); - + if (vq_is_packed(dev)) { + write_back_completed_descs_packed(vq, nr_cpl_pkts); + vhost_vring_call_packed(dev, vq); + } else { + write_back_completed_descs_split(vq, nr_cpl_pkts); + __atomic_add_fetch(&vq->used->idx, nr_cpl_pkts, __ATOMIC_RELEASE); + vhost_vring_call_split(dev, vq); + } vq->async->pkts_inflight_n -= nr_cpl_pkts; return nr_cpl_pkts; @@ -3342,8 +3346,8 @@ virtio_dev_tx_async_split(struct virtio_net *dev, struct vhost_virtqueue *vq, out: /* DMA device may serve other queues, unconditionally check completed. */ - nr_done_pkts = async_poll_dequeue_completed_split(dev, queue_id, pkts, pkts_size, - dma_id, vchan_id, legacy_ol_flags); + nr_done_pkts = async_poll_dequeue_completed(dev, queue_id, pkts, pkts_size, + dma_id, vchan_id, legacy_ol_flags); return nr_done_pkts; } @@ -3370,6 +3374,172 @@ virtio_dev_tx_async_split_compliant(struct virtio_net *dev, pkts, count, dma_id, vchan_id, false); } +static __rte_always_inline void +vhost_async_shadow_dequeue_single_packed(struct vhost_virtqueue *vq, uint16_t buf_id) +{ + struct vhost_async *async = vq->async; + uint16_t idx = async->buffer_idx_packed; + + async->buffers_packed[idx].id = buf_id; + async->buffers_packed[idx].len = 0; + async->buffers_packed[idx].count = 1; + + async->buffer_idx_packed++; + if (async->buffer_idx_packed >= vq->size) + async->buffer_idx_packed -= vq->size; + +} + +static __rte_always_inline int +virtio_dev_tx_async_single_packed(struct virtio_net *dev, + struct vhost_virtqueue *vq, + struct rte_mempool *mbuf_pool, + struct rte_mbuf *pkts, + uint16_t slot_idx, + bool legacy_ol_flags) +{ + int err; + uint16_t buf_id, desc_count = 0; + uint16_t nr_vec = 0; + uint32_t buf_len; + struct buf_vector buf_vec[BUF_VECTOR_MAX]; + static bool allocerr_warned; + + if (unlikely(fill_vec_buf_packed(dev, vq, vq->last_avail_idx, &desc_count, + buf_vec, &nr_vec, &buf_id, &buf_len, + VHOST_ACCESS_RO) < 0)) + return -1; + + if (unlikely(virtio_dev_pktmbuf_prep(dev, pkts, buf_len))) { + if (!allocerr_warned) { + VHOST_LOG_DATA(ERR, "Failed mbuf alloc of size %d from %s on %s.\n", + buf_len, mbuf_pool->name, dev->ifname); + allocerr_warned = true; + } + return -1; + } + + err = desc_to_mbuf(dev, vq, buf_vec, nr_vec, pkts, mbuf_pool, + legacy_ol_flags, slot_idx, true); + if (unlikely(err)) { + rte_pktmbuf_free(pkts); + if (!allocerr_warned) { + VHOST_LOG_DATA(ERR, "Failed to copy desc to mbuf on %s.\n", dev->ifname); + allocerr_warned = true; + } + return -1; + } + + /* update async shadow packed ring */ + vhost_async_shadow_dequeue_single_packed(vq, buf_id); + + return err; +} + +static __rte_always_inline uint16_t +virtio_dev_tx_async_packed(struct virtio_net *dev, struct vhost_virtqueue *vq, uint16_t queue_id, + struct rte_mempool *mbuf_pool, struct rte_mbuf **pkts, + uint16_t count, uint16_t dma_id, uint16_t vchan_id, bool legacy_ol_flags) +{ + uint16_t pkt_idx; + uint16_t slot_idx = 0; + uint16_t nr_done_pkts = 0; + uint16_t pkt_err = 0; + uint32_t n_xfer; + struct vhost_async *async = vq->async; + struct async_inflight_info *pkts_info = async->pkts_info; + struct rte_mbuf *pkts_prealloc[MAX_PKT_BURST]; + + VHOST_LOG_DATA(DEBUG, "(%d) about to dequeue %u buffers\n", dev->vid, count); + + async_iter_reset(async); + + if (rte_pktmbuf_alloc_bulk(mbuf_pool, pkts_prealloc, count)) + goto out; + + for (pkt_idx = 0; pkt_idx < count; pkt_idx++) { + struct rte_mbuf *pkt = pkts_prealloc[pkt_idx]; + + rte_prefetch0(&vq->desc_packed[vq->last_avail_idx]); + + slot_idx = (async->pkts_idx + pkt_idx) % vq->size; + if (unlikely(virtio_dev_tx_async_single_packed(dev, vq, mbuf_pool, pkt, + slot_idx, legacy_ol_flags))) { + rte_pktmbuf_free_bulk(&pkts_prealloc[pkt_idx], count - pkt_idx); + break; + } + + pkts_info[slot_idx].mbuf = pkt; + + vq_inc_last_avail_packed(vq, 1); + + } + + n_xfer = vhost_async_dma_transfer(dev, vq, dma_id, vchan_id, async->pkts_idx, + async->iov_iter, pkt_idx); + + async->pkts_inflight_n += n_xfer; + + pkt_err = pkt_idx - n_xfer; + + if (unlikely(pkt_err)) { + pkt_idx -= pkt_err; + + /** + * recover DMA-copy related structures and free pktmbuf for DMA-error pkts. + */ + if (async->buffer_idx_packed >= pkt_err) + async->buffer_idx_packed -= pkt_err; + else + async->buffer_idx_packed += vq->size - pkt_err; + + while (pkt_err-- > 0) { + rte_pktmbuf_free(pkts_info[slot_idx % vq->size].mbuf); + slot_idx--; + } + + /* recover available ring */ + if (vq->last_avail_idx >= pkt_err) { + vq->last_avail_idx -= pkt_err; + } else { + vq->last_avail_idx += vq->size - pkt_err; + vq->avail_wrap_counter ^= 1; + } + } + + async->pkts_idx += pkt_idx; + if (async->pkts_idx >= vq->size) + async->pkts_idx -= vq->size; + +out: + nr_done_pkts = async_poll_dequeue_completed(dev, queue_id, pkts, count, + dma_id, vchan_id, legacy_ol_flags); + + return nr_done_pkts; +} + +__rte_noinline +static uint16_t +virtio_dev_tx_async_packed_legacy(struct virtio_net *dev, + struct vhost_virtqueue *vq, uint16_t queue_id, + struct rte_mempool *mbuf_pool, struct rte_mbuf **pkts, + uint16_t count, uint16_t dma_id, uint16_t vchan_id) +{ + return virtio_dev_tx_async_packed(dev, vq, queue_id, mbuf_pool, + pkts, count, dma_id, vchan_id, true); +} + +__rte_noinline +static uint16_t +virtio_dev_tx_async_packed_compliant(struct virtio_net *dev, + struct vhost_virtqueue *vq, uint16_t queue_id, + struct rte_mempool *mbuf_pool, struct rte_mbuf **pkts, + uint16_t count, uint16_t dma_id, uint16_t vchan_id) +{ + return virtio_dev_tx_async_packed(dev, vq, queue_id, mbuf_pool, + pkts, count, dma_id, vchan_id, false); +} + uint16_t rte_vhost_async_try_dequeue_burst(int vid, uint16_t queue_id, struct rte_mempool *mbuf_pool, struct rte_mbuf **pkts, uint16_t count, @@ -3468,25 +3638,22 @@ rte_vhost_async_try_dequeue_burst(int vid, uint16_t queue_id, count -= 1; } - if (unlikely(vq_is_packed(dev))) { - static bool not_support_pack_log; - if (!not_support_pack_log) { - VHOST_LOG_DATA(ERR, - "(%s) %s: async dequeue does not support packed ring.\n", - dev->ifname, __func__); - not_support_pack_log = true; - } - count = 0; - goto out; + if (vq_is_packed(dev)) { + if (dev->flags & VIRTIO_DEV_LEGACY_OL_FLAGS) + count = virtio_dev_tx_async_packed_legacy(dev, vq, queue_id, + mbuf_pool, pkts, count, dma_id, vchan_id); + else + count = virtio_dev_tx_async_packed_compliant(dev, vq, queue_id, + mbuf_pool, pkts, count, dma_id, vchan_id); + } else { + if (dev->flags & VIRTIO_DEV_LEGACY_OL_FLAGS) + count = virtio_dev_tx_async_split_legacy(dev, vq, queue_id, + mbuf_pool, pkts, count, dma_id, vchan_id); + else + count = virtio_dev_tx_async_split_compliant(dev, vq, queue_id, + mbuf_pool, pkts, count, dma_id, vchan_id); } - if (dev->flags & VIRTIO_DEV_LEGACY_OL_FLAGS) - count = virtio_dev_tx_async_split_legacy(dev, vq, queue_id, - mbuf_pool, pkts, count, dma_id, vchan_id); - else - count = virtio_dev_tx_async_split_compliant(dev, vq, queue_id, - mbuf_pool, pkts, count, dma_id, vchan_id); - *nr_inflight = vq->async->pkts_inflight_n; out: