From patchwork Thu May 12 12:19:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "taoyunxiang@cmss.chinamobile.com" X-Patchwork-Id: 111168 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 741C5A00BE; Mon, 16 May 2022 09:38:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5892740E03; Mon, 16 May 2022 09:38:12 +0200 (CEST) Received: from cmccmta3.chinamobile.com (cmccmta3.chinamobile.com [221.176.66.81]) by mails.dpdk.org (Postfix) with ESMTP id CA9DC40E64 for ; Thu, 12 May 2022 14:20:21 +0200 (CEST) X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from spf.mail.chinamobile.com (unknown[172.16.121.11]) by rmmx-syy-dmz-app09-12009 (RichMail) with SMTP id 2ee9627cfb8129b-3dfd3; Thu, 12 May 2022 20:20:18 +0800 (CST) X-RM-TRANSID: 2ee9627cfb8129b-3dfd3 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from yun.localdomain (unknown[223.108.79.96]) by rmsmtp-syy-appsvr06-12006 (RichMail) with SMTP id 2ee6627cfb81ac0-c7cb4; Thu, 12 May 2022 20:20:18 +0800 (CST) X-RM-TRANSID: 2ee6627cfb81ac0-c7cb4 From: taoyunxiang To: dev@dpdk.org Cc: taoyunxiang Subject: [PATCH] bus: fix code unused Date: Thu, 12 May 2022 20:19:58 +0800 Message-Id: <20220512121958.2491-1-taoyunxiang@cmss.chinamobile.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <8> References: <8> X-Mailman-Approved-At: Mon, 16 May 2022 09:38:11 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The return value of pci_plug in pci_common.c will always be int vaule, can not be NULL. We could use not 0 to check it. Author: Tao YunXiang Signed-off-by: Tao YunXiang --- lib/eal/common/eal_common_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c index 148a23830a..99677bae58 100644 --- a/lib/eal/common/eal_common_dev.c +++ b/lib/eal/common/eal_common_dev.c @@ -143,7 +143,7 @@ local_dev_probe(const char *devargs, struct rte_device **new_dev) if (ret) goto err_devarg; - if (da->bus->plug == NULL) { + if (da->bus->plug != 0) { RTE_LOG(ERR, EAL, "Function plug not supported by bus (%s)\n", da->bus->name); ret = -ENOTSUP;