From patchwork Wed Jun 15 11:27:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Raja Zidane X-Patchwork-Id: 112761 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 638A5A0548; Wed, 15 Jun 2022 13:27:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1766340220; Wed, 15 Jun 2022 13:27:43 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2079.outbound.protection.outlook.com [40.107.237.79]) by mails.dpdk.org (Postfix) with ESMTP id 9F03C40040 for ; Wed, 15 Jun 2022 13:27:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mz1LEyr3Q2G1EAWwZZhTvm8DAsdKygZE0TEscn9drOmrht9nvf8z0rO+LcYLYGbZvgJCBlEJYUqtjTisaKqS8UZFhvrOV74kQegWYA26roEPmj/n71GfaoEcwQYEIWIDzqqNj7wFtC97AQcL1lzzVSo3aKz3KTWiMiKc5xNgNmYnF/zA0Jsx35nkNDRML67xcTigaEaU1cyXgIyZfOEAe6F9aHoN94XAMFfLjNEXUtweaOAXOVmEQONOOoqg+BNn4zeO3ja3dJFMqAO7EN0RNEXhpZ1t0RbIasQLdDNXCdUKmbGWpM5tZg5WiMzuv+Uu+CUaNt4ucZqv8EFCm61IcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F2mlP08GGemaaJ1rSVlE9GhOF2SiUaC6F1XP/yT0Idc=; b=aenAzlJK8XjVwbWQs7Z2CnpEw3pHOgs5HsaVRX1GqzgIzCUw1K6iqP2SZ7eZ5nb9ChqtAOFESpcIMUNuHEfELFpvcmk+d325e2lRlJ8T5+APhXZNC2lS/NUWbuz+Meb33++7P4XdA23WzXaEBo31Ev5RQVGLWGgAum385ODUuRFIHUCEPWryvoIrDfkIyaLJAOrjahUKZk/iWgIH4HH5CxmpSpIt0vRclsb5ZEcCXpjoSVH0tl0lNlhXL81YE9+Ouk2Jtwpj/A+SBWJgxb20W++eVfkQxa9nFwNEFBagQwLWTpg5vVyiKhUqyXHTB0rUg4B+jB2T1NcvLSN15GXKnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.238) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F2mlP08GGemaaJ1rSVlE9GhOF2SiUaC6F1XP/yT0Idc=; b=hadnRR1+MGZwQajbd9MfloM3ekG6+X2Ixmr/0nbRLpcwV668AJ0CA8fZ/BmF3FGk6KejSwJN63qYsdssAMl4ax/MgM3SKAh5OzM0wBvGTiZveeNuJd44LZ+o1axhKCGoYZE5wyHdo9/xf/hk5IlKaYvT3CdNXUUmsFqa5KEmcnOC5B9IYUAhTvcQTSmCq+JrNchrL+fA+5kfceJHhpgslvydUWHaq2KT9JQuIvpNJqCih0prlMyDWX0XTpL3WrBAmgnwgpWwRJMn1NBuCHfj57Rp7l6RGCDuT0qyY6h/7dWyNzCL4NRt7vjXWq02TnSPfsIEmzA4UQ3GxjEiC2koQw== Received: from DM6PR18CA0023.namprd18.prod.outlook.com (2603:10b6:5:15b::36) by CH2PR12MB4874.namprd12.prod.outlook.com (2603:10b6:610:64::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.13; Wed, 15 Jun 2022 11:27:39 +0000 Received: from DM6NAM11FT044.eop-nam11.prod.protection.outlook.com (2603:10b6:5:15b:cafe::29) by DM6PR18CA0023.outlook.office365.com (2603:10b6:5:15b::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.22 via Frontend Transport; Wed, 15 Jun 2022 11:27:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.238) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.238 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.238; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.238) by DM6NAM11FT044.mail.protection.outlook.com (10.13.173.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5332.12 via Frontend Transport; Wed, 15 Jun 2022 11:27:38 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL105.nvidia.com (10.27.9.14) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Wed, 15 Jun 2022 11:27:38 +0000 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 15 Jun 2022 04:27:36 -0700 From: Raja Zidane To: CC: Matan Azrad , Gregory Etelson Subject: [PATCH] net/mlx5: block negative integrity flows Date: Wed, 15 Jun 2022 14:27:28 +0300 Message-ID: <20220615112728.14956-1-rzidane@nvidia.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6f5c0d51-e9ff-4687-c796-08da4ec20ddf X-MS-TrafficTypeDiagnostic: CH2PR12MB4874:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ue0tyCfautoCUV6k/dUjhL8MQAWpP4LTob5wURLrliJ98XS1cSuspt9O1AN3SYTv00t53o5uCGmatmosAFEdvf0jj2jYCOOK2j+quxYrUWlI7wCD+RoAb6Cr8gtHmygjlwcYoOOkttCLwCkvTrgka1Nd8QcBBgKVRJmAEs1WVFGsphH0iNT9EJdaRcsG7VPpQAFShNJX6UpuFnm/TXrTbe+K3gyqTE+kyNUP9GbyyVoaPMloPZcF2bhDAHBK87543reReg1rX35eVRgaSlokGEH+jV4kHZBYOVM+jB7iNa+CMOvG6blS/I6C6HFwk1yXIyxvrqfwgxrJka9Fb54uP62PSm5/7NaIWZ33lqjHGCk1aAIaUCOUxf4HwH/0y1HZZZbwkaVaAUcniKzRjGocT6sKiuYHgRLiU2XaWt/BEQ/1mcMmierNMO14DT1sWAF+aAsjCyrUMnSDsDdb6L6z/KWlK8PgQCyUz7v1I0VZd4rs6llA/O71OmWLDcosqGshF7P3MDOTebhdu5KHc00l1d2nDHj1nBCoOhJU7NXJSABbDkePu/KPBU7QHfa2xODoXfQMVyY0lxmwXtU/UrQNMm8nVbIJCLTuqYB4F7jSiXwj4e7l/oM7oFP3lDrTpEsA2vPKJFTrZ64E+DREmndZ1gli4oAHph9AfBZEYFSzTRHkI8LzmNBuZIaCpDPVkaFj9iFrI7K+rdenu3KSTQWl9Q== X-Forefront-Antispam-Report: CIP:12.22.5.238; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230016)(4636009)(40470700004)(46966006)(36840700001)(54906003)(316002)(356005)(47076005)(336012)(6916009)(1076003)(2616005)(83380400001)(36756003)(2906002)(107886003)(55016003)(6286002)(186003)(4326008)(426003)(70206006)(70586007)(508600001)(8676002)(16526019)(86362001)(5660300002)(8936002)(6666004)(36860700001)(82310400005)(26005)(81166007)(40460700003)(7696005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 11:27:38.8487 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6f5c0d51-e9ff-4687-c796-08da4ec20ddf X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.238]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT044.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4874 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Negative integrity flows are supported, but malfunctioning due to a bug, and an API change is necessary to fix. Drop negative flow support for now. Signed-off-by: Raja Zidane Acked-by: Matan Azrad Acked-by: Gregory Etelson --- doc/guides/nics/mlx5.rst | 4 +++- drivers/net/mlx5/mlx5_flow_dv.c | 6 ++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index f41703277e..f28a874006 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -467,7 +467,9 @@ Limitations TCP or UDP, must be in the rule pattern as well:: flow create 0 ingress pattern integrity level is 0 value mask l3_ok value spec l3_ok / eth / ipv6 / end … - or + + Negative integrity flows are not supported. i.e. + flow create 0 ingress pattern integrity level is 0 value mask l4_ok value spec 0 / eth / ipv4 proto is udp / end … - Connection tracking: diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 65b02b20ce..f82986ac31 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -6809,6 +6809,12 @@ flow_dv_validate_item_integrity(struct rte_eth_dev *dev, RTE_FLOW_ERROR_TYPE_ITEM, integrity_item, "unsupported integrity filter"); + if ((mask->l3_ok & !spec->l3_ok) || (mask->l4_ok & !spec->l4_ok) || + (mask->ipv4_csum_ok & !spec->ipv4_csum_ok) || + (mask->l4_csum_ok & !spec->l4_csum_ok)) + return rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ITEM, + NULL, "negative integrity flow is not supported"); if (spec->level > 1) { if (pattern_flags & MLX5_FLOW_ITEM_INNER_INTEGRITY) return rte_flow_error_set