From patchwork Tue Jun 21 06:22:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tu, Lijuan" X-Patchwork-Id: 113132 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD5EAA0550; Tue, 21 Jun 2022 08:26:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B778C4069C; Tue, 21 Jun 2022 08:26:39 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 99ABE40151 for ; Tue, 21 Jun 2022 08:26:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655792798; x=1687328798; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=bP4fQ2kj+/6oiN48uakGxgstSYjpqZGzCbf5qnP78E0=; b=IoO7yJB6M1b/GPo7VBp57hgVsNN41F75xJgfCHzwbMDiPD6udDVunG7Q +J59+VFhqMBQqcHd6Luvlowzh4jaxDMFfpT6hx1IA1L7R0bDgHHi5TDlT k/Z5gjvgjPR1Ok2iTdCh6gR+Byp39/rpuELoAjEouN/EOFdcc5RPHxDAE XgWyXha9mzbmAMGWa22aNOYHLwm6Z4EiIITFWz2ppZCf48H76T6z7PVPi yRwlWGsza+rllW4yroUHjoGoMZQYwipVYMXj69v2k00lAh4rdnhxFenhn 49igE80H9MG6ljBJIDh4KlKOwRu+9gJncqJ06dVL7/9L0wG3Qq2fVp6g/ w==; X-IronPort-AV: E=McAfee;i="6400,9594,10384"; a="263071532" X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="263071532" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2022 23:26:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="689788463" Received: from dpdk-lijuan-1.sh.intel.com ([10.67.119.208]) by fmsmga002.fm.intel.com with ESMTP; 20 Jun 2022 23:26:35 -0700 From: Lijuan Tu To: dts@dpdk.org Cc: Lijuan Tu , Owen Hilyard Subject: [v2] tests/unit_tests: Unit Test Deprecation Date: Tue, 21 Jun 2022 14:22:50 +0800 Message-Id: <20220621062250.2924341-1-lijuan.tu@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Meson was judged to be a sufficent test harness for running DPDK unit tests. To avoid the ongoing maintenance burden of these test suites, they will be deleted in the next release. Signed-off-by: Owen Hilyard Signed-off-by: Lijuan Tu --- doc/dts_gsg/rel_notes/release_22_03.rst | 38 ++++++++++++++++++++ tests/TestSuite_unit_tests_cmdline.py | 3 ++ tests/TestSuite_unit_tests_crc.py | 3 ++ tests/TestSuite_unit_tests_cryptodev_func.py | 3 ++ tests/TestSuite_unit_tests_dump.py | 3 ++ tests/TestSuite_unit_tests_eal.py | 3 ++ tests/TestSuite_unit_tests_event_timer.py | 4 +++ tests/TestSuite_unit_tests_kni.py | 4 +++ tests/TestSuite_unit_tests_loopback.py | 3 ++ tests/TestSuite_unit_tests_lpm.py | 3 ++ tests/TestSuite_unit_tests_mbuf.py | 3 ++ tests/TestSuite_unit_tests_mempool.py | 3 ++ tests/TestSuite_unit_tests_pmd_perf.py | 3 ++ tests/TestSuite_unit_tests_power.py | 3 ++ tests/TestSuite_unit_tests_qos.py | 3 ++ tests/TestSuite_unit_tests_ring.py | 3 ++ tests/TestSuite_unit_tests_ringpmd.py | 3 ++ tests/TestSuite_unit_tests_timer.py | 3 ++ 18 files changed, 91 insertions(+) create mode 100644 doc/dts_gsg/rel_notes/release_22_03.rst diff --git a/doc/dts_gsg/rel_notes/release_22_03.rst b/doc/dts_gsg/rel_notes/release_22_03.rst new file mode 100644 index 00000000..c1b87be5 --- /dev/null +++ b/doc/dts_gsg/rel_notes/release_22_03.rst @@ -0,0 +1,38 @@ +.. SPDX-License-Identifier: BSD-3-Clause + Copyright 2022 The DTS contributors + +DTS Release 22.03 +================= + +New Features +------------ + +* **Add new test plans.** + +* **Add new test suites.** + + +Removed Items +------------- + +* **Remove test plans.** + +* **Remove test suites.** + + +Removed Items +------------- + +**Removed Makefile Builds.** + +Support for makefile builds has been removed. + + +Deprecation Notices +------------------- + +**Unit Testing** + +DPDK provide 2 ways to run unit test, one is `dpdk-test` app, the other is `meson test` command. +Support for running unit tests through `dpdk-test` app is now deprecated and will be removed in the next release. +Instead `meson test` command will be executed. diff --git a/tests/TestSuite_unit_tests_cmdline.py b/tests/TestSuite_unit_tests_cmdline.py index de78ca6d..2ae6e8c1 100644 --- a/tests/TestSuite_unit_tests_cmdline.py +++ b/tests/TestSuite_unit_tests_cmdline.py @@ -32,6 +32,9 @@ class TestUnitTestsCmdline(TestCase): """ # icc compilation cost long long time. self.cores = self.dut.get_core_list("all") + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) def set_up(self): """ diff --git a/tests/TestSuite_unit_tests_crc.py b/tests/TestSuite_unit_tests_crc.py index 33d33f7e..683360d5 100644 --- a/tests/TestSuite_unit_tests_crc.py +++ b/tests/TestSuite_unit_tests_crc.py @@ -30,6 +30,9 @@ class TestUnitTestsCrc(TestCase): Run at the start of each test suite. """ self.cores = self.dut.get_core_list("all") + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) def set_up(self): """ diff --git a/tests/TestSuite_unit_tests_cryptodev_func.py b/tests/TestSuite_unit_tests_cryptodev_func.py index 816109e8..9aff00ea 100644 --- a/tests/TestSuite_unit_tests_cryptodev_func.py +++ b/tests/TestSuite_unit_tests_cryptodev_func.py @@ -13,6 +13,9 @@ class UnitTestsCryptodev(TestCase): def set_up_all(self): self._app_path = self.dut.apps_name["test"] cc.bind_qat_device(self, "vfio-pci") + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) def set_up(self): pass diff --git a/tests/TestSuite_unit_tests_dump.py b/tests/TestSuite_unit_tests_dump.py index 1f00fc8a..da4caf25 100644 --- a/tests/TestSuite_unit_tests_dump.py +++ b/tests/TestSuite_unit_tests_dump.py @@ -39,6 +39,9 @@ class TestUnitTestsDump(TestCase): self.verify(len(self.dut_ports) >= 1, "Insufficient ports for testing") self.start_test_time = 60 self.run_cmd_time = 60 + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) def set_up(self): """ diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py index 9cac6197..431fda01 100644 --- a/tests/TestSuite_unit_tests_eal.py +++ b/tests/TestSuite_unit_tests_eal.py @@ -38,6 +38,9 @@ class TestUnitTestsEal(TestCase): eal_params = self.dut.create_eal_parameters(cores=default_cores) app_name = self.dut.apps_name["test"] self.test_app_cmdline = app_name + eal_params + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) def set_up(self): """ diff --git a/tests/TestSuite_unit_tests_event_timer.py b/tests/TestSuite_unit_tests_event_timer.py index f48d8e4e..01b64099 100644 --- a/tests/TestSuite_unit_tests_event_timer.py +++ b/tests/TestSuite_unit_tests_event_timer.py @@ -39,6 +39,10 @@ class TestUnitTestEventTimer(TestCase): self.eventdev_timer_device_bus_id = "0000:0a:01.0" self.dut.bind_eventdev_port(port_to_bind=self.eventdev_timer_device_bus_id) + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) + def set_up(self): """ Run before each test case. diff --git a/tests/TestSuite_unit_tests_kni.py b/tests/TestSuite_unit_tests_kni.py index 65515c21..2b4b44aa 100644 --- a/tests/TestSuite_unit_tests_kni.py +++ b/tests/TestSuite_unit_tests_kni.py @@ -37,6 +37,10 @@ class TestUnitTestsKni(TestCase): self.verify("Error" not in out, "Error loading KNI module: " + out) + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) + # # # diff --git a/tests/TestSuite_unit_tests_loopback.py b/tests/TestSuite_unit_tests_loopback.py index f596e242..368dfbeb 100644 --- a/tests/TestSuite_unit_tests_loopback.py +++ b/tests/TestSuite_unit_tests_loopback.py @@ -55,6 +55,9 @@ class TestUnitTestsLoopback(TestCase): self.tmp_path = "/tmp/test_pmd_perf.c" self.dut.send_expect("rm -fr %s" % self.tmp_path, "# ") self.dut.send_expect("cp app/test/test_pmd_perf.c %s" % self.tmp_path, "# ") + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) def set_up(self): """ diff --git a/tests/TestSuite_unit_tests_lpm.py b/tests/TestSuite_unit_tests_lpm.py index f3ad6355..711d705f 100644 --- a/tests/TestSuite_unit_tests_lpm.py +++ b/tests/TestSuite_unit_tests_lpm.py @@ -34,6 +34,9 @@ class TestUnitTestsLpmIpv6(TestCase): Qos Prerequisites """ self.cores = self.dut.get_core_list("all") + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) def set_up(self): """ diff --git a/tests/TestSuite_unit_tests_mbuf.py b/tests/TestSuite_unit_tests_mbuf.py index c7962abd..c6b8c0ad 100644 --- a/tests/TestSuite_unit_tests_mbuf.py +++ b/tests/TestSuite_unit_tests_mbuf.py @@ -31,6 +31,9 @@ class TestUnitTestsMbuf(TestCase): Run at the start of each test suite. """ self.cores = self.dut.get_core_list("all") + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) def set_up(self): """ diff --git a/tests/TestSuite_unit_tests_mempool.py b/tests/TestSuite_unit_tests_mempool.py index 25cefecd..a7f2d49d 100644 --- a/tests/TestSuite_unit_tests_mempool.py +++ b/tests/TestSuite_unit_tests_mempool.py @@ -31,6 +31,9 @@ class TestUnitTestsMempool(TestCase): Run at the start of each test suite. """ self.cores = self.dut.get_core_list("all") + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) def set_up(self): """ diff --git a/tests/TestSuite_unit_tests_pmd_perf.py b/tests/TestSuite_unit_tests_pmd_perf.py index c1c35d27..d043bc2c 100644 --- a/tests/TestSuite_unit_tests_pmd_perf.py +++ b/tests/TestSuite_unit_tests_pmd_perf.py @@ -44,6 +44,9 @@ class TestUnitTestsPmdPerf(TestCase): self.anchors = ["rxtx", "rxonly", "txonly"] socket_id = self.dut.ports_info[0]["port"].socket self.cores = self.dut.get_core_list(config="1S/4C/1T", socket=socket_id) + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) def set_up(self): """ diff --git a/tests/TestSuite_unit_tests_power.py b/tests/TestSuite_unit_tests_power.py index a3214964..9bd2ce67 100644 --- a/tests/TestSuite_unit_tests_power.py +++ b/tests/TestSuite_unit_tests_power.py @@ -32,6 +32,9 @@ class TestUnitTestsPower(TestCase): Power Prerequisites """ self.cores = self.dut.get_core_list("all") + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) def set_up(self): """ diff --git a/tests/TestSuite_unit_tests_qos.py b/tests/TestSuite_unit_tests_qos.py index 2938d7c9..20459622 100644 --- a/tests/TestSuite_unit_tests_qos.py +++ b/tests/TestSuite_unit_tests_qos.py @@ -33,6 +33,9 @@ class TestUnitTestsQos(TestCase): QoS Prerequisites """ self.cores = self.dut.get_core_list("all") + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) def set_up(self): """ diff --git a/tests/TestSuite_unit_tests_ring.py b/tests/TestSuite_unit_tests_ring.py index 91c5788c..924778a0 100644 --- a/tests/TestSuite_unit_tests_ring.py +++ b/tests/TestSuite_unit_tests_ring.py @@ -31,6 +31,9 @@ class TestUnitTestsRing(TestCase): Run at the start of each test suite. """ self.cores = self.dut.get_core_list("all") + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) def set_up(self): """ diff --git a/tests/TestSuite_unit_tests_ringpmd.py b/tests/TestSuite_unit_tests_ringpmd.py index 4f4442b9..137c6f37 100644 --- a/tests/TestSuite_unit_tests_ringpmd.py +++ b/tests/TestSuite_unit_tests_ringpmd.py @@ -32,6 +32,9 @@ class TestUnitTestsRingPmd(TestCase): Nothing to do here. """ self.cores = self.dut.get_core_list("all") + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) def set_up(self): """ diff --git a/tests/TestSuite_unit_tests_timer.py b/tests/TestSuite_unit_tests_timer.py index 82d82fa2..7767dd89 100644 --- a/tests/TestSuite_unit_tests_timer.py +++ b/tests/TestSuite_unit_tests_timer.py @@ -38,6 +38,9 @@ class TestUnitTestsTimer(TestCase): self.this_timeout = 60 if len(self.cores) > 16: self.this_timeout = self.this_timeout * len(self.cores) / 16 + self.logger.warning( + f"Test Suite {self.__name__} is deprecated and will be removed in the next release" + ) def set_up(self): """