From patchwork Wed Jun 22 18:51:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 113265 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68F21A034C; Wed, 22 Jun 2022 20:52:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F486427F1; Wed, 22 Jun 2022 20:52:05 +0200 (CEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 83DC44069F for ; Wed, 22 Jun 2022 20:52:02 +0200 (CEST) Received: by mail-pl1-f178.google.com with SMTP id y6so16162086plg.0 for ; Wed, 22 Jun 2022 11:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ASDI7VlMGbt/sowXqxAvG6UCiOr64gL8QK31uMKnzVs=; b=GTq/F/qGSLUhB3cPGnxqPxdqVuuNqlypqq2DK7lSbxlgPtIo3IPExdmZIKyA/Yhw++ lNdcsXBzhN6KgD92dqfzuu4P3gWS3b2UbIm/oD1pVO8C4wySZWDpIS35L3U4tEuRXTV1 jrjAcuWNs9TPazxdmKGzGLwFTrNClp9ZgDV/xuy1C7Md32ii0/HZQiutag+IRykJTFxe pdB3bwJK179CHJAjfvBi+hPc+ro9EL/FP/0PhnL5GYFm4eeBTntSMjMr3htR3QOxsNo+ cXloHGFuQepZP1xPfd/3ep2eSutiUUjnySnWTYJbw2IzpYG/kdiW45FE4GKNrolCDx7j orlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ASDI7VlMGbt/sowXqxAvG6UCiOr64gL8QK31uMKnzVs=; b=06mSJlR8d+TJzmqu+JlYPbBXLlLqtDM0bLtjaVy8mX1cHXfpiT0+qZqhUcL6JZObYQ LGhn5YUd/nyYV4F5l7zV1QO7oMqGhgo/NXqBrx3VO/aMQ7d4hGC0GiuKrmo2SeIzXIpy 2Dm/jkC7+uMDShMoh2+GnCgpEdKg04oSZ0IVSG7+Od9MweZCzZ8tWCfhkgnwMCdK0nyM 12AEO7L0SPq3sLVRBBZowc/kT5q4/zStQtBBD4+uHIVRiPnsMWoqrwYiys4dAsEBNZJw jmJdL89nXJGYrIa8i3JpND+9F42sXQc2cftTOvKp1Bde6m6CtPC6hfKiV8XTMVbzuY6i l0Cg== X-Gm-Message-State: AJIora+eOUfzIxCGf74gZTbrSyHPWL4VFOCVvUWSkEicnwUawXIhcZj/ dUvNC24TGB7knnsebWWfeevXJ/RKCa1yLZLU X-Google-Smtp-Source: AGRyM1veChZ7mZY2tJbI2drB+QAiPBL9boGQtX+kh+N9TqR3vA90WsdJUWoBVoxssc/pLeAewz6LKA== X-Received: by 2002:a17:903:41d2:b0:16a:2cca:4869 with SMTP id u18-20020a17090341d200b0016a2cca4869mr13690920ple.13.1655923921460; Wed, 22 Jun 2022 11:52:01 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id r6-20020a638f46000000b00407e25d4527sm9215817pgn.22.2022.06.22.11.52.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 11:52:00 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Matan Azrad , Viacheslav Ovsiienko Subject: [PATCH 1/3] vdpa/mlx5: remove unnecessary null check Date: Wed, 22 Jun 2022 11:51:56 -0700 Message-Id: <20220622185158.397779-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220622185158.397779-1-stephen@networkplumber.org> References: <20220622185158.397779-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Found by nullfree.cocci. Signed-off-by: Stephen Hemminger Acked-by: Matan Azrad --- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c index e025be47d277..e06d6afb676f 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c @@ -285,8 +285,7 @@ mlx5_vdpa_virtq_setup(struct mlx5_vdpa_priv *priv, int index) if (virtq->umems[i].obj) claim_zero(mlx5_glue->devx_umem_dereg (virtq->umems[i].obj)); - if (virtq->umems[i].buf) - rte_free(virtq->umems[i].buf); + rte_free(virtq->umems[i].buf); virtq->umems[i].size = 0; virtq->umems[i].obj = NULL; virtq->umems[i].buf = NULL; From patchwork Wed Jun 22 18:51:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 113266 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56D9BA034C; Wed, 22 Jun 2022 20:52:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72DBF4280C; Wed, 22 Jun 2022 20:52:06 +0200 (CEST) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id BBB7F40DDB for ; Wed, 22 Jun 2022 20:52:03 +0200 (CEST) Received: by mail-pg1-f178.google.com with SMTP id h192so16904556pgc.4 for ; Wed, 22 Jun 2022 11:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zfI0msxtJexYn9bg1W1OKQ2JGVCOz9N/nINVqmZiRW4=; b=JnbtYemprlvQkB/5sZwtTwsatxyX7FdbrTvBijMoU4GwDlG4um34fS7KaBO/5VSi7n iUlNchJDk735gSuTiPwZGLCek0JILM9wueJqR9lEtE6isvo1yTNweAvoWKHcuWqf2/6Q 8NUgQwEcrN1jkVXUbiM1ZnRCfITsNXaElvSiK00RY21FNrPwzfCWbKMeYqZpgOdCZiDb 1VbeLP/CKGgspt8SRj9ewK2rU4hi687xIxT17bBLCoT+aZS/nwGPeYfbGcvii6XbnPAL wmLHwuz1w7UvhKCoZwgbX9vmNrbK4gTKwiwTdDmgiVhygirvPbxFIuKEFO0qzr22hamt ULHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zfI0msxtJexYn9bg1W1OKQ2JGVCOz9N/nINVqmZiRW4=; b=2sNtwssf6MRdzpwRSaIqXpF4QXD9q9SP1Tu2sJUiub3fKdpvmp+D0HLW+umOYnqpSu FEOZyxuBdEUCdHaDdvn3KLASvnQm7SkdZC3VBqAkhtIbIxxBPEHHbazGq8dnc0xv/RhH PeTwKp1k9j+7v14LvxxJ8oLd2GF5PJ5wdIG9pnPk88xeeYd260mWnSuP5iyklOONiqkP yY30XQS88NYVrGaRPgPUR4KyaNuDw9nq2LDId9+HSuwwiRWx/Vl5U00/Ec4OUDZh+xEg fgBp4S69JByY7VtqtwDMJDycxSR4Ephj73HeqX0Gm1+o4UwIDqhrXVmvQFC/UYMnYTqT 4ndg== X-Gm-Message-State: AJIora+SD8H8rG5/0KVUO1iR55723aE9pqQOr+Ke8cYN7AOWZmDgfH/Y dB2PT2yzkPyB7iUe3h3SADqLO1lIjdprUJqm X-Google-Smtp-Source: AGRyM1sbPP7IC3P2RvNSyIvZZjVTwlD5fn/4Gfkgdu3Z82A6dX612qez9o9gvMJwpM+cxj9P507Zxw== X-Received: by 2002:a05:6a00:430e:b0:525:26c1:973e with SMTP id cb14-20020a056a00430e00b0052526c1973emr15963582pfb.52.1655923922656; Wed, 22 Jun 2022 11:52:02 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id r6-20020a638f46000000b00407e25d4527sm9215817pgn.22.2022.06.22.11.52.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 11:52:02 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rosen Xu , Tianfei zhang Subject: [PATCH 2/3] raw/ifpga: remove unnecessary null check Date: Wed, 22 Jun 2022 11:51:57 -0700 Message-Id: <20220622185158.397779-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220622185158.397779-1-stephen@networkplumber.org> References: <20220622185158.397779-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The function rte_kvargs_free handles calling with NULL. Found by nullfree.cocci. Signed-off-by: Stephen Hemminger --- drivers/raw/ifpga/ifpga_rawdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c index ceb18aed8d44..8c05302a65b8 100644 --- a/drivers/raw/ifpga/ifpga_rawdev.c +++ b/drivers/raw/ifpga/ifpga_rawdev.c @@ -1768,8 +1768,7 @@ ifpga_vdev_parse_devargs(struct rte_devargs *devargs, ret = 0; end: - if (kvlist) - rte_kvargs_free(kvlist); + rte_kvargs_free(kvlist); return ret; } From patchwork Wed Jun 22 18:51:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 113267 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6664BA034C; Wed, 22 Jun 2022 20:52:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5567B42820; Wed, 22 Jun 2022 20:52:07 +0200 (CEST) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id BBA0E427EE for ; Wed, 22 Jun 2022 20:52:04 +0200 (CEST) Received: by mail-pj1-f42.google.com with SMTP id h34-20020a17090a29a500b001eb01527d9eso312279pjd.3 for ; Wed, 22 Jun 2022 11:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DbJbymnYBvGDYjOg7pEpXUgzC8QJr6FLIKzsdpSh2wM=; b=UEtFLGR1LrR/0fhBGlBYV0/vycQMJ5nqlvHF43In2nMYckZUT1ITEWpNhsm6JHiJm1 ODKgME5unFtHRNfiGWDm7hdJnETP5sDy6uwYFOT44fzwl659bOIRdvwGQEz4+Kd6Ipyp HQEhbVeqXtQhdDXKAgIRgHpZ3nlGltmj8yvVD/C03C4VMA3dDdlXv5PeFIsdkxlpjzTX oNqWkh7fCO07bt85bcOBG22DcwXfjyqfv1TqX0kUukR8ePy9pweXUIk0/Y2pG4guEZp/ Oa4a7uZpRz8reaO4A9GPCUnf8fi3m5HHEo1MVqdeDPWeSIaJDRU5gPC1g318ZiMZTwlv I4HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DbJbymnYBvGDYjOg7pEpXUgzC8QJr6FLIKzsdpSh2wM=; b=FxeZUes/llinDAjHJX1ELGDFeRFglkRqlHyg1i8nvY/tv1igxOjIMGu3rhoxz0tybk mFGlRF+2YPYMHtdygxp/CWGQCqWwKy7YGsT8/1FE26Wx3qyl7p7afjD9cLmyXCrQd2bz 6ScUmyBDz97o2oEsaRJgkpEfVsrhLeJ9QWliVe5teRi9oLjAXd3+DIwUdwljKe4ET8PN j1onifrnS40wDmet+IwY9NR7XRbPx/DVNfXLhEjnN773z0kjsynquD2jxTXVsl/X6VCi qPr4NhTWOgB2Bzh7uATE3BVF3uBGZvAhn3AXgBn00It08g3DrD6enWZILmjK3pTt13Ug sOHw== X-Gm-Message-State: AJIora+CT1DhuZjc6utwICnFaP0HBpUkgvD+Hz5riN78I7pv2Bsi550J 6rjbd6+6cdFnrrqyvjc/4qcGphfq+pM1NfgC X-Google-Smtp-Source: AGRyM1v4clXobR5YPj0dJ7vASvRVnQmg6u1KTFoG8HJO7ZT87XQB1Oa5ZsQ/wowEEngvJqqt0cZ7rg== X-Received: by 2002:a17:902:f710:b0:15f:165f:b50b with SMTP id h16-20020a170902f71000b0015f165fb50bmr36325489plo.158.1655923923765; Wed, 22 Jun 2022 11:52:03 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id r6-20020a638f46000000b00407e25d4527sm9215817pgn.22.2022.06.22.11.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 11:52:03 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gagandeep Singh , Hemant Agrawal Subject: [PATCH 3/3] dmap/dpaa2: remove unnecessary null check Date: Wed, 22 Jun 2022 11:51:58 -0700 Message-Id: <20220622185158.397779-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220622185158.397779-1-stephen@networkplumber.org> References: <20220622185158.397779-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The function rte_free already handles being called with NULL. Found by nullfree.cocci. Signed-off-by: Stephen Hemminger --- drivers/dma/dpaa2/dpaa2_qdma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c b/drivers/dma/dpaa2/dpaa2_qdma.c index a93a60565df7..0500e8c22590 100644 --- a/drivers/dma/dpaa2/dpaa2_qdma.c +++ b/drivers/dma/dpaa2/dpaa2_qdma.c @@ -1404,11 +1404,9 @@ dpaa2_qdma_reset(struct rte_dma_dev *dev) /* Reset and free virtual queues */ for (i = 0; i < qdma_dev->num_vqs; i++) { - if (qdma_dev->vqs[i].status_ring) - rte_ring_free(qdma_dev->vqs[i].status_ring); + rte_ring_free(qdma_dev->vqs[i].status_ring); } - if (qdma_dev->vqs) - rte_free(qdma_dev->vqs); + rte_free(qdma_dev->vqs); qdma_dev->vqs = NULL; /* Reset QDMA device structure */