From patchwork Mon Jul 18 08:25:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Weiyuan Li X-Patchwork-Id: 114007 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E817A00C2; Mon, 18 Jul 2022 10:25:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4DEE64069F; Mon, 18 Jul 2022 10:25:37 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id CAE9D40041 for ; Mon, 18 Jul 2022 10:25:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658132736; x=1689668736; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=wKlrLQUOnt6r+Tkcpy9QsKogjT2NmTedPiMgcOiXpTw=; b=C9FDHmvytfaTdHGALbQ0IDpPbai1W756H0O4RpUoNjYbCORI1rqeNP/t 9vTB01OTPMMB5r8w091iJqK7SVM6X7cXYWU3jQ1JdRAkw6nr6wRNLtIn/ BSQAG6LLPTin0kHXFaz4TDf7MpuDszOKpZpZnP6IZIXbMwIl+iX6T0WBp 4uikwhdXPMkrXAs0/8yjK7N9Zh0i1k53JFeXEm3g4OdQQ0LY6A0ouIxg3 pGHPmI4AfaGAj5xnt9rbRenloA3wnDnSQnN5cQd/GImhPu1dUNQWV5uPq cGlf5K2MWuW80HqUqIvuKZe6c/dcXzDZVY9zf/o74XdjocI42QJcYMihm Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10411"; a="286905036" X-IronPort-AV: E=Sophos;i="5.92,280,1650956400"; d="scan'208";a="286905036" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 01:25:34 -0700 X-IronPort-AV: E=Sophos;i="5.92,280,1650956400"; d="scan'208";a="655177899" Received: from unknown (HELO localhost.localdomain) ([10.239.252.248]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 01:25:33 -0700 From: Weiyuan Li To: dts@dpdk.org Cc: Weiyuan Li Subject: [dts][PATCH V1 1/2] tests/checksum_offload: checksum suite script and testplan optimization Date: Mon, 18 Jul 2022 16:25:30 +0800 Message-Id: <20220718082531.17145-1-weiyuanx.li@intel.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Optimize the test case name to match test plan, add test case in test plan to map test suite and delete the cmd "tx_checksum set 0x0 0" using "csum set". Signed-off-by: Weiyuan Li --- tests/TestSuite_checksum_offload.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py index 3554f5eb..3680db11 100644 --- a/tests/TestSuite_checksum_offload.py +++ b/tests/TestSuite_checksum_offload.py @@ -604,7 +604,7 @@ class TestChecksumOffload(TestCase): # send the packet checksum value different from the expected value self.checksum_valid_flags(pkts_bad, 0) - def test_checksum_offload_enable(self): + def test_insert_checksum_on_the_transmit_packet(self): """ Insert IPv4/IPv6 UDP/TCP/SCTP checksum on the transmit packet. Enable Checksum offload. @@ -653,7 +653,7 @@ class TestChecksumOffload(TestCase): self.verify(len(result) == 0, ",".join(list(result.values()))) - def test_checksum_offload_disable(self): + def test_do_not_insert_checksum_on_the_transmit_packet(self): """ Do not insert IPv4/IPv6 UDP/TCP checksum on the transmit packet. Disable Checksum offload. From patchwork Mon Jul 18 08:25:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Weiyuan Li X-Patchwork-Id: 114008 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2AF7A034C; Mon, 18 Jul 2022 10:25:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67C8140DF6; Mon, 18 Jul 2022 10:25:37 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 7EFE740041 for ; Mon, 18 Jul 2022 10:25:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658132736; x=1689668736; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1DWxuSjZxS2Qkf1Z9NmxSK5rlaYlyJxzn8z/LO/FfOo=; b=b+eAoME+n4iRvi6BlmEvoCH73FB3Q1GP/Ss8WRnmyoBOyYAP3mB+omI9 8qoFfhdZoAy2qYyimLbbNRmM4H/HjcnLJ8zU1KDwtrrZdTqf46QPN9uUL lkAjqXwwg3c1lfhyT5PTonaKNNdsoOXQFOCadFI8HKocNlCpql85P2Sob cJ77vmzRldVKiDyxBNNCyCnw7YQdumbR6ncGExKwiAhTIfH9JmF0Iuty8 cyEYaPBb8nyAerbzO98ccDlD2uBs64FLB5NC48PGMDt/e3sE2Thk6K6vT iUQ25pFYP9Zo9veam4yd/kJLBENcPT8pTjCn+bYed3fZcoNreTBQsACOz Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10411"; a="286905039" X-IronPort-AV: E=Sophos;i="5.92,280,1650956400"; d="scan'208";a="286905039" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 01:25:35 -0700 X-IronPort-AV: E=Sophos;i="5.92,280,1650956400"; d="scan'208";a="655177906" Received: from unknown (HELO localhost.localdomain) ([10.239.252.248]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 01:25:34 -0700 From: Weiyuan Li To: dts@dpdk.org Cc: Weiyuan Li Subject: [dts][PATCH V1 2/2] test_plans/checksum_offload: checksum suite script and testplan optimization Date: Mon, 18 Jul 2022 16:25:31 +0800 Message-Id: <20220718082531.17145-2-weiyuanx.li@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220718082531.17145-1-weiyuanx.li@intel.com> References: <20220718082531.17145-1-weiyuanx.li@intel.com> MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Optimize the test case name to match test plan, add test case in test plan to map test suite and delete the cmd "tx_checksum set 0x0 0" using "csum set". Signed-off-by: Weiyuan Li Acked-by: Fu, Qi Tested-by: Lingli Chen --- test_plans/checksum_offload_test_plan.rst | 27 ++++++++++------------- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/test_plans/checksum_offload_test_plan.rst b/test_plans/checksum_offload_test_plan.rst index 45f081b0..7f51cc1f 100644 --- a/test_plans/checksum_offload_test_plan.rst +++ b/test_plans/checksum_offload_test_plan.rst @@ -71,16 +71,17 @@ Set the verbose level to 1 to display information for each received packet:: testpmd> set verbose 1 -Test Case: Validate checksum on the receive packet -================================================== +Test Case: checksum offload with vlan +===================================== Setup the ``csum`` forwarding mode:: testpmd> set fwd csum Set csum packet forwarding mode -Start the packet forwarding:: +Enable the IPv4/UDP/TCP/SCTP checksum offload on port 0:: + testpmd> csum set 0xf 0 testpmd> start csum packet forwarding - CRC stripping disabled - packets/burst=32 nb forwarding cores=1 - nb forwarding ports=10 @@ -89,21 +90,17 @@ Start the packet forwarding:: TX queues=1 - TX desc=512 - TX free threshold=0 TX threshold registers: pthresh=32 hthresh=8 wthresh=8 -Configure the traffic generator to send the multiple packets with the following -combination: good/bad ip checksum + good/bad udp/tcp checksum. +Configure the traffic generator to send the multiple packets with vlan for the +following combination: IPv4/UDP, IPv4/TCP, IPv4/SCTP, IPv6/UDP, IPv6/TCP. Except that SCTP header + payload length must be a multiple of 4 bytes. IPv4 + UDP/TCP packet length can range from the minimum length to 1518 bytes. -Then verify that how many packets found with Bad-ipcsum or Bad-l4csum:: - - testpmd> stop - ---------------------- Forward statistics for port 0 ---------------------- - RX-packets: 0 RX-dropped: 0 RX-total: 0 - Bad-ipcsum: 0 Bad-l4csum: 0 - TX-packets: 0 TX-dropped: 0 TX-total: 0 - ---------------------------------------------------------------------------- +Then verify that the same number of packet are correctly received on the traffic +generator side. And IPv4 checksum, TCP checksum, UDP checksum, SCTP CRC32c need +be validated as pass by the IXIA. +The IPv4 source address will not be changed by testpmd. Test Case: Insert IPv4/IPv6 UDP/TCP/SCTP checksum on the transmit packet ======================================================================== @@ -115,7 +112,7 @@ Setup the ``csum`` forwarding mode:: Enable the IPv4/UDP/TCP/SCTP checksum offload on port 0:: - testpmd> tx_checksum set 0xf 0 + testpmd> csum set 0xf 0 testpmd> start csum packet forwarding - CRC stripping disabled - packets/burst=32 nb forwarding cores=1 - nb forwarding ports=10 @@ -147,7 +144,7 @@ Setup the ``csum`` forwarding mode:: Disable the IPv4/UDP/TCP/SCTP checksum offload on port 0:: - testpmd> tx_checksum set 0x0 0 + testpmd> csum set 0x0 0 testpmd> start csum packet forwarding - CRC stripping disabled - packets/burst=32 nb forwarding cores=1 - nb forwarding ports=10