From patchwork Thu Sep 15 08:14:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Weiyuan Li X-Patchwork-Id: 116329 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76DE6A00C5; Thu, 15 Sep 2022 10:13:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 721634021D; Thu, 15 Sep 2022 10:13:57 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 61E8940156 for ; Thu, 15 Sep 2022 10:13:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663229636; x=1694765636; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=A6HyU/DeR1rObqFy0y4I/s4/Yr6Dq/FYmlJezfiujXo=; b=WuEqBoffT/3+GdRxvnFlXu4ki37/nog+JZhlHMVUlyrp2vsZS5E+pxLi fcwowtff2cAZH8+AcArPQjBowz8G58Ao7hIkFkjaEUnfVvkpx7idiyxrv DySYb4KOkTOKjWbpMAKUl5q+EWBe6KD0RLLjMoKpg5BsJPHVdprJ5WJ9t TN9mGNCQIf4eSE4xQT3ebY76bsidexYg4jGI9QtDqgcu7QOz39LTnF4qD Y3LqFAAvCeljIhwLztjKz0Fc2amGIbXbFbPhkmtLwIlpythvzK9PRNElS dfHgX8QuuFD7bKs+BHDP3htPHNtuMCOA14IK93LcUe8PCeamrfRYZnugo g==; X-IronPort-AV: E=McAfee;i="6500,9779,10470"; a="362608544" X-IronPort-AV: E=Sophos;i="5.93,317,1654585200"; d="scan'208";a="362608544" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 01:13:55 -0700 X-IronPort-AV: E=Sophos;i="5.93,317,1654585200"; d="scan'208";a="792613868" Received: from unknown (HELO localhost.localdomain) ([10.239.252.248]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 01:13:53 -0700 From: Weiyuan Li To: dts@dpdk.org Cc: Weiyuan Li , Lingli Chen , Fu@dpdk.org, Qi Subject: [dts][PATCH V2 1/2] tests/checksum_offload: checksum suite script and testplan optimization Date: Thu, 15 Sep 2022 16:14:09 +0800 Message-Id: <20220915081410.9195-1-weiyuanx.li@intel.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Optimize the test case name to match test plan, add test case in test plan to map test suite and delete the cmd "tx_checksum set 0x0 0" using "csum set". Signed-off-by: Weiyuan Li --- Tested-by: Lingli Chen Acked-by: Fu, Qi v2: -modify test plan delete IXIA description. tests/TestSuite_checksum_offload.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py index 1ccc884c..b181bf37 100644 --- a/tests/TestSuite_checksum_offload.py +++ b/tests/TestSuite_checksum_offload.py @@ -605,7 +605,7 @@ class TestChecksumOffload(TestCase): # send the packet checksum value different from the expected value self.checksum_valid_flags(pkts_bad, 0) - def test_checksum_offload_enable(self): + def test_insert_checksum_on_the_transmit_packet(self): """ Insert IPv4/IPv6 UDP/TCP/SCTP checksum on the transmit packet. Enable Checksum offload. @@ -654,7 +654,7 @@ class TestChecksumOffload(TestCase): self.verify(len(result) == 0, ",".join(list(result.values()))) - def test_checksum_offload_disable(self): + def test_do_not_insert_checksum_on_the_transmit_packet(self): """ Do not insert IPv4/IPv6 UDP/TCP checksum on the transmit packet. Disable Checksum offload. From patchwork Thu Sep 15 08:14:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Weiyuan Li X-Patchwork-Id: 116330 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96689A00C5; Thu, 15 Sep 2022 10:13:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90BCE40223; Thu, 15 Sep 2022 10:13:59 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id C8A3E40156 for ; Thu, 15 Sep 2022 10:13:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663229639; x=1694765639; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Nk8CEq+rhFx2x/qkcnA+C+PFpUEjrRfmhlT5UjtwTr4=; b=QaZA0J3zmFfMXzVY6iT5Br8D4NxT00M9hXwaJ4RYvebD8CTcH9+pxhRY C6O7fmcXeVJQiFIj7T0qkf4yjYb9SuGZIqVhnJ5qzxGEax3Me1cDPcZdD q6iRHVTdazgTYix4dpTiGfsK35fWz3gsyzkXSKTdfW4eeiT4hBX29hfYi uU/K48qUDAXZ37XbYwogQ6vBGaaRu7lqPlQv8dnoBgxUpGt63QPPEFAJz 2UiMnUGlaeOzrj8o8Heox7lzLpPnfOuXYMWUdGvl+gUWb6D+xLir5w+hy wm58bL0BMgPxserQh6lcdwrX6AlnWlZHLvUIf1TYMVPTD89wmdf5RWCT8 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10470"; a="362608550" X-IronPort-AV: E=Sophos;i="5.93,317,1654585200"; d="scan'208";a="362608550" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 01:13:58 -0700 X-IronPort-AV: E=Sophos;i="5.93,317,1654585200"; d="scan'208";a="792613885" Received: from unknown (HELO localhost.localdomain) ([10.239.252.248]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 01:13:55 -0700 From: Weiyuan Li To: dts@dpdk.org Cc: Weiyuan Li , Lingli Chen , Fu@dpdk.org, Qi Subject: [dts][PATCH V2 2/2] test_plans/checksum_offload: checksum suite script and testplan optimization Date: Thu, 15 Sep 2022 16:14:10 +0800 Message-Id: <20220915081410.9195-2-weiyuanx.li@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220915081410.9195-1-weiyuanx.li@intel.com> References: <20220915081410.9195-1-weiyuanx.li@intel.com> MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Optimize the test case name to match test plan, add test case in test plan to map test suite and delete the cmd "tx_checksum set 0x0 0" using "csum set". Signed-off-by: Weiyuan Li --- Tested-by: Lingli Chen Acked-by: Fu, Qi v2: -modify test plan delete IXIA description. test_plans/checksum_offload_test_plan.rst | 27 ++++++++++------------- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/test_plans/checksum_offload_test_plan.rst b/test_plans/checksum_offload_test_plan.rst index 45f081b0..10a1d981 100644 --- a/test_plans/checksum_offload_test_plan.rst +++ b/test_plans/checksum_offload_test_plan.rst @@ -71,16 +71,17 @@ Set the verbose level to 1 to display information for each received packet:: testpmd> set verbose 1 -Test Case: Validate checksum on the receive packet -================================================== +Test Case: checksum offload with vlan +===================================== Setup the ``csum`` forwarding mode:: testpmd> set fwd csum Set csum packet forwarding mode -Start the packet forwarding:: +Enable the IPv4/UDP/TCP/SCTP checksum offload on port 0:: + testpmd> csum set 0xf 0 testpmd> start csum packet forwarding - CRC stripping disabled - packets/burst=32 nb forwarding cores=1 - nb forwarding ports=10 @@ -89,21 +90,17 @@ Start the packet forwarding:: TX queues=1 - TX desc=512 - TX free threshold=0 TX threshold registers: pthresh=32 hthresh=8 wthresh=8 -Configure the traffic generator to send the multiple packets with the following -combination: good/bad ip checksum + good/bad udp/tcp checksum. +Configure the traffic generator to send the multiple packets with vlan for the +following combination: IPv4/UDP, IPv4/TCP, IPv4/SCTP, IPv6/UDP, IPv6/TCP. Except that SCTP header + payload length must be a multiple of 4 bytes. IPv4 + UDP/TCP packet length can range from the minimum length to 1518 bytes. -Then verify that how many packets found with Bad-ipcsum or Bad-l4csum:: - - testpmd> stop - ---------------------- Forward statistics for port 0 ---------------------- - RX-packets: 0 RX-dropped: 0 RX-total: 0 - Bad-ipcsum: 0 Bad-l4csum: 0 - TX-packets: 0 TX-dropped: 0 TX-total: 0 - ---------------------------------------------------------------------------- +Then verify that the same number of packet are correctly received on the traffic +generator side. And IPv4 checksum, TCP checksum, UDP checksum, SCTP CRC32c need +be validated as pass. +The IPv4 source address will not be changed by testpmd. Test Case: Insert IPv4/IPv6 UDP/TCP/SCTP checksum on the transmit packet ======================================================================== @@ -115,7 +112,7 @@ Setup the ``csum`` forwarding mode:: Enable the IPv4/UDP/TCP/SCTP checksum offload on port 0:: - testpmd> tx_checksum set 0xf 0 + testpmd> csum set 0xf 0 testpmd> start csum packet forwarding - CRC stripping disabled - packets/burst=32 nb forwarding cores=1 - nb forwarding ports=10 @@ -147,7 +144,7 @@ Setup the ``csum`` forwarding mode:: Disable the IPv4/UDP/TCP/SCTP checksum offload on port 0:: - testpmd> tx_checksum set 0x0 0 + testpmd> csum set 0x0 0 testpmd> start csum packet forwarding - CRC stripping disabled - packets/burst=32 nb forwarding cores=1 - nb forwarding ports=10