From patchwork Tue Dec 20 09:11:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Naga Harish K, S V" X-Patchwork-Id: 121067 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB2F1A0545; Tue, 20 Dec 2022 10:11:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F65F40685; Tue, 20 Dec 2022 10:11:50 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 2FFF840395 for ; Tue, 20 Dec 2022 10:11:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671527509; x=1703063509; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HEpYfcNSlbtSU5gMTuhhHnQqcF5GTTIKsHGlwlFsuMk=; b=nfFYwcE8emSAlhaf9oIlC/4P3yMYqW5S/UpJuNiXMY+aQu6XRTAFMoEW PxUUdJARJoWqCht9WleSgPSwax7oi+h8+ZpGnYIHgrMRnkupntz4aVftH gM2Ud13F92AuEI0VniZwPniKclpZF4+EcdD6ME76JabIfPNc7R1wm2E0f wO0cdZ+8zpOHzDsZ4otjnaHSQE6orXIUGWaSz0lgVl3kaBRGSdO6QsPlZ NFfY/oWVdhQrH6ZsTeoiFGIRIpJ9Ja5AB6MiCtiOi6bBtsb2IJs5X32po OEantIQo12GGMwePHN6/1O2H2kics06PiJeWpkXaF0VkHMzpPXsZoyjFo Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="299910311" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="299910311" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2022 01:11:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="601007577" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="601007577" Received: from txandevlnx322.an.intel.com ([10.123.117.44]) by orsmga003.jf.intel.com with ESMTP; 20 Dec 2022 01:11:47 -0800 From: Naga Harish K S V To: jerinj@marvell.com, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com Cc: dev@dpdk.org, jay.jayatheerthan@intel.com Subject: [PATCH v5 1/4] eventdev/eth_rx: change eventdev reconfig logic Date: Tue, 20 Dec 2022 03:11:34 -0600 Message-Id: <20221220091137.3137300-1-s.v.naga.harish.k@intel.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20221219062852.2557488-1-s.v.naga.harish.k@intel.com> References: <20221219062852.2557488-1-s.v.naga.harish.k@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When rte_event_eth_rx_adapter_create() or rte_event_eth_rx_adapter_create_with_params() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter if the adapter event port config is of type ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. With this change the application no longer need to configure the eventdev with ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter required for eth_rx adapter when the adapter is created using above mentioned apis. Signed-off-by: Naga Harish K S V Acked-by: Abhinandan Gujjar --- v2: * Fix build error v3: * update doxygen v5: * update doxygen as per review comments --- --- .../prog_guide/event_ethernet_rx_adapter.rst | 19 +++++++++++++++++++ lib/eventdev/rte_event_eth_rx_adapter.c | 3 +++ lib/eventdev/rte_event_eth_rx_adapter.h | 14 ++++++++++++++ 3 files changed, 36 insertions(+) diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst index 116c0a27c6..bbe278f7db 100644 --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst @@ -71,6 +71,25 @@ set to true. The function is passed the event device to be associated with the adapter and port configuration for the adapter to setup an event port if the adapter needs to use a service function. +Event device configuration for service based adapter +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +When rte_event_eth_rx_adapter_create() or +rte_event_eth_rx_adapter_create_with_params() is used for creating +adapter instance, ``rte_event_dev_config::nb_event_ports`` is +automatically incremented and the event device is reconfigured with +the additional event port during service initialization. This event +device reconfigure logic also increments the +``rte_event_dev_config::nb_single_link_event_port_queues`` +parameter if the adapter event port config is of type +``RTE_EVENT_PORT_CFG_SINGLE_LINK``. + +Application no longer needs to account for the +``rte_event_dev_config::nb_event_ports`` and +``rte_event_dev_config::nb_single_link_event_port_queues`` +parameters required for eth Rx adapter in the event device configuration, +when the adapter is created using the above-mentioned APIs. + Adding Rx Queues to the Adapter Instance ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index cf7bbd4d69..34aa87379e 100644 --- a/lib/eventdev/rte_event_eth_rx_adapter.c +++ b/lib/eventdev/rte_event_eth_rx_adapter.c @@ -1532,6 +1532,9 @@ rxa_default_conf_cb(uint8_t id, uint8_t dev_id, rte_event_dev_stop(dev_id); port_id = dev_conf.nb_event_ports; dev_conf.nb_event_ports += 1; + if (port_conf->event_port_cfg & RTE_EVENT_PORT_CFG_SINGLE_LINK) + dev_conf.nb_single_link_event_port_queues += 1; + ret = rte_event_dev_configure(dev_id, &dev_conf); if (ret) { RTE_EDEV_LOG_ERR("failed to configure event dev %u\n", diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h b/lib/eventdev/rte_event_eth_rx_adapter.h index d0e7d0092c..f4652f40e8 100644 --- a/lib/eventdev/rte_event_eth_rx_adapter.h +++ b/lib/eventdev/rte_event_eth_rx_adapter.h @@ -382,6 +382,20 @@ int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id, * control in configuration of the service, it should use the * rte_event_eth_rx_adapter_create_ext() version. * + * When this API is used for creating adapter instance, + * ``rte_event_dev_config::nb_event_ports`` is automatically incremented, + * and event device is reconfigured with additional event port during service + * initialization. This event device reconfigure logic also increments the + * ``rte_event_dev_config::nb_single_link_event_port_queues`` + * parameter if the adapter event port config is of type + * ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. + * + * Application no longer needs to account for + * ``rte_event_dev_config::nb_event_ports`` and + * ``rte_event_dev_config::nb_single_link_event_port_queues`` + * parameters required for eth Rx adapter in the event device configuration + * when the adapter is created with this API. + * * @param id * The identifier of the ethernet Rx event adapter. * From patchwork Tue Dec 20 09:11:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Naga Harish K, S V" X-Patchwork-Id: 121068 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5FE7A0545; Tue, 20 Dec 2022 10:11:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E305410DE; Tue, 20 Dec 2022 10:11:54 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 4FD2640F18 for ; Tue, 20 Dec 2022 10:11:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671527511; x=1703063511; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=AMcCTrhAs+qR8gsfUT3OT7ZAwHifEVvxWZ5c7Z/Y2mU=; b=ACkeSTjqiTpLlFnsjFe9I9BSAQ0xtt3Es082JPP1w9+VeKOrhW9JH3Wx B5DLTHV17DV9FWfnBYSyfKUw40mTUSiqGE9NHXhP601k9GevlDdxNsI1P 9eCcDQp+9AUspDWoxaiI5QkEwrp98q+twmPewMmsTDM77Xc3H72EuEW+b jJY8a2zD9BsnA7SJahVe30/jRH135D69jw6J6zdAr3GwFZPUU7qKGnVxg hlPi3YNlTZnWh5LUelHSIm5eeNIAxGB23JLNZy7Df8BOxeFFmvoqZjttO o7+0tfoJvi6eTsbKx7wPvQ3g5xT6iXVi4jajjtnAVX2hful5u2abbVXW0 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="299910315" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="299910315" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2022 01:11:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="601007596" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="601007596" Received: from txandevlnx322.an.intel.com ([10.123.117.44]) by orsmga003.jf.intel.com with ESMTP; 20 Dec 2022 01:11:50 -0800 From: Naga Harish K S V To: jerinj@marvell.com, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com Cc: dev@dpdk.org, jay.jayatheerthan@intel.com Subject: [PATCH v5 2/4] eventdev/eth_tx: change eventdev reconfig logic Date: Tue, 20 Dec 2022 03:11:35 -0600 Message-Id: <20221220091137.3137300-2-s.v.naga.harish.k@intel.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20221220091137.3137300-1-s.v.naga.harish.k@intel.com> References: <20221219062852.2557488-1-s.v.naga.harish.k@intel.com> <20221220091137.3137300-1-s.v.naga.harish.k@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When rte_event_eth_tx_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter if the adapter event port config is of type ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. With this change the application is no longer need to configure the eventdev with ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter required for eth_tx adapter when the adapter is created using above mentioned api. Signed-off-by: Naga Harish K S V Acked-by: Abhinandan Gujjar --- v2: * fix build error in doc/prog_guide v3: * update doxygen v5: * update doxygen as per review comments --- --- .../prog_guide/event_ethernet_tx_adapter.rst | 17 +++++++++++++++++ lib/eventdev/rte_event_eth_tx_adapter.c | 2 ++ lib/eventdev/rte_event_eth_tx_adapter.h | 14 ++++++++++++++ 3 files changed, 33 insertions(+) diff --git a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst b/doc/guides/prog_guide/event_ethernet_tx_adapter.rst index 905cb445e0..711ecb7441 100644 --- a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst +++ b/doc/guides/prog_guide/event_ethernet_tx_adapter.rst @@ -56,6 +56,23 @@ and needs to create an event port for it. The callback is expected to fill the err = rte_event_eth_tx_adapter_create(id, dev_id, &tx_p_conf); +Event device configuration for service based adapter +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +When rte_event_eth_tx_adapter_create() is used for creating +adapter instance, ``rte_event_dev_config::nb_event_ports`` is +automatically incremented, and the event device is reconfigured with additional +event port during service initialization. This event device reconfigure logic +also increments the ``rte_event_dev_config::nb_single_link_event_port_queues`` +parameter if the adapter event port config is of type +``RTE_EVENT_PORT_CFG_SINGLE_LINK``. + +Application no longer needs to configure the event device with +``rte_event_dev_config::nb_event_ports`` and +``rte_event_dev_config::nb_single_link_event_port_queues`` +parameters required for eth Tx adapter when the adapter is created +using the above-mentioned API. + Adding Tx Queues to the Adapter Instance ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c index 88309d2aaa..c780ee1264 100644 --- a/lib/eventdev/rte_event_eth_tx_adapter.c +++ b/lib/eventdev/rte_event_eth_tx_adapter.c @@ -316,6 +316,8 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id, port_id = dev_conf.nb_event_ports; dev_conf.nb_event_ports += 1; + if (pc->event_port_cfg & RTE_EVENT_PORT_CFG_SINGLE_LINK) + dev_conf.nb_single_link_event_port_queues += 1; ret = rte_event_dev_configure(dev_id, &dev_conf); if (ret) { diff --git a/lib/eventdev/rte_event_eth_tx_adapter.h b/lib/eventdev/rte_event_eth_tx_adapter.h index 645b87b78a..cd539af7ef 100644 --- a/lib/eventdev/rte_event_eth_tx_adapter.h +++ b/lib/eventdev/rte_event_eth_tx_adapter.h @@ -142,6 +142,20 @@ struct rte_event_eth_tx_adapter_stats { /** * Create a new ethernet Tx adapter with the specified identifier. * + * When this API is used for creating adapter instance, + * ``rte_event_dev_config::nb_event_ports`` is automatically incremented, + * and event device is reconfigured with additional event port during service + * initialization. This event device reconfigure logic also increments the + * ``rte_event_dev_config::nb_single_link_event_port_queues`` + * parameter if the adapter event port config is of type + * ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. + * + * Application no longer needs to account for the + * ``rte_event_dev_config::nb_event_ports`` and + * ``rte_event_dev_config::nb_single_link_event_port_queues`` + * parameters required for eth Tx adapter in event device configure when + * the adapter is created with this API. + * * @param id * The identifier of the ethernet Tx adapter. * @param dev_id From patchwork Tue Dec 20 09:11:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Naga Harish K, S V" X-Patchwork-Id: 121069 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60DFAA0545; Tue, 20 Dec 2022 10:12:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2586742D10; Tue, 20 Dec 2022 10:11:56 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 9108140F18 for ; Tue, 20 Dec 2022 10:11:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671527513; x=1703063513; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=g/PQ6nVUqOuSQHM+xu4ALuCrvxKHHnKhqfdTAUbZpwY=; b=Eu6D7OE4CMYYogLkA3s83hNkkoKu/ETm+hHtQFAitiCJsQEkal+qfLhc y1h8iXFKEFds8RF/tEwVEuj+BgLZ5rzEX2PKJrQUAxx6gHbHOgOqglH8r IbMlz5NxwqpVFhLw0yM4QYPN+J/spIQCfQr535Wraps5Tzdak949Vio3o hh4SosXEOBhPRXsooOJFxAp5xXzJoSmr+dKGZJ1bhK0CO65zN3cWkbOMe 3csE2LO1L+cVryETHdMrK+HEoartVQk8kngORkFYJasMj0KOcYLNXHvw+ Xy+4a6db77NxEIkRiCeZxR2oCXytPaPyzvEUlnwqvcXzG4AaUi6ft7AXW w==; X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="299910327" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="299910327" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2022 01:11:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="601007610" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="601007610" Received: from txandevlnx322.an.intel.com ([10.123.117.44]) by orsmga003.jf.intel.com with ESMTP; 20 Dec 2022 01:11:52 -0800 From: Naga Harish K S V To: jerinj@marvell.com, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com Cc: dev@dpdk.org, jay.jayatheerthan@intel.com Subject: [PATCH v5 3/4] eventdev/crypto: change eventdev reconfig logic Date: Tue, 20 Dec 2022 03:11:36 -0600 Message-Id: <20221220091137.3137300-3-s.v.naga.harish.k@intel.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20221220091137.3137300-1-s.v.naga.harish.k@intel.com> References: <20221219062852.2557488-1-s.v.naga.harish.k@intel.com> <20221220091137.3137300-1-s.v.naga.harish.k@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When rte_event_crypto_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter if the adapter event port config is of type ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. With this change the application is no longer need to configure the eventdev with ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter required for crypto adapter when the adapter is created using above mentioned api. Signed-off-by: Naga Harish K S V Acked-by: Abhinandan Gujjar --- v2: * fix build error in documentation v3: * update doxygen v5: * update doxygen as per review comments --- --- doc/guides/prog_guide/event_crypto_adapter.rst | 17 +++++++++++++++++ lib/eventdev/rte_event_crypto_adapter.c | 3 +++ lib/eventdev/rte_event_crypto_adapter.h | 14 ++++++++++++++ 3 files changed, 34 insertions(+) diff --git a/doc/guides/prog_guide/event_crypto_adapter.rst b/doc/guides/prog_guide/event_crypto_adapter.rst index 554df7e358..7c409176d1 100644 --- a/doc/guides/prog_guide/event_crypto_adapter.rst +++ b/doc/guides/prog_guide/event_crypto_adapter.rst @@ -159,6 +159,23 @@ which it enqueues events towards the crypto adapter using nb_events); } +Event device configuration for service based adapter +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +When rte_event_crypto_adapter_create() is used for creating +adapter instance, ``rte_event_dev_config::nb_event_ports`` is +automatically incremented, and event device is reconfigured with additional +event port during service initialization. This event device reconfigure +logic also increments the +``rte_event_dev_config::nb_single_link_event_port_queues`` +parameter if the adapter event port config is of type +``RTE_EVENT_PORT_CFG_SINGLE_LINK``. + +Application no longer needs to configure the +event device with ``rte_event_dev_config::nb_event_ports`` and +``rte_event_dev_config::nb_single_link_event_port_queues`` +parameters required for crypto adapter when the adapter is created +using the above-mentioned API. Querying adapter capabilities ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/lib/eventdev/rte_event_crypto_adapter.c b/lib/eventdev/rte_event_crypto_adapter.c index 3c585d7b0d..5620a36dd3 100644 --- a/lib/eventdev/rte_event_crypto_adapter.c +++ b/lib/eventdev/rte_event_crypto_adapter.c @@ -287,6 +287,9 @@ eca_default_config_cb(uint8_t id, uint8_t dev_id, rte_event_dev_stop(dev_id); port_id = dev_conf.nb_event_ports; dev_conf.nb_event_ports += 1; + if (port_conf->event_port_cfg & RTE_EVENT_PORT_CFG_SINGLE_LINK) + dev_conf.nb_single_link_event_port_queues += 1; + ret = rte_event_dev_configure(dev_id, &dev_conf); if (ret) { RTE_EDEV_LOG_ERR("failed to configure event dev %u\n", dev_id); diff --git a/lib/eventdev/rte_event_crypto_adapter.h b/lib/eventdev/rte_event_crypto_adapter.h index 83d154a6ce..0c610b8e04 100644 --- a/lib/eventdev/rte_event_crypto_adapter.h +++ b/lib/eventdev/rte_event_crypto_adapter.h @@ -414,6 +414,20 @@ rte_event_crypto_adapter_create_ext(uint8_t id, uint8_t dev_id, * control in configuration of the service, it should use the * rte_event_crypto_adapter_create_ext() version. * + * When this API is used for creating adapter instance, + * ``rte_event_dev_config::nb_event_ports`` is automatically incremented, + * and the event device is reconfigured with additional event port during + * service initialization. This event device reconfigure logic also increments + * the ``rte_event_dev_config::nb_single_link_event_port_queues`` + * parameter if the adapter event port config is of type + * ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. + * + * Application no longer needs to account for + * ``rte_event_dev_config::nb_event_ports`` and + * ``rte_event_dev_config::nb_single_link_event_port_queues`` + * parameters required for crypto adapter in event device configuration + * when the adapter is created with this API. + * * @param id * Adapter identifier. * From patchwork Tue Dec 20 09:11:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Naga Harish K, S V" X-Patchwork-Id: 121070 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77A69A034C; Tue, 20 Dec 2022 10:12:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E545C42D17; Tue, 20 Dec 2022 10:11:58 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id A733442D17 for ; Tue, 20 Dec 2022 10:11:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671527516; x=1703063516; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QQPf4zr6Vk3xXRN0afFDQF0l7fuRbtFyPw4h+yZOxIM=; b=TtRVKEDjk0b5GouGcY3pRbuF/dhxkH82YhZNtMHkK1S6EiXsBeGI7f43 B+kWy+ri6cfV/AC7Uzoxxe9HjFSSqB8iXSw5KtsN4zAgg7Rgh72xQrHrL SvQWtSWBHo+L8Qxk62KvfMJ3dxxgo3oZjLbRmNjKN2Vome8L/b0vQzQ1p hKofBXjms6v5d0Q1Vh+cCjlTk4JtNALwDaHaSlyKRlDKqJy4E42lVOsHW +9OjNBYYTGL36Rtxl3WsQTUoZJH64cB9XpYbqlLSr59bgX7RXp8KCD0Ya 0MxHmgK4gRTUxmYZM7mLjOOsjE2ifdhnIfdx/ceGZ1bwzauU/sYxYNq0o g==; X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="299910333" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="299910333" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2022 01:11:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="601007619" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="601007619" Received: from txandevlnx322.an.intel.com ([10.123.117.44]) by orsmga003.jf.intel.com with ESMTP; 20 Dec 2022 01:11:55 -0800 From: Naga Harish K S V To: jerinj@marvell.com, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com Cc: dev@dpdk.org, jay.jayatheerthan@intel.com Subject: [PATCH v5 4/4] eventdev/timer: change eventdev reconfig logic Date: Tue, 20 Dec 2022 03:11:37 -0600 Message-Id: <20221220091137.3137300-4-s.v.naga.harish.k@intel.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20221220091137.3137300-1-s.v.naga.harish.k@intel.com> References: <20221219062852.2557488-1-s.v.naga.harish.k@intel.com> <20221220091137.3137300-1-s.v.naga.harish.k@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When rte_event_timer_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter if the adapter event port config is of type ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. With this change the application is no longer need to configure the eventdev with ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter required for timer adapter when the adapter is created using above mentioned api. Signed-off-by: Naga Harish K S V Acked-by: Abhinandan Gujjar --- v2: * fix build error in documentation v3: * update doxygen v4: * fix programmer guide v5: * update doxygen as per review comments --- --- doc/guides/prog_guide/event_timer_adapter.rst | 18 +++++++++++++++ lib/eventdev/rte_event_timer_adapter.c | 23 +++++++++++-------- lib/eventdev/rte_event_timer_adapter.h | 14 +++++++++++ 3 files changed, 45 insertions(+), 10 deletions(-) diff --git a/doc/guides/prog_guide/event_timer_adapter.rst b/doc/guides/prog_guide/event_timer_adapter.rst index d7307a29bb..b5cd95fef1 100644 --- a/doc/guides/prog_guide/event_timer_adapter.rst +++ b/doc/guides/prog_guide/event_timer_adapter.rst @@ -139,6 +139,24 @@ This function is passed a callback function that will be invoked if the adapter needs to create an event port, giving the application the opportunity to control how it is done. +Event device configuration for service based adapter +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +When rte_event_timer_adapter_create() is used for creating +adapter instance, ``rte_event_dev_config::nb_event_ports`` is +automatically incremented, and the event device is reconfigured with +additional event port during service initialization. +This event device reconfigure logic also increments the +``rte_event_dev_config::nb_single_link_event_port_queues`` +parameter if the adapter event port config is of type +``RTE_EVENT_PORT_CFG_SINGLE_LINK``. + +Application no longer needs to account for the +``rte_event_dev_config::nb_event_ports`` and +``rte_event_dev_config::nb_single_link_event_port_queues`` +parameters required for timer adapter in event device configuration, +when the adapter is created using the above-mentioned API. + Adapter modes ^^^^^^^^^^^^^ An event timer adapter can be configured in either periodic or non-periodic mode diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c index a0f14bf861..5ed233db00 100644 --- a/lib/eventdev/rte_event_timer_adapter.c +++ b/lib/eventdev/rte_event_timer_adapter.c @@ -88,7 +88,20 @@ default_port_conf_cb(uint16_t id, uint8_t event_dev_id, uint8_t *event_port_id, rte_event_dev_stop(dev_id); port_id = dev_conf.nb_event_ports; + if (conf_arg != NULL) + port_conf = conf_arg; + else { + port_conf = &def_port_conf; + ret = rte_event_port_default_conf_get(dev_id, port_id, + port_conf); + if (ret < 0) + return ret; + } + dev_conf.nb_event_ports += 1; + if (port_conf->event_port_cfg & RTE_EVENT_PORT_CFG_SINGLE_LINK) + dev_conf.nb_single_link_event_port_queues += 1; + ret = rte_event_dev_configure(dev_id, &dev_conf); if (ret < 0) { EVTIM_LOG_ERR("failed to configure event dev %u\n", dev_id); @@ -99,16 +112,6 @@ default_port_conf_cb(uint16_t id, uint8_t event_dev_id, uint8_t *event_port_id, return ret; } - if (conf_arg != NULL) - port_conf = conf_arg; - else { - port_conf = &def_port_conf; - ret = rte_event_port_default_conf_get(dev_id, port_id, - port_conf); - if (ret < 0) - return ret; - } - ret = rte_event_port_setup(dev_id, port_id, port_conf); if (ret < 0) { EVTIM_LOG_ERR("failed to setup event port %u on event dev %u\n", diff --git a/lib/eventdev/rte_event_timer_adapter.h b/lib/eventdev/rte_event_timer_adapter.h index cd10db19e4..e21588bede 100644 --- a/lib/eventdev/rte_event_timer_adapter.h +++ b/lib/eventdev/rte_event_timer_adapter.h @@ -212,6 +212,20 @@ typedef int (*rte_event_timer_adapter_port_conf_cb_t)(uint16_t id, * * This function must be invoked first before any other function in the API. * + * When this API is used for creating adapter instance, + * ``rte_event_dev_config::nb_event_ports`` is automatically incremented, + * and the event device is reconfigured with additional event port during + * service initialization. This event device reconfigure logic also increments + * the ``rte_event_dev_config::nb_single_link_event_port_queues`` + * parameter if the adapter event port config is of type + * ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. + * + * Application no longer needs to account for + * ``rte_event_dev_config::nb_event_ports`` and + * ``rte_event_dev_config::nb_single_link_event_port_queues`` + * parameters required for Timer adapter in event device configuration + * when the adapter is created with this API. + * * @param conf * The event timer adapter configuration structure. *