From patchwork Wed Dec 21 08:39:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: rongwei liu X-Patchwork-Id: 121172 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4DFAA034C; Wed, 21 Dec 2022 09:40:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A10BE41141; Wed, 21 Dec 2022 09:40:38 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2061.outbound.protection.outlook.com [40.107.93.61]) by mails.dpdk.org (Postfix) with ESMTP id 2F12540698 for ; Wed, 21 Dec 2022 09:40:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iOxa9V7TNi0t1HVX0/AYgesS5C2DeYvXJ9iKF/dX8Bs3gK3zgArDp8lUKkGa5xlxZf/XT4NfV1VHbh6p+VHFxdCuXBtKQv+az9D9CNBw9Pkp4I9E7imdzm3Flfeody80NwhnIYTkBCU5JdbDkXA/MwZSBqS9t6CBI7UAsCtoWewVg/4lLYXKq7AUtXbZmKHwXOe5FTG0UunWASU8rDnx7Vv7aw0rWrpzVs9Z6kLUP17k7CY44wVCppWi1RiVNc5S0lU473FObsICxOtta+5wOjo55JKYEsJIvVtSM4yoEWFNZALUlu62nDDhdtNF/mMkF1acFw0lYz+xeeYmivN+iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5zklOTso2EVAhYNOsidNZhOPLNoa45ersplm5JUkW1Q=; b=nduDSkkg8xLsmHDPLTFEExSFjJ9Puh0/hCJ3Ti0ZbIZPp0AwICjD31fzM5lcNx6sDz56NMwdT3yBArq/pI3zvhp3dvRamlvPHCpjfmKMLP5UEOapP3wz7X8F4DqtcMeeK/Ie1dVv7aBrD+IMlWB0GoMjB59S7KSgo9coFOUCZipQvhNRsVyyw8RWpJZLjqjyipowcCDKNh1F0ZSg6kgzKFxp0/njwJH2Ea81n01q7Z3REFCUH3y0LAZrfzVYpC40aMoi6pi42mcI6u50Nsht78EWrrxLHIPXo/jyM9GNEUXJLEbcnylnPWMmsfNg6G862gQNA/ReAYCm1qs7vW8HWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5zklOTso2EVAhYNOsidNZhOPLNoa45ersplm5JUkW1Q=; b=ic9Q6j7rxwy44algyg65iEdoroCIfjUZ8KFaVBUU/iPSgUdjIzNLNjJ15anLOaDQu+fUT40VbVRy/ry4jkmsr7puBycM8g2fp+Ji+AHqbG7JRtJzrOJkkelge7YROZA0J28IxRdKaE2gDufQR4stxS8YF+wMsWRRufYVteoDhFWBQhWZoW20Ph8+uL6OOpCIcvQBVBDC54tDpii//saDBcBCTJ4rLRLdPS3/zRFUybF6pK5GoPMY31E/T0TsqHjPWLo48gslRcFmrwii2AiVm5Dl/Sy6OzCMl489VgTF2O6y89AjApGvIqoILH0GB7XqYxOiV6lb1G3M1/N5Igjivg== Received: from MW4PR04CA0336.namprd04.prod.outlook.com (2603:10b6:303:8a::11) by IA1PR12MB7664.namprd12.prod.outlook.com (2603:10b6:208:423::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 08:40:34 +0000 Received: from CO1NAM11FT099.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8a:cafe::3) by MW4PR04CA0336.outlook.office365.com (2603:10b6:303:8a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.21 via Frontend Transport; Wed, 21 Dec 2022 08:40:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT099.mail.protection.outlook.com (10.13.175.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.6 via Frontend Transport; Wed, 21 Dec 2022 08:40:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:19 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:16 -0800 From: Rongwei Liu To: , , , , Ferruh Yigit , Andrew Rybchenko CC: , Subject: [RFC 1/9] ethdev: add flex item modify field support Date: Wed, 21 Dec 2022 10:39:52 +0200 Message-ID: <20221221084000.3680015-2-rongweil@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20221221084000.3680015-1-rongweil@nvidia.com> References: <20221221084000.3680015-1-rongweil@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT099:EE_|IA1PR12MB7664:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e9f933f-6d49-421c-db3a-08dae32f0657 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lG5VivFv6UCUk0t5IZ0rfdc1FQeeCotMo4XaWUeez3hnoHsrLb4L6jsV9CKoLpX5L3TfDoOcF/RjXc6ycKREZ0QymVvsfI3p125qMkzHYiMB1uNBf+J3rN7VaDPJhZfsDGMAteXf3Omnk01g8DqG8Tj0FgOQ0JwTCFd1dclrAKO3r+LDs9kt+nTGTO4B9PpWuK4LPwSM9Eb152LS0foh5cPZz5NzPjFkuhSLOs99UQbglmFegQX/h01DZY4vqsU8NU34DmQzM++VGvnYU/ZwoPx2LTGEykOmo1fkfH4QyiPxuD11pe/Pq6h3gnODafB4pnuH0S/jAs61sr60U0cq00sFRlULmml6iJXZ5u1SyODOoIygyTpIA+tSiopwUMUgpg/rCUvRbhaQ2aMhPL+x+uG37HvCCgA/4DDVzOcnS/v5moxPWzM1evaAhcCSoCZTqRi/BET1+wS/A+6kiNaIpfawEHBmatwwMsXdRyAGMfWn0bOizzt3NioL+jWEK6y872qhdF5Nd/L+9fkvWlzX9quzuSheDhkZJAv1NXObaJyMfSFiKCBp7BQCm+Wr3rqGDEu3ka/AU4JAwtgJsDmvHoSwePZlh1jkdn9AqZzakRgHPaUckyC9ds3IKmRHVquy19KMoEklfLZgoQrZwZRM5u5fUND5q5CTc2iM5NFrId5Iw+6l/yDWMWMkVtjeAGyu2Qcng3xfMapLklSqZafDBWomUUhMS1bkcBc91gLaVsM= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(136003)(346002)(396003)(39860400002)(376002)(451199015)(46966006)(40470700004)(36840700001)(8676002)(70206006)(316002)(70586007)(336012)(36860700001)(55016003)(4326008)(1076003)(36756003)(16526019)(8936002)(83380400001)(41300700001)(5660300002)(47076005)(426003)(7696005)(6666004)(107886003)(478600001)(110136005)(2616005)(40460700003)(6286002)(26005)(82310400005)(54906003)(86362001)(186003)(2906002)(356005)(82740400003)(7636003)(40480700001)(21314003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 08:40:33.4173 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1e9f933f-6d49-421c-db3a-08dae32f0657 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT099.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7664 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add flex item as modify field destination. Add "struct rte_flow_item_flex_handle *flex_handle" into "struct rte_flow_action_modify_data" as union with existed "level" member. This new member is dedicated for modifying flex item. Signed-off-by: Rongwei Liu Acked-by: Ori Kam --- doc/guides/prog_guide/rte_flow.rst | 36 ++++++++++++++------------ doc/guides/rel_notes/release_22_03.rst | 4 +++ lib/ethdev/rte_flow.h | 8 ++++-- 3 files changed, 29 insertions(+), 19 deletions(-) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 3e6242803d..ea20145224 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -2952,23 +2952,25 @@ value as sequence of bytes {xxx, xxx, 0x85, xxx, xxx, xxx}. .. table:: destination/source field definition - +---------------+----------------------------------------------------------+ - | Field | Value | - +===============+==========================================================+ - | ``field`` | ID: packet field, mark, meta, tag, immediate, pointer | - +---------------+----------------------------------------------------------+ - | ``level`` | encapsulation level of a packet field or tag array index | - +---------------+----------------------------------------------------------+ - | ``offset`` | number of bits to skip at the beginning | - +---------------+----------------------------------------------------------+ - | ``value`` | immediate value buffer (source field only, not | - | | applicable to destination) for RTE_FLOW_FIELD_VALUE | - | | field type | - +---------------+----------------------------------------------------------+ - | ``pvalue`` | pointer to immediate value data (source field only, not | - | | applicable to destination) for RTE_FLOW_FIELD_POINTER | - | | field type | - +---------------+----------------------------------------------------------+ + +-----------------+----------------------------------------------------------+ + | Field | Value | + +=================+==========================================================+ + | ``field`` | ID: packet field, mark, meta, tag, immediate, pointer | + +-----------------+----------------------------------------------------------+ + | ``level`` | encapsulation level of a packet field or tag array index | + +-----------------+----------------------------------------------------------+ + | ``flex_handle`` | flex item handle of a packet field | + +-----------------+----------------------------------------------------------+ + | ``offset`` | number of bits to skip at the beginning | + +-----------------+----------------------------------------------------------+ + | ``value`` | immediate value buffer (source field only, not | + | | applicable to destination) for RTE_FLOW_FIELD_VALUE | + | | field type | + +-----------------+----------------------------------------------------------+ + | ``pvalue`` | pointer to immediate value data (source field only, not | + | | applicable to destination) for RTE_FLOW_FIELD_POINTER | + | | field type | + +-----------------+----------------------------------------------------------+ Action: ``CONNTRACK`` ^^^^^^^^^^^^^^^^^^^^^ diff --git a/doc/guides/rel_notes/release_22_03.rst b/doc/guides/rel_notes/release_22_03.rst index 0923707cb8..5fc5aff8a4 100644 --- a/doc/guides/rel_notes/release_22_03.rst +++ b/doc/guides/rel_notes/release_22_03.rst @@ -207,6 +207,10 @@ API Changes * ethdev: Old public macros and enumeration constants without ``RTE_ETH_`` prefix, which are kept for backward compatibility, are marked as deprecated. +* ethdev: added a new field: + + - modify flex item: ``rte_flow_action_modify_data.flex_handle`` + * cryptodev: The asymmetric session handling was modified to use a single mempool object. An API ``rte_cryptodev_asym_session_pool_create`` was added to create a mempool with element size big enough to hold the generic asymmetric diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index b60987db4b..d535722773 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethdev/rte_flow.h @@ -3528,6 +3528,7 @@ enum rte_flow_field_id { RTE_FLOW_FIELD_IPV6_ECN, /**< IPv6 ECN. */ RTE_FLOW_FIELD_GTP_PSC_QFI, /**< GTP QFI. */ RTE_FLOW_FIELD_METER_COLOR, /**< Meter color marker. */ + RTE_FLOW_FIELD_FLEX_ITEM, /**< Flex item. */ }; /** @@ -3541,8 +3542,11 @@ struct rte_flow_action_modify_data { RTE_STD_C11 union { struct { - /** Encapsulation level or tag index. */ - uint32_t level; + /**< Encapsulation level or tag index or flex item handle. */ + union { + uint32_t level; + struct rte_flow_item_flex_handle *flex_handle; + }; /** Number of bits to skip from a field. */ uint32_t offset; }; From patchwork Wed Dec 21 08:39:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: rongwei liu X-Patchwork-Id: 121173 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C391A034C; Wed, 21 Dec 2022 09:40:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C00C942D14; Wed, 21 Dec 2022 09:40:41 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2067.outbound.protection.outlook.com [40.107.237.67]) by mails.dpdk.org (Postfix) with ESMTP id 2190742D14 for ; Wed, 21 Dec 2022 09:40:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fXBjbFOubIgTEyaueus5sSXCjP/98vBpkaUzTNgUtC/ycggYJMCmSGfYxXz6A4gtd6X2et4zpMTXjTxIdl3yNt7G0ipzGZ50G2TD2Zo752O3knHw6I3U+4fz79o9ZrZzumvaZX7wm89jK12znN4WAdQGIn+KWcrxLGOb2gA7tPYGgSsXuLcwk6J4yPVB14ywU+LvUVsVOScSshPr2u7UqpWoRNSYgr+stQEs7FO/CKkraqgKDv4E6ZbOCIv6JjzJbbPjYKB4lgfCnWcyBEEEBXVOwKxh84XYZRrg1+3p8/1tpMvgFXIfL5YRhiqPZPEfCeqgHlKU5kPNKBq8dEg7rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2eTVissLkKk3fFX0lMv63B7YmGpOQdwVcW8t5hTYTYw=; b=kl5rS+V2TRvZuO4Imx+MB1jPN5862pT6hpV9hdRcD9nmfpHFKOCZauRcGKEt4qpgy1gB4q+TJiA1YB4prqDUO8bpCd1rABQvh5Rxa8SQ+FTHyliN+2pRt9VVty+qyO+O7hpdxYcx42uWLdrryhKFoN6RwqX38Nspu/P71cagOgGGL0913CaPTFLHsz9pP4L7Ot3rAiftrulDY6uip0FQQ2eTBGa7kyeFLOWmvnQ1uRmwgJyCp0URkL7vpNlNr8uc+EXkg61+SA2595Uq09OjFhqi6GYbEsZAW1xIsrnAKjAPRhtqGJo3Nu8/F5vKZB+O1KEa9bQXCoe5tvP8Vx+MSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2eTVissLkKk3fFX0lMv63B7YmGpOQdwVcW8t5hTYTYw=; b=eRVQ1RZ7TixQ4C4X+xvItr5TS6LbXE59S6gcKqHKxpshdbL4IEimsr9wPjrYULwraHuS35iYw5tvdw0954lqTr+V7toha4yRKldP/8Kp4YR4JCGn1iW8n6sT1jk4d7ZaBYAlZa2JfViQdnmdtNHzla4m7IhefClaCfs86QahDriUjbDV7lbAsKNdmZ1m6DuSu4x/cQkiTBm6ywqmX9cpDnkTiWDwh3ebNjRCynZq7SYxNlTK7xiulvclAYVU0qNAy77zPIfDYbSwFaYRRay5qScO4YUwiK9FYDNz1B4dU027hRkSPwjrPqWXEyZPG4wvPfAZMFOupSGFoMdIviWKlQ== Received: from BN8PR04CA0045.namprd04.prod.outlook.com (2603:10b6:408:d4::19) by PH7PR12MB7332.namprd12.prod.outlook.com (2603:10b6:510:20f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 08:40:39 +0000 Received: from BL02EPF00010208.namprd05.prod.outlook.com (2603:10b6:408:d4:cafe::a1) by BN8PR04CA0045.outlook.office365.com (2603:10b6:408:d4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.21 via Frontend Transport; Wed, 21 Dec 2022 08:40:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF00010208.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.8 via Frontend Transport; Wed, 21 Dec 2022 08:40:39 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:22 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:19 -0800 From: Rongwei Liu To: , , , , Aman Singh , Yuying Zhang CC: , Subject: [RFC 2/9] app/testpmd: add flex item modify field cmdline support Date: Wed, 21 Dec 2022 10:39:53 +0200 Message-ID: <20221221084000.3680015-3-rongweil@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20221221084000.3680015-1-rongweil@nvidia.com> References: <20221221084000.3680015-1-rongweil@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00010208:EE_|PH7PR12MB7332:EE_ X-MS-Office365-Filtering-Correlation-Id: 59d3a3dd-8fbb-48c0-a5ad-08dae32f09ca X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GXKHB6E+oYMy0lUR9QGIxa3B+Pcq9OOMCjErdcojURpDzuKiYd1WoQRhDDraPbTzc02imdOEen6nZpupp5VfXZ3wNhPfxvI4mU0V31nLC8ubTNCqCtd2CYCTZXY8Znv7NMUluPdWVuBafkj+Mg/7VwpFfu4pUjKPA0Dp8zahdLG4zMaNOPQrhAjKNxhxEKRTUmAvImZlcP2u85+hk+LUXVkLXEI+7x0Paoc3U8KmmfJ3AiHKSPEtAp97eJgPPx11ZAwoPgX13F6R+8pH0+uKZ0BIfHoBzWveWdUrthbc4Dy9lEBRn5a4Fidd/FJMetfRMno6VCp78HmBiRLqoKno9fjlIizV/kXJ7IH4rq2j0eZPe0JhSaKe56MHrYSlLJm0a+0RLgtqSSKy/bkGcKw3skAoXbbSHN4A2g4kHLpFPqjZ56UbniNkAT+91gFCVHiXbXnrBtfAoY/0ktMjLoBA170fgMC5U/oNce96qrAN1DDgvfKwcYCyj/kT6JZlU3Md3e3wZAifcU0seLyNIclPQZ5VjVwfngWZSKlPfX7nviEontOu9+ve8+kGI9kZZYfqmY4NtnehK4LKAOV/K+8nXYgbWv0+91GLL/8wqUPoYGLFdJwAdp/VZPw0lAD+4fAHhp4bgwDIo9xasU3nCOkypyrtH1BQ5Cz2MxKDwbZphu0O1p1cpTGFFbuq9KVHCwB3A8Yphrir7xMYdwTJzxbn/g== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199015)(46966006)(40470700004)(36840700001)(83380400001)(36756003)(186003)(478600001)(86362001)(55016003)(40480700001)(40460700003)(26005)(426003)(356005)(36860700001)(82310400005)(336012)(2616005)(82740400003)(1076003)(8676002)(47076005)(7696005)(107886003)(6666004)(4326008)(70586007)(16526019)(70206006)(6286002)(7636003)(8936002)(5660300002)(2906002)(41300700001)(110136005)(54906003)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 08:40:39.1558 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59d3a3dd-8fbb-48c0-a5ad-08dae32f09ca X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00010208.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7332 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add flex item modify field cmdline support. Now user can use testpmd cli to specify which flex item to be modified, either source or destination. Syntax is as below: modify_field op set dst_type flex_item dst_level 0 dst_offset 16 src_type value src_value 0x123456781020 width 8 Signed-off-by: Rongwei Liu --- app/test-pmd/cmdline_flow.c | 89 ++++++++++++++++++++++++++++++++++--- 1 file changed, 82 insertions(+), 7 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 88108498e0..7c12d63cbc 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -601,10 +601,12 @@ enum index { ACTION_MODIFY_FIELD_DST_TYPE, ACTION_MODIFY_FIELD_DST_TYPE_VALUE, ACTION_MODIFY_FIELD_DST_LEVEL, + ACTION_MODIFY_FIELD_DST_LEVEL_VALUE, ACTION_MODIFY_FIELD_DST_OFFSET, ACTION_MODIFY_FIELD_SRC_TYPE, ACTION_MODIFY_FIELD_SRC_TYPE_VALUE, ACTION_MODIFY_FIELD_SRC_LEVEL, + ACTION_MODIFY_FIELD_SRC_LEVEL_VALUE, ACTION_MODIFY_FIELD_SRC_OFFSET, ACTION_MODIFY_FIELD_SRC_VALUE, ACTION_MODIFY_FIELD_SRC_POINTER, @@ -807,7 +809,8 @@ static const char *const modify_field_ids[] = { "udp_port_src", "udp_port_dst", "vxlan_vni", "geneve_vni", "gtp_teid", "tag", "mark", "meta", "pointer", "value", - "ipv4_ecn", "ipv6_ecn", "gtp_psc_qfi", "meter_color", NULL + "ipv4_ecn", "ipv6_ecn", "gtp_psc_qfi", "meter_color", + "flex_item", NULL }; static const char *const meter_colors[] = { @@ -2282,6 +2285,10 @@ parse_vc_modify_field_id(struct context *ctx, const struct token *token, const char *str, unsigned int len, void *buf, unsigned int size); static int +parse_vc_modify_field_level(struct context *ctx, const struct token *token, + const char *str, unsigned int len, void *buf, + unsigned int size); +static int parse_vc_action_conntrack_update(struct context *ctx, const struct token *token, const char *str, unsigned int len, void *buf, unsigned int size); @@ -5976,11 +5983,15 @@ static const struct token token_list[] = { .name = "dst_level", .help = "destination field level", .next = NEXT(action_modify_field_dst, - NEXT_ENTRY(COMMON_UNSIGNED)), - .args = ARGS(ARGS_ENTRY(struct rte_flow_action_modify_field, - dst.level)), + NEXT_ENTRY(ACTION_MODIFY_FIELD_DST_LEVEL_VALUE)), .call = parse_vc_conf, }, + [ACTION_MODIFY_FIELD_DST_LEVEL_VALUE] = { + .name = "{dst_level}", + .help = "destination field level value", + .call = parse_vc_modify_field_level, + .comp = comp_none, + }, [ACTION_MODIFY_FIELD_DST_OFFSET] = { .name = "dst_offset", .help = "destination field bit offset", @@ -6007,11 +6018,15 @@ static const struct token token_list[] = { .name = "src_level", .help = "source field level", .next = NEXT(action_modify_field_src, - NEXT_ENTRY(COMMON_UNSIGNED)), - .args = ARGS(ARGS_ENTRY(struct rte_flow_action_modify_field, - src.level)), + NEXT_ENTRY(ACTION_MODIFY_FIELD_SRC_LEVEL_VALUE)), .call = parse_vc_conf, }, + [ACTION_MODIFY_FIELD_SRC_LEVEL_VALUE] = { + .name = "{src_level}", + .help = "source field level value", + .call = parse_vc_modify_field_level, + .comp = comp_none, + }, [ACTION_MODIFY_FIELD_SRC_OFFSET] = { .name = "src_offset", .help = "source field bit offset", @@ -8477,6 +8492,66 @@ parse_vc_modify_field_id(struct context *ctx, const struct token *token, return len; } +/** Parse level for modify_field command. */ +static int +parse_vc_modify_field_level(struct context *ctx, const struct token *token, + const char *str, unsigned int len, void *buf, + unsigned int size) +{ + struct rte_flow_action_modify_field *action; + struct flex_item *fp; + uint32_t val; + struct buffer *out = buf; + char *end; + + (void)token; + (void)size; + if (ctx->curr != ACTION_MODIFY_FIELD_DST_LEVEL_VALUE && + ctx->curr != ACTION_MODIFY_FIELD_SRC_LEVEL_VALUE) + return -1; + if (!ctx->object) + return len; + action = ctx->object; + errno = 0; + val = strtoumax(str, &end, 0); + if (errno || (size_t)(end - str) != len) + return -1; + /* No need to validate action template mask value */ + if (out->args.vc.masks) { + if (ctx->curr == ACTION_MODIFY_FIELD_DST_LEVEL_VALUE) + action->dst.level = val; + else + action->src.level = val; + return len; + } + if ((ctx->curr == ACTION_MODIFY_FIELD_DST_LEVEL_VALUE && + action->dst.field == RTE_FLOW_FIELD_FLEX_ITEM) || + (ctx->curr == ACTION_MODIFY_FIELD_SRC_LEVEL_VALUE && + action->src.field == RTE_FLOW_FIELD_FLEX_ITEM)) { + if (val >= FLEX_MAX_PARSERS_NUM) { + printf("Bad flex item handle\n"); + return -1; + } + fp = flex_items[ctx->port][val]; + if (!fp) { + printf("Bad flex item handle\n"); + return -1; + } + } + if (ctx->curr == ACTION_MODIFY_FIELD_DST_LEVEL_VALUE) { + if (action->dst.field != RTE_FLOW_FIELD_FLEX_ITEM) + action->dst.level = val; + else + action->dst.flex_handle = fp->flex_handle; + } else if (ctx->curr == ACTION_MODIFY_FIELD_SRC_LEVEL_VALUE) { + if (action->src.field != RTE_FLOW_FIELD_FLEX_ITEM) + action->src.level = val; + else + action->src.flex_handle = fp->flex_handle; + } + return len; +} + /** Parse the conntrack update, not a rte_flow_action. */ static int parse_vc_action_conntrack_update(struct context *ctx, const struct token *token, From patchwork Wed Dec 21 08:39:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: rongwei liu X-Patchwork-Id: 121174 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 082E3A034C; Wed, 21 Dec 2022 09:40:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5A9742D20; Wed, 21 Dec 2022 09:40:45 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2055.outbound.protection.outlook.com [40.107.101.55]) by mails.dpdk.org (Postfix) with ESMTP id F09A142D15 for ; Wed, 21 Dec 2022 09:40:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wfv8+T5pAZLaqceZmnRXtBPem6pXYBxLHbRoz8TjVwwELTWO/1R9DAXyfhQS0plK/XrDALsqWy9FMTIvgZ+Iku7iy67eSW0EfCl4rPcrE5PK7CilsjvyAt2l/+xMHOEm/gVD4ajQvYS1fVPqmZTopSpS3jdnNEp7gQUzzz6bsZjylqfyVVAmS+hxllzsQ66XR2ncq7H1YCfxg55zrg3fgFJPevY+sIlCb0CxaqICI9OwryJrGTg4YfbfOBJgqCdYSSFOtyUkNlGTXfvHJpAY/R0JC8C1AfDuM1wPaPEWTKJLc+m5e+5tCaBI5VPi06qWJKccwyYGp2nTp4j4S1gmRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=izWQsvqsYbWbh/KLnvwIRfH7zG3iboKtutQbKAhufPk=; b=FD6oxzgSZr6BACxYInKRocXRlOyGrMwVzaWLv4nGFkZqAZmG2Q6IIBnp0Q9OpW3eR+5Gktcgbl8T0yXu0a3dnSnHAxue/PecQCnfVZ5kMjI1hrNdZjewvfGYQOE3wChgnaoBoWg+xBPnfO/vBOLJdXNDo2er4N/+3pQN17Vx+VVUn8XvdtK/tybqyn0dIVsL2iUP/UvKYN+z4EH52LF5iQR/LH/uS2fPCOiidVh7DbiMI+FdjBbeO+R/O7vv3TnuI4I/BLeen2TBqgTz6QO86gjjmyGMMNiyoTsFa3bwWuOjpp2b8Y8OHXyPg0t/uY8HbsVHhnbw5F1GBKH+SSuvOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=izWQsvqsYbWbh/KLnvwIRfH7zG3iboKtutQbKAhufPk=; b=MMI6UzbvXxTi/52qi5Ilk9U1Aj5jCg0NzbCf4nr8jEakyoJfPxU1Ev/eZsPgLNMOBuLdruj9py7RdtwPTPN7brePi3J9xrBdyWXozMX/gHDftzI4/3SmLPv0RLuh+RL78OOpo6s1m3io4H1wdSLfoqm0RvYW3jig9NEhxBobPepkp+b9nW8DMlpc/IzfMZvWI+PUGDYBjyxl1h+d2/am+hKgJHHzy98/S5xsQtTt3vdKurgRjOwncPdLnOtNtypQWUrT2Y3+hAWa6+ly6D6CyatWSyUaXVu533reZBnfPrBIpD0LPyRoFNS4FQlpwriSowtwJpeqO24uKKba5Hb3Iw== Received: from BL1P221CA0024.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:2c5::31) by SA0PR12MB7092.namprd12.prod.outlook.com (2603:10b6:806:2d5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 08:40:42 +0000 Received: from BL02EPF00010206.namprd05.prod.outlook.com (2603:10b6:208:2c5:cafe::77) by BL1P221CA0024.outlook.office365.com (2603:10b6:208:2c5::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.21 via Frontend Transport; Wed, 21 Dec 2022 08:40:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF00010206.mail.protection.outlook.com (10.167.241.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.8 via Frontend Transport; Wed, 21 Dec 2022 08:40:41 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:25 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:22 -0800 From: Rongwei Liu To: , , , , Aman Singh , Yuying Zhang CC: , Subject: [RFC 3/9] app/testpmd: pass flex handle into matching mask Date: Wed, 21 Dec 2022 10:39:54 +0200 Message-ID: <20221221084000.3680015-4-rongweil@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20221221084000.3680015-1-rongweil@nvidia.com> References: <20221221084000.3680015-1-rongweil@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00010206:EE_|SA0PR12MB7092:EE_ X-MS-Office365-Filtering-Correlation-Id: df4951e6-3473-4ca6-a31d-08dae32f0b39 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wP1v+ByPqocB0D8gNUNtut4Gk2Bmc/HMUYLZeqX1VEARBD/swGwMBOPuuvEWZJgbVIXGmkoAcaOfAsFVEs0r+EYmuSKAEY/19F0+gBe0GgI1U1VZTeWDGz/0jrLML/Q5JaLKVY2ahTU31I4bYeNnbOdiADo6JKGU6BBGLCX0CAaTgM7J3T19o3gFpjZrjW0SGDdqSF0jA1Dx9p7zs585oO6o6gMJFZbDxKpm+nhqPCaQD5KcftxxCg5PNXdsIHuipcv40yeWjaB6y7d+RNcInoaxGBO3QGg6jw4uw7zzKA4R4/QUwRzObeYzD6yFn/1rdRP6PbGIRQY3yaOklSENcGqOeIUxWLl0GUbR/HG0S4Xeaxbu8+SfiIFrNuAXXYb7h0s7dwAElruNR1U+MErtmUT7lJTfxx/4MMyhlr+Gqb6rRIGkX4L8H2166VbikUJgQYsCscJ36eLyKTDkWNgreDDot+gG5Ewv4WfuTu452uzQxtdfo7j5GzdJeqqUldi04TZ0+vQpK/TJMAudr96xmOpDdM1bGjzuTlLibcN5QoyaOMbc9YAKZy+SpGbJB9dE3bfF+W6xnVa2w0N20nY/Qu/+3578NLo0sgz73w31+M7F53s2t+yOejRFSw1bIUGY+Xl+zK+kYT9KA3A2O11YBe4FEkj355C+pIW+SlayA22IdLtkcIQUkcbdtJa0364rIMgvUntBjjt/FwtW/4qV8g== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199015)(36840700001)(46966006)(40470700004)(36756003)(110136005)(7636003)(55016003)(356005)(54906003)(316002)(86362001)(82310400005)(40460700003)(4326008)(8676002)(70206006)(41300700001)(83380400001)(36860700001)(40480700001)(70586007)(8936002)(107886003)(7696005)(6666004)(82740400003)(2906002)(16526019)(5660300002)(426003)(478600001)(2616005)(336012)(1076003)(47076005)(6286002)(26005)(186003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 08:40:41.5766 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: df4951e6-3473-4ca6-a31d-08dae32f0b39 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00010206.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7092 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In async flow create API, there is only mask information when creating flow table but flex item handle is required to parse the HW sample information. Pass the flex item handle instead of UINT64/32_MAX to mask. Signed-off-by: Rongwei Liu --- app/test-pmd/cmdline_flow.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 7c12d63cbc..9037432cc8 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -10068,8 +10068,8 @@ parse_flex_handle(struct context *ctx, const struct token *token, } if (offset == offsetof(struct rte_flow_item_flex, handle)) { const struct flex_item *fp; - struct rte_flow_item_flex *item_flex = ctx->object; - handle = (uint16_t)(uintptr_t)item_flex->handle; + spec = ctx->object; + handle = (uint16_t)(uintptr_t)spec->handle; if (handle >= FLEX_MAX_PARSERS_NUM) { printf("Bad flex item handle\n"); return -1; @@ -10079,7 +10079,9 @@ parse_flex_handle(struct context *ctx, const struct token *token, printf("Bad flex item handle\n"); return -1; } - item_flex->handle = fp->flex_handle; + spec->handle = fp->flex_handle; + mask = spec + 2; /* spec, last, mask */ + mask->handle = fp->flex_handle; } else if (offset == offsetof(struct rte_flow_item_flex, pattern)) { handle = (uint16_t)(uintptr_t) ((struct rte_flow_item_flex *)ctx->object)->pattern; From patchwork Wed Dec 21 08:39:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: rongwei liu X-Patchwork-Id: 121175 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 450CCA034C; Wed, 21 Dec 2022 09:40:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B19742D27; Wed, 21 Dec 2022 09:40:47 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2055.outbound.protection.outlook.com [40.107.95.55]) by mails.dpdk.org (Postfix) with ESMTP id ABD8642D20 for ; Wed, 21 Dec 2022 09:40:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MGI3o1FPCkh/w9VBwb7w+4oKzD6J6SYgAZjV4xOuWT2KLy5L5xOEt90bo2yy8+t/Ized4Ek2yeksd6Sy0rURXBLgwxQKEBna7ob6WQLHe+yaI1mo72r+5aJO2woBztUu7a3mdwIoBz1SKctevqHSOHTVxVbg0WrvDzZXTPnCNyiYscr4is2jiK7reole2ySnI0bk7HbKG1AF0xRzGUM0KlmSc9Zhbn2CAqIBfV32rtVn/gOVU9NXHydQuudjHQ5E9NqtTdsAYqunX34Jr/fqHGbWsB4GnDhwE51lut1rfynEyAMt/2RIfQZgSWzmHZkOjNsR7JauQECqejcVc7d8qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qKD/beZ8HYMOo0Axqwo79FTadLxyfPR+G7yt0LgCyL4=; b=GN7zJLPSfC6F8z48yDBCAWf9n+jK/B2DCPXvHjqZ2lEQeUPyoLdhrj8rWueSrYuUzGv7Lbrkxm4SToaLQd3+ZN3ybxvSdzqyT1+EFfaVb9IN/bfTnnOmVeqRo64nj37HvLOb3S3+hCopJkE+gJFshaAo0cT+nDlbw34AgQ31nnzOLxUD6J5rS5Vzzm+ckVgRi9a7kfyiO8O3GMZRgZ6x6fLwBghtMLkS/M764vwnkG7dsm69LnP2Yyd+9h+iKAQslEBr/nvNKVspkvrmZG+FViJtB8i8tYtHSGjOUzwSdDhVDvt3vgmx7HzcVPYjcuqtDVgZnj7gKLMvBSS/bTk0UA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qKD/beZ8HYMOo0Axqwo79FTadLxyfPR+G7yt0LgCyL4=; b=heCTbMQw//zz5WG4/gzJuGkWcvJmUUDkot5PWGhPhtGCb5v45ptMtGhO1+8w1zMO21+P0u68nuel0S/JSt73YBbN3UrD9uooajJ4L67xp00PZnZKKO1gxj5pNVMc8fD72xMxFnBmPDNQDhDFetwXFKQw3GQOqBQIRfd6T6QmbjIwJVFV6IpC5StM7nD5PsKTM/glw18WFfvyiD6Be7L5yzoCgrpTb8h3/Iegc9pQRdQm/cB8yHv3DhjqFvSyE9ahybwZzIXjJ9eaK1vR2QqBoK79mAMpXoGu8FDUvO6I4lAYqfDBYEANrBplqKYf/1RfjOtXNVyjyZE/DDi1avE38A== Received: from MW4PR04CA0342.namprd04.prod.outlook.com (2603:10b6:303:8a::17) by PH7PR12MB7163.namprd12.prod.outlook.com (2603:10b6:510:202::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 08:40:43 +0000 Received: from CO1NAM11FT099.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8a:cafe::5c) by MW4PR04CA0342.outlook.office365.com (2603:10b6:303:8a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.21 via Frontend Transport; Wed, 21 Dec 2022 08:40:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT099.mail.protection.outlook.com (10.13.175.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.6 via Frontend Transport; Wed, 21 Dec 2022 08:40:42 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:27 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:25 -0800 From: Rongwei Liu To: , , , CC: , Subject: [RFC 4/9] net/mlx5: enable hws flex item create Date: Wed, 21 Dec 2022 10:39:55 +0200 Message-ID: <20221221084000.3680015-5-rongweil@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20221221084000.3680015-1-rongweil@nvidia.com> References: <20221221084000.3680015-1-rongweil@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT099:EE_|PH7PR12MB7163:EE_ X-MS-Office365-Filtering-Correlation-Id: d30a6ee1-5efc-40c2-840a-08dae32f0be9 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xe2n7/YfR7M7HPM22gw48NRoJqh2x2pvsChyf5MZNQt8FhuqPzMCJ28Y4Nt8l9UfsqceHd50lsa1ALTYIKuLQygKn59PsycbscyGFFFCQbEBYIt3BsnvZpZqOqCVctAoEhDjCPPk2/9RZIXxh6iI7KJUuIrBX7N1v3A6Xzk1Nem4e1P+Q1ykNFqgabcDfnmd0IRYTaLVsBeTT6i0SibgwQtsioFi2ca4lWmPH51UvAXmIBv5wbREXj/4gFkLHGryRv5z2qUarrC4qAzU6SAR22jHuZz9EVaQilcul9DIPfCawcHipxwcbLNpYFGjzqMyanth9C2JJXL382gzYA+2WI+Ymo/uca8RfHQ9DYpv3sPJhKfnmWSlktShAZHKNXC3HS3+UKJsvFP1/myHxMyhTZEgPMh05OX1gveO5MU4rgbjCp5gsYHlUhU/dgRaUrVUsAft/2b7EXatlz+1Rp48RGdvKqN8eGPCJLy4sokg3319LP9EWF7JnsfyBgiQX0E3qWaqZWqdOk7XBExp3x8H1d6uKuYIALR/ABqk2OY2b/Ky7w1zZ8GOx6nG4zdm3HZZLb1UPV2xAPESiAq5xgokG40UsSXiy1AvlYd7LdpplOH8E1/68OckhHOlHSYNWjuGUr4RJ4h4rGDLTFw5Tth6nKtsko9EDAFevpIxVeByAHWskEUFZNK277XjrNNLO3oDPXAfsVHoIZVAJaqG0q4PZw== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(376002)(136003)(39860400002)(346002)(451199015)(46966006)(40470700004)(36840700001)(16526019)(1076003)(6286002)(186003)(6666004)(26005)(107886003)(2616005)(86362001)(2906002)(478600001)(7696005)(5660300002)(336012)(47076005)(316002)(54906003)(426003)(110136005)(82310400005)(70586007)(83380400001)(70206006)(36756003)(8936002)(41300700001)(8676002)(4326008)(36860700001)(82740400003)(40460700003)(40480700001)(356005)(55016003)(7636003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 08:40:42.7449 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d30a6ee1-5efc-40c2-840a-08dae32f0be9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT099.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7163 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Enable flex item create and destroy with dv_flow_en=2 Signed-off-by: Rongwei Liu --- drivers/net/mlx5/linux/mlx5_os.c | 27 +++++++++++++++------------ drivers/net/mlx5/mlx5_flow_hw.c | 2 ++ 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index a71474c90a..f5b3edea99 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -474,10 +474,20 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv) err = mlx5_alloc_table_hash_list(priv); if (err) goto error; - if (priv->sh->config.dv_flow_en == 2) - return 0; /* The resources below are only valid with DV support. */ #ifdef HAVE_IBV_FLOW_DV_SUPPORT + /* Init shared flex parsers list, no need lcore_share */ + snprintf(s, sizeof(s), "%s_flex_parsers_list", sh->ibdev_name); + sh->flex_parsers_dv = mlx5_list_create(s, sh, false, + mlx5_flex_parser_create_cb, + mlx5_flex_parser_match_cb, + mlx5_flex_parser_remove_cb, + mlx5_flex_parser_clone_cb, + mlx5_flex_parser_clone_free_cb); + if (!sh->flex_parsers_dv) + goto error; + if (priv->sh->config.dv_flow_en == 2) + return 0; /* Init port id action list. */ snprintf(s, sizeof(s), "%s_port_id_action_list", sh->ibdev_name); sh->port_id_action_list = mlx5_list_create(s, sh, true, @@ -518,16 +528,9 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv) flow_dv_dest_array_clone_free_cb); if (!sh->dest_array_list) goto error; - /* Init shared flex parsers list, no need lcore_share */ - snprintf(s, sizeof(s), "%s_flex_parsers_list", sh->ibdev_name); - sh->flex_parsers_dv = mlx5_list_create(s, sh, false, - mlx5_flex_parser_create_cb, - mlx5_flex_parser_match_cb, - mlx5_flex_parser_remove_cb, - mlx5_flex_parser_clone_cb, - mlx5_flex_parser_clone_free_cb); - if (!sh->flex_parsers_dv) - goto error; +#else + if (priv->sh->config.dv_flow_en == 2) + return 0; #endif #ifdef HAVE_MLX5DV_DR void *domain; diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 20c71ff7f0..44953451d5 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -8336,6 +8336,8 @@ const struct mlx5_flow_driver_ops mlx5_flow_hw_drv_ops = { .query = flow_hw_query, .get_aged_flows = flow_hw_get_aged_flows, .get_q_aged_flows = flow_hw_get_q_aged_flows, + .item_create = flow_dv_item_create, + .item_release = flow_dv_item_release, }; /** From patchwork Wed Dec 21 08:39:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: rongwei liu X-Patchwork-Id: 121176 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F53FA034C; Wed, 21 Dec 2022 09:41:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F1EF42D2B; Wed, 21 Dec 2022 09:40:48 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2057.outbound.protection.outlook.com [40.107.92.57]) by mails.dpdk.org (Postfix) with ESMTP id 186EF42D15 for ; Wed, 21 Dec 2022 09:40:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e8RrntRCavD4baSae1k3+BaDHD+jQp5MZ0GczinSLqZAHrX1f5t57URR4uzobG9afTVdiGfeOXK+t3pcx9muGoZAEsrmYrWTjktJcq6pgALcGms6LlUOBb9mDlruzITQhYFp8f0RujI5w7gzO6W5xmJGlduOQfct6Zhv5S59NOCzxAIoFVrDPAY8rOI7/9W6oRSAqD+2Q1dhqCwXZyZGZxj1/TYXccphGx+Sgkxzwm4iT9Ls/BX0dW7/xBB2U328vUEmvHXDH2OtQg4wHg1JzG0PsRib0WF8T2F7syiVwHQWS0/rlFywuQr8YPkHiDMF2CY3M9UvnoIyrayp6/bA3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rYsKWPVIg0uDRdZBRltxYOkyVeSCsDRHoF1tQjC1oTg=; b=RMjYvKmKlFJNnoAiLCjx04DVezg7CjjAAy6yZ/O+KXwXuQcHV3faiJLskdOBE/e/PG1bkJNGbiRGo7NXGy0tzhPqfQY8zIZA79AuDkoYGwvhLDRnz7n3IoYF11NCjHruTjOvCdWLPe5U9NtwhCQm+sWKB83ibB4BvA6q6pdNxRgF2+hv0lrCeUN+if6oh2e4tZSQAXChSdcaoslXXn6vY95gNL9w9GawVfkf6JQQY0W1ERdAET/JWwJGdRqhPEQ3GNMJ0ts3WHvaHnJnzkXM5llUPMd9sAcAK+RIw4UyGgdORXN+7lt2nTqNzSdJr+oge/xLrq2YSVeeOFuqZ4JcBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rYsKWPVIg0uDRdZBRltxYOkyVeSCsDRHoF1tQjC1oTg=; b=H7PfzVM6YjvVEhhvUcUytx8EQcUPwmv5N7ydvO1S1PvANuhFGJHiXFnY7SAYS/Kr/auOMj82y+W5wwy29/1JmHxXOSEAMmLlK8TU+/aLq5naEA8HKkZd7MO8vhSpMmT+92DubywlCZBgeVNbstnkQIFQDCvzphQvItwG3/PJ3UAoO/+O/jBSXo6ZrocD0LLIKtZgas+EABFMLrkNxJoHQHUwmuN6vGfEihfoF7W3jKT4OqaWa1ATb4gVXAmvwDQC7gI0uLuzMA7DJF67zek+IlY847z7emx2KvSm28CsYBwnME+MzoeRXOZZpykpAZaXO1V6LA3pmY7v5hcLDr3cwA== Received: from BN8PR04CA0041.namprd04.prod.outlook.com (2603:10b6:408:d4::15) by SJ1PR12MB6100.namprd12.prod.outlook.com (2603:10b6:a03:45d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 08:40:43 +0000 Received: from BL02EPF00010208.namprd05.prod.outlook.com (2603:10b6:408:d4:cafe::aa) by BN8PR04CA0041.outlook.office365.com (2603:10b6:408:d4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.21 via Frontend Transport; Wed, 21 Dec 2022 08:40:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF00010208.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.8 via Frontend Transport; Wed, 21 Dec 2022 08:40:42 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:30 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:27 -0800 From: Rongwei Liu To: , , , CC: , Subject: [RFC 5/9] net/mlx5: add IPv6 protocol as flex item input Date: Wed, 21 Dec 2022 10:39:56 +0200 Message-ID: <20221221084000.3680015-6-rongweil@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20221221084000.3680015-1-rongweil@nvidia.com> References: <20221221084000.3680015-1-rongweil@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00010208:EE_|SJ1PR12MB6100:EE_ X-MS-Office365-Filtering-Correlation-Id: 88b24150-f89b-42aa-16e4-08dae32f0c02 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OnZcPEXOi9h4I8v/1iZOxYWbcTG2tEr8mxKBsF0/U8pEEXKc/AdACUwAdCmwJdQeAvW16pMb48ZqOQsuUq+NYAY5RqJdp0HUTKePClIhx9FDQ4pxC7JTZnpKfN9MBvKIuOaBPVz6vJEhn+vYenDzvSZAdpyD37g2h1j6LaCkok6ADq4y0SfzLiDwfZZkX3oDlAZHokUlfRy4LDCVULy2h2HNpMZxkUe18xvy6AIzdkL9lxKsqZnUss/aUZOuP4X+Ej1XZ7AhOBwvno/80PP6q55lTvSoLQyAf3adWpNRWrcFMtdxwpb3B1BewGwrHIifXjuN8ECL+Da+Uh/iez55+ip/JXRVxqZUt6JCka7X4yCmWmGUeBKr6pSjmFtVokvO+Uv4vHrkhKkKT/Dt59C3Xplg/zJrLD1tern76AsQ68jLtk68VJ9JMzS1Ll5caZmrwps5EJkhcgQYDbVTVg8O6a3U+YOUm7J6WraUynLjCXF/uPpVOzztLJbr8vOG9C5NZYevm0dYBfOMjTnGlXYqOZsaqIAIwUVFd1InM6QYs5JXZeKmdYC1JZ+1uDQyV7kXHUQgU8WfgiVYhiilrg/K3u9sNzrJErqeJdpz/44G9D11z0PYkCDpd+qsgGKoW9p1ZOAikh11xX8/NNQrfW8ztIh6pHKvqKzyIirRWV9+vi0lAjCXGxVeMacWPzx4tRtuArT+nIP+UvP2XF+cXFvDIQ== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(136003)(346002)(39860400002)(396003)(451199015)(36840700001)(40470700004)(46966006)(41300700001)(40480700001)(8936002)(4326008)(8676002)(5660300002)(70206006)(54906003)(70586007)(55016003)(7636003)(86362001)(356005)(316002)(110136005)(2906002)(426003)(47076005)(1076003)(336012)(2616005)(82740400003)(7696005)(16526019)(82310400005)(40460700003)(186003)(6286002)(107886003)(6666004)(36860700001)(36756003)(478600001)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 08:40:42.8746 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88b24150-f89b-42aa-16e4-08dae32f0c02 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00010208.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Support IPv6 protocol as new flex item input link. Signed-off-by: Rongwei Liu --- drivers/net/mlx5/mlx5_flow_flex.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_flex.c b/drivers/net/mlx5/mlx5_flow_flex.c index fb08910ddb..bec07b13c1 100644 --- a/drivers/net/mlx5/mlx5_flow_flex.c +++ b/drivers/net/mlx5/mlx5_flow_flex.c @@ -1043,6 +1043,22 @@ mlx5_flex_arc_in_udp(const struct rte_flow_item *item, return rte_be_to_cpu_16(spec->hdr.dst_port); } +static int +mlx5_flex_arc_in_ipv6(const struct rte_flow_item *item, + struct rte_flow_error *error) +{ + const struct rte_flow_item_ipv6 *spec = item->spec; + const struct rte_flow_item_ipv6 *mask = item->mask; + struct rte_flow_item_ipv6 ip = { .hdr.proto = 0xff }; + + if (memcmp(mask, &ip, sizeof(struct rte_flow_item_ipv6))) { + return rte_flow_error_set + (error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, item, + "invalid ipv6 item mask, full mask is desired"); + } + return spec->hdr.proto; +} + static int mlx5_flex_translate_arc_in(struct mlx5_hca_flex_attr *attr, const struct rte_flow_item_flex_conf *conf, @@ -1089,6 +1105,9 @@ mlx5_flex_translate_arc_in(struct mlx5_hca_flex_attr *attr, case RTE_FLOW_ITEM_TYPE_UDP: ret = mlx5_flex_arc_in_udp(rte_item, error); break; + case RTE_FLOW_ITEM_TYPE_IPV6: + ret = mlx5_flex_arc_in_ipv6(rte_item, error); + break; default: MLX5_ASSERT(false); return rte_flow_error_set From patchwork Wed Dec 21 08:39:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: rongwei liu X-Patchwork-Id: 121177 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABBDCA034C; Wed, 21 Dec 2022 09:41:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAFC342D1A; Wed, 21 Dec 2022 09:40:53 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2082.outbound.protection.outlook.com [40.107.220.82]) by mails.dpdk.org (Postfix) with ESMTP id 3BE5F42D34 for ; Wed, 21 Dec 2022 09:40:51 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ze6/UayI5spJimiTrdJ/R1xqIJ961FkCLkmWWHl/HKMIT6Pmk985ymqehUOsDZIBAoKnX8XV86oV3woafHLCK2l/GtdicdEmqzXCXrFtuHZCINCLFmCzb3Uin44cw1tmDc3t26KvI7DI/yRnyWNo+kueGkYsjFoKCO59RLooZKX8pgYsVlgs/6EIikYmyazmWsAs9dR8qe5iovfLNE8OaIaaOUkN6kOdivm/E3pRWbiqZVNZIZors9i1zAahYhUZP+mwQfzo7O7bpiTGqIbEZgQfSCroTkWaMe+mhbtKpXrY3GigVjS1+bNifgNW32bCGZ03XGkWZxpL/Lch+184Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q4LnO/iwdCL+wCLoirR2t2L3h7IXdRJapvupHk+KuhM=; b=ae/Z5mZSvI/1fnROUkB/FJyoH/jhW9ROTdYJWtm8pLSzEg+xz2K/w6DtO8279qQ+Dt2LVY7duUGFyXWVp8hZUvF6rhdHdVXLLHfNOMMWg2VZnb1JlEyu97xxgWTpuhpCxaPauUZFyXseJ5xaL8LycHlESNY4ggKSf+zwqqCuRVFgkajWuYJk4Lozh3gddxpCeoeFnjBF3Aqu+sbdO1afW4hzYXOEmvDVkq7WM84pq2QkBrhgpshHc0tbzpWmLZHOm56WJln4IDtosQHH/j7Aiea+4ybccJ+lYHhe/9NtmJyHSyo/0nYwf8HPENtj/HUUsYiwYuHJdD70Qrq41sEwKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q4LnO/iwdCL+wCLoirR2t2L3h7IXdRJapvupHk+KuhM=; b=nT6IuRbGm3aAqVydpVofS0haZrm/v8j6CPXOwqSceTSkGT4Ud8OzwxLHAArtDAfx2ib7Tw1MQQ6QqSEqAvNBBmH/OBxM8G01hjnGg5ISNXII4dabYjYJSZBOrT4iRSzutve59oWtXYB6WLLS4w3BEvdbw5cf3wakPq/M2ZWewXj3oyVV2yJJVuerCcgCv60E5QB6wOdA95j+e3y6yUD//hJFiVVaxPXca697Y5c8NljMBQ9lYaTSqMZDxv4FyKljHOxaDyeTzHyej6PTTgJIIRJh4+thXhR9fCqTGllqNT6Y5vp953LlZ55habDH4pp9vF2KcUq2H6pcB65JEmvSiQ== Received: from MW4PR04CA0340.namprd04.prod.outlook.com (2603:10b6:303:8a::15) by SN7PR12MB8146.namprd12.prod.outlook.com (2603:10b6:806:323::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 08:40:46 +0000 Received: from CO1NAM11FT099.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8a::4) by MW4PR04CA0340.outlook.office365.com (2603:10b6:303:8a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.21 via Frontend Transport; Wed, 21 Dec 2022 08:40:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT099.mail.protection.outlook.com (10.13.175.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.6 via Frontend Transport; Wed, 21 Dec 2022 08:40:46 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:33 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:30 -0800 From: Rongwei Liu To: , , , CC: , Subject: [RFC 6/9] net/mlx5/hws: add hws flex item matching support Date: Wed, 21 Dec 2022 10:39:57 +0200 Message-ID: <20221221084000.3680015-7-rongweil@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20221221084000.3680015-1-rongweil@nvidia.com> References: <20221221084000.3680015-1-rongweil@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT099:EE_|SN7PR12MB8146:EE_ X-MS-Office365-Filtering-Correlation-Id: c361e286-704d-4498-9f33-08dae32f0df3 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4ESitwWnuvYPm/q/ltM/L1dOhMAHLYIBlgDfqiIM4iqCR8XSZUE5LOsgfxtrtzRiZT1L35KClFtksu3uN7bR4KETnzRXL3L/ZneyIOcNYFZBgHhw2vxsWrkJm7qy1DXsXFXsCEv+XAs87Sq1Vl7edG0AfDjavBUH9K8lgqXNzR/wwFmoUhX78bzdAjfitzqdjdsy9v8/TsFwj6XwE2EyEVE0Kc9UlRFiuPvslPMDsh6FJaEBVbPv+RQ0YF849XrHaeiAVe64Jdjt8xkXJSe3U2yT4O0Ai+tMSX7AN4TW9JyYMjr3duOUFP6+I/SH3NjDEfWwT0U+hPqAePKbTiZ7PA85g5iZ+koSY99mpsJpWD0VPf2lJJHQz3VGSoOmfq24AYUpYUiwH4No1ZZGqYL6d5xiHXBT72ZofSufJoNvcHpLIb02VayiXVmDnCeaq9nRDnPR84ylKq3uzQn0klbEET3X0RxUjhOBOm7aQ6ydb0AOd1w87WssIxeHbXfn9mgPxLRRYpOyJ7XK4exSgcm02y6EMLUdB8RpRmIQcKm+xcjZHtY7/iGyIIQJOEWFMsdTiFhUA/wcNccVGl2O3ukC23K34dcC04J6qLuSgj/ZfDHt0ItRj/D48XjQbbojN0F1nEIqOIOdD8L57y9522JGc0PG2IA1DwbOQhPCLi4ZtRQvnOq334sCmvw4CmBAPUQDlSHC5kx6IzRKCmEgbhJWCA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(1076003)(426003)(8676002)(40460700003)(8936002)(4326008)(336012)(356005)(7696005)(36756003)(41300700001)(36860700001)(47076005)(82740400003)(30864003)(7636003)(83380400001)(82310400005)(5660300002)(2906002)(107886003)(6666004)(478600001)(40480700001)(316002)(86362001)(110136005)(54906003)(70206006)(70586007)(2616005)(26005)(55016003)(6286002)(16526019)(186003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 08:40:46.1665 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c361e286-704d-4498-9f33-08dae32f0df3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT099.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8146 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Support flex item matching in hws and syntax follows sws exactly. Flex item should be created in advance and follow current json mapping logic. Signed-off-by: Rongwei Liu --- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 1 + drivers/common/mlx5/mlx5_devx_cmds.c | 14 ++- drivers/common/mlx5/mlx5_devx_cmds.h | 7 +- drivers/common/mlx5/mlx5_prm.h | 22 +++- drivers/net/mlx5/hws/mlx5dr_definer.c | 141 ++++++++++++++++++++++++++ drivers/net/mlx5/mlx5.c | 17 +++- drivers/net/mlx5/mlx5.h | 8 +- drivers/net/mlx5/mlx5_flow.h | 1 + drivers/net/mlx5/mlx5_flow_flex.c | 83 +++++++++++---- drivers/net/mlx5/mlx5_flow_hw.c | 48 ++++++++- 11 files changed, 310 insertions(+), 33 deletions(-) diff --git a/doc/guides/nics/features/mlx5.ini b/doc/guides/nics/features/mlx5.ini index 62fd330e2b..135b5c035d 100644 --- a/doc/guides/nics/features/mlx5.ini +++ b/doc/guides/nics/features/mlx5.ini @@ -87,6 +87,7 @@ vlan = Y vxlan = Y vxlan_gpe = Y represented_port = Y +flex item = Y [rte_flow actions] age = I diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 51f51259e3..397e04fbed 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -106,6 +106,7 @@ Features - Sub-Function representors. - Sub-Function. - Matching on represented port. +- Matching on flex item with specific pattern. Limitations diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index 59cebb530f..d6d70b600b 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -607,7 +607,8 @@ mlx5_devx_cmd_query_hca_vdpa_attr(void *ctx, int mlx5_devx_cmd_query_parse_samples(struct mlx5_devx_obj *flex_obj, - uint32_t ids[], uint32_t num) + struct mlx5_ext_sample_id ids[], + uint32_t num, uint8_t *anchor) { uint32_t in[MLX5_ST_SZ_DW(general_obj_in_cmd_hdr)] = {0}; uint32_t out[MLX5_ST_SZ_DW(create_flex_parser_out)] = {0}; @@ -636,6 +637,7 @@ mlx5_devx_cmd_query_parse_samples(struct mlx5_devx_obj *flex_obj, (void *)flex_obj); return -rte_errno; } + *anchor = MLX5_GET(parse_graph_flex, flex, head_anchor_id); for (i = 0; i < MLX5_GRAPH_NODE_SAMPLE_NUM; i++) { void *s_off = (void *)((char *)sample + i * MLX5_ST_SZ_BYTES(parse_graph_flow_match_sample)); @@ -645,8 +647,8 @@ mlx5_devx_cmd_query_parse_samples(struct mlx5_devx_obj *flex_obj, flow_match_sample_en); if (!en) continue; - ids[idx++] = MLX5_GET(parse_graph_flow_match_sample, s_off, - flow_match_sample_field_id); + ids[idx++].id = MLX5_GET(parse_graph_flow_match_sample, s_off, + flow_match_sample_field_id); } if (num != idx) { rte_errno = EINVAL; @@ -794,6 +796,12 @@ mlx5_devx_cmd_query_hca_parse_graph_node_cap max_num_arc_out); attr->max_num_sample = MLX5_GET(parse_graph_node_cap, hcattr, max_num_sample); + attr->anchor_en = MLX5_GET(parse_graph_node_cap, hcattr, anchor_en); + attr->ext_sample_id = MLX5_GET(parse_graph_node_cap, hcattr, ext_sample_id); + attr->sample_tunnel_inner2 = MLX5_GET(parse_graph_node_cap, hcattr, + sample_tunnel_inner2); + attr->zero_size_supported = MLX5_GET(parse_graph_node_cap, hcattr, + zero_size_supported); attr->sample_id_in_out = MLX5_GET(parse_graph_node_cap, hcattr, sample_id_in_out); attr->max_base_header_length = MLX5_GET(parse_graph_node_cap, hcattr, diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h index c94b9eac06..5b33010155 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.h +++ b/drivers/common/mlx5/mlx5_devx_cmds.h @@ -114,6 +114,10 @@ struct mlx5_hca_flex_attr { uint8_t max_num_arc_out; uint8_t max_num_sample; uint8_t max_num_prog_sample:5; /* From HCA CAP 2 */ + uint8_t anchor_en:1; + uint8_t ext_sample_id:1; + uint8_t sample_tunnel_inner2:1; + uint8_t zero_size_supported:1; uint8_t sample_id_in_out:1; uint16_t max_base_header_length; uint8_t max_sample_base_offset; @@ -706,7 +710,8 @@ int mlx5_devx_cmd_modify_tir(struct mlx5_devx_obj *tir, struct mlx5_devx_modify_tir_attr *tir_attr); __rte_internal int mlx5_devx_cmd_query_parse_samples(struct mlx5_devx_obj *flex_obj, - uint32_t ids[], uint32_t num); + struct mlx5_ext_sample_id ids[], + uint32_t num, uint8_t *anchor); __rte_internal struct mlx5_devx_obj * diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index 2b5c43ee6e..b080599570 100644 --- a/drivers/common/mlx5/mlx5_prm.h +++ b/drivers/common/mlx5/mlx5_prm.h @@ -1890,7 +1890,11 @@ struct mlx5_ifc_parse_graph_node_cap_bits { u8 max_num_arc_in[0x08]; u8 max_num_arc_out[0x08]; u8 max_num_sample[0x08]; - u8 reserved_at_78[0x07]; + u8 reserved_at_78[0x3]; + u8 anchor_en[0x1]; + u8 ext_sample_id[0x1]; + u8 sample_tunnel_inner2[0x1]; + u8 zero_size_supported[0x1]; u8 sample_id_in_out[0x1]; u8 max_base_header_length[0x10]; u8 reserved_at_90[0x08]; @@ -1900,6 +1904,18 @@ struct mlx5_ifc_parse_graph_node_cap_bits { u8 header_length_mask_width[0x08]; }; +/* ext_sample_id structure, see PRM Table 539. */ +struct mlx5_ext_sample_id { + union { + struct { + uint32_t format_select_dw:8; + uint32_t modify_field_id:12; + uint32_t sample_id:12; + }; + uint32_t id; + }; +}; + struct mlx5_ifc_flow_table_prop_layout_bits { u8 ft_support[0x1]; u8 flow_tag[0x1]; @@ -4455,7 +4471,9 @@ struct mlx5_ifc_parse_graph_flex_bits { u8 header_length_mode[0x4]; u8 header_length_field_offset[0x10]; u8 next_header_field_offset[0x10]; - u8 reserved_at_160[0x1b]; + u8 reserved_at_160[0x12]; + u8 head_anchor_id[0x6]; + u8 reserved_at_178[0x3]; u8 next_header_field_size[0x5]; u8 header_length_field_mask[0x20]; u8 reserved_at_224[0x20]; diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index 6b98eb8c96..5b933734b7 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -293,6 +293,57 @@ mlx5dr_definer_integrity_set(struct mlx5dr_definer_fc *fc, DR_SET(tag, ok1_bits, fc->byte_off, fc->bit_off, fc->bit_mask); } +static uint32_t +mlx5dr_definer_flex_parser_common(const struct mlx5dr_definer_fc *fc, + const struct rte_flow_item_flex *flex, + bool is_mask) +{ + struct mlx5_flex_item *tp = (struct mlx5_flex_item *)flex->handle; + struct mlx5_flex_pattern_field *map; + uint32_t i, val, pos, def; + int id; + + tp = (struct mlx5_flex_item *)flex->handle; + for (i = 0, pos = 0, val = 0; i < tp->mapnum && pos < flex->length * CHAR_BIT; i++) { + map = tp->map + i; + id = mlx5_flex_get_sample_id(tp, i, &pos, fc->bit_off, &def); + if (id == -1) + continue; + MLX5_ASSERT(id < (int)tp->devx_fp->num_samples); + if (id >= (int)tp->devx_fp->num_samples || id >= MLX5_GRAPH_NODE_SAMPLE_NUM) + return -1; + if (tp->devx_fp->sample_ids[id].format_select_dw * 4 == fc->byte_off) { + val |= RTE_BE32(mlx5_flex_get_bitfield(flex, pos, map->width, map->shift)) & + (is_mask ? def : UINT32_MAX); + } + pos += map->width; + } + return val; +} + +static void +mlx5dr_definer_flex_parser_set(struct mlx5dr_definer_fc *fc, + const void *item, + uint8_t *tag) +{ + uint32_t val; + + val = mlx5dr_definer_flex_parser_common(fc, item, false); + DR_SET_BE32(tag, (val & fc->bit_mask), fc->byte_off, 0, fc->bit_mask); +} + +static void +mlx5dr_definer_flex_parser_mask_set(struct mlx5dr_definer_fc *fc, + const void *item, + uint8_t *tag) +{ + uint32_t mask; + + mask = mlx5dr_definer_flex_parser_common(fc, item, true); + DR_SET_BE32(tag, (mask), fc->byte_off, 0, UINT32_MAX); + fc->bit_mask = mask; +} + static void mlx5dr_definer_gre_key_set(struct mlx5dr_definer_fc *fc, const void *item_spec, @@ -1465,6 +1516,91 @@ mlx5dr_definer_conv_item_meter_color(struct mlx5dr_definer_conv_data *cd, return 0; } +static struct mlx5dr_definer_fc * +mlx5dr_definer_get_flex_parser_fc(struct mlx5dr_definer_conv_data *cd, + struct mlx5_ext_sample_id reg, int item_idx) +{ + enum mlx5dr_definer_fname i = MLX5DR_DEFINER_FNAME_FLEX_PARSER_0; + struct mlx5dr_definer_fc *fc; + + for (; i <= MLX5DR_DEFINER_FNAME_FLEX_PARSER_7; i++) { + fc = &cd->fc[i]; + switch (i) { + case MLX5DR_DEFINER_FNAME_FLEX_PARSER_0: + DR_CALC_SET_HDR(fc, flex_parser, flex_parser_0); + break; + case MLX5DR_DEFINER_FNAME_FLEX_PARSER_1: + DR_CALC_SET_HDR(fc, flex_parser, flex_parser_1); + break; + case MLX5DR_DEFINER_FNAME_FLEX_PARSER_2: + DR_CALC_SET_HDR(fc, flex_parser, flex_parser_2); + break; + case MLX5DR_DEFINER_FNAME_FLEX_PARSER_3: + DR_CALC_SET_HDR(fc, flex_parser, flex_parser_3); + break; + case MLX5DR_DEFINER_FNAME_FLEX_PARSER_4: + DR_CALC_SET_HDR(fc, flex_parser, flex_parser_4); + break; + case MLX5DR_DEFINER_FNAME_FLEX_PARSER_5: + DR_CALC_SET_HDR(fc, flex_parser, flex_parser_5); + break; + case MLX5DR_DEFINER_FNAME_FLEX_PARSER_6: + DR_CALC_SET_HDR(fc, flex_parser, flex_parser_6); + break; + case MLX5DR_DEFINER_FNAME_FLEX_PARSER_7: + default: + DR_CALC_SET_HDR(fc, flex_parser, flex_parser_7); + break; + } + if (fc->byte_off == reg.format_select_dw * 4) + break; + } + if (i > MLX5DR_DEFINER_FNAME_FLEX_PARSER_7) { + rte_errno = ENOTSUP; + return NULL; + } + fc->item_idx = item_idx; + fc->tag_set = &mlx5dr_definer_flex_parser_set; + fc->fname = i; + fc->tag_mask_set = &mlx5dr_definer_flex_parser_mask_set; + fc->bit_off = cd->tunnel; + return fc; +} + +static int +mlx5dr_definer_conv_item_flex(struct mlx5dr_definer_conv_data *cd, + struct rte_flow_item *item, + int item_idx) +{ + const struct rte_flow_item_flex *v, *m; + struct mlx5_flex_pattern_field *map; + bool is_inner = cd->tunnel; + struct mlx5_flex_item *tp; + uint32_t i, mask, def; + uint32_t pos; + int id; + + MLX5_ASSERT(item->spec && item->mask); + m = item->mask; + v = item->spec; + tp = (struct mlx5_flex_item *)v->handle; + for (i = 0, pos = 0; i < tp->mapnum && pos < m->length * CHAR_BIT; i++) { + map = tp->map + i; + id = mlx5_flex_get_sample_id(tp, i, &pos, is_inner, &def); + if (id == -1) + continue; + MLX5_ASSERT(id < (int)tp->devx_fp->num_samples); + if (id >= (int)tp->devx_fp->num_samples || id >= MLX5_GRAPH_NODE_SAMPLE_NUM) + return -1; + mask = mlx5_flex_get_bitfield(m, pos, map->width, map->shift); + if (def & RTE_BE32(mask) && + !mlx5dr_definer_get_flex_parser_fc(cd, tp->devx_fp->sample_ids[id], item_idx)) + return rte_errno; + pos += map->width; + } + return 0; +} + static int mlx5dr_definer_conv_items_to_hl(struct mlx5dr_context *ctx, struct mlx5dr_match_template *mt, @@ -1581,6 +1717,11 @@ mlx5dr_definer_conv_items_to_hl(struct mlx5dr_context *ctx, ret = mlx5dr_definer_conv_item_meter_color(&cd, items, i); item_flags |= MLX5_FLOW_ITEM_METER_COLOR; break; + case RTE_FLOW_ITEM_TYPE_FLEX: + ret = mlx5dr_definer_conv_item_flex(&cd, items, i); + item_flags |= cd.tunnel ? MLX5_FLOW_ITEM_INNER_FLEX : + MLX5_FLOW_ITEM_OUTER_FLEX; + break; default: DR_LOG(ERR, "Unsupported item type %d", items->type); rte_errno = ENOTSUP; diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index e55be8720e..667d90405a 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -964,11 +964,13 @@ int mlx5_flex_parser_ecpri_alloc(struct rte_eth_dev *dev) { struct mlx5_priv *priv = dev->data->dev_private; + struct mlx5_hca_flex_attr *attr = &priv->sh->cdev->config.hca_attr.flex; struct mlx5_ecpri_parser_profile *prf = &priv->sh->ecpri_parser; struct mlx5_devx_graph_node_attr node = { .modify_field_select = 0, }; - uint32_t ids[8]; + struct mlx5_ext_sample_id ids[8]; + uint8_t anchor_id; int ret; if (!priv->sh->cdev->config.hca_attr.parse_graph_flex_node) { @@ -1004,15 +1006,20 @@ mlx5_flex_parser_ecpri_alloc(struct rte_eth_dev *dev) return (rte_errno == 0) ? -ENODEV : -rte_errno; } prf->num = 2; - ret = mlx5_devx_cmd_query_parse_samples(prf->obj, ids, prf->num); + ret = mlx5_devx_cmd_query_parse_samples(prf->obj, ids, prf->num, &anchor_id); if (ret) { DRV_LOG(ERR, "Failed to query sample IDs."); return (rte_errno == 0) ? -ENODEV : -rte_errno; } prf->offset[0] = 0x0; prf->offset[1] = sizeof(uint32_t); - prf->ids[0] = ids[0]; - prf->ids[1] = ids[1]; + if (attr->ext_sample_id) { + prf->ids[0] = ids[0].sample_id; + prf->ids[1] = ids[1].sample_id; + } else { + prf->ids[0] = ids[0].id; + prf->ids[1] = ids[1].id; + } return 0; } @@ -1027,7 +1034,7 @@ static void mlx5_flex_parser_ecpri_release(struct rte_eth_dev *dev) { struct mlx5_priv *priv = dev->data->dev_private; - struct mlx5_ecpri_parser_profile *prf = &priv->sh->ecpri_parser; + struct mlx5_ecpri_parser_profile *prf = &priv->sh->ecpri_parser; if (prf->obj) mlx5_devx_cmd_destroy(prf->obj); diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 31982002ee..20b2529cc4 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -1307,9 +1307,10 @@ struct mlx5_lag { struct mlx5_flex_parser_devx { struct mlx5_list_entry entry; /* List element at the beginning. */ uint32_t num_samples; + uint8_t anchor_id; void *devx_obj; struct mlx5_devx_graph_node_attr devx_conf; - uint32_t sample_ids[MLX5_GRAPH_NODE_SAMPLE_NUM]; + struct mlx5_ext_sample_id sample_ids[MLX5_GRAPH_NODE_SAMPLE_NUM]; }; /* Pattern field descriptor - how to translate flex pattern into samples. */ @@ -2238,6 +2239,11 @@ void mlx5_flex_item_port_cleanup(struct rte_eth_dev *dev); void mlx5_flex_flow_translate_item(struct rte_eth_dev *dev, void *matcher, void *key, const struct rte_flow_item *item, bool is_inner); +int mlx5_flex_get_sample_id(const struct mlx5_flex_item *tp, + uint32_t idx, uint32_t *pos, + bool is_inner, uint32_t *def); +uint32_t mlx5_flex_get_bitfield(const struct rte_flow_item_flex *item, + uint32_t pos, uint32_t width, uint32_t shift); int mlx5_flex_acquire_index(struct rte_eth_dev *dev, struct rte_flow_item_flex_handle *handle, bool acquire); diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h index 1f57ecd6e1..c2f656e702 100644 --- a/drivers/net/mlx5/mlx5_flow.h +++ b/drivers/net/mlx5/mlx5_flow.h @@ -1225,6 +1225,7 @@ struct rte_flow_pattern_template { * tag pattern item for representor matching. */ bool implicit_tag; + uint8_t flex_item; /* flex item index. */ }; /* Flow action template struct. */ diff --git a/drivers/net/mlx5/mlx5_flow_flex.c b/drivers/net/mlx5/mlx5_flow_flex.c index bec07b13c1..affec62384 100644 --- a/drivers/net/mlx5/mlx5_flow_flex.c +++ b/drivers/net/mlx5/mlx5_flow_flex.c @@ -113,7 +113,7 @@ mlx5_flex_free(struct mlx5_priv *priv, struct mlx5_flex_item *item) } } -static uint32_t +uint32_t mlx5_flex_get_bitfield(const struct rte_flow_item_flex *item, uint32_t pos, uint32_t width, uint32_t shift) { @@ -198,6 +198,50 @@ mlx5_flex_set_match_sample(void *misc4_m, void *misc4_v, } #undef SET_FP_MATCH_SAMPLE_ID } + +/** + * Get the flex parser sample id and corresponding mask + * per shift and width information. + * + * @param[in] tp + * Mlx5 flex item sample mapping handle. + * @param[in] idx + * Mapping index. + * @param[in, out] pos + * Where to search the value and mask. + * @param[in] is_inner + * For inner matching or not. + * @param[in, def] def + * Mask generated by mapping shift and width. + * + * @return + * 0 on success, -1 to ignore. + */ +int +mlx5_flex_get_sample_id(const struct mlx5_flex_item *tp, + uint32_t idx, uint32_t *pos, + bool is_inner, uint32_t *def) +{ + const struct mlx5_flex_pattern_field *map = tp->map + idx; + uint32_t id = map->reg_id; + + *def = (RTE_BIT64(map->width) - 1) << map->shift; + /* Skip placeholders for DUMMY fields. */ + if (id == MLX5_INVALID_SAMPLE_REG_ID) { + *pos += map->width; + return -1; + } + MLX5_ASSERT(map->width); + MLX5_ASSERT(id < tp->devx_fp->num_samples); + if (tp->tunnel_mode == FLEX_TUNNEL_MODE_MULTI && is_inner) { + uint32_t num_samples = tp->devx_fp->num_samples / 2; + + MLX5_ASSERT(tp->devx_fp->num_samples % 2 == 0); + MLX5_ASSERT(id < num_samples); + id += num_samples; + } + return id; +} /** * Translate item pattern into matcher fields according to translation * array. @@ -226,40 +270,38 @@ mlx5_flex_flow_translate_item(struct rte_eth_dev *dev, void *misc4_m = MLX5_ADDR_OF(fte_match_param, matcher, misc_parameters_4); void *misc4_v = MLX5_ADDR_OF(fte_match_param, key, misc_parameters_4); + struct mlx5_priv *priv = dev->data->dev_private; + struct mlx5_hca_flex_attr *attr = &priv->sh->cdev->config.hca_attr.flex; struct mlx5_flex_item *tp; uint32_t i, pos = 0; + uint32_t sample_id; RTE_SET_USED(dev); MLX5_ASSERT(item->spec && item->mask); spec = item->spec; mask = item->mask; tp = (struct mlx5_flex_item *)spec->handle; - MLX5_ASSERT(mlx5_flex_index(dev->data->dev_private, tp) >= 0); + MLX5_ASSERT(mlx5_flex_index(priv, tp) >= 0); for (i = 0; i < tp->mapnum; i++) { struct mlx5_flex_pattern_field *map = tp->map + i; - uint32_t id = map->reg_id; - uint32_t def = (RTE_BIT64(map->width) - 1) << map->shift; - uint32_t val, msk; + uint32_t val, msk, def; + int id = mlx5_flex_get_sample_id(tp, i, &pos, is_inner, &def); - /* Skip placeholders for DUMMY fields. */ - if (id == MLX5_INVALID_SAMPLE_REG_ID) { - pos += map->width; + if (id == -1) continue; - } + MLX5_ASSERT(id < (int)tp->devx_fp->num_samples); + if (id >= (int)tp->devx_fp->num_samples || + id >= MLX5_GRAPH_NODE_SAMPLE_NUM) + return; val = mlx5_flex_get_bitfield(spec, pos, map->width, map->shift); msk = mlx5_flex_get_bitfield(mask, pos, map->width, map->shift); - MLX5_ASSERT(map->width); - MLX5_ASSERT(id < tp->devx_fp->num_samples); - if (tp->tunnel_mode == FLEX_TUNNEL_MODE_MULTI && is_inner) { - uint32_t num_samples = tp->devx_fp->num_samples / 2; - - MLX5_ASSERT(tp->devx_fp->num_samples % 2 == 0); - MLX5_ASSERT(id < num_samples); - id += num_samples; - } + if (attr->ext_sample_id) + sample_id = tp->devx_fp->sample_ids[id].sample_id; + else + sample_id = tp->devx_fp->sample_ids[id].id; mlx5_flex_set_match_sample(misc4_m, misc4_v, def, msk & def, val & msk & def, - tp->devx_fp->sample_ids[id], id); + sample_id, id); pos += map->width; } } @@ -1317,7 +1359,8 @@ mlx5_flex_parser_create_cb(void *list_ctx, void *ctx) /* Query the firmware assigned sample ids. */ ret = mlx5_devx_cmd_query_parse_samples(fp->devx_obj, fp->sample_ids, - fp->num_samples); + fp->num_samples, + &fp->anchor_id); if (ret) goto error; DRV_LOG(DEBUG, "DEVx flex parser %p created, samples num: %u", diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 44953451d5..abd0ebbb23 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -4331,6 +4331,36 @@ flow_hw_set_vlan_vid_construct(struct rte_eth_dev *dev, &modify_action); } +static int +flow_hw_flex_item_acquire(struct rte_eth_dev *dev, + struct rte_flow_item_flex_handle *handle, + uint8_t *flex_item) +{ + int index = mlx5_flex_acquire_index(dev, handle, false); + + MLX5_ASSERT(index >= 0 && index <= (int)(sizeof(uint32_t) * CHAR_BIT)); + if (index < 0) + return -1; + if (!(*flex_item & RTE_BIT32(index))) { + /* Don't count same flex item again. */ + if (mlx5_flex_acquire_index(dev, handle, true) != index) + MLX5_ASSERT(false); + *flex_item |= (uint8_t)RTE_BIT32(index); + } + return 0; +} + +static void +flow_hw_flex_item_release(struct rte_eth_dev *dev, uint8_t *flex_item) +{ + while (*flex_item) { + int index = rte_bsf32(*flex_item); + + mlx5_flex_release_index(dev, index); + *flex_item &= ~(uint8_t)RTE_BIT32(index); + } +} + /** * Create flow action template. * @@ -4732,6 +4762,7 @@ flow_hw_pattern_validate(struct rte_eth_dev *dev, case RTE_FLOW_ITEM_TYPE_ICMP: case RTE_FLOW_ITEM_TYPE_ICMP6: case RTE_FLOW_ITEM_TYPE_CONNTRACK: + case RTE_FLOW_ITEM_TYPE_FLEX: break; case RTE_FLOW_ITEM_TYPE_INTEGRITY: /* @@ -4809,6 +4840,7 @@ flow_hw_pattern_template_create(struct rte_eth_dev *dev, .mask = &tag_m, .last = NULL }; + unsigned int i = 0; if (flow_hw_pattern_validate(dev, attr, items, error)) return NULL; @@ -4868,6 +4900,19 @@ flow_hw_pattern_template_create(struct rte_eth_dev *dev, it->implicit_tag = true; mlx5_free(copied_items); } + for (i = 0; items[i].type != RTE_FLOW_ITEM_TYPE_END; ++i) { + if (items[i].type == RTE_FLOW_ITEM_TYPE_FLEX) { + const struct rte_flow_item_flex *spec = + (const struct rte_flow_item_flex *)items[i].spec; + struct rte_flow_item_flex_handle *handle = spec->handle; + + if (flow_hw_flex_item_acquire(dev, handle, &it->flex_item)) { + claim_zero(mlx5dr_match_template_destroy(it->mt)); + mlx5_free(it); + return NULL; + } + } + } __atomic_fetch_add(&it->refcnt, 1, __ATOMIC_RELAXED); LIST_INSERT_HEAD(&priv->flow_hw_itt, it, next); return it; @@ -4887,7 +4932,7 @@ flow_hw_pattern_template_create(struct rte_eth_dev *dev, * 0 on success, a negative errno value otherwise and rte_errno is set. */ static int -flow_hw_pattern_template_destroy(struct rte_eth_dev *dev __rte_unused, +flow_hw_pattern_template_destroy(struct rte_eth_dev *dev, struct rte_flow_pattern_template *template, struct rte_flow_error *error __rte_unused) { @@ -4900,6 +4945,7 @@ flow_hw_pattern_template_destroy(struct rte_eth_dev *dev __rte_unused, "item template in using"); } LIST_REMOVE(template, next); + flow_hw_flex_item_release(dev, &template->flex_item); claim_zero(mlx5dr_match_template_destroy(template->mt)); mlx5_free(template); return 0; From patchwork Wed Dec 21 08:39:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: rongwei liu X-Patchwork-Id: 121178 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D164FA034C; Wed, 21 Dec 2022 09:41:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D906742D35; Wed, 21 Dec 2022 09:40:54 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2052.outbound.protection.outlook.com [40.107.94.52]) by mails.dpdk.org (Postfix) with ESMTP id B79FD42D25 for ; Wed, 21 Dec 2022 09:40:51 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FP2y+imCVEigdajdgqh0Ke9sxyiq3oewGiaXNwDbSKQbTZ28NfKKsjifyidd1F7i3TZaMGYv0b2PTzrNg+xWfJgamsVyOX348Es2vW1NjPAGn6rTu/QHH6KLjLuGRqYbtn+knkN3lcQ2qrgSQDzq8rjR4asa6p4aJlcQbFsOKHbmQNPjJJ6SIPljM2vvmGEur6ounKZURNBPnusvKhpt/JoBH6U+2krgbDEzYxWiiAtQPIR3mgVaqUMi7SVN4mhXa+1V6nEwJhwrcUL3vOJKRx+xW5PCrNx0UfF3Zt57vXhQ/vQyIuYehYuZ0VZeJZq9qGjbialIcJKDxbHf79T3lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eOdj5RNVDwYjSfIpN855tnAIaGMnx3DochAVixOt7lY=; b=YTs+xJRYFVot9SM0m2vCaUxRAALBEodo0FN1Uw0Jfw03P+IYTLVT8l7YUZ7A0VF+OAGI6iUFgFRMKpVs588srXtF5ayuqawms0XmC2mHCzutBcN2yx5m5TQWh5AWUhh/BfCYJoBjphYBSjeNG3gUZKtNRWek+bOZLzm+VyyqPXXnK2TWXPnsgZdtlqvQnF+2xPBO7omHmRJtlFe58v2kouNlU9MgsUQARMZoWP08g+EEjfghH9W7gB71mZYyUfkrTOMt77q+w1yxzdxYMBoJboDEDA+5eoE01oyWgsxegx0j4PeYHPbjxNcSnxS2l6oxwVEs5cJg7/WA2qrkcEFW0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eOdj5RNVDwYjSfIpN855tnAIaGMnx3DochAVixOt7lY=; b=j2BirJ6PTjYF0+kTRS2ZwsobVcZTjhAx9qUf7V++antQbENmXNPktyqDFxoQh1RLeBcuShuEOxUTu/a0/0fyzhrPljbb/HwSAjJMcqFJjcOJl9pkfSWaRmqXxDH8zXzFiiVX4eU19ZSAvyHLRSFEjMUW+3OJSIfD2ziH/xghVTufAhnlc2pWNN9PcQLR+2FG0qpwpQ5AbdLP6YYmdYeo40NqOPVU+w1mG1wntrdJkx5j8tZBiphbBWHzkvz6z5Zlaxnxli9J0rJFXWfEUu45a5olVhOWI4ZMMqkYhwhSJYQPcx+t9n3R1V4kWlY7NJobLqs7NcVm1f5ligeXc/7/LA== Received: from BN8PR04CA0042.namprd04.prod.outlook.com (2603:10b6:408:d4::16) by BY5PR12MB4083.namprd12.prod.outlook.com (2603:10b6:a03:20d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 08:40:49 +0000 Received: from BL02EPF00010208.namprd05.prod.outlook.com (2603:10b6:408:d4:cafe::b3) by BN8PR04CA0042.outlook.office365.com (2603:10b6:408:d4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.21 via Frontend Transport; Wed, 21 Dec 2022 08:40:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF00010208.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.8 via Frontend Transport; Wed, 21 Dec 2022 08:40:49 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:36 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:33 -0800 From: Rongwei Liu To: , , , CC: , Subject: [RFC 7/9] net/mlx5/hws: add flex item modify field implementation Date: Wed, 21 Dec 2022 10:39:58 +0200 Message-ID: <20221221084000.3680015-8-rongweil@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20221221084000.3680015-1-rongweil@nvidia.com> References: <20221221084000.3680015-1-rongweil@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00010208:EE_|BY5PR12MB4083:EE_ X-MS-Office365-Filtering-Correlation-Id: e41608ae-7218-41ff-3c9a-08dae32f0fb2 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6FPAzxbOHw3MimCCulPsL8yATcIisbk1RA7l88+T9GwXSKxXHLgQ9jmc/GVc6mmDvdKZtb3uRmw5p7mw8MykSoDkyyGO5x6d0Lnf30DxO4VOmD5DqCOS0axL590/1etiDgxO+8c2tPKbs6qo6wWJ1y18zKM7Rdi+Wyv/q/v28qhAsmNOHY/3ZAbHVYzVwj+H85LIRsYfvpQoEZHnrDIq2ZXjyeVXqGtVOw5UKR5XHrt9Kcp8h956mROJQX+jozUIKHm4EGSkcnV2MH2GttNUr2sk4gfvZ3gjtso/PvtK1id5gwTCDke7mk9iKiwb74xq5xWqBqmmV87TJs1LwJ72AkzjpNSsmbjgVqz7yjlbRvmbFEsKO2kkU+ogKcBVEdQbiKcMBkyl3WSGescwKhC4xpsowVoH4O61mk+2dwn2/M0ImUIBkkzdfwASJDu7X53Hm+ndI4vVEp9LZ/B3HWg3Ed2V3XvEfkKl7DnYQzmpMbU7XhykSZHTl07UKFp73MiBWFPN3dgQatACikz9BrAzHaV+7uKpb2s8FN4QzS7Sn6kkzBBg/2xichQ3s83SYGB63RKejMENsCJzo50OZVfUfvTQRva0h8qOYKDhotSCqMxH1L/israP+T/Ovh+/zv10+icyxoNTjvYpOTBuCtYrMOII2680gF97lnBueyBCVxI= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(39860400002)(346002)(136003)(396003)(451199015)(36840700001)(46966006)(41300700001)(336012)(7636003)(8676002)(1076003)(82740400003)(2906002)(4326008)(5660300002)(36860700001)(36756003)(82310400005)(8936002)(47076005)(356005)(30864003)(426003)(83380400001)(7696005)(6666004)(107886003)(478600001)(110136005)(86362001)(54906003)(70206006)(70586007)(316002)(55016003)(26005)(186003)(6286002)(40480700001)(2616005)(16526019); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 08:40:49.0466 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e41608ae-7218-41ff-3c9a-08dae32f0fb2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00010208.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4083 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add flex item modify field HWS implementation. The minimum modify boundary is one byte. Signed-off-by: Rongwei Liu --- doc/guides/nics/mlx5.rst | 1 + drivers/common/mlx5/mlx5_prm.h | 1 + drivers/net/mlx5/mlx5_flow.h | 3 + drivers/net/mlx5/mlx5_flow_dv.c | 165 +++++++++++++++++++++++++++++--- drivers/net/mlx5/mlx5_flow_hw.c | 14 ++- 5 files changed, 171 insertions(+), 13 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 397e04fbed..26d68d86f4 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -107,6 +107,7 @@ Features - Sub-Function. - Matching on represented port. - Matching on flex item with specific pattern. +- Modify flex item field. Limitations diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index b080599570..74fc8d9936 100644 --- a/drivers/common/mlx5/mlx5_prm.h +++ b/drivers/common/mlx5/mlx5_prm.h @@ -753,6 +753,7 @@ enum mlx5_modification_field { MLX5_MODI_OUT_IP_ECN = 0x73, MLX5_MODI_TUNNEL_HDR_DW_1 = 0x75, MLX5_MODI_GTPU_FIRST_EXT_DW_0 = 0x76, + MLX5_MODI_INVALID = INT_MAX, }; /* Total number of metadata reg_c's. */ diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h index c2f656e702..b54eaf64f4 100644 --- a/drivers/net/mlx5/mlx5_flow.h +++ b/drivers/net/mlx5/mlx5_flow.h @@ -1080,6 +1080,8 @@ struct field_modify_info { uint32_t size; /* Size of field in protocol header, in bytes. */ uint32_t offset; /* Offset of field in protocol header, in bytes. */ enum mlx5_modification_field id; + uint32_t shift; + uint8_t is_flex; /* Temporary indicator for flex item modify filed WA. */ }; /* HW steering flow attributes. */ @@ -1244,6 +1246,7 @@ struct rte_flow_actions_template { uint16_t mhdr_off; /* Offset of DR modify header action. */ uint32_t refcnt; /* Reference counter. */ uint16_t rx_cpy_pos; /* Action position of Rx metadata to be copied. */ + uint8_t flex_item; /* flex item index. */ }; /* Jump action struct. */ diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 7ca909999b..110d08b271 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -414,10 +414,15 @@ flow_dv_convert_modify_action(struct rte_flow_item *item, ++field; continue; } - /* Deduce actual data width in bits from mask value. */ - off_b = rte_bsf32(mask) + carry_b; - size_b = sizeof(uint32_t) * CHAR_BIT - - off_b - __builtin_clz(mask); + if (type == MLX5_MODIFICATION_TYPE_COPY && field->is_flex) { + off_b = 32 - field->shift + carry_b - field->size * CHAR_BIT; + size_b = field->size * CHAR_BIT - carry_b; + } else { + /* Deduce actual data width in bits from mask value. */ + off_b = rte_bsf32(mask) + carry_b; + size_b = sizeof(uint32_t) * CHAR_BIT - + off_b - __builtin_clz(mask); + } MLX5_ASSERT(size_b); actions[i] = (struct mlx5_modification_cmd) { .action_type = type, @@ -437,40 +442,46 @@ flow_dv_convert_modify_action(struct rte_flow_item *item, * Destination field overflow. Copy leftovers of * a source field to the next destination field. */ - carry_b = 0; if ((size_b > dcopy->size * CHAR_BIT - dcopy->offset) && dcopy->size != 0) { actions[i].length = dcopy->size * CHAR_BIT - dcopy->offset; - carry_b = actions[i].length; + carry_b += actions[i].length; next_field = false; + } else { + carry_b = 0; } /* * Not enough bits in a source filed to fill a * destination field. Switch to the next source. */ if ((size_b < dcopy->size * CHAR_BIT - dcopy->offset) && - (size_b == field->size * CHAR_BIT - off_b)) { - actions[i].length = - field->size * CHAR_BIT - off_b; + ((size_b == field->size * CHAR_BIT - off_b) || + field->is_flex)) { + actions[i].length = size_b; dcopy->offset += actions[i].length; next_dcopy = false; } - if (next_dcopy) - ++dcopy; } else { MLX5_ASSERT(item->spec); data = flow_dv_fetch_field((const uint8_t *)item->spec + field->offset, field->size); /* Shift out the trailing masked bits from data. */ data = (data & mask) >> off_b; + if (field->is_flex) + actions[i].offset = 32 - field->shift - field->size * CHAR_BIT; actions[i].data1 = rte_cpu_to_be_32(data); } /* Convert entire record to expected big-endian format. */ actions[i].data0 = rte_cpu_to_be_32(actions[i].data0); + if ((type != MLX5_MODIFICATION_TYPE_COPY || + dcopy->id != (enum mlx5_modification_field)UINT32_MAX) && + field->id != (enum mlx5_modification_field)UINT32_MAX) + ++i; + if (next_dcopy && type == MLX5_MODIFICATION_TYPE_COPY) + ++dcopy; if (next_field) ++field; - ++i; } while (field->size); if (resource->actions_num == i) return rte_flow_error_set(error, EINVAL, @@ -1421,6 +1432,131 @@ flow_modify_info_mask_32_masked(uint32_t length, uint32_t off, uint32_t post_mas return rte_cpu_to_be_32(mask & post_mask); } +static void +mlx5_modify_flex_item(const struct rte_eth_dev *dev, + const struct mlx5_flex_item *flex, + const struct rte_flow_action_modify_data *data, + struct field_modify_info *info, + uint32_t *mask, uint32_t width) +{ + struct mlx5_priv *priv = dev->data->dev_private; + struct mlx5_hca_flex_attr *attr = &priv->sh->cdev->config.hca_attr.flex; + uint32_t i, j; + int id = 0; + uint32_t pos = 0; + const struct mlx5_flex_pattern_field *map; + uint32_t offset = data->offset; + uint32_t width_left = width; + uint32_t def; + uint32_t cur_width = 0; + uint32_t tmp_ofs; + uint32_t idx = 0; + struct field_modify_info tmp; + int tmp_id; + + if (!attr->ext_sample_id) { + DRV_LOG(ERR, "FW doesn't support modify field with flex item."); + return; + } + /* + * search for the mapping instance until Accumulated width is no + * less than data->offset. + */ + for (i = 0; i < flex->mapnum; i++) { + if (flex->map[i].width + pos > data->offset) + break; + pos += flex->map[i].width; + } + if (i >= flex->mapnum) + return; + tmp_ofs = pos < data->offset ? data->offset - pos : 0; + for (j = i; i < flex->mapnum && width_left > 0; ) { + map = flex->map + i; + id = mlx5_flex_get_sample_id(flex, i, &pos, false, &def); + if (id == -1) { + i++; + /* All left length is dummy */ + if (pos >= data->offset + width) + return; + cur_width = map->width; + /* One mapping instance covers the whole width. */ + } else if (pos + map->width >= (data->offset + width)) { + cur_width = width_left; + } else { + cur_width = cur_width + map->width - tmp_ofs; + pos += map->width; + /* + * Continue to search next until: + * 1. Another flex parser ID. + * 2. Width has been covered. + */ + for (j = i + 1; j < flex->mapnum; j++) { + tmp_id = mlx5_flex_get_sample_id(flex, j, &pos, false, &def); + if (tmp_id == -1) { + i = j; + pos -= flex->map[j].width; + break; + } + if (id >= (int)flex->devx_fp->num_samples || + id >= MLX5_GRAPH_NODE_SAMPLE_NUM || + tmp_id >= (int)flex->devx_fp->num_samples || + tmp_id >= MLX5_GRAPH_NODE_SAMPLE_NUM) + return; + if (flex->devx_fp->sample_ids[id].id != + flex->devx_fp->sample_ids[tmp_id].id || + flex->map[j].shift != flex->map[j - 1].width + + flex->map[j - 1].shift) { + i = j; + break; + } + if ((pos + flex->map[j].width) >= (data->offset + width)) { + cur_width = width_left; + break; + } + pos += flex->map[j].width; + cur_width += flex->map[j].width; + } + } + if (cur_width > width_left) + cur_width = width_left; + else if (cur_width < width_left && (j == flex->mapnum || i == flex->mapnum)) + return; + + MLX5_ASSERT(id < (int)flex->devx_fp->num_samples); + if (id >= (int)flex->devx_fp->num_samples || id >= MLX5_GRAPH_NODE_SAMPLE_NUM) + return; + /* Use invalid entry as placeholder for DUMMY mapping. */ + info[idx] = (struct field_modify_info){cur_width / CHAR_BIT, offset / CHAR_BIT, + id == -1 ? MLX5_MODI_INVALID : + (enum mlx5_modification_field) + flex->devx_fp->sample_ids[id].modify_field_id, + map->shift + tmp_ofs, 1}; + offset += cur_width; + width_left -= cur_width; + if (!mask) { + info[idx].offset = (32 - cur_width - map->shift - tmp_ofs); + info[idx].size = cur_width / CHAR_BIT + info[idx].offset / CHAR_BIT; + } + cur_width = 0; + tmp_ofs = 0; + idx++; + } + if (unlikely(width_left > 0)) { + MLX5_ASSERT(false); + return; + } + if (mask) + memset(mask, 0xff, data->offset / CHAR_BIT + width / CHAR_BIT); + /* Re-order the info to follow IPv6 address. */ + for (i = 0; i < idx / 2; i++) { + tmp = info[i]; + MLX5_ASSERT(info[i].id); + MLX5_ASSERT(info[idx - 1 - i].id); + info[i] = info[idx - 1 - i]; + info[idx - 1 - i] = tmp; + } +} + void mlx5_flow_field_id_to_modify_info (const struct rte_flow_action_modify_data *data, @@ -1883,6 +2019,11 @@ mlx5_flow_field_id_to_modify_info info[idx].offset = data->offset; } break; + case RTE_FLOW_FIELD_FLEX_ITEM: + MLX5_ASSERT(data->flex_handle != NULL && !(data->offset & 0x7)); + mlx5_modify_flex_item(dev, (const struct mlx5_flex_item *)data->flex_handle, + data, info, mask, width); + break; case RTE_FLOW_FIELD_POINTER: case RTE_FLOW_FIELD_VALUE: default: diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index abd0ebbb23..a023c2051b 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -4550,6 +4550,17 @@ flow_hw_actions_template_create(struct rte_eth_dev *dev, at->actions[i].conf = actions->conf; at->masks[i].conf = masks->conf; } + if (actions->type == RTE_FLOW_ACTION_TYPE_MODIFY_FIELD) { + const struct rte_flow_action_modify_field *info = actions->conf; + + if ((info->dst.field == RTE_FLOW_FIELD_FLEX_ITEM && + flow_hw_flex_item_acquire(dev, info->dst.flex_handle, + &at->flex_item)) || + (info->src.field == RTE_FLOW_FIELD_FLEX_ITEM && + flow_hw_flex_item_acquire(dev, info->src.flex_handle, + &at->flex_item))) + goto error; + } } at->tmpl = flow_hw_dr_actions_template_create(at); if (!at->tmpl) @@ -4581,7 +4592,7 @@ flow_hw_actions_template_create(struct rte_eth_dev *dev, * 0 on success, a negative errno value otherwise and rte_errno is set. */ static int -flow_hw_actions_template_destroy(struct rte_eth_dev *dev __rte_unused, +flow_hw_actions_template_destroy(struct rte_eth_dev *dev, struct rte_flow_actions_template *template, struct rte_flow_error *error __rte_unused) { @@ -4594,6 +4605,7 @@ flow_hw_actions_template_destroy(struct rte_eth_dev *dev __rte_unused, "action template in using"); } LIST_REMOVE(template, next); + flow_hw_flex_item_release(dev, &template->flex_item); if (template->tmpl) mlx5dr_action_template_destroy(template->tmpl); mlx5_free(template); From patchwork Wed Dec 21 08:39:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: rongwei liu X-Patchwork-Id: 121179 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 129CBA034C; Wed, 21 Dec 2022 09:41:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D14A42D40; Wed, 21 Dec 2022 09:40:56 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2044.outbound.protection.outlook.com [40.107.100.44]) by mails.dpdk.org (Postfix) with ESMTP id C693F42D30 for ; Wed, 21 Dec 2022 09:40:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HTW9BT9ZyHnUiKFttM9LQuKy/GCPm3I/Xs/tYruj72spwG8wnl/RK130Fu9GOY4F2hevHxbpysagv3ow+i7XzJQbEWhkjSZ4Iu8dWbI9AoBKM97CoWLufRPwITtfFcDew+hUBvGx18sQ588Yspt5aiShuji9LEkpkMkBo6h888Ih4LiCcIguxpqRnsRCxcIU/pXW4D/I8HmDJLPObOBzsWpRV+Wm2Ecvy+JACpfNusFbPw2johrEEz6ZWN+PUOxPoLu6By8sK2CnJlfnasamNNHiIwgr8jtZ59YThu3egD7WMTgFi+Q5hX/CZHEaDB1NY0vN34p15eyw1uUa4KpCZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dXjhHwMEaTYrcOpigqNnDfHZvDkyMXFwz5SISmjdXZM=; b=L2pwnLrEEl07OqN6JiZahPqAqaA8x/+B2JN9FogCapeWtG1bM8A4B/AnsHzIQ/mIx/MChhifYEBEVAit++Zx8jv7eBlgXZURfUJsZfacD6sKoOII/ks0oGo0W6onBugQmco9W5kmk/6+gEFtusgfCKWECGgUCqFGONuCPHvopKeyPXPojLUs7sh9t+OtDQQY6bNkof0/Usu5YyLfqZt8jhvbXuOc/AmuE9Z1ZpvKoj3dXT3el3SSNY0O+Hhl3dUKyn7wSCk+0gEQnxg4LOclhfPOXIF0PYY1x9iobmXNHrFOKxlZB90M5Tlk1+ZrUmg/0zr2WSMpah2sxS3F7SSamg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dXjhHwMEaTYrcOpigqNnDfHZvDkyMXFwz5SISmjdXZM=; b=FKq1fNfWsMUMeDETaE+KqtR6is2I/f5TKqmQLcJDZN2kPEeik/snAP97T4uekQ2zn2MoEBHfCL+MXvYP51HoK+glkc0aevEdbispS49NLN2LbPjRDxSxPW+aWHSR07bT0A3q4XdWq5+Vyym6mTXcr2Rg6aC2wQNLn7IHvEPMVQrJpe5K7KMheYLxsBMWLxgNEBk0RpaHs5NSa8Z3ntQdUMpCw63GBvICQZ2DUieD7Pp3I8yf9wR3pqZ0gDL1wJrbIbp2S8uBDGWguE7UWA+wNUkOnCh8OqvQToxXsAZeTwfZ0rLIVNryZU4Ld4hXG8OpAiaDI93CfvpSFS2dRtos8Q== Received: from BN8PR04CA0037.namprd04.prod.outlook.com (2603:10b6:408:d4::11) by PH7PR12MB8153.namprd12.prod.outlook.com (2603:10b6:510:2b0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 08:40:52 +0000 Received: from BL02EPF00010208.namprd05.prod.outlook.com (2603:10b6:408:d4:cafe::d1) by BN8PR04CA0037.outlook.office365.com (2603:10b6:408:d4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.21 via Frontend Transport; Wed, 21 Dec 2022 08:40:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF00010208.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.8 via Frontend Transport; Wed, 21 Dec 2022 08:40:52 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:38 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:36 -0800 From: Rongwei Liu To: , , , CC: , Subject: [RFC 8/9] net/mlx5: return error for sws modify field Date: Wed, 21 Dec 2022 10:39:59 +0200 Message-ID: <20221221084000.3680015-9-rongweil@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20221221084000.3680015-1-rongweil@nvidia.com> References: <20221221084000.3680015-1-rongweil@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00010208:EE_|PH7PR12MB8153:EE_ X-MS-Office365-Filtering-Correlation-Id: 88007213-c13e-4967-d904-08dae32f1193 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iNMi5Et4P7Rw6ODDyjJcwRuKjuChD5LnICQ+YCPwJb3Q8dgBXUuVMDnOkUSPmeQ+NNAIt5pWjGQVs2vWncF9f9Y1MqevNzvdO16j8YDC/GPY9L9kaBGh7rkT5+EZhh3eKEbyzlXvvvdVaqRoX9HoTBHid1394OM3nO4PI+lx2LAXMgrYT+Uvg9R0kXB2y9XYC3O7PVmV5GaBVIzmkZIVFsKJej/XdJas80iiAjxLidyr4uD+O1flQXreF83oTjjvkzUe/4Cs48xBvPDq8+hVpRTsdXak1NqZjdUT4GA2ea55IUB1Gd3n7/MitISPFjTy7kdFRZKL07w6cju4455txn9S3k0NmxrfHZ0MWs+TnkI+9r3OZIzsFzJfZEUP6i6+bVjO3/Ch9Blmoefs1uv65V4K8TpcMELRw86oShMxD3DwAGUZslJPxPNVaUrKMwuuyWNvxr3MEAj4MCoUVajhAPtH6CeAUnlBCtQbgHZ/e8fe/nqyGgC75YwKDApG8/cHWBqcHaLyajJNXmQfqcpyd3SkVVuf1RzO3D14SZoXLfT9picLYlgR7+80vK/svyzgW+h83r5QdHseK7h7bc89rVfzKN5Rk3F1WgrBBRCPGXgjfc9nWhtKgv1qDTSmF8IKnrZsv93726CG1Zor5t0BQuljEf71XGfk55FzssGU1nia+4xAxM0GsNvNDO1x9i4Do/5twrC7LBEQ8OLYO8El/g== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(376002)(346002)(39860400002)(136003)(451199015)(36840700001)(40470700004)(46966006)(70586007)(4326008)(86362001)(70206006)(8676002)(40460700003)(316002)(5660300002)(36756003)(8936002)(36860700001)(2616005)(41300700001)(82310400005)(6666004)(16526019)(1076003)(6286002)(186003)(107886003)(47076005)(26005)(83380400001)(426003)(336012)(7696005)(356005)(40480700001)(82740400003)(55016003)(7636003)(478600001)(54906003)(110136005)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 08:40:52.2341 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88007213-c13e-4967-d904-08dae32f1193 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00010208.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8153 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Return unsupported error message when application tries to modify flex item field. Signed-off-by: Rongwei Liu --- drivers/net/mlx5/mlx5_flow_dv.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 110d08b271..f9419463eb 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -4824,10 +4824,18 @@ flow_dv_validate_action_modify_hdr(const uint64_t action_flags, const struct rte_flow_action *action, struct rte_flow_error *error) { + const struct rte_flow_action_modify_field *action_modify_field = action->conf; + if (action->type != RTE_FLOW_ACTION_TYPE_DEC_TTL && !action->conf) return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL, "action configuration not set"); + if (action_modify_field->src.field == RTE_FLOW_FIELD_FLEX_ITEM || + action_modify_field->dst.field == RTE_FLOW_FIELD_FLEX_ITEM) + return rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_ACTION, action, + "flex item fields modification" + " is not supported"); if (action_flags & MLX5_FLOW_ACTION_ENCAP) return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, NULL, @@ -5153,17 +5161,16 @@ flow_dv_validate_action_modify_field(struct rte_eth_dev *dev, struct mlx5_hca_attr *hca_attr = &priv->sh->cdev->config.hca_attr; const struct rte_flow_action_modify_field *action_modify_field = action->conf; - uint32_t dst_width = mlx5_flow_item_field_width(dev, - action_modify_field->dst.field, - -1, attr, error); - uint32_t src_width = mlx5_flow_item_field_width(dev, - action_modify_field->src.field, - dst_width, attr, error); + uint32_t dst_width, src_width; ret = flow_dv_validate_action_modify_hdr(action_flags, action, error); if (ret) return ret; + dst_width = mlx5_flow_item_field_width(dev, action_modify_field->dst.field, + -1, attr, error); + src_width = mlx5_flow_item_field_width(dev, action_modify_field->src.field, + dst_width, attr, error); if (action_modify_field->width == 0) return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, action, From patchwork Wed Dec 21 08:40:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: rongwei liu X-Patchwork-Id: 121180 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52038A034C; Wed, 21 Dec 2022 09:41:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFF4D42D2A; Wed, 21 Dec 2022 09:40:56 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2070.outbound.protection.outlook.com [40.107.244.70]) by mails.dpdk.org (Postfix) with ESMTP id 6A8E642D37 for ; Wed, 21 Dec 2022 09:40:55 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aYEAHXYn59cVeybc5LiELdyzxMG3IwiTGA2f2Aj2C42p3dfGQMNmVcdkh+KKKq1Vqoy59urFMjqV9zAXmsTiCGQ/Qm7XzC7F4b1XyqdnTt02iNp9XatBvKAK+WA4d7fr4/KtkVRyfBMQtzBEcFzm5PWVWl8UBTcFwTw1kV332oNvmM4FKjUa5rQIMQmKPZUg+VW3htb0Ks1N9JsTzHsMoNELBIcrnbM9cf44uQLJHWHaHwJGlDTq4jYiwcTuqHBNg/3jVhRKDVnZngUFodkwR0xDU7MQ75drlCnokspQ99/vJsZoc2OyKBOvPREwtniasw6j+PVPqIuowfN9ye5+AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZUTL9KMnBoky5HJ86pLxtyufakUYY/FuLLNV75jJTnY=; b=aSjw222+wjhBdGHFwJlTS998m3lLgNjo7IeEcx+YZgMGz15Qr905x6pBWwdPV2JQVmF3cj55Psrb3LRFywF5Xou2FMwfjpgAcJrG3ZmwEdCJ+pl0C8Gu3pvzIL0SAP+z0qu3Bw2vLB940G6Lyy7uRRrj4CtHBZjVvAKDaER8B4Z44PTH1mfAIpcNwUB4NtEVGHTEvTOQU6Yise5mVUwYs0z/aoZo/yH8Eps3VwhyCEgZJ60yNRCsQNI4SkHojLMVogzHWJfdQ1pAGHH1t1xOgA1FDUGqjehZtAtjMi7mm8THVmQ/kDfpNt+iAZ240Tmdmqa6pQNL2dg5bIOSGIOHLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZUTL9KMnBoky5HJ86pLxtyufakUYY/FuLLNV75jJTnY=; b=IAKrBLYX8ePmVdoAqMc0G4npsFYHogiNZ/xiB5FnByVXz9FQ2e6pMVFY9XwxFn0A0xwIkyHWiK0b9MFLIGSNPGX+z6CF5/QzTN/dprE1nstZwIHoceRvO2zPWxFQ1JqZr4xY65oWJdZV9nKfjbpBhP8v+fm2vqo20+i7BxbbM1R0xru/69F0NI63UzXnsXuBvz+aBZaBt2EIDo3dwAArdsS9HfyIKGu4SOvCnWPVgrYUpGBmWIQrwN4vBnYbof7oIt031+cw74F1koK8O2KMSYXWCKF4IAouxXqvNFF4oedU/JmJJFrfelLiXkpWmslcnrUxjGLgpHT6YVRhuvQBQQ== Received: from BN8PR04CA0041.namprd04.prod.outlook.com (2603:10b6:408:d4::15) by DM4PR12MB6662.namprd12.prod.outlook.com (2603:10b6:8:bb::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 08:40:53 +0000 Received: from BL02EPF00010208.namprd05.prod.outlook.com (2603:10b6:408:d4:cafe::25) by BN8PR04CA0041.outlook.office365.com (2603:10b6:408:d4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.21 via Frontend Transport; Wed, 21 Dec 2022 08:40:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF00010208.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.8 via Frontend Transport; Wed, 21 Dec 2022 08:40:53 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:41 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 21 Dec 2022 00:40:38 -0800 From: Rongwei Liu To: , , , , Aman Singh , Yuying Zhang CC: , Subject: [RFC 9/9] app/testpmd: raw encap with flex item support Date: Wed, 21 Dec 2022 10:40:00 +0200 Message-ID: <20221221084000.3680015-10-rongweil@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20221221084000.3680015-1-rongweil@nvidia.com> References: <20221221084000.3680015-1-rongweil@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00010208:EE_|DM4PR12MB6662:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e28d778-c51f-4506-e408-08dae32f1260 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Yh/TmTBIQ9WKMqyzxYJZmOx1vnkHi1V4gMTa2srvgp9Q3+wGeS1GaOSDUQ0wiISqn2RTTafvjQBHau3TNeldJcgwUdnFfKoqULm6R9jIAnMz2iuSA73cl9GxdVPsHZlkk3LwfmedBAXGS6xKRv2TzDwWv4nOI7X6tmxs0BVxcfOPKx296pB1aT7RaLrZQmr/DxRpXIlHOCVIkQiUQiVeDFkLOrwMPdfaKaNschrWRJ+kuBM8krnhf0o2Lb16F7lHqa6vIYNMc+io1Y3kiEv4VN62CsaQCpqRm++mZJKJISLdrOgLgD7kPdHzonayPgc9waul+zVKNrp54wOd4TLV5S5+dDHLCxKppwOu1zXj6XyAZ8y3gikV1OZ+2i//W60d3pwQSfAErTP+lA8APpd2pMPTq4wmJTukDmmOXcq8heIrvIQUZpAESvIRU7jE1LUXndS29+Df/sMUMqusWvyAktl0SxOB6QzJXnXkzSRrLzHQEsyWEtjrhHB5jXjANzx/ueH+n4vJ3wMIVtk2C1uTNTN7Vnxt6iskSe2hzwsBQGPBjkx6pt3tybH7vC8VonqT6syjK9LFmtubDN1OPez0pGYgAoH+ZXrQ27PxMgVehvsmkr0IK1GIJstJWedc8gqHZbtnExrw9C2ku1U/8Xmc0yL4314qlgusML3MqI85owypjYHHqMVsVoD+Euf6HrjQfGOK0hqz9j+U6AuqBkuCfw== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199015)(46966006)(40470700004)(36840700001)(54906003)(7696005)(316002)(36860700001)(82740400003)(40460700003)(2616005)(478600001)(86362001)(7636003)(4326008)(8676002)(110136005)(1076003)(356005)(70586007)(82310400005)(70206006)(36756003)(40480700001)(83380400001)(5660300002)(8936002)(107886003)(426003)(6666004)(47076005)(336012)(2906002)(26005)(6286002)(16526019)(186003)(41300700001)(55016003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 08:40:53.5622 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e28d778-c51f-4506-e408-08dae32f1260 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00010208.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6662 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Application should retrieve raw_encap buffer from spec->pattern if it is flex item. Signed-off-by: Rongwei Liu --- app/test-pmd/cmdline_flow.c | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 9037432cc8..3b2975ee83 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -11193,6 +11193,7 @@ cmd_set_raw_parsed(const struct buffer *in) uint16_t proto = 0; uint16_t idx = in->port; /* We borrow port field as index */ int gtp_psc = -1; /* GTP PSC option index. */ + const void *src_spec; if (in->command == SET_SAMPLE_ACTIONS) return cmd_set_raw_parsed_sample(in); @@ -11216,6 +11217,7 @@ cmd_set_raw_parsed(const struct buffer *in) item = in->args.vc.pattern + i; if (item->spec == NULL) item->spec = flow_item_default_mask(item); + src_spec = item->spec; switch (item->type) { case RTE_FLOW_ITEM_TYPE_ETH: size = sizeof(struct rte_ether_hdr); @@ -11343,9 +11345,13 @@ cmd_set_raw_parsed(const struct buffer *in) size = sizeof(struct rte_flow_item_pfcp); break; case RTE_FLOW_ITEM_TYPE_FLEX: - size = item->spec ? - ((const struct rte_flow_item_flex *) - item->spec)->length : 0; + if (item->spec != NULL) { + size = ((const struct rte_flow_item_flex *)item->spec)->length; + src_spec = ((const struct rte_flow_item_flex *)item->spec)->pattern; + } else { + size = 0; + src_spec = NULL; + } break; case RTE_FLOW_ITEM_TYPE_GRE_OPTION: size = 0; @@ -11378,12 +11384,14 @@ cmd_set_raw_parsed(const struct buffer *in) fprintf(stderr, "Error - Not supported item\n"); goto error; } - *total_size += size; - rte_memcpy(data_tail - (*total_size), item->spec, size); - /* update some fields which cannot be set by cmdline */ - update_fields((data_tail - (*total_size)), item, - upper_layer); - upper_layer = proto; + if (size) { + *total_size += size; + rte_memcpy(data_tail - (*total_size), src_spec, size); + /* update some fields which cannot be set by cmdline */ + update_fields((data_tail - (*total_size)), item, + upper_layer); + upper_layer = proto; + } } if (verbose_level & 0x1) printf("total data size is %zu\n", (*total_size));