From patchwork Mon Dec 26 00:37:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Yang X-Patchwork-Id: 121365 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AE4CA0032; Mon, 26 Dec 2022 01:48:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3810F4114B; Mon, 26 Dec 2022 01:48:39 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 7D846400D4 for ; Mon, 26 Dec 2022 01:48:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672015716; x=1703551716; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FP7meY4iZIa1OftO9bmoDun6RI3USDu6lJFVbgWMSIk=; b=XZJmn+YbYTHuUeNazNnv9oPIPC/Z/lNwQu4QhPx9sLVcQLWkNVas8YMK oWTC9FbZwXcfE8ZPiRlCY+ZfRYFsULzssqpRZIT8k4E2fVQaJ89lbCPlE ZOhzRu+ksAioX6GdoYiw5SKpsDtmjuHxrazmEhXgM7LPWPjqjGhiH0r7t /EEq2D4K2sbOYN/QRyg9K80Tu2T0QpASbhUQVQfSFgTDQvNinaR+TGQxk 5vo90J7TnnEUu4tfxguYsl3LChivYHOB+UeaYfqy/Tji6tnOS4gbJChO7 MfyxNfoJd6LLkJaAUxwR7WMTT/vlGUPXjzv9nNB+uZrPElMFky9UtEmDz Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10571"; a="406771358" X-IronPort-AV: E=Sophos;i="5.96,274,1665471600"; d="scan'208";a="406771358" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2022 16:48:36 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10571"; a="897999221" X-IronPort-AV: E=Sophos;i="5.96,274,1665471600"; d="scan'208";a="897999221" Received: from intel-cd-odc-steve.cd.intel.com ([10.240.178.136]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2022 16:48:34 -0800 From: Steve Yang To: dev@dpdk.org Cc: Yuying.Zhang@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com, Steve Yang Subject: [PATCH v1 1/2] net/i40e: fix unsupported flow rule transfer attribute Date: Mon, 26 Dec 2022 00:37:14 +0000 Message-Id: <20221226003715.615278-2-stevex.yang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221226003715.615278-1-stevex.yang@intel.com> References: <20221226003715.615278-1-stevex.yang@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org i40e doesn't support transfer attribute of flow rule, ignore it when validating rule attributes. Fixes: 86eb05d6350b ("net/i40e: add flow validate function") Signed-off-by: Steve Yang Acked-by: Qi Zhang --- drivers/net/i40e/i40e_flow.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index 65a826d51c..67df77890a 100644 --- a/drivers/net/i40e/i40e_flow.c +++ b/drivers/net/i40e/i40e_flow.c @@ -1236,6 +1236,14 @@ i40e_flow_parse_attr(const struct rte_flow_attr *attr, return -rte_errno; } + /* Not supported */ + if (attr->transfer) { + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER, + attr, "Not support transfer."); + return -rte_errno; + } + /* Not supported */ if (attr->priority) { rte_flow_error_set(error, EINVAL, From patchwork Mon Dec 26 00:37:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Yang X-Patchwork-Id: 121366 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4157A0032; Mon, 26 Dec 2022 01:48:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DA4F42D17; Mon, 26 Dec 2022 01:48:40 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id A660F40E2D for ; Mon, 26 Dec 2022 01:48:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672015718; x=1703551718; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=I7zWPrfQKZBm7ZnAb7dQUHPd9UHM4iLliTHS/9R9T5I=; b=Jk444rFG0zGxwf4/+7/IFJCowXn5dZPRiO071kUs9GJMNkrlJCmDKZYF gJFyAIk6Oe28B2gyyrjYdSKHUAy9WIPjgq1LTuj/ZFyKKsizwj6W5NBIo KA30e40ijbUtHD3d6y1GL0NTACuFGOLq3q+6VV8PHAqe2zVGxeQnoDSbp x4jQOilBe+0Uzsgc77XMwQ7AwfpzDeWyWxISVKa62Oug04HSzu/qmRhmz AccJc0A23wrn45IXVVpK7vTKzrH6UGxLKWRuqo3UJauk9aJYbFehRUyp2 Un95BljFL6T6J4nsC+V6lA2fnIGSO7fZEn4+MffOr3Gcu6qtMA8YdxoRQ Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10571"; a="406771360" X-IronPort-AV: E=Sophos;i="5.96,274,1665471600"; d="scan'208";a="406771360" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2022 16:48:38 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10571"; a="897999226" X-IronPort-AV: E=Sophos;i="5.96,274,1665471600"; d="scan'208";a="897999226" Received: from intel-cd-odc-steve.cd.intel.com ([10.240.178.136]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2022 16:48:36 -0800 From: Steve Yang To: dev@dpdk.org Cc: Yuying.Zhang@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com, Steve Yang Subject: [PATCH v1 2/2] net/ice: fix unsupported flow rule transfer attribute Date: Mon, 26 Dec 2022 00:37:15 +0000 Message-Id: <20221226003715.615278-3-stevex.yang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221226003715.615278-1-stevex.yang@intel.com> References: <20221226003715.615278-1-stevex.yang@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org ice doesn't support transfer attribute of flow rule, ignore it when validating rule attributes. Fixes: d76116a4678f ("net/ice: add generic flow API") Signed-off-by: Steve Yang Acked-by: Qi Zhang --- drivers/net/ice/ice_generic_flow.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c index d496c28dec..86a32f8cb1 100644 --- a/drivers/net/ice/ice_generic_flow.c +++ b/drivers/net/ice/ice_generic_flow.c @@ -2030,6 +2030,14 @@ ice_flow_valid_attr(struct ice_adapter *ad, return -rte_errno; } + /* Not supported */ + if (attr->transfer) { + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER, + attr, "Not support transfer."); + return -rte_errno; + } + /* Check pipeline mode support to set classification stage */ if (ad->devargs.pipe_mode_support) { if (attr->priority == 0)