From patchwork Tue Jan 3 11:11:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Slava Ovsiienko X-Patchwork-Id: 121529 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 328DBA00C2; Tue, 3 Jan 2023 12:11:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2703C40697; Tue, 3 Jan 2023 12:11:42 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2070.outbound.protection.outlook.com [40.107.237.70]) by mails.dpdk.org (Postfix) with ESMTP id 6FB4040689; Tue, 3 Jan 2023 12:11:40 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UsxFeg2jDN61h3fsUCCbmalt7oKJpXHitliQrXpEPYjuToZswTkNWlvMC9Mdf7zrOnyAlVnrxE/kJirbLjcIc3F4qEFRMZFtlwwfCBavQR6YdEmfGmWb49Y0cqXb1LAf7L/3rUnLhtTzAZX3cRpeXxHd/82AXsJtVej7bw+04oMoca9zyo3S0kd5D8OnAzls6FJvRP64X5JRpAxJHQLDJHZ7aQmqc6s843YUNnlvBkug5L10RDFCtoHsm+rrGl3WeUdaGQSK1QOdBUl+O7OIXYsoC0ugpaGXK+wkUUvMwH7y1WHpWzEz31z5RWpyjRd6hC+dS+NvU4yNANskLf2m9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=01Pzs4W0lPOoSuGRYtpTukudCOzqrcBMn2FDN+CVCnE=; b=H0ZNG++a5UE3G94H+8gV02t7bNY7520+XlrYy9T0Ao0Y+6ZugeLT3rTLj+LpcgPqk9Saon35/ifJ0qSQMaq9T919P26bmYPDLPOquOx/KD3R4+dG0xt+j++smswR+Zmw+MqaCbDTygDRXZgqcZbmUQjE0t9tqbJQddLz8TLq+nsRoGYUjjh+cfNQVpGHWpDRdRRGGMpjlBjUrxVM5pf/f/DG1vn0Q1xTAz1ljbs+GD2Mzld5KnNxcwmNmICVyXNhVThD27Q8kL0ZkIlrbEHFNug0lyLJ8gSXPIaM2HdS8Qtwzs0YQ4lRkt8SSGFgH/P2nacii2usN4gJskjRn8VEQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=01Pzs4W0lPOoSuGRYtpTukudCOzqrcBMn2FDN+CVCnE=; b=ENXR9kOusED6iZb7YpHPG5RqJiLsC0/SvZDydLSl7IHn9zVbDrc8WNVWjvWKoekipbtbGm+HY/Ac/D3gdiT5pwL0n/siWADn4MlCp0zKJdyL24hKKq/721cvEnIiEiPN/LdFeUBf6GFQkmD1DZ5LyZImEon7OjMv2suxlSg55w7xsTTIsXqLfxufsLsf6zCZuGSoYWC9dBhVVNuzxYHE1uwrkuW6EK4IStnRMlETiY6pb3oxo9cMfbPlV62YaVFAApvEDOiIrqY6pofAWe/1pt7VxA9U+2KVvNejANxI7TgwqtOXOD1sIvwVC3ZjvbGSHdDg/4WpdHuXcZ5A1HoMCg== Received: from DS7PR03CA0312.namprd03.prod.outlook.com (2603:10b6:8:2b::21) by CH3PR12MB8509.namprd12.prod.outlook.com (2603:10b6:610:157::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 11:11:38 +0000 Received: from DM6NAM11FT090.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2b:cafe::62) by DS7PR03CA0312.outlook.office365.com (2603:10b6:8:2b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5966.19 via Frontend Transport; Tue, 3 Jan 2023 11:11:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT090.mail.protection.outlook.com (10.13.172.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.17 via Frontend Transport; Tue, 3 Jan 2023 11:11:38 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 3 Jan 2023 03:11:33 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 3 Jan 2023 03:11:32 -0800 From: Viacheslav Ovsiienko To: CC: , , , Subject: [PATCH] net/mlx5: fix irrelevant send skew devarg warning Date: Tue, 3 Jan 2023 13:11:13 +0200 Message-ID: <20230103111113.29030-1-viacheslavo@nvidia.com> X-Mailer: git-send-email 2.18.1 MIME-Version: 1.0 X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT090:EE_|CH3PR12MB8509:EE_ X-MS-Office365-Filtering-Correlation-Id: b2a39dde-1611-44db-5551-08daed7b48ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JBgIvknTFVYsu0VJ/2SyJwCSuZRTCuy0qFYzpk4XbSn84Jt4SwFNS05JlSTrGT4iTuC4kZHkODdSvfPaaVwIrTiCpsKBIpcMwF9uh9wBvbxMWJ0JDGApTpw6Q84xj+xV9Qy5mc4aTywxXnfXQrnKjZhy04Kaw3zlCgKwK3qscH91QwGN+UCG649rJWxlrmhd7Em0mlz+ccNAJI4tKEzX50XA6pC7GHXkX7VBN94v7+8rlQcvfwVpkyuL2EqzximZSAeHMrI+HfuMAX6XJBAudwo0iGhkLg84/fDZGbAd7Uu1e838FXX7o0omH4aizm9VkkxenJfraavZQBiGam+UuvXii3LyfQzK+ji6Y5gaZBiQ20I0UwDa87FSx5P6fwA5UouGvRQSycthBkce3/fVoc4qzgZhjF+g5HSHCGjZ9lnmAI29I3E4cHHFkiCkLSqQgK1+fwMmdnIvIQRi1pKJxwvtOP+iJm8OCbG9sj58ARpKoGVuzF1sWuJVA9sTFjnwApZ4ryHDtjhtxtn7b7wYd0S3vLFl3ge9A2f+W6TGTEXkAj5BDqD1XwZZLErmIRZb5WxEeIHsRUY+qMUqngmLy5bJXkly+BpZiA0IucoiwL85vCKuu99kyO+B2NG6LT3gnusg/rTLHCjnj+mjnUNcXhOJIcYjxF8KpL6l9yPlgCiX+IO0s2Qx6Dh/cLY/erQpchybKfG917kLOImuivFACkGiuFQ24F6khLN3eOYGduI= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(346002)(39860400002)(376002)(396003)(136003)(451199015)(36840700001)(46966006)(40470700004)(47076005)(1076003)(336012)(2616005)(426003)(83380400001)(26005)(186003)(6286002)(16526019)(7636003)(40460700003)(82740400003)(356005)(86362001)(40480700001)(55016003)(36860700001)(36756003)(82310400005)(6916009)(2906002)(70206006)(5660300002)(450100002)(8936002)(4326008)(8676002)(4744005)(316002)(70586007)(6666004)(54906003)(41300700001)(7696005)(478600001)(22166006); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 11:11:38.0798 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b2a39dde-1611-44db-5551-08daed7b48ac X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT090.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8509 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Since ConnectX-7 hardware supports the send scheduling on explicitly specified timestamp, if this feature support is detected by PMD the tx_skew devarg becomes applicable and appropriate warning should not be emitted. Fixes: 49e8797619e40 ("net/mlx5: support wait on time in Tx") Cc: stable@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index e55be8720e..3ae35587b6 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1401,7 +1401,8 @@ mlx5_shared_dev_ctx_args_config(struct mlx5_dev_ctx_shared *sh, rte_errno = ENODEV; return -rte_errno; } - if (!config->tx_pp && config->tx_skew) { + if (!config->tx_pp && config->tx_skew && + !sh->cdev->config.hca_attr.wait_on_time) { DRV_LOG(WARNING, "\"tx_skew\" doesn't affect without \"tx_pp\"."); }