From patchwork Thu Jan 5 12:28:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Ajmera, Megha" X-Patchwork-Id: 121611 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6DC6A00C2; Thu, 5 Jan 2023 13:33:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A58EB400D4; Thu, 5 Jan 2023 13:33:34 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 85AA740041; Thu, 5 Jan 2023 13:33:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672922013; x=1704458013; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=AGKpBhSdS+7vlBJppqT1ixFCjAixSQW79j9GB1flJ4s=; b=F6cytPbNZm6efzh7mvcXFE2N9vSzivJXFAr3lo5rVt00+p0X3zVizdtI tcdNygcj5Yg/rMFC6kxp+Lv9bF3lCz25ElscpA3XciYf8cLeY9H3ilqSS QCfG2YhNWpwxhumByVyR1OJ4D3Jupmsp1+dUOIodFesPUrpfMuENIbAuX 94y4KXAKOuuf6sGWxzyrpWnJQhKe/QMUr9wr3NSo6GjGz6HFhptsU5as+ 9fpCrRxBecM3CcUxVp89KOVBrKyxJ8TCX/mm1f5TToeypNptVU0mJuNs1 a6kNLnfI2sHD8lCirwmTLVmy7t++BahtC8y2UGUbjQYprBI7oGvVZWVt+ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="319898805" X-IronPort-AV: E=Sophos;i="5.96,302,1665471600"; d="scan'208";a="319898805" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2023 04:33:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="605532321" X-IronPort-AV: E=Sophos;i="5.96,302,1665471600"; d="scan'208";a="605532321" Received: from unknown (HELO localhost.localdomain) ([10.190.213.60]) by orsmga003.jf.intel.com with ESMTP; 05 Jan 2023 04:33:30 -0800 From: Megha Ajmera To: dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com Cc: stable@dpdk.org Subject: [PATCH] sched: fix for demo failure in debug mode Date: Thu, 5 Jan 2023 12:28:53 +0000 Message-Id: <20230105122853.144440-1-megha.ajmera@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This issue is happening due to non-initialization of some fields in “rte_eth_rxconf” structure in our application. Doing a memset to zero before initialization in HQoS application. Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- examples/qos_sched/init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 0709aec10c..d28350e14a 100644 --- a/examples/qos_sched/init.c +++ b/examples/qos_sched/init.c @@ -79,6 +79,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) if (app_inited_port_mask & (1u << portid)) return 0; + memset(&rx_conf, 0, sizeof(struct rte_eth_rxconf)); rx_conf.rx_thresh.pthresh = rx_thresh.pthresh; rx_conf.rx_thresh.hthresh = rx_thresh.hthresh; rx_conf.rx_thresh.wthresh = rx_thresh.wthresh; @@ -86,6 +87,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) rx_conf.rx_drop_en = 0; rx_conf.rx_deferred_start = 0; + memset(&tx_conf, 0, sizeof(struct rte_eth_txconf)); tx_conf.tx_thresh.pthresh = tx_thresh.pthresh; tx_conf.tx_thresh.hthresh = tx_thresh.hthresh; tx_conf.tx_thresh.wthresh = tx_thresh.wthresh;