From patchwork Thu Jan 26 23:27:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 122590 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD9BA42498; Fri, 27 Jan 2023 00:28:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A141642D16; Fri, 27 Jan 2023 00:28:37 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2051.outbound.protection.outlook.com [40.107.220.51]) by mails.dpdk.org (Postfix) with ESMTP id 456B241133 for ; Fri, 27 Jan 2023 00:28:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=imjTSRrBvaB/gE18cFOAY98VHMN71oCs3w0s80Enk5+iX7vwtrMO4lyjRyXJO8/YPrW+W8gf+VpKdsKGTjPdg0Y1XANQn2s8A12lkfchV8mZ7gyKgr7y7+ndEfV3SHS9cek2C08nrncVYyz4Ye51q9mSSbFICoLkTEwlIJzsznfnux6QWEp36B+X6oDOUKBPNKVylQYTV5XAkJnxWIjDqsXotgSe5/qYW2uWLVHZP7zWOXPzR9z/u1EZaxWXXmtTTvWvhZODVq0QQZPyLHZKz5VwrzDutuXAAcxF7QSAkxxEg2RppYenOtQilLUjkxmHyVvqz8CSwIdC1sYsnaxFZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7dufe3CbHASipMVZXX4JDaVZh8AWrQ16hKEMNn9vWhc=; b=OUpArRPn/mGV+RjcJ2KZPJch+rycGSBd4lpLSmgNqivxYzD7IVIHHnKTKrpYTpuYglY2PY/g7ul46fJKV0mznzPTDtdXUNu0e8IMkW7DQ5MDLG5jBuauTTuDgJpzleYZQw9RTyQUYCvc1q7g4/pYVuPof8EfqjAUSeOPjxXuJYtonPtk6hyxgAYzMghgXiz1p+qBAkbD6f1uw1U9T18bke2j2INttzbyM232aF9kuwuYJ6T4oxoGHlrdzpjS1HUWxI8ONEI3GRalRzeVXx3p2Ry97a5t+XAVd9bZzMXM5BMfm31dSoxp5KuP+TTLNp2c6TbG7ub+hhRTt0B8CQb76w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7dufe3CbHASipMVZXX4JDaVZh8AWrQ16hKEMNn9vWhc=; b=Olw3V4rY/1sZor4Htw5weBd73G9g00g7o9KPWmagmz2NHgsbcr69pOaDSh+vPTY3ACNamfhbwMWZxKt8TVs4hRkJ6gdCs2eTFTMgNQ/BHv51I9AekvpiQRmhmDH40aHLeexVAn1MJW8MbiF1ZgfQcPhoQ97Hc7wzf0cIdwaiwwUJ3OF+GNQn5HmOV3U2YPXj5ZmFJ1Mpvq1J9NEmKiX0tLJWoJOINpJRmILNP1VyRefzZEU0Aduyy6W5laJlqBKd+QsNqF5huRdwBV4FnQ4IGSkSSr8Vu8StZl4n2FL1ewFPtR4OcGv4rQZ67m55HOs1gTuhM943FxJBCCkEz5TnPg== Received: from BN9PR03CA0241.namprd03.prod.outlook.com (2603:10b6:408:ff::6) by BY5PR12MB4870.namprd12.prod.outlook.com (2603:10b6:a03:1de::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22; Thu, 26 Jan 2023 23:28:33 +0000 Received: from BN8NAM11FT049.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ff:cafe::f1) by BN9PR03CA0241.outlook.office365.com (2603:10b6:408:ff::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22 via Frontend Transport; Thu, 26 Jan 2023 23:28:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT049.mail.protection.outlook.com (10.13.177.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.21 via Frontend Transport; Thu, 26 Jan 2023 23:28:32 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 26 Jan 2023 15:28:25 -0800 Received: from pegasus01.mtr.labs.mlnx (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 26 Jan 2023 15:28:23 -0800 From: Alexander Kozyrev To: CC: , , , Subject: [PATCH v2 1/4] ethdev: add template table insertion type Date: Fri, 27 Jan 2023 01:27:59 +0200 Message-ID: <20230126232802.3960109-2-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20230126232802.3960109-1-akozyrev@nvidia.com> References: <20230121052158.2928238-1-akozyrev@nvidia.com> <20230126232802.3960109-1-akozyrev@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT049:EE_|BY5PR12MB4870:EE_ X-MS-Office365-Filtering-Correlation-Id: a8dce089-5e56-46bf-9186-08dafff50a54 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KOeaI+gBltXMrvoqHZppWIAoXmrFlaGgRBia93YTDzSsnVe/s7Y7K/2f/LkDqWVkMcSlrIoOP1O+mCxpz5WS/gN8TCho6y+EysSCaj6kPuaaYO5M3ApACJUEVBa3pfo5DU+AvZOdMvI1A6RizcfS36FQbtU4wfgmz6tRWL73GgeUmBO/WyA8EdKcA5k4wqOw3cwStZmzZQLgaeYiSeZYXMYTMFeaS5ZpaDXhn8qfCraujBooA2axj/uK1yhdTj+S7jylojQN5KMJJTaKkv7hwCB0+BZctF0GrHeARbz2zMjqzGnvDhQJQOEEVwYtQ+a2EZG4YeEvDebDlqMUGKRyh2fQDka/Ldpw2A1a9hRn1T8+XdS1h3X739mjfqFZr2+MKWNWeCOg1mo9VEdxCYMGEwXGYG/uGV0Ic+Zu2Qy0WpRnTI9+J3LEcLd7MMERfiLrZxnSwhbqNMgbFHG7Aj6xX1faB4ZAcnXynmjeVwnOlF3j7iUei7Pw3ScjlqPQZFdfrg8gztxewdFBHioC7qMb4yNlFAFu2QHtyDX8SshXTJ0Nc+WJR9WUdFa5aEPP/hB6hJgDVIqBUw6QVVOmwmsBsSv64giSHY9F1cN4KTTyjw6znRcLAoGwMQfvlZdnx/o7tzU8II2QLO+P46VbXpyP5JrOeZjBXA61/FS0Im9C7ZM= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(136003)(376002)(396003)(346002)(451199018)(46966006)(36840700001)(86362001)(40480700001)(5660300002)(356005)(426003)(336012)(83380400001)(26005)(16526019)(2616005)(47076005)(7636003)(186003)(36860700001)(8676002)(54906003)(82740400003)(316002)(36756003)(4326008)(8936002)(478600001)(70586007)(70206006)(107886003)(6666004)(82310400005)(6916009)(1076003)(41300700001)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 23:28:32.9700 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8dce089-5e56-46bf-9186-08dafff50a54 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4870 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Allow user to specify insertion type used in template tables. The insertion type is responsible for choosing the appropriate key value used to map inserted flow rules into a template table. Flow rules can be inserted by calculating the hash value for the pattern or inserted by index via the new create_by_index() API. The idea of the index-based insertion is to avoid additional matches and simply execute predefined actions after jumping to the index. The insertion into an already occupied index results in an error. The old rule must be destroyed first. An index cannot be bigger than the size of the table, otherwise, the rule is rejected as well. Signed-off-by: Alexander Kozyrev --- doc/guides/prog_guide/rte_flow.rst | 20 ++++++++ doc/guides/rel_notes/release_23_03.rst | 6 +++ lib/ethdev/rte_flow.c | 24 ++++++++++ lib/ethdev/rte_flow.h | 65 ++++++++++++++++++++++++++ lib/ethdev/rte_flow_driver.h | 11 +++++ lib/ethdev/version.map | 3 ++ 6 files changed, 129 insertions(+) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 3e6242803d..fbed7da9d8 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -3669,6 +3669,26 @@ Enqueueing a flow rule creation operation is similar to simple creation. A valid handle in case of success is returned. It must be destroyed later by calling ``rte_flow_async_destroy()`` even if the rule is rejected by HW. +Enqueue creation by index operation +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +Enqueueing a flow rule creation operation to insert a rule at a table index. + +.. code-block:: c + + struct rte_flow * + rte_flow_async_create_by_index(uint16_t port_id, + uint32_t queue_id, + const struct rte_flow_op_attr *op_attr, + struct rte_flow_template_table *template_table, + uint32_t rule_index, + const struct rte_flow_action actions[], + uint8_t actions_template_index, + void *user_data, + struct rte_flow_error *error); + +A valid handle in case of success is returned. It must be destroyed later +by calling ``rte_flow_async_destroy()`` even if the rule is rejected by HW. + Enqueue destruction operation ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/doc/guides/rel_notes/release_23_03.rst b/doc/guides/rel_notes/release_23_03.rst index c15f6fbb9f..fa9391de2b 100644 --- a/doc/guides/rel_notes/release_23_03.rst +++ b/doc/guides/rel_notes/release_23_03.rst @@ -69,6 +69,12 @@ New Features ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter required for eth_rx, eth_tx, crypto and timer eventdev adapters. +* **Added index-based rules insertion in flow API.** + + Added ``rte_flow_table_insertion_type`` to allow the creation + of index-based template tables in addition to pattern-based tables. + Introduced new function ``rte_flow_async_create_by_index()`` + to insert rules by index into index-based template tables. Removed Items ------------- diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index 7d0c24366c..013eb355ca 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_flow.c @@ -1765,6 +1765,30 @@ rte_flow_async_create(uint16_t port_id, return flow; } +struct rte_flow * +rte_flow_async_create_by_index(uint16_t port_id, + uint32_t queue_id, + const struct rte_flow_op_attr *op_attr, + struct rte_flow_template_table *template_table, + uint32_t rule_index, + const struct rte_flow_action actions[], + uint8_t actions_template_index, + void *user_data, + struct rte_flow_error *error) +{ + struct rte_eth_dev *dev = &rte_eth_devices[port_id]; + const struct rte_flow_ops *ops = rte_flow_ops_get(port_id, error); + struct rte_flow *flow; + + flow = ops->async_create_by_index(dev, queue_id, + op_attr, template_table, rule_index, + actions, actions_template_index, + user_data, error); + if (flow == NULL) + flow_err(port_id, -rte_errno, error); + return flow; +} + int rte_flow_async_destroy(uint16_t port_id, uint32_t queue_id, diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index b60987db4b..2ba616eeb1 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethdev/rte_flow.h @@ -5187,6 +5187,23 @@ rte_flow_actions_template_destroy(uint16_t port_id, */ struct rte_flow_template_table; +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Template table flow rules insertion type. + */ +enum rte_flow_table_insertion_type { + /** + * Pattern-based insertion. + */ + RTE_FLOW_TABLE_INSERTION_TYPE_PATTERN, + /** + * Index-based insertion. + */ + RTE_FLOW_TABLE_INSERTION_TYPE_INDEX, +}; + /** * @warning * @b EXPERIMENTAL: this API may change without prior notice. @@ -5202,6 +5219,10 @@ struct rte_flow_template_table_attr { * Maximum number of flow rules that this table holds. */ uint32_t nb_flows; + /** + * Insertion type for flow rules. + */ + enum rte_flow_table_insertion_type insertion_type; }; /** @@ -5336,6 +5357,50 @@ rte_flow_async_create(uint16_t port_id, void *user_data, struct rte_flow_error *error); +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Enqueue rule creation operation. + * + * @param port_id + * Port identifier of Ethernet device. + * @param queue_id + * Flow queue used to insert the rule. + * @param[in] op_attr + * Rule creation operation attributes. + * @param[in] template_table + * Template table to select templates from. + * @param[in] rule_index + * Rule index in the table. + * @param[in] actions + * List of actions to be used. + * The list order should match the order in the actions template. + * @param[in] actions_template_index + * Actions template index in the table. + * @param[in] user_data + * The user data that will be returned on the completion events. + * @param[out] error + * Perform verbose error reporting if not NULL. + * PMDs initialize this structure in case of error only. + * + * @return + * Handle on success, NULL otherwise and rte_errno is set. + * The rule handle doesn't mean that the rule has been populated. + * Only completion result indicates that if there was success or failure. + */ +__rte_experimental +struct rte_flow * +rte_flow_async_create_by_index(uint16_t port_id, + uint32_t queue_id, + const struct rte_flow_op_attr *op_attr, + struct rte_flow_template_table *template_table, + uint32_t rule_index, + const struct rte_flow_action actions[], + uint8_t actions_template_index, + void *user_data, + struct rte_flow_error *error); + /** * @warning * @b EXPERIMENTAL: this API may change without prior notice. diff --git a/lib/ethdev/rte_flow_driver.h b/lib/ethdev/rte_flow_driver.h index c7d0699c91..b5b597dd28 100644 --- a/lib/ethdev/rte_flow_driver.h +++ b/lib/ethdev/rte_flow_driver.h @@ -221,6 +221,17 @@ struct rte_flow_ops { uint8_t actions_template_index, void *user_data, struct rte_flow_error *err); + /** See rte_flow_async_create_by_index() */ + struct rte_flow *(*async_create_by_index) + (struct rte_eth_dev *dev, + uint32_t queue_id, + const struct rte_flow_op_attr *op_attr, + struct rte_flow_template_table *template_table, + uint32_t rule_index, + const struct rte_flow_action actions[], + uint8_t actions_template_index, + void *user_data, + struct rte_flow_error *err); /** See rte_flow_async_destroy() */ int (*async_destroy) (struct rte_eth_dev *dev, diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map index 17201fbe0f..dbc2bffe64 100644 --- a/lib/ethdev/version.map +++ b/lib/ethdev/version.map @@ -298,6 +298,9 @@ EXPERIMENTAL { rte_flow_get_q_aged_flows; rte_mtr_meter_policy_get; rte_mtr_meter_profile_get; + + # added in 23.03 + rte_flow_async_create_by_index; }; INTERNAL { From patchwork Thu Jan 26 23:28:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 122591 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D00F42498; Fri, 27 Jan 2023 00:28:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DF2542D44; Fri, 27 Jan 2023 00:28:42 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2062.outbound.protection.outlook.com [40.107.94.62]) by mails.dpdk.org (Postfix) with ESMTP id 1B71A41133 for ; Fri, 27 Jan 2023 00:28:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bRTV5qlrAH33fp5sQdOaKK238ZA8RULUS3VXHmRnaFobvS0ln0cY/vQrkwks/mt/nwB+wiUwH7mvvNumHFMuVVdKWwrQiNAhHrIvc9o4OVarZnowxOWxdDTc5U5+25ATfUzDxCxPdh+P8h9Dv7nWKo0O3+w2HfMFmohfUmargXDA6uy5cLhXuRsGHBmGBRvCPS5obppvWDvPXdRUytwsvaX7tqhxazPp5BWeOt3wF4oad+PhpjACK/RldUoAKu2XONt7pIdOohD9+oHjnLH4ZBVFLsgsrm3E7leBwjxhaEwopPrNWYwd9IdQT7y+T3N7Nv/Eq34hi+BQkTUYULaOlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eGXTrIV6PIrDv0GkI5Z7ZLsYpokQi3yWvQ3tlM4OVoI=; b=D5Bz+U58rFMZKhyQUaE3Qn8lFwQYfp+wxtpmdIA0H8eu7KYt29cxn9ZQeW7gv+ha0vcColh7MXxXGNmK5WxnutMN5U0hQGEjGfYrBLYVan5cCiucHrTgDBcdRaZkzR2dzAPo34gCdnEiRAQC/Qf9ktdAPxg184ubhe1b4i1BVD9A2GzbLmsp4L578RRnKhhuagtlZ552dx2DTFsrfNRvJeg1X+5ImgW/EjNdesC0FJSExyQjud1v0n2ZmpbuRzxjkK/Az5+iQBesR9Z1LX83188cNxCRCGzOtyztumiimQ0kDF3BLJyTGiBkHVqL/KC8ZGhUL+YZs56iL10aEV0n0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eGXTrIV6PIrDv0GkI5Z7ZLsYpokQi3yWvQ3tlM4OVoI=; b=a3mUEYOL9BdMsh5kCeX6nYcd7SaI2AFvmH4WFXMyV9s70bGlT1TQqrWE33bkAdTiR6pu1fV9pjNSuK2HyD4ChoIY+1/CPLlyAKnlED3A440+y4H6oQOJOxOQh28YskC8uVwVChnHxEVJehUlBTO26+boem/2oaXo93XiOVVMON5HDyP/fO2PzKQ9a3tm+xMDL0AJlEWnTv3lzkvYmFif29pg7xaYz3nV3k4K6CJdACs3r5m5wESOr548zl8b5AJAbZI4MEAeV7hh7G8DAGDE2b2jhrOqZmcxDnh+XdOlXp8VyjmWAd+P6b0Qoj2GI5iht3uub05LVh8hkjz+uFrCfQ== Received: from DS7PR03CA0172.namprd03.prod.outlook.com (2603:10b6:5:3b2::27) by IA1PR12MB6092.namprd12.prod.outlook.com (2603:10b6:208:3ec::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22; Thu, 26 Jan 2023 23:28:39 +0000 Received: from DM6NAM11FT115.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b2:cafe::1a) by DS7PR03CA0172.outlook.office365.com (2603:10b6:5:3b2::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22 via Frontend Transport; Thu, 26 Jan 2023 23:28:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT115.mail.protection.outlook.com (10.13.173.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.21 via Frontend Transport; Thu, 26 Jan 2023 23:28:38 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 26 Jan 2023 15:28:28 -0800 Received: from pegasus01.mtr.labs.mlnx (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 26 Jan 2023 15:28:26 -0800 From: Alexander Kozyrev To: CC: , , , Subject: [PATCH v2 2/4] ethdev: add template table hash calculation function Date: Fri, 27 Jan 2023 01:28:00 +0200 Message-ID: <20230126232802.3960109-3-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20230126232802.3960109-1-akozyrev@nvidia.com> References: <20230121052158.2928238-1-akozyrev@nvidia.com> <20230126232802.3960109-1-akozyrev@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT115:EE_|IA1PR12MB6092:EE_ X-MS-Office365-Filtering-Correlation-Id: 115fa946-74f1-40b0-00b9-08dafff50dc7 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N/5/Kfxv79VC72aj5phvDXhnB5FmOOdMQU7cq+cE0KwP+enhXCf/yprRBk3y6JG2eNRGb56UNnbC0VKLeCvDGFGkQEfsh5YDf35nMnnc4Hl3dJHWmOqQpe2H2G4J1EIlZ+ZWxuvXXCQRORuEIELCZ7ZUWpdjqvEFkrT5gtWSsk04v1sb+G3tCas6GwHhcxhgoUgAdfeotdOgCdDznJ9ExqI3yLcVPpBGabTsPnHtycrvVGBC1638BGiSfIWTZ7YOdzQ50xNMi02wR77zGrSyXNsE0tlR4xLbsUoZB69hPlPthISDFN9LLEWQYRj4u0SCLYzGqpS90qz0o7rEre5uvCq9tPlHWsvtmceRok50MmTY1ZnFu/FZb5CSJl8qER16VT3UZf2UQ0ZncG72shLRJEBDl6IV2Im6YCHUc/UJJ2cvvux0Vs1bENEQjMBFmhuCtxrz/tv0bi+n3zyeSFyhfDquPr/NpICr1iCvq//YmfjRILwPOatlWszjH99Rkvmvslto+SMVuy+p+i9V+wq7GSK3Ba8uFYPE4mysvYJm2R8OOabEwPiLkz4dJQlPi8Rh1Qa9lYWLhh7pverfXTqjbGCHyfZG/Sea1GbMqOaSMJ+IhXMCHk2xiAzshY6kKfNz2vQr6aZ9tvZoBkp396MEz9+S7Oibz6mtoplAk9n2EqZt+eb7fTlvU+m4HwhgBW+p1MFv/j6MOmemCY2XDVc0Ug== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(346002)(136003)(376002)(396003)(451199018)(40470700004)(46966006)(36840700001)(40460700003)(7636003)(2906002)(356005)(36860700001)(1076003)(2616005)(107886003)(186003)(26005)(16526019)(6666004)(426003)(86362001)(83380400001)(40480700001)(336012)(4326008)(6916009)(70586007)(47076005)(5660300002)(8676002)(36756003)(70206006)(41300700001)(316002)(54906003)(82740400003)(8936002)(478600001)(82310400005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 23:28:38.8000 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 115fa946-74f1-40b0-00b9-08dafff50dc7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT115.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6092 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Allow user to specify hash calculation function used in template tables. The hash calculation type is responsible for the calculation of the flow rule index a packet would hit upon arrival at the table. Control over this is useful for applications with custom RSS algorithms, for example. An application can select various packet fields to serve as a hash calculation source and jump to the appropriate flow rule location. The RSS hash result will be used as the index in the table. For the linear hash function, the mapping is one-to-one and the hash result is the index. For other hash functions, the index is the hash result module table size. The RSS hash result can be retrieved via modify_field API: HASH_RESULT. Signed-off-by: Alexander Kozyrev --- doc/guides/rel_notes/release_23_03.rst | 4 ++++ lib/ethdev/rte_flow.h | 30 ++++++++++++++++++++++++++ 2 files changed, 34 insertions(+) diff --git a/doc/guides/rel_notes/release_23_03.rst b/doc/guides/rel_notes/release_23_03.rst index fa9391de2b..6f7c38ec66 100644 --- a/doc/guides/rel_notes/release_23_03.rst +++ b/doc/guides/rel_notes/release_23_03.rst @@ -76,6 +76,10 @@ New Features Introduced new function ``rte_flow_async_create_by_index()`` to insert rules by index into index-based template tables. +* **Added index-based rules insertion in flow API.** + Added hash calculation function used in template tables + to allow control over the calculation of the rule index for a packet. + Removed Items ------------- diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 2ba616eeb1..6ce61e3f53 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethdev/rte_flow.h @@ -3528,6 +3528,7 @@ enum rte_flow_field_id { RTE_FLOW_FIELD_IPV6_ECN, /**< IPv6 ECN. */ RTE_FLOW_FIELD_GTP_PSC_QFI, /**< GTP QFI. */ RTE_FLOW_FIELD_METER_COLOR, /**< Meter color marker. */ + RTE_FLOW_FIELD_HASH_RESULT, /**< Hash result. */ }; /** @@ -5204,6 +5205,31 @@ enum rte_flow_table_insertion_type { RTE_FLOW_TABLE_INSERTION_TYPE_INDEX, }; +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Template table hash index calculation function. + */ +enum rte_flow_table_hash_func { + /** + * Default hash calculation. + */ + RTE_FLOW_TABLE_HASH_FUNC_DEFAULT, + /** + * Linear hash calculation. + */ + RTE_FLOW_TABLE_HASH_FUNC_LINEAR, + /** + * 32-bit checksum hash calculation. + */ + RTE_FLOW_TABLE_HASH_FUNC_CRC32, + /** + * 16-bit checksum hash calculation. + */ + RTE_FLOW_TABLE_HASH_FUNC_CRC16, +}; + /** * @warning * @b EXPERIMENTAL: this API may change without prior notice. @@ -5223,6 +5249,10 @@ struct rte_flow_template_table_attr { * Insertion type for flow rules. */ enum rte_flow_table_insertion_type insertion_type; + /** + * Hash calculation function for the packet matching. + */ + enum rte_flow_table_hash_func hash_func; }; /** From patchwork Thu Jan 26 23:28:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 122593 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95D3842498; Fri, 27 Jan 2023 00:28:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A98442D6B; Fri, 27 Jan 2023 00:28:45 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2073.outbound.protection.outlook.com [40.107.92.73]) by mails.dpdk.org (Postfix) with ESMTP id 3F08542D53 for ; Fri, 27 Jan 2023 00:28:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GEzbDPgisD5SiV5XVeMLr0gZzAaeQWTvrRIZ7xLgkIpxXOcI2Vf46qA7uxWbQaQ5XJ66EkNZjxoAUmG/2VpHhJB4BTSZ8tFjxmM6wr4AQNB0Th3bcZf6a8Kp7naTve8rNXK3iKJXmh+B/YpslkEA9kP2fjsO1CORB8cX7rbO6M/W4cs83EDqknyqFHPNj4UYPRp1hyM5NhCMEI0ClOZOb72YidntOlmGqymnNUEvTG7MZYQmDY4qlZAJDcvR2NAgmxQM4xXEs5sj5r5bsiHxWmzOhYnClYpujV6GHxn3RNWNQL+r0NOeYOalJcud8QWPqrqADw6lQIV3p2vqEHRXVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GelJ1nuhvqrn9p+RpgUtTZZp1RFvJ8PBtkHX1F43tyE=; b=M9Q7MBGp8jkeUFf+4j+6i39RidM+/OVSr/20//mCAtQClFUS5XloCy6XhzLy6JcQwrAY5bksEpJyLXOlrdhkKlUKqylDjVA1f37Wbr0jSZMbV0BQuCIgw/2vST4ITNo0c6ivC+OnJKtooZUndoZfrr8UFVfBPg9F8bYRHxFTLa5TN3HoC7R/7WcmnaxDuLFRJxuBtxNBvR9dBCuaXIt/YQZm2L1YmR1/gie+MFIdtETKHkxIwHz+X4Ufda0+LcXSob+da/E43o8Upxx1vZSC5YdY2opsB7dcagxU8YbXuntHMRXhuf1wpfBFjA3oF2ikCsfAeQw0du2BqA3WXZ15Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GelJ1nuhvqrn9p+RpgUtTZZp1RFvJ8PBtkHX1F43tyE=; b=VSNZu6JUonubd+8OLjBaEDyuW57se6NWr/SN7rcdLE851lXpaSIReLMCNJPSIIckeE6LYj6x/ihKrM2zAA5zRdN/FEDG4jqYifhGW8SYHcrWs8iFFWuS/3biuDLdL5kAgorqMhO8EDNF2iXdUUn9adTxV0o+a4KqkQhpohIJ5as8qCTe80wjPCo77YD4EbOf3EpfeoXupdnJHt1ROr4juD2a34u8esyyrj3fR3l8/JAOLh3UU44Zo3MuVQktH+/oE6vSpnwO/WWehjXi+yzqLDopyt50YphCYPI3oszF7IrI8uY0C/bTJZRBIu1ZvcC8qPq86QwJ/uHY+yu7cIxREg== Received: from DM5PR07CA0070.namprd07.prod.outlook.com (2603:10b6:4:ad::35) by SJ0PR12MB5405.namprd12.prod.outlook.com (2603:10b6:a03:3af::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22; Thu, 26 Jan 2023 23:28:41 +0000 Received: from DM6NAM11FT031.eop-nam11.prod.protection.outlook.com (2603:10b6:4:ad:cafe::26) by DM5PR07CA0070.outlook.office365.com (2603:10b6:4:ad::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22 via Frontend Transport; Thu, 26 Jan 2023 23:28:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT031.mail.protection.outlook.com (10.13.172.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.21 via Frontend Transport; Thu, 26 Jan 2023 23:28:41 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 26 Jan 2023 15:28:30 -0800 Received: from pegasus01.mtr.labs.mlnx (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 26 Jan 2023 15:28:28 -0800 From: Alexander Kozyrev To: CC: , , , Subject: [PATCH v2 3/4] app/testpmd: add template table insertion type Date: Fri, 27 Jan 2023 01:28:01 +0200 Message-ID: <20230126232802.3960109-4-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20230126232802.3960109-1-akozyrev@nvidia.com> References: <20230121052158.2928238-1-akozyrev@nvidia.com> <20230126232802.3960109-1-akozyrev@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT031:EE_|SJ0PR12MB5405:EE_ X-MS-Office365-Filtering-Correlation-Id: 6cb4e443-1a61-4c5a-8ae0-08dafff50f31 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T6L+xEDnd+XhHBp/7H1xEZ0Yj+QNsV+Fs8r8FXnvKayhGrWN5kZ9pnAL74fvSnyyK3IcOzF01mGKKbddU32lnu2iuRuCjrB3eqR8jzGSFRYkBHfzBrt06tW9GotTTVoT6fZcg24qL4N+1lrklHrFWtvvgXyC49cywv7P1R61I2z0zGcQ2tqDWTB5t9qgzVb6pM8VkIYKJvp+By6qqc+umIvdtf6OZyXh+Onq+4ZGDiPsvpxGw6qPDkdaWiTqiZTqdzWSwEIr+RAizAntjWGEuerYFzHmY3gYEfui1KjJLJgTfhKQzxtWn7pgnCRo453iW57p4o99FSxQewxGojYTtIEmY+qmVrsyNelR0yXay+9OJ8JGCpJvV/MEhzftID54vBjW7bsXb1GYv7pyMzszdSJ/WAUFl0dGclZm7UZ6WOOQoGCFHQmOJ4EPZ73DlZyBbvXXCNqceIjHqY+0pNqj0SZMhJK/UZ4SJRzQRUFEIYqXIVWZJotKx+DbppaH2j3sX/ElpMeXep6qe900TvoIgb2hGVgFkhGG1ai9KN+bYRPSAen5yBQuG/yOiAj1elOhkjZGvMaxOkwQY+Uf99k0PHEpKL048P8q3At7WlgmYNje7sYtd7bbsI4R5WhUU+KPxkvau9Pkd/4yOO7Gcu2PiNdVgpqObXyshGglzkBCY7YJsJFjxos+oUSVjwq5xGjZyhgbn+hyBVnH8bVza8nBXw== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(346002)(136003)(376002)(396003)(451199018)(40470700004)(46966006)(36840700001)(40460700003)(7636003)(2906002)(356005)(36860700001)(1076003)(2616005)(107886003)(186003)(26005)(16526019)(6666004)(426003)(86362001)(83380400001)(40480700001)(336012)(4326008)(6916009)(70586007)(47076005)(5660300002)(8676002)(36756003)(70206006)(41300700001)(316002)(54906003)(82740400003)(8936002)(478600001)(82310400005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 23:28:41.1915 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6cb4e443-1a61-4c5a-8ae0-08dafff50f31 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT031.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5405 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add testpmd CLI interface for specifying a template table insertion type. Available types are: pattern and index. flow template_table 0 create table_id 0 insertion_type index ... Allow specifying the rule index instead of the pattern template index: flow queue 0 create 0 template_table 0 rule_index 5 actions_template 0 ... Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 97 ++++++++++++++++++++++++++++++++++--- app/test-pmd/config.c | 10 ++-- app/test-pmd/testpmd.h | 2 +- 3 files changed, 99 insertions(+), 10 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 88108498e0..f1d6813baa 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -133,12 +133,11 @@ enum index { QUEUE_INDIRECT_ACTION, /* Queue create arguments. */ - QUEUE_CREATE_ID, QUEUE_CREATE_POSTPONE, QUEUE_TEMPLATE_TABLE, QUEUE_PATTERN_TEMPLATE, QUEUE_ACTIONS_TEMPLATE, - QUEUE_SPEC, + QUEUE_RULE_ID, /* Queue destroy arguments. */ QUEUE_DESTROY_ID, @@ -179,6 +178,8 @@ enum index { TABLE_DESTROY, TABLE_CREATE_ID, TABLE_DESTROY_ID, + TABLE_INSERTION_TYPE, + TABLE_INSERTION_TYPE_NAME, TABLE_GROUP, TABLE_PRIORITY, TABLE_INGRESS, @@ -814,6 +815,12 @@ static const char *const meter_colors[] = { "green", "yellow", "red", "all", NULL }; +static const char *const table_insertion_types[] = { + "pattern", "index", NULL +}; + +#define RAW_IPSEC_CONFS_MAX_NUM 8 + /** Maximum number of subsequent tokens and arguments on the stack. */ #define CTX_STACK_SIZE 16 @@ -1015,6 +1022,7 @@ struct buffer { struct { uint32_t table_id; uint32_t pat_templ_id; + uint32_t rule_id; uint32_t act_templ_id; struct rte_flow_attr attr; struct tunnel_ops tunnel_ops; @@ -1154,6 +1162,7 @@ static const enum index next_table_subcmd[] = { static const enum index next_table_attr[] = { TABLE_CREATE_ID, TABLE_GROUP, + TABLE_INSERTION_TYPE, TABLE_PRIORITY, TABLE_INGRESS, TABLE_EGRESS, @@ -1287,6 +1296,12 @@ static const enum index next_ia_destroy_attr[] = { ZERO, }; +static const enum index next_async_insert_subcmd[] = { + QUEUE_PATTERN_TEMPLATE, + QUEUE_RULE_ID, + ZERO, +}; + static const enum index item_param[] = { ITEM_PARAM_IS, ITEM_PARAM_SPEC, @@ -2399,6 +2414,9 @@ static int parse_meter_policy_id2ptr(struct context *ctx, static int parse_meter_color(struct context *ctx, const struct token *token, const char *str, unsigned int len, void *buf, unsigned int size); +static int parse_insertion_table_type(struct context *ctx, const struct token *token, + const char *str, unsigned int len, void *buf, + unsigned int size); static int comp_none(struct context *, const struct token *, unsigned int, char *, unsigned int); static int comp_boolean(struct context *, const struct token *, @@ -2431,6 +2449,8 @@ static int comp_queue_id(struct context *, const struct token *, unsigned int, char *, unsigned int); static int comp_meter_color(struct context *, const struct token *, unsigned int, char *, unsigned int); +static int comp_insertion_table_type(struct context *, const struct token *, + unsigned int, char *, unsigned int); /** Token definitions. */ static const struct token token_list[] = { @@ -2901,6 +2921,20 @@ static const struct token token_list[] = { args.table_destroy.table_id)), .call = parse_table_destroy, }, + [TABLE_INSERTION_TYPE] = { + .name = "insertion_type", + .help = "specify insertion type", + .next = NEXT(next_table_attr, + NEXT_ENTRY(TABLE_INSERTION_TYPE_NAME)), + .args = ARGS(ARGS_ENTRY(struct buffer, + args.table.attr.insertion_type)), + }, + [TABLE_INSERTION_TYPE_NAME] = { + .name = "insertion_type_name", + .help = "insertion type name", + .call = parse_insertion_table_type, + .comp = comp_insertion_table_type, + }, [TABLE_GROUP] = { .name = "group", .help = "specify a group", @@ -3002,7 +3036,7 @@ static const struct token token_list[] = { [QUEUE_TEMPLATE_TABLE] = { .name = "template_table", .help = "specify table id", - .next = NEXT(NEXT_ENTRY(QUEUE_PATTERN_TEMPLATE), + .next = NEXT(next_async_insert_subcmd, NEXT_ENTRY(COMMON_TABLE_ID)), .args = ARGS(ARGS_ENTRY(struct buffer, args.vc.table_id)), @@ -3026,6 +3060,15 @@ static const struct token token_list[] = { args.vc.act_templ_id)), .call = parse_qo, }, + [QUEUE_RULE_ID] = { + .name = "rule_index", + .help = "specify flow rule index", + .next = NEXT(NEXT_ENTRY(QUEUE_ACTIONS_TEMPLATE), + NEXT_ENTRY(COMMON_UNSIGNED)), + .args = ARGS(ARGS_ENTRY(struct buffer, + args.vc.rule_id)), + .call = parse_qo, + }, [QUEUE_CREATE_POSTPONE] = { .name = "postpone", .help = "postpone create operation", @@ -9069,11 +9112,13 @@ parse_qo(struct context *ctx, const struct token *token, ctx->objdata = 0; ctx->object = out; ctx->objmask = NULL; + out->args.vc.rule_id = UINT32_MAX; return len; case QUEUE_TEMPLATE_TABLE: case QUEUE_PATTERN_TEMPLATE: case QUEUE_ACTIONS_TEMPLATE: case QUEUE_CREATE_POSTPONE: + case QUEUE_RULE_ID: return len; case ITEM_PATTERN: out->args.vc.pattern = @@ -10052,6 +10097,32 @@ parse_meter_color(struct context *ctx, const struct token *token, return len; } +/** Parse Insertion Table Type name */ +static int +parse_insertion_table_type(struct context *ctx, const struct token *token, + const char *str, unsigned int len, void *buf, + unsigned int size) +{ + const struct arg *arg = pop_args(ctx); + unsigned int i; + char tmp[2]; + int ret; + + (void)size; + /* Argument is expected. */ + if (!arg) + return -1; + for (i = 0; table_insertion_types[i]; ++i) + if (!strcmp_partial(table_insertion_types[i], str, len)) + break; + if (!table_insertion_types[i]) + return -1; + push_args(ctx, arg); + snprintf(tmp, sizeof(tmp), "%u", i); + ret = parse_int(ctx, token, tmp, strlen(tmp), buf, sizeof(i)); + return ret > 0 ? (int)len : ret; +} + /** No completion. */ static int comp_none(struct context *ctx, const struct token *token, @@ -10357,6 +10428,20 @@ comp_meter_color(struct context *ctx, const struct token *token, return -1; } +/** Complete available Insertion Table types. */ +static int +comp_insertion_table_type(struct context *ctx, const struct token *token, + unsigned int ent, char *buf, unsigned int size) +{ + RTE_SET_USED(ctx); + RTE_SET_USED(token); + if (!buf) + return RTE_DIM(table_insertion_types); + if (ent < RTE_DIM(table_insertion_types) - 1) + return rte_strscpy(buf, table_insertion_types[ent], size); + return -1; +} + /** Internal context. */ static struct context cmd_flow_context; @@ -10670,9 +10755,9 @@ cmd_flow_parsed(const struct buffer *in) break; case QUEUE_CREATE: port_queue_flow_create(in->port, in->queue, in->postpone, - in->args.vc.table_id, in->args.vc.pat_templ_id, - in->args.vc.act_templ_id, in->args.vc.pattern, - in->args.vc.actions); + in->args.vc.table_id, in->args.vc.rule_id, + in->args.vc.pat_templ_id, in->args.vc.act_templ_id, + in->args.vc.pattern, in->args.vc.actions); break; case QUEUE_DESTROY: port_queue_flow_destroy(in->port, in->queue, in->postpone, diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index acccb6b035..41484c3dde 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2609,7 +2609,7 @@ port_flow_template_table_flush(portid_t port_id) /** Enqueue create flow rule operation. */ int port_queue_flow_create(portid_t port_id, queueid_t queue_id, - bool postpone, uint32_t table_id, + bool postpone, uint32_t table_id, uint32_t rule_idx, uint32_t pattern_idx, uint32_t actions_idx, const struct rte_flow_item *pattern, const struct rte_flow_action *actions) @@ -2685,8 +2685,12 @@ port_queue_flow_create(portid_t port_id, queueid_t queue_id, } /* Poisoning to make sure PMDs update it in case of error. */ memset(&error, 0x11, sizeof(error)); - flow = rte_flow_async_create(port_id, queue_id, &op_attr, pt->table, - pattern, pattern_idx, actions, actions_idx, job, &error); + if (rule_idx == UINT32_MAX) + flow = rte_flow_async_create(port_id, queue_id, &op_attr, pt->table, + pattern, pattern_idx, actions, actions_idx, job, &error); + else + flow = rte_flow_async_create_by_index(port_id, queue_id, &op_attr, pt->table, + rule_idx, actions, actions_idx, job, &error); if (!flow) { uint32_t flow_id = pf->id; port_queue_flow_destroy(port_id, queue_id, true, 1, &flow_id); diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 7d24d25970..22d02a742c 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -930,7 +930,7 @@ int port_flow_template_table_destroy(portid_t port_id, uint32_t n, const uint32_t *table); int port_flow_template_table_flush(portid_t port_id); int port_queue_flow_create(portid_t port_id, queueid_t queue_id, - bool postpone, uint32_t table_id, + bool postpone, uint32_t table_id, uint32_t rule_idx, uint32_t pattern_idx, uint32_t actions_idx, const struct rte_flow_item *pattern, const struct rte_flow_action *actions); From patchwork Thu Jan 26 23:28:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 122592 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C77F42498; Fri, 27 Jan 2023 00:28:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9CFAB42D54; Fri, 27 Jan 2023 00:28:44 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2044.outbound.protection.outlook.com [40.107.220.44]) by mails.dpdk.org (Postfix) with ESMTP id 1D0F242D52 for ; Fri, 27 Jan 2023 00:28:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CGGsS6cfoGO+SLLqLUsq0jB8Xgro3h17SIEGPqQu8iYlOqC7x0GmjTQAUJG2DerF1OgziyHX3dDHFmfzrkXoeR0qmlWtY18btuUr/MJw/G1M0zF2tP5xDGneYTFlWImIVwhptlkJ5RnPLlrCMe1I7d8Ffk+h8GzA5uwOS3xGSpprKo2cfdQ26FLTU4Zo1CsWUuvpyzwu4pOunFeCOUcTO2TMYA68jQn7NbqBXOXLvYv2o4z8qkQUWgB2JL6XDVNO4JJZyDh4HGggXzdy4Y02aj/JdttZ13wInOt1yNbHG5mBroXOb5M1qHdbEmCrCDaI31zdeR3XvQoGDh8A+P9/8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iYZMtTDg56l+/XXxXlQ0dmmRZhKgO2DmYs3VJ4Q+6/4=; b=RN3NRyCYeT398DWl9sw3BlsL1jew6HoQ5cYQI7MJqxDVI1Ud3pqIQCMI4WVDJ9nalowDpMOVXPwyycgiQIkVgwKLeK6ANhOtSf3G864t0mZGeCcEC0pQjwdsEt3hJNjG2ouocZ/X8aRsRHOzwCdVQUaFEpHa5W4N2qmuZsT01JQvejPlHmpQkbrFUjx1mK5MbawXtN63N8frQy25yW07rf7eYp3gwYrnTdoLNf7ra9HuF8XphvZKtq0NsRlEhN4W726y/JzlvEuvwzQBNuXnspNk2hUsHLBrMQDWUGZQ1UC+b9eDd9piZ5DNJBmlSF5MpjlMGhsGHLhakuT7QuqQyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iYZMtTDg56l+/XXxXlQ0dmmRZhKgO2DmYs3VJ4Q+6/4=; b=YK3jZf2UGzdMwurOujkTdpPC/a535DC3b48+bwGIQcdJKVWiRJbrHloCxoHfZK1xx5gG4GVxj4qpcImjg6ESBxGjM/NIigmmYABShpItvNk5iwDH+JXEUchhxWBxBtiWnYjS1EsaZU2ayksAivElHzVQC6xgXFAjn6I/YMAETiViqbWscmBroIWM/2a/d1VA5t45Fy/mOTGniyQSCSZ/yL1T5kRbUuUwR4UTvZUu6i99ZGQf3I4smQMVTj2xT2k049K5QDSw06BZB6SlGtZtEQ+sd6dg+JYGXFyO1aksll6OuGZHaLQtNT4DwtFkRX/ATq3gQJymn/2owgzIMxfJBA== Received: from BN9PR03CA0249.namprd03.prod.outlook.com (2603:10b6:408:ff::14) by PH7PR12MB5654.namprd12.prod.outlook.com (2603:10b6:510:137::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22; Thu, 26 Jan 2023 23:28:41 +0000 Received: from BN8NAM11FT049.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ff::4) by BN9PR03CA0249.outlook.office365.com (2603:10b6:408:ff::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22 via Frontend Transport; Thu, 26 Jan 2023 23:28:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT049.mail.protection.outlook.com (10.13.177.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.21 via Frontend Transport; Thu, 26 Jan 2023 23:28:40 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 26 Jan 2023 15:28:32 -0800 Received: from pegasus01.mtr.labs.mlnx (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 26 Jan 2023 15:28:30 -0800 From: Alexander Kozyrev To: CC: , , , Subject: [PATCH v2 4/4] app/testpmd: add template table hash calculation function Date: Fri, 27 Jan 2023 01:28:02 +0200 Message-ID: <20230126232802.3960109-5-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20230126232802.3960109-1-akozyrev@nvidia.com> References: <20230121052158.2928238-1-akozyrev@nvidia.com> <20230126232802.3960109-1-akozyrev@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT049:EE_|PH7PR12MB5654:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a0f1026-b5f8-4184-b193-08dafff50ef0 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 63MQziSqI6qX3snKHClrsxfdSUPjp0wbYGMpb5Lnn5qXYuM9HDZfSxZ78qfNlDyrDfeHM6AQtPBeyRFhhiTE+m5vC6mWjOOwyTq/gWijjyvS71a+ymtc5U7P65y93/gaWlu4aq+S3iwJuWw8IH+Bu5V5XFo11Zx5dc67X/g6rndtQNBNE2RWiJP441hkVGGnB4fQ4GvsP3cf/5lMCac6QJTkysoU9U0TVfIHLPdvWCi2AmuHCRfuBDRmoKWy3oxP+VN9zA8uBFd34TdmwktuLzNUqDX3rl5MC6m1hWNtpEhg7J4UbaZaQsZCv9TjyQ3YHfqvgnmbtsqwe8zecfqAujIOqyVqW+IG9ge77SSzOTP99G46ANbdWpaD6nE836PUFHhLTFGoyG0DnTuZ0ZXcv0IrhSP70COV0V47AYTCZq1sVk2j6nF6PfueIlVy/OBr9TbqGbo555S3R9V1CMAXWSuzjIKeasjOGgfmXu98kayX8fHbTrTs9rPTpdX1CgaKNV/y4czQOdtE4crBowdOjDaprVOoeFgGkVi1+6PwtHW2wVoKmwQhEEr8T1Wi7fdLLUy7823T/MfYTpulRGRNgZAUtg0aONNPXtEWdolYPMqRM0SSsICFDA4kne3fzn5xDCGQ/LEHiLeDBbpD5inK9MmQY4tWOz6elz6xi/r5rA9rTRw1RpKuJwLiixPpYMMfTVp6AoTiDwWCZ9Xfg4ZvGg== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(396003)(376002)(346002)(136003)(39860400002)(451199018)(40470700004)(46966006)(36840700001)(36756003)(70586007)(4326008)(54906003)(316002)(8676002)(6916009)(8936002)(41300700001)(70206006)(36860700001)(356005)(86362001)(82740400003)(7636003)(6666004)(1076003)(107886003)(16526019)(26005)(186003)(40480700001)(5660300002)(336012)(83380400001)(2906002)(426003)(82310400005)(40460700003)(47076005)(478600001)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 23:28:40.7040 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a0f1026-b5f8-4184-b193-08dafff50ef0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5654 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add testpmd CLI interface for a template table hash function. Available types are: default, linear, crc32 and crc16. flow template_table 0 create table_id 0 hash_func linear ... Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 69 ++++++++++++++++++++++++++++++++++++- 1 file changed, 68 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index f1d6813baa..007d31c5cf 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -180,6 +180,8 @@ enum index { TABLE_DESTROY_ID, TABLE_INSERTION_TYPE, TABLE_INSERTION_TYPE_NAME, + TABLE_HASH_FUNC, + TABLE_HASH_FUNC_NAME, TABLE_GROUP, TABLE_PRIORITY, TABLE_INGRESS, @@ -808,7 +810,8 @@ static const char *const modify_field_ids[] = { "udp_port_src", "udp_port_dst", "vxlan_vni", "geneve_vni", "gtp_teid", "tag", "mark", "meta", "pointer", "value", - "ipv4_ecn", "ipv6_ecn", "gtp_psc_qfi", "meter_color", NULL + "ipv4_ecn", "ipv6_ecn", "gtp_psc_qfi", "meter_color", + "hash_result", NULL }; static const char *const meter_colors[] = { @@ -819,6 +822,10 @@ static const char *const table_insertion_types[] = { "pattern", "index", NULL }; +static const char *const table_hash_funcs[] = { + "default", "linear", "crc32", "crc16", NULL +}; + #define RAW_IPSEC_CONFS_MAX_NUM 8 /** Maximum number of subsequent tokens and arguments on the stack. */ @@ -1163,6 +1170,7 @@ static const enum index next_table_attr[] = { TABLE_CREATE_ID, TABLE_GROUP, TABLE_INSERTION_TYPE, + TABLE_HASH_FUNC, TABLE_PRIORITY, TABLE_INGRESS, TABLE_EGRESS, @@ -2417,6 +2425,9 @@ static int parse_meter_color(struct context *ctx, const struct token *token, static int parse_insertion_table_type(struct context *ctx, const struct token *token, const char *str, unsigned int len, void *buf, unsigned int size); +static int parse_hash_table_type(struct context *ctx, const struct token *token, + const char *str, unsigned int len, void *buf, + unsigned int size); static int comp_none(struct context *, const struct token *, unsigned int, char *, unsigned int); static int comp_boolean(struct context *, const struct token *, @@ -2451,6 +2462,8 @@ static int comp_meter_color(struct context *, const struct token *, unsigned int, char *, unsigned int); static int comp_insertion_table_type(struct context *, const struct token *, unsigned int, char *, unsigned int); +static int comp_hash_table_type(struct context *, const struct token *, + unsigned int, char *, unsigned int); /** Token definitions. */ static const struct token token_list[] = { @@ -2935,6 +2948,20 @@ static const struct token token_list[] = { .call = parse_insertion_table_type, .comp = comp_insertion_table_type, }, + [TABLE_HASH_FUNC] = { + .name = "hash_func", + .help = "specify hash calculation function", + .next = NEXT(next_table_attr, + NEXT_ENTRY(TABLE_HASH_FUNC_NAME)), + .args = ARGS(ARGS_ENTRY(struct buffer, + args.table.attr.hash_func)), + }, + [TABLE_HASH_FUNC_NAME] = { + .name = "hash_func_name", + .help = "hash calculation function name", + .call = parse_hash_table_type, + .comp = comp_hash_table_type, + }, [TABLE_GROUP] = { .name = "group", .help = "specify a group", @@ -10123,6 +10150,32 @@ parse_insertion_table_type(struct context *ctx, const struct token *token, return ret > 0 ? (int)len : ret; } +/** Parse Hash Calculation Table Type name */ +static int +parse_hash_table_type(struct context *ctx, const struct token *token, + const char *str, unsigned int len, void *buf, + unsigned int size) +{ + const struct arg *arg = pop_args(ctx); + unsigned int i; + char tmp[2]; + int ret; + + (void)size; + /* Argument is expected. */ + if (!arg) + return -1; + for (i = 0; table_hash_funcs[i]; ++i) + if (!strcmp_partial(table_hash_funcs[i], str, len)) + break; + if (!table_hash_funcs[i]) + return -1; + push_args(ctx, arg); + snprintf(tmp, sizeof(tmp), "%u", i); + ret = parse_int(ctx, token, tmp, strlen(tmp), buf, sizeof(i)); + return ret > 0 ? (int)len : ret; +} + /** No completion. */ static int comp_none(struct context *ctx, const struct token *token, @@ -10442,6 +10495,20 @@ comp_insertion_table_type(struct context *ctx, const struct token *token, return -1; } +/** Complete available Hash Calculation Table types. */ +static int +comp_hash_table_type(struct context *ctx, const struct token *token, + unsigned int ent, char *buf, unsigned int size) +{ + RTE_SET_USED(ctx); + RTE_SET_USED(token); + if (!buf) + return RTE_DIM(table_hash_funcs); + if (ent < RTE_DIM(table_hash_funcs) - 1) + return rte_strscpy(buf, table_hash_funcs[ent], size); + return -1; +} + /** Internal context. */ static struct context cmd_flow_context;