From patchwork Mon Apr 17 04:31:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 126155 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA09842967; Mon, 17 Apr 2023 06:31:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4231B41144; Mon, 17 Apr 2023 06:31:58 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2077.outbound.protection.outlook.com [40.107.223.77]) by mails.dpdk.org (Postfix) with ESMTP id D603640DFB for ; Mon, 17 Apr 2023 06:31:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NqZNYHFQDvs08L832V4P4d1V1LPWC4c128I3OovxKQQsBmXupt1S1HIaNshdM3yTiXunDowOHWLXWd1jhGDo011NAiyrjP8BVjGZBpaHiW2ZHYDShm5GSIMXB8senaiZc+zEsM8FHsD2C29WKuvVcGpe+53sr056W3gmVlFh6RwU39Ao3ex2THOhcVSKbJAmLX8BPq70zUxyaqojUzrdMMtqf0wK/TQADJMhC0ynWs8tzkwN3q/NYTA8s1pz9ivJuAbl/d/h3TRRLqqCQWx1m/zwoC4SlxcVipNVhDfLtC4K7Dg5xb0eBHhqZUZrl1/myGN3gvq40Zaa3RtvNAAn7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iXfbbUwYLji8ewfVcgq+kPKrTKgAjpQrVEO056AAvls=; b=Eacza7gTW9a9tIDiZ7Ot8aAk0Qwd2esRSjYyJE/JFTmUwyTLQ5kbHEhOp0DDib6QTMu/RKkDpJi3s0Vk9TTTVy/2ldh9HQ+5yKPB8IeGBMLYjPlVbapSUFYJ0PfkO64NlceHoqG6jd4ZOjHyz1zTa3SKu1MJ31cBO5MvJ6hRdY+Ce0SyjC0FrdCnQVoDv2IKvpoSJY7JQJegofxsKMIoxaPNBBFA1rPy/24RbQScCaGjFroyoXAsGhRHOGYI0mxCQV2tnKy29phFvCuPSGMiO/avJNGvvUHl63lz/g5Quj+l3Fv8qkJGhbQCkOj9jMfIwvRjJ4phE4Q/dIFwOnKLew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iXfbbUwYLji8ewfVcgq+kPKrTKgAjpQrVEO056AAvls=; b=CIn15/e4Ut+J4USW4/QaJvdcDhrF2oF5q8IwXb/2XHYPxWyzYYYOOUAeMDuuPkO1IkzyuBQHO7nMVYhNJSaE5JVdHnLik1lJzxMUZvwvMrlxAqxhVg+ARN8TGjlIrZCL6RhWs7tSOc7rRJDVrWRNKxeeMMBBNd8eaGK2hi1Su+o= Received: from SJ0PR13CA0212.namprd13.prod.outlook.com (2603:10b6:a03:2c1::7) by CH3PR12MB8935.namprd12.prod.outlook.com (2603:10b6:610:169::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Mon, 17 Apr 2023 04:31:52 +0000 Received: from CO1PEPF00001A64.namprd05.prod.outlook.com (2603:10b6:a03:2c1:cafe::da) by SJ0PR13CA0212.outlook.office365.com (2603:10b6:a03:2c1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.19 via Frontend Transport; Mon, 17 Apr 2023 04:31:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF00001A64.mail.protection.outlook.com (10.167.241.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6319.14 via Frontend Transport; Mon, 17 Apr 2023 04:31:50 +0000 Received: from telco-siena.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sun, 16 Apr 2023 23:31:49 -0500 From: Sivaprasad Tummala To: CC: Subject: [PATCH v3 1/4] doc: announce new cpu flag added to rte_cpu_flag_t Date: Sun, 16 Apr 2023 21:31:36 -0700 Message-ID: <20230417043136.470110-1-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230413115334.43172-2-sivaprasad.tummala@amd.com> References: <20230413115334.43172-2-sivaprasad.tummala@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF00001A64:EE_|CH3PR12MB8935:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f37005e-12ba-4a39-b28d-08db3efcaa0a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5BNpnp6tJvF5UXtF+iU5qwr/azujsio0bluUmdIho+bTGR9WF+VcyoqnI/96fCLqK+eLwll/F4mw8adx+sO1zEz9HsklPr9uZtdj06kmBtdOkohDt6/KrAHD3z+S8qUyBHEaSH+2NsqifZ1FEqGbZBu63N8CV5jwraNeburlho4JrapiviW1hxy7f6pyoC5E9tD4rRF6bRozh8K72vuA7MTc+kp3xRF99IorP3gFrhryOPQ8xhY1MHJbq46aecGEs/vjRKoo/FMDCkMkpzyTCOYCUa8Q81xSaX7+nah51vZZ+rCLIHnaKLiMjSFJfYUq0l69nYauUwZYATDkHR9nr471csPtTTeyfSLb39w5DTEOgD5MjWN4ZmR4TawnEa/RGTn3KI8LTg5YMND4RtIiNLKAbVRhYl8F8ob0njDjHoeuoh2sgAOhssRvgLHziXRCLwoZa6LNxg5LMTpZrUo6GKf044/4Ona/znVvpG8u6iNrZ21TFlaNIWnfkjDqRVMdB9gJQEK/sb+i5zrEQz/+wY4TwHZNNVQLLQGBIkxVhNSpx5uTf6WnRVQG0nIpbOvDjYU2GkYHdLqzN75vSuO5aVbTDkMEc9i/326Ysey3fni2sZhgrXpVJNvT4wfCeyiG0ryqivFZIjSICWR4cYvJFIrfkW6r7jgF7BTm3ocruREMBjQI1bU1Z3Xyq9yaPWsrxy6B+l+7Gs4nwtzq9wQIQPhTlTY2tMSCeedhpcUz09s= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199021)(36840700001)(40470700004)(46966006)(5660300002)(4744005)(7696005)(40460700003)(6916009)(2906002)(4326008)(36756003)(70586007)(70206006)(44832011)(86362001)(8936002)(81166007)(6666004)(82310400005)(41300700001)(478600001)(356005)(8676002)(82740400003)(316002)(40480700001)(1076003)(26005)(336012)(426003)(36860700001)(2616005)(16526019)(186003)(47076005)(83380400001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 04:31:50.7159 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f37005e-12ba-4a39-b28d-08db3efcaa0a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00001A64.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8935 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org A new flag RTE_CPUFLAG_MONITORX is added to rte_cpu_flag_t in DPDK 23.07 release to support monitorx instruction on EPYC processors. This results in ABI breakage for legacy apps. Signed-off-by: Sivaprasad Tummala --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index dcc1ca1696..831713983f 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -163,3 +163,6 @@ Deprecation Notices The new port library API (functions rte_swx_port_*) will gradually transition from experimental to stable status starting with DPDK 23.07 release. + +* eal/x86: The enum ``rte_cpu_flag_t`` will be extended with a new cpu flag + ``RTE_CPUFLAG_MONITORX`` to support monitorx instruction on EPYC processors. From patchwork Tue Apr 18 08:25:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 126221 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66A704297B; Tue, 18 Apr 2023 10:26:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C23A42B8E; Tue, 18 Apr 2023 10:26:00 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2075.outbound.protection.outlook.com [40.107.237.75]) by mails.dpdk.org (Postfix) with ESMTP id 049D040698 for ; Tue, 18 Apr 2023 10:25:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PX5TY3ebbt6WVBqxz/fJIeKSTAFttXevZvKNwm2sYGQtjcvttTuTXb1DVfT0vXNJya1kGDY+BFy590JuR72wiZtXj9z3Z5o6n/NL7OVxhbyY5krU0FJw6CtKSajqFer79CJ2CJFt4Jl+O77yfWaLTdSejY5NYi9SgcxSm6nqU1Xlp2j3R61Lj99nc3fSPhcRfIYLffwPsR14bzU50PeMt3wif+zgs4OLUvy4ItdUo56Vw1g2eTCVTDmzOZeIbAbcrOEzQdzkAaAiybZpCnv4gv3UlZzKQ0F3M9/GCIKJjIA1v5uiJ3tcksGX9KJlZH6UYVqdw2xVM+BGLcJAoh28bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DmsDhuU99Dg1CaEhMe2C9LrNPROBdfWYRCv5XVjQG3M=; b=gLacJMu9thxlgh5qQ4cBQ5pxjQvYwlU3K6FiH7xTVqiBEeOpLtShHRZZSTdPahboXSV4nXvTYEWBTBVBg42196s54Jo59ZmzYgyGuqhckD4IJvyofCUo+5X6+Hv/EWMO0Ghh/sI3tg8WjWmC5+7xxW2JybzFJ+AGSP+qU6SHxjb7kR1dDJQ6KKY/I20tV4d1aQJhZRXi+/Btqkh06uBRJDQ9G9jPyUqEfOCYjzh+eSW9rWsloKW8gVLLWyzBdSB8HZSyYxqCIyljb+SIOfVA0uYK4ucojBg4UjyASGhgkvbhmkD6reOFycRkcmxHQLyKWft85ge5nG0rQifD4oHoYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DmsDhuU99Dg1CaEhMe2C9LrNPROBdfWYRCv5XVjQG3M=; b=KL7Qj6kz/eJV/8Gxu5kt5WqsrQajHemveG6gg2v1GXj6BCdGy3Q6XzSxyjmxPku3rKzabMEhfnVDEkCYIGTWediytzR2M2WtSPyuOo2BinlUZR2XFmqq89lLcsaS8yVv/Um94PR3BGinXM7HW05+D9xD1HKBvJ60r5hIYyDq+3A= Received: from BN9PR03CA0277.namprd03.prod.outlook.com (2603:10b6:408:f5::12) by SJ1PR12MB6194.namprd12.prod.outlook.com (2603:10b6:a03:458::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 08:25:56 +0000 Received: from BN8NAM11FT053.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f5:cafe::7d) by BN9PR03CA0277.outlook.office365.com (2603:10b6:408:f5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.47 via Frontend Transport; Tue, 18 Apr 2023 08:25:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT053.mail.protection.outlook.com (10.13.177.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6319.20 via Frontend Transport; Tue, 18 Apr 2023 08:25:55 +0000 Received: from telco-siena.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 18 Apr 2023 03:25:52 -0500 From: Sivaprasad Tummala To: CC: , , Subject: [PATCH v4 2/4] eal: add x86 cpuid support for monitorx Date: Tue, 18 Apr 2023 01:25:27 -0700 Message-ID: <20230418082529.544777-3-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230418082529.544777-1-sivaprasad.tummala@amd.com> References: <20230417043136.470110-1-sivaprasad.tummala@amd.com> <20230418082529.544777-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT053:EE_|SJ1PR12MB6194:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ccb06bb-d723-4053-1973-08db3fe687ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CODmPn3voxXCLrvzog1kLTLBUMCxfzUpO6+dVU0qPk8Kyewkqkjl+bijldCZ/EGFmoOYun7P64XAjiXhf5zlWbi/+OALYhQGPCoIdcoWoxAzRZjQ4JsHLCHDx3wXPm/s8EbDzusOqiM8yk90g77WCaQf5KEeokJ7WMM9gDiBLb4BmrI1LGkF5QEv8uYYf59s5cg7akQR7a/tcShgJ5EFw00oudfFpECjSgwBSC9RZlm/Ycna4POcRl7pXYo5Y4Zv03zPuhs/fXD2naiO5QElRLjNoWJwZWcQVsYuemMiEGULn0eDy87OBtgxjGE4722d8On+GxcTbO61SP4tNmowsuFWhCouCxUmbTG263OsizHfhmF5D9ZoqAfILhP7JSYQpScTqJ5n8GouphYIjjbu5vWsHW89LlKPO+hl0pUlpYYnvTJQ5JfItjpFmColUOMDeakgPFc8Wc/ZPSYyF+0vDrQ5eWANU5mQ4ytSh/Hj1/I4tzH8QuZmLmt8KEzL6UnFplcTnTPzuBCTmRY/pCkRU3z0IaJpdxaaGclzZ08mpv3OA3bv8b2RgDBBmRYHINC6xI+OKoo/z3G6G3ftEsoQpS3N1c+776xhR/Bx0SLeavc0NyZmDlnMEflBoNTga/AEAJsV4GkB2KFHgJqOyTWfSRZjApJcLcf2CQmRJ+LTxLcawRCukPbETTkdy4m9ftflwgHMLX/wlsi3kOp0UevZ8fgzXC4Q2MAmTDAvY+8PBno= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199021)(40470700004)(36840700001)(46966006)(356005)(81166007)(2906002)(82740400003)(40480700001)(40460700003)(478600001)(7696005)(6666004)(2616005)(47076005)(36860700001)(1076003)(26005)(426003)(336012)(86362001)(16526019)(186003)(36756003)(41300700001)(44832011)(316002)(5660300002)(8676002)(8936002)(82310400005)(54906003)(6916009)(4326008)(70206006)(70586007)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 08:25:55.6047 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7ccb06bb-d723-4053-1973-08db3fe687ce X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT053.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6194 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add a new CPUID flag to indicate support for monitorx instruction on AMD EPYC processors. Signed-off-by: Sivaprasad Tummala Acked-by: Anatoly Burakov --- lib/eal/x86/include/rte_cpuflags.h | 1 + lib/eal/x86/rte_cpuflags.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/lib/eal/x86/include/rte_cpuflags.h b/lib/eal/x86/include/rte_cpuflags.h index 92e90fb6e0..d3e608533a 100644 --- a/lib/eal/x86/include/rte_cpuflags.h +++ b/lib/eal/x86/include/rte_cpuflags.h @@ -133,6 +133,7 @@ enum rte_cpu_flag_t { RTE_CPUFLAG_AVX512VP2INTERSECT, /**< AVX512 Two Register Intersection */ RTE_CPUFLAG_WAITPKG, /**< UMONITOR/UMWAIT/TPAUSE */ + RTE_CPUFLAG_MONITORX, /**< MONITORX */ /* The last item */ RTE_CPUFLAG_NUMFLAGS, /**< This should always be the last! */ diff --git a/lib/eal/x86/rte_cpuflags.c b/lib/eal/x86/rte_cpuflags.c index d6b518251b..22f3bed412 100644 --- a/lib/eal/x86/rte_cpuflags.c +++ b/lib/eal/x86/rte_cpuflags.c @@ -133,6 +133,7 @@ const struct feature_entry rte_cpu_feature_table[] = { FEAT_DEF(LAHF_SAHF, 0x80000001, 0, RTE_REG_ECX, 0) FEAT_DEF(LZCNT, 0x80000001, 0, RTE_REG_ECX, 4) + FEAT_DEF(MONITORX, 0x80000001, 0, RTE_REG_ECX, 29) FEAT_DEF(SYSCALL, 0x80000001, 0, RTE_REG_EDX, 11) FEAT_DEF(XD, 0x80000001, 0, RTE_REG_EDX, 20) @@ -191,5 +192,7 @@ rte_cpu_get_intrinsics_support(struct rte_cpu_intrinsics *intrinsics) intrinsics->power_pause = 1; if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_RTM)) intrinsics->power_monitor_multi = 1; + } else if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_MONITORX)) { + intrinsics->power_monitor = 1; } } From patchwork Tue Apr 18 08:25:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 126222 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05DD54297B; Tue, 18 Apr 2023 10:26:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB0A342D12; Tue, 18 Apr 2023 10:26:01 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2077.outbound.protection.outlook.com [40.107.96.77]) by mails.dpdk.org (Postfix) with ESMTP id EDAD740698 for ; Tue, 18 Apr 2023 10:25:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cOre72GcdbnsaTf7A5Rr+2BBTX5zqKM2CgL1uITz6wBajSKXl0MU6AQlpQXD1r4sAUt+6xdeSPNV8VUkKwMVUBIokQRAVcDEKSQmFNG8OnCc8uYry2JM/u/7R/d+0kkKTLLkY7ioq7cQKPDHlspeaVNIOU+Fi+R0DMqUPOzYV1o//Y1sQfLtUnylltRmEk5PygFER18T2KUt84WDoJmYwjU2MNeNDNDgdMrfx7Vhyf4kxtH2paF4bIKUa2HXD8gJ8G+47ZAjQ8K0WZSCfT5yvHp+yIrY7oAi6Hai2rtJyp5ohkUPVCL/N/tdNrOthHVJVnb+U6p+Z5mQff8vA4xhCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/47gIOdB443xbyKMCwhRGd49jCfvw7aIQx2/gaXe+A8=; b=dpGsSg5/klFWH1h9J8Hi8U91Ujqj9onpetS0DvyfBDrKeKbXaKo7txP1DO941Lr2lf4LFwAIXIZV7PB8tsnASr/kzrFbigCoehx8UyeTC1De/Q+3yQ+yHYEPFQivZ2uLsUO0xmngEtslTxZwosfesw5Xd2Ii314P+lqGukfQVNeQjj0lQhYfFb9VwA3gBs8vEKv3hcst7/wQb8dV2xDUnOl2tZrTKbV42EqUtW1ZoblIzr5OF3iXmhQVv5UBz5xiOzNBewf9lCdoll0wkeBLP4Co4tZZg57XWxlLaYPhmbkkwKWSLeJTQvu4gvxVBX01O6M/SPxojqHVI+rKoq950A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/47gIOdB443xbyKMCwhRGd49jCfvw7aIQx2/gaXe+A8=; b=p8b7d4jtI7gZ3CaVkbCXbq8W9Wfxr7GeyBVA1O1trfMd+UQS7NUVB0GEU6Qaf5hnbG2jxaC88VmKkndMjspWn5p1lya564eDa8/RGWST38nstnDSb1towj/VGSxglzOSa1DXR4aJgRwY7A/qBjtknUqHUVKJ9XYCs13muiIkq+8= Received: from BN9PR03CA0272.namprd03.prod.outlook.com (2603:10b6:408:f5::7) by DM6PR12MB4895.namprd12.prod.outlook.com (2603:10b6:5:1bc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 08:25:56 +0000 Received: from BN8NAM11FT053.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f5:cafe::d0) by BN9PR03CA0272.outlook.office365.com (2603:10b6:408:f5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.47 via Frontend Transport; Tue, 18 Apr 2023 08:25:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT053.mail.protection.outlook.com (10.13.177.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6319.20 via Frontend Transport; Tue, 18 Apr 2023 08:25:56 +0000 Received: from telco-siena.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 18 Apr 2023 03:25:52 -0500 From: Sivaprasad Tummala To: CC: , , Subject: [PATCH v4 3/4] eal: removed unnecessary checks in x86 power monitor APIs Date: Tue, 18 Apr 2023 01:25:28 -0700 Message-ID: <20230418082529.544777-4-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230418082529.544777-1-sivaprasad.tummala@amd.com> References: <20230417043136.470110-1-sivaprasad.tummala@amd.com> <20230418082529.544777-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT053:EE_|DM6PR12MB4895:EE_ X-MS-Office365-Filtering-Correlation-Id: d3844ba9-b1ac-43ac-e921-08db3fe68861 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VosXStP5+aVO4Xe4UYOIWuHQo6O0iBQn2mdAvAxvE3N/bAy/SyopbtQAOVlnKH8zN4kUR3bq8kXeJB+2DPcCt4JhIpsVjwSeH3dp/TTB/wX/UwwFhKppUcoaEqSh8joypKVz5eE/ivhp3dADRpa7OnCRoxJD05V2x3wXNyU5uid8j1QjXPiItR2vfIPJ7ZAyZCoiN0Ffh5rSRdTt2yfC+zfcTBClam0+x9DNPXHrhIPWVcjtTyunAlRWQTPrMMxHJH5ALUwAmNp18IB1d8n6AzljHiBcc/eIEwNF9fkQuszehX3Hx6oTjeo+z4vo2Xl001e0EvImAPWr9od+cHn9myFNAWLBIlWvHXlRCtZXdYxo5uDdOj6jR7nt7OM4GYK9wGfGJB9XrXj5sbHnUlRECck/3J0EmCeFKjF7T2Rq7KMV0PMq8whaxpkwJWVyryzHo964cFgpOCZCVpup/wp7ci485prCK0NTnG4wEzUp8MfrR1QJYWqq89+tGT9QVc/5mXRh8N0QkIcw2KZ43Y5mtQ8yOdMs3RDpjzZ+V+ULyYD1caGPaEPd10U9Z0YChF6Y+sN3hKeSz9APXBIXwTTvVd/wOSBg3fLoCuHO4tLmVSygYJLgZhNcRV+rsWBWOUItBy1VeuwjzeruKKQt7OUP8vj/Z2EcK5Sy6p7IFaV36tofnh6V1c7qeC0Ku7Es5EKD2M7km5VPFl4CIr11MC+vpDQSPouNTmpq1mcVXp+58Hs= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199021)(36840700001)(40470700004)(46966006)(36756003)(8936002)(8676002)(40460700003)(44832011)(5660300002)(2906002)(82310400005)(86362001)(40480700001)(478600001)(7696005)(6666004)(54906003)(16526019)(186003)(2616005)(36860700001)(1076003)(70586007)(70206006)(26005)(41300700001)(356005)(82740400003)(316002)(83380400001)(81166007)(6916009)(4326008)(47076005)(426003)(336012)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 08:25:56.5734 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d3844ba9-b1ac-43ac-e921-08db3fe68861 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT053.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4895 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org current x86 power monitor implementation fails on platforms with only monitor supported and not power_pause. Signed-off-by: Sivaprasad Tummala Acked-by: Anatoly Burakov --- lib/eal/x86/rte_power_intrinsics.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/eal/x86/rte_power_intrinsics.c b/lib/eal/x86/rte_power_intrinsics.c index f749da9b85..6eb9e50807 100644 --- a/lib/eal/x86/rte_power_intrinsics.c +++ b/lib/eal/x86/rte_power_intrinsics.c @@ -30,6 +30,7 @@ __umwait_wakeup(volatile void *addr) static bool wait_supported; static bool wait_multi_supported; +static bool monitor_supported; static inline uint64_t __get_umwait_val(const volatile void *p, const uint8_t sz) @@ -81,7 +82,7 @@ rte_power_monitor(const struct rte_power_monitor_cond *pmc, uint64_t cur_value; /* prevent user from running this instruction if it's not supported */ - if (!wait_supported) + if (!monitor_supported) return -ENOTSUP; /* prevent non-EAL thread from using this API */ @@ -170,6 +171,8 @@ RTE_INIT(rte_power_intrinsics_init) { wait_supported = 1; if (i.power_monitor_multi) wait_multi_supported = 1; + if (i.power_monitor) + monitor_supported = 1; } int @@ -178,7 +181,7 @@ rte_power_monitor_wakeup(const unsigned int lcore_id) struct power_wait_status *s; /* prevent user from running this instruction if it's not supported */ - if (!wait_supported) + if (!monitor_supported) return -ENOTSUP; /* prevent buffer overrun */