From patchwork Thu May 18 21:59:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 127052 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D417542B3F; Fri, 19 May 2023 00:00:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA03241141; Fri, 19 May 2023 00:00:00 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2063.outbound.protection.outlook.com [40.107.94.63]) by mails.dpdk.org (Postfix) with ESMTP id 5658940E25 for ; Thu, 18 May 2023 23:59:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=huUWORiOaLw5RpZCSSer8hLdYSF5qB5/DWMEsilVXZkPLoIeav2/ILp21lZDRRkV9bCfxNXGgb46njlAl7Z0GbVV1GZgL6KZzrmfJ1m0Hm1Z1TzslDamHCG7VUiVIAb9Zgyp27MLe+VRK7gQTPbHKviBQ0Ffiz2MOHRnhpxLdUmMNy3C0XFDe2MrGKpT9qt37uoecEf0O9PxYgx8zejfoJiaBKWHjMcuQtgfkXVL0jmrQ5QLGobVsJQAgTm24S254vRPNRhjk94467/S19JFRV3DWSKY04+JqemGs+URUrA3MJCWyVD4Fagu/RCs8fYXcowOVfAJmqTv49kTEYFkDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iNSk3nimn0jtXF97XpZgYiJrl33+fbew0sO5g+Q1F/A=; b=Wr4XUmXuNzziZD36UIChzd4K6RfQnLd9i9IoWaVQD8QRRneqbpB1l1YuHKVWgVnG/il0Oeb7vJivxNDV2SfMH8U3szSEcxQaNfTBU9UI+z7Hnylmqk1I607aiNgC/Jz8QsY8L5SEXgo6PDUf7a7KRnPu1nFt9XgXK9sxICcLOt3QxawJ/dIiyWQAVgtejITJmKaZnQU/kP5Qg1jllec2DnRJ3xmzzu3App9DWAtzDChrx8Qh+hbjNUqfYbMPmuEsR20vGqxJh8DcDqxYDhuSOwKv4IRixWjOuHzT6zcVXv3xkvGWy4VRs1aPnivvdqhtoJiUFG769jdLagjtbG7+4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iNSk3nimn0jtXF97XpZgYiJrl33+fbew0sO5g+Q1F/A=; b=qrsj+g3hjLMzz5aXHml/9XmmsoGhAjyiPdPYHp3N+xdmMB7n5w1VOp0IcN6KVTvvpqA35b/zaMxHl5OS1aYwS82i0HBDpYfkN1NyE4q8M/4hszUnDwcs7xrFBrjfrZasVnsXaW1gLy5PTsHcm2y4B+wQwyQFTT386U8iwO9pZI0SUcn2PNpYB+sFEXc1OuTSjA3uyRFYrACH8E8RbOFBRYsFFUWSTnbuO12y1cJ7Xeg2/HqBsSUdrAbAh903Gs9IlqoXQEPF0u+xkZt8qSYX30ceuzK1GcMUmppsTt2yl4Ni2NO9kRDnxWqjBXeKFZT1dR/Lt7YDgvGB9Sd5YTedkg== Received: from MW4PR03CA0229.namprd03.prod.outlook.com (2603:10b6:303:b9::24) by MW4PR12MB7430.namprd12.prod.outlook.com (2603:10b6:303:224::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 21:59:56 +0000 Received: from CO1NAM11FT097.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b9:cafe::38) by MW4PR03CA0229.outlook.office365.com (2603:10b6:303:b9::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 21:59:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT097.mail.protection.outlook.com (10.13.175.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend Transport; Thu, 18 May 2023 21:59:56 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 18 May 2023 14:59:45 -0700 Received: from pegasus01.mtr.labs.mlnx (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 18 May 2023 14:59:43 -0700 From: Alexander Kozyrev To: CC: , , , Subject: [PATCH] ethdev: fix asynchronous destroy and push tracepoints Date: Fri, 19 May 2023 00:59:28 +0300 Message-ID: <20230518215928.2366851-1-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT097:EE_|MW4PR12MB7430:EE_ X-MS-Office365-Filtering-Correlation-Id: bf017182-0a41-4dee-0b05-08db57eb37c5 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dxhdaPhu63AlKstSSUbi9SU8j7alaOO4FqGiKuvaTdfzaKXYpXWjywx74jPMDY7451IJj7W+HfrNpdXT/Rin9FJqMQtjvnhc4ckp3ABpwaw5hTPHKwzhBW+T6b+IV5vBk0QmEK3Ejvx2ciOzpYMitntCB8HRr8/s2KOBAVqIgTI4VRoofsJ/3Y0sWoR6O5rEiAuTzUZ9RdV1NY8IblCqZzkFhFr3iI6kNJA2mBJvrW5nUY+LePitXplm8rUILHLsfMSHrRQFjX8l4QGcOG3UCZ+6eoMoUkE52VThUlK9a8Ex+hCaO1MaxPeqCS+WjsspALJGXXJrlLc+iT0K5F0KSdguCJCrM0CSfTcafoH46o9Ku/CIoIS545uqG+SoP0Nr8VbOQepHfJuoajgIFF9BBh3sLL7Kt0y8Vc9rwltGWui0HmuMK9mEHzfZNTHO8/+F/UrLV1FI1+QnM8ip0XJtM4vXcfPPCN/v/+xjVHRn1LLxdvX4xOzqzJv9EIh7ca2Ns8/L6GphRAl0ZTIkGYTO9ZC1ry4rRwpERW7LpcuqAAU4f9fv94DrSqWQJpFyi63iJLrPMAreDE7UqW8g1ErqJkq+k18o7ebDoh7VLdeo3ZZMuLXz5vmImpwcHpxN017j+UTKpsr9wQ/8S+qsFO+u8Qnn5g+sllQpO0ha3REWR7+ERG8ubyBbPDh5BMpkd3FN/rQDWMy2v7+W6Bkr90PXObPa/svfi2qHTdS6WNaYPZM= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199021)(46966006)(40470700004)(36840700001)(40460700003)(1076003)(26005)(70586007)(186003)(16526019)(36860700001)(426003)(2616005)(83380400001)(47076005)(336012)(5660300002)(70206006)(4326008)(316002)(41300700001)(6916009)(8936002)(8676002)(6666004)(54906003)(2906002)(40480700001)(86362001)(36756003)(478600001)(356005)(82310400005)(82740400003)(7636003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 21:59:56.6711 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bf017182-0a41-4dee-0b05-08db57eb37c5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT097.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7430 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_flow_async_destroy() and rte_flow_push() API is intended to be as fast as possible and tracepoints for these functions must be marked as fast-path tracepoints. Fixes: 6679cf21d608 ("ethdev: add trace points") Signed-off-by: Alexander Kozyrev Acked-by: Ankur Dwivedi Acked-by: Ori Kam --- lib/ethdev/ethdev_trace.h | 42 +++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/lib/ethdev/ethdev_trace.h b/lib/ethdev/ethdev_trace.h index ba7871aa3e..c8498b19e3 100644 --- a/lib/ethdev/ethdev_trace.h +++ b/lib/ethdev/ethdev_trace.h @@ -1582,27 +1582,6 @@ RTE_TRACE_POINT( rte_trace_point_emit_int(ret); ) -RTE_TRACE_POINT( - rte_flow_trace_async_destroy, - RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, - const struct rte_flow_op_attr *op_attr, - const struct rte_flow *flow, const void *user_data, int ret), - rte_trace_point_emit_u16(port_id); - rte_trace_point_emit_u32(queue_id); - rte_trace_point_emit_ptr(op_attr); - rte_trace_point_emit_ptr(flow); - rte_trace_point_emit_ptr(user_data); - rte_trace_point_emit_int(ret); -) - -RTE_TRACE_POINT( - rte_flow_trace_push, - RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, int ret), - rte_trace_point_emit_u16(port_id); - rte_trace_point_emit_u32(queue_id); - rte_trace_point_emit_int(ret); -) - RTE_TRACE_POINT( rte_mtr_trace_capabilities_get, RTE_TRACE_POINT_ARGS(uint16_t port_id, @@ -2356,6 +2335,19 @@ RTE_TRACE_POINT_FP( rte_trace_point_emit_ptr(flow); ) +RTE_TRACE_POINT_FP( + rte_flow_trace_async_destroy, + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, + const struct rte_flow_op_attr *op_attr, + const struct rte_flow *flow, const void *user_data, int ret), + rte_trace_point_emit_u16(port_id); + rte_trace_point_emit_u32(queue_id); + rte_trace_point_emit_ptr(op_attr); + rte_trace_point_emit_ptr(flow); + rte_trace_point_emit_ptr(user_data); + rte_trace_point_emit_int(ret); +) + RTE_TRACE_POINT_FP( rte_flow_trace_async_update, RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, @@ -2374,6 +2366,14 @@ RTE_TRACE_POINT_FP( rte_trace_point_emit_int(ret); ) +RTE_TRACE_POINT_FP( + rte_flow_trace_push, + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, int ret), + rte_trace_point_emit_u16(port_id); + rte_trace_point_emit_u32(queue_id); + rte_trace_point_emit_int(ret); +) + RTE_TRACE_POINT_FP( rte_flow_trace_pull, RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id,