From patchwork Tue May 23 17:36:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 127224 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F04EC42B83; Tue, 23 May 2023 19:36:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CB6E40689; Tue, 23 May 2023 19:36:52 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2046.outbound.protection.outlook.com [40.107.243.46]) by mails.dpdk.org (Postfix) with ESMTP id 690394014F for ; Tue, 23 May 2023 19:36:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H6cUlEXifCANns36hMxrM1xOCbr1rktCQ9Rx+Zr0PEivX8n+aSOK3zmU1yFV65jnbIZ7dxi6u93EpGRVYETGxyTwXvTna3Q0dIICdSjWidXwLRcFLOnZgJwdzLQS42hIvnDFQ0eR2V9YfHBzW9BkRNXkIUcDLahDmoAzjGXqjd2jZbjPNxz1Ou/RTtx+1RMsgsD06u6G/pzdZZKIcgNDr6y2Hh8DrApTsLrS8szM734it06CsRyc5SJDSgt5YNYIY5okYdLfawEGj3eZQD+wEdxhhuiENwsptZy1VQgZnJS+abt4ephh9EIoF7K8yj1dnxc6J/SHd9EHFkeWrxT4ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b1COzamyuotlviKBVQZxTihoCGiAnx+NErARyaBwCy8=; b=Qx0ODgBMq5/I+AW8H2zqr9afZg37cxB/vbvnIPx5gDItJ6ZeNmKyAg7S4OWQTWcmvA/HFtPkpplB6L0F0AjCJ8BOU9jxDtQPEwjrXrz0ILmZ5NeTOL9BvFujmIgdabXQ6RrZ1eBRRF/A+7jiGFq0WHW5Q0qOKajltgjBI5da0K34/OBgq0tAmVGJ6aXOe9ivFzW4UDQB7BRRKMZjkmNdSJziy0Ujar/6/ADHcUyvtz5uYkx6QfabLgv2Umb+VfCHQgaJ9dze1IOyJ8ghQBjBraQ1cQaImCPfS5otcmNMI3qNOmwRWjUGTpufGhWrSNlS+QbWKTudFygdUj/ZK2mARQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b1COzamyuotlviKBVQZxTihoCGiAnx+NErARyaBwCy8=; b=cp8na6moym6Rubkyc7/qwb3BX2B4sZsQBjlYVdS3yPYYOg6diUpggMn3FKWjolj53LP8rixj42QURsvr7mzwW8bQvEuKB2ocMScuEHLdJT7oKjZ+5V1ckmWdM5LXDlU/LvA5dBQN1NLCRNh+goNnLBgmY629DrEQW7tH4UiKbpj1HRKexAVk1rNGtITp1I8+ysdanH5zGgt5yEBtbGX2Q6zW4DqNzMx9umGqBkZbGLkgZNa1nSFS+6IPCjKMWQB04NlWcH2kqD4M+HDJBvJwARMkdpz1O71oUxQ4x2idDUVwcz4Nmdh5LOXRSUQzAmRyiImFhwI9DLYbjP6OZPydkw== Received: from BN1PR12CA0016.namprd12.prod.outlook.com (2603:10b6:408:e1::21) by BL0PR12MB4993.namprd12.prod.outlook.com (2603:10b6:208:17e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 17:36:49 +0000 Received: from BL02EPF000145BA.namprd05.prod.outlook.com (2603:10b6:408:e1:cafe::f9) by BN1PR12CA0016.outlook.office365.com (2603:10b6:408:e1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28 via Frontend Transport; Tue, 23 May 2023 17:36:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF000145BA.mail.protection.outlook.com (10.167.241.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.7 via Frontend Transport; Tue, 23 May 2023 17:36:49 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 23 May 2023 10:36:33 -0700 Received: from pegasus01.mtr.labs.mlnx (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 23 May 2023 10:36:31 -0700 From: Alexander Kozyrev To: CC: , , , Subject: [PATCH v2] ethdev: fix asynchronous destroy and push tracepoints Date: Tue, 23 May 2023 20:36:16 +0300 Message-ID: <20230523173616.3360211-1-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF000145BA:EE_|BL0PR12MB4993:EE_ X-MS-Office365-Filtering-Correlation-Id: 8828ebc0-75a0-4934-7991-08db5bb449cf X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JdVnOQFlNHkg2VUpGB3Jp1kmGl5pBEwh7XXL5Z6pyHFLTigtHaAzH1UO9WzOO6kc818L0oq2Y+Y+wWwz74VyF2hNHHJInqAKuNTdz8YOIlRZBjjdNX0Bu7HK3xz8DcQL+LnyF+lje8wp98X7XEkYGFM0J8lYUfHLqiGpKUgk6KRkFMgh3Eh7mfMtfl9rEaMzrlEA+kaT/7YGwV3YYzqfHngBFup5f/ZV6cWK7sxwip6Rnq5URcR5JhVHmAmY/bgvHnPqagaqlZBQbcrCO7Rph+dEViLGiygIy3xNeF33z4n7BrZMCfiM7nxcc0l9KOpIjBI5XQ2cIP7W1RcctXrunkMndWZHCls50rAIg76f6W9XSuXu/FFkRSwv6tdLgJCKprnXrzw7bjiuPoch3f5fOoCLu19rE718QFaYC4uApXgCVKrIZYK5FhQqphdRCD7OvGFoHChn+xr7EO5KNKCNQcsdVzyXCK0NCsVrWE6uGgL/wbYgUJpjco/UqOeu+F1vwOE8XqmlmDhZWox2bWD+gbovOQQM4lJKgqeNOosExmqnlTCEW0PuwWycl0MfiLVuKUDFEYIhMDTxUCRy+CGtumPppw8waUohvdvGShjX0g/YQ7Vr+B71CKz+iKP0r94wvmlBMyO+EkQzR0+0Tv7e88rHK1+elr1LqG2CrGahsXrTQxYz8VoCZw6Fpdyq/+cNu274su5VkiEVab0PExoacPhSAI4Pjk45TWTM/+094+E= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199021)(46966006)(40470700004)(36840700001)(36860700001)(47076005)(83380400001)(7636003)(82740400003)(1076003)(356005)(26005)(36756003)(2616005)(40480700001)(40460700003)(186003)(16526019)(2906002)(426003)(336012)(478600001)(316002)(70206006)(70586007)(4326008)(6916009)(6666004)(86362001)(41300700001)(5660300002)(8676002)(8936002)(82310400005)(54906003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 17:36:49.1444 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8828ebc0-75a0-4934-7991-08db5bb449cf X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF000145BA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4993 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_flow_async_destroy() and rte_flow_push() API is intended to be as fast as possible and tracepoints for these functions must be marked as fast-path tracepoints. Fixes: 6679cf21d608 ("ethdev: add trace points") Signed-off-by: Alexander Kozyrev Acked-by: Ankur Dwivedi Acked-by: Ori Kam --- lib/ethdev/ethdev_trace.h | 42 +++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/lib/ethdev/ethdev_trace.h b/lib/ethdev/ethdev_trace.h index 3dc7d028b8..18bf1a706f 100644 --- a/lib/ethdev/ethdev_trace.h +++ b/lib/ethdev/ethdev_trace.h @@ -1582,27 +1582,6 @@ RTE_TRACE_POINT( rte_trace_point_emit_int(ret); ) -RTE_TRACE_POINT( - rte_flow_trace_async_destroy, - RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, - const struct rte_flow_op_attr *op_attr, - const struct rte_flow *flow, const void *user_data, int ret), - rte_trace_point_emit_u16(port_id); - rte_trace_point_emit_u32(queue_id); - rte_trace_point_emit_ptr(op_attr); - rte_trace_point_emit_ptr(flow); - rte_trace_point_emit_ptr(user_data); - rte_trace_point_emit_int(ret); -) - -RTE_TRACE_POINT( - rte_flow_trace_push, - RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, int ret), - rte_trace_point_emit_u16(port_id); - rte_trace_point_emit_u32(queue_id); - rte_trace_point_emit_int(ret); -) - RTE_TRACE_POINT( rte_mtr_trace_capabilities_get, RTE_TRACE_POINT_ARGS(uint16_t port_id, @@ -2345,6 +2324,27 @@ RTE_TRACE_POINT_FP( rte_trace_point_emit_ptr(flow); ) +RTE_TRACE_POINT_FP( + rte_flow_trace_async_destroy, + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, + const struct rte_flow_op_attr *op_attr, + const struct rte_flow *flow, const void *user_data, int ret), + rte_trace_point_emit_u16(port_id); + rte_trace_point_emit_u32(queue_id); + rte_trace_point_emit_ptr(op_attr); + rte_trace_point_emit_ptr(flow); + rte_trace_point_emit_ptr(user_data); + rte_trace_point_emit_int(ret); +) + +RTE_TRACE_POINT_FP( + rte_flow_trace_push, + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, int ret), + rte_trace_point_emit_u16(port_id); + rte_trace_point_emit_u32(queue_id); + rte_trace_point_emit_int(ret); +) + RTE_TRACE_POINT_FP( rte_flow_trace_pull, RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id,