From patchwork Thu Jun 8 02:59:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 128362 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 203BE42C57; Thu, 8 Jun 2023 04:59:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14E95427E9; Thu, 8 Jun 2023 04:59:29 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2100.outbound.protection.outlook.com [40.107.244.100]) by mails.dpdk.org (Postfix) with ESMTP id 5465E40042; Thu, 8 Jun 2023 04:59:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T1k4wrMlb1eFid5TlizQTmpVS7VEX/fVqJEhuhSDm89w3ndK7OgvRwgpTIgQf2MU8KVV1QjlDusiB7nI96OZGIvj3tH0msnhSemA/joPe0m+FsmHJ0fmVdIl82Eh3xTzSsuyZ4JLgoJ4XQT2L+6A9k+Gemsx80oWkA98Zd+Y/yEZboUz+/yRuqKnvuExObnO+XxTZscewWns024g5B1aog+bKBJbX7OuPpf4mCYM7zV/SB3JgvFstu60GxEnzUpElH6nSgrfCQpX01RJqSEbK/IxX6pQeyZh9gNviSMElz/+S2zGQuAq+e0Kuc4vOnvyTpvuHutzUbGtRbDEJWgOmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UpSueBezcGL0mnxqzluraoCzm+KvShDlYr9Z3tjJdQw=; b=FelhnWPFGNcnMm0KqmLB1AkWRHNH2PvyHKJiWVZ72G6Ua0JtoFndJyQ32NQleX4oPI5VpuK59eqQnnxfsS9Brf+LiUn8mQ7w7uNYAfsNYa4dBZQAPhviY7tAGGerQoCCpgUqii+5F5iD8SaMYlMF1Bu2T/cDoE8/bJ8CUuOLQoMX/4E/lAISe8/pZ7tX244WI+4xAbLjc9B7z7TA8h6t/BwFqoXaU4P82ajGO5XHsCoSZljqdJjzyD3KJ72ongaAhT+0V8L0dfH+F6wLNGYG1ayQoWPF78uIdQQGkvH4Iv8HH69fEzcBRNtmJyC/QtEUuJMMlMIlv5knFNiWow9QKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UpSueBezcGL0mnxqzluraoCzm+KvShDlYr9Z3tjJdQw=; b=qaH40+oEhl0fPUew5fzQEfcb48Yw0WfZwDYMg4JJGH1q0Q1l74eqUqzFK+oROkWR6ozgbg2WoWQDYmg5SXkz1or0IbvCTnweB1JOU/pdyTEJzKbiGw6LIrNQopXHLAagwtUceQvRxk7dxJ+iWeD4X2H41uUocSWzPLEYI8tTArA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BLAPR13MB4691.namprd13.prod.outlook.com (2603:10b6:208:306::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.36; Thu, 8 Jun 2023 02:59:23 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::d2cb:a650:e1ce:2174]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::d2cb:a650:e1ce:2174%3]) with mapi id 15.20.6455.030; Thu, 8 Jun 2023 02:59:23 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Long Wu , matan@mellanox.com, stable@dpdk.org, Chaoyong He Subject: [PATCH] net/bonding: fix destroy dedicated queues flow Date: Thu, 8 Jun 2023 10:59:03 +0800 Message-Id: <20230608025903.814504-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 X-ClientProxiedBy: BYAPR21CA0011.namprd21.prod.outlook.com (2603:10b6:a03:114::21) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BLAPR13MB4691:EE_ X-MS-Office365-Filtering-Correlation-Id: 91e67a90-696c-4059-5f31-08db67cc5cc2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: khMyXPYKVdl6wyzoL+uYl6GrybUmD3r0BwcQ5R056K7xvLl5rzneXhm5OfQohxWX1lA4iGxGw48ASzOt7hFyZ9mO9YpAVEBia5im/+zTJMoN44yKGaqU3m8mJhtx8KUcWVlMEEePwiHjYOjE7Fg0H1vvpILDKzc+u9DJ1aAD3pZ8bVGYcfTuTz6BIsHfzPoUTqJz0FxYAdXHpW9m1+3dbJdphaP4t+Yk3/cgWYt43oLcjPoJmaa1HfqlRRN/Q9+27m/wvPJkJM90c13dpkuwtlT4BF1Ry7u6CVWrg8kSl1CDeVpcAyen0fmkxK1TrOPpbNuA9KiiyTzK8wHwkNDSCYVc08DLK/LVo8ZeT23ztMEiiSXg9/bUp5dZiAHvEnQwhLMA19PC/7CaL00xhE726bAqCmEUr4tB3DozrCWnLS3tunR6tKJnnRTLrDY+fleTb4C52J2f/foDz2QhKXdzic54NBFznU5Zml8KRLZtUQOr9lUTLmYuZ8cUzZqd+8PbJgmIZLHGxPIoAH5cT/C22lEnJeQU/oC+fo3ElhUXyBsWQlxLquDmdVPRDrKmh0/WsgobvvnCZrKDEAN71QvhI7KDZjhFT++KmDT6BANyWfSosKB9aJX1nVn8RKOgRC1u58htFnyUTPMSyWWHLzlal3UAWumGG6sOLLwckQS3RdU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(396003)(39840400004)(376002)(366004)(451199021)(6486002)(52116002)(6666004)(2906002)(66946007)(66556008)(66476007)(54906003)(36756003)(38100700002)(5660300002)(8936002)(86362001)(8676002)(44832011)(41300700001)(6916009)(4326008)(316002)(38350700002)(478600001)(2616005)(1076003)(6506007)(6512007)(26005)(107886003)(186003)(83380400001)(66574015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?42RwRwY5KIpTnnl3atci9R4KNFq1?= =?utf-8?q?jbvg1MIIzqxBPwilXVE0Q2JwZ60Aj0mDVMdpMx00eqMI8miUVqV5YfNeMt0OT9E00?= =?utf-8?q?9Wr0T93HIgBgdoCnsdk6rPBDJOWhPntrvdw0Dw5nQkeA45kqVYcTxJsQz1grwm2YX?= =?utf-8?q?r7kJYegww5+tOuWxscrcDK2fa7R1aI3p94S9/S/b71mg/OvdaL6ycT2bn7qVoRVEA?= =?utf-8?q?cUt71xRgbwCgb7mqkPSSmUyLJcmWck7Ek8uIOGAO0XFF6M3rEjshmPr1rEYvs9hxH?= =?utf-8?q?ReaErRrgDbsyIloICoVZWsl8FXiQqhwcfXfoG/dx3dykhU+QeRMlz8mZbWw+Wz+Cu?= =?utf-8?q?7eROMTkiTqJKsMrfBWyanwIkRJ9+WfOGSXWdjNHx8JVlXc3fcNu8cOtYmXvk6Chqu?= =?utf-8?q?3/pmIOIhsoMha2bhG3zs1iAg3E8Rj/0KTtrhoY+jG77gJzMo406sEwPwuvBn19/+w?= =?utf-8?q?YE+Nf1QrMKZSq6sTSUhElOodRrnXDx31R4jWJvm45GtCfn87pTQH4byJHQ3/t3IpM?= =?utf-8?q?DwB1ryH9ChPlTaTDFyDpTT+iK64PFpTJyjDqHavkThe2m0uQPxnaKgw6kcgF4FqKy?= =?utf-8?q?Q3edOd19nqJpGKisLPEcJjTYuS+Qv+UCbcUiejrXrT99yZ7rZNMjQcCgTt4DI+cgD?= =?utf-8?q?krEWeTeuQ75ACF2Yt9j22Fkr6ajZ+fxX4rmC2bvjmQbo8R54OtdIo88QWBBvSz2YZ?= =?utf-8?q?zA+wLnEPCDq46zWRS6IFjScz3V48PhxF6/yZhmT+gKbYYnJqJiBz1epNh51EJEqtr?= =?utf-8?q?6wg2Sa9rYyQB8II2AJHvDPHqKuoWi6lLE7y0ZmTp0gbMdHTfddTzOSjS6khAWfMoR?= =?utf-8?q?55hnpQSDDxTgo6N//xnNjb8P5immYi6uFawnJBA3VqocypcLeJSkxSz/Ixi2JUC+I?= =?utf-8?q?ZMQPuZy+TQAmjq+g1W9sfx+dbb3nmmZ49uzQoTyXJBz+bq6XjkxAXAlBGCftUTHkX?= =?utf-8?q?P2XewyspQ+6J5pv7V7GLmnzimvnuhfvTyRfh24LC+XVzu0sIjzN08txQxKo+UCWV9?= =?utf-8?q?DZiLUcIesPRK+j5Z1/1evb7qWNX0YHUcRLSF1pI/4RMRvUAT7B2Iqn/oJRbZuTHk4?= =?utf-8?q?BreLbNE5oY5uCe/xhnGyYuMmiDPkvu1MgDsB+uKZKi9gr5HjEHWhMN1S5m67xro7F?= =?utf-8?q?mLfOo2GKAphv/fGq8KltetOtg54YQvG0XmCTmWER58m3E8YKf88QED0lRUAG0Ha1d?= =?utf-8?q?5GTgvl3WlrL5rNJBwWdSL61OZ9bkwX7euHmeQXi+OW89SBOdp/bE58zvLCPhJkNaO?= =?utf-8?q?ntKAG2p03bAEp6WDqWJmkMzHok+0sQxtEi633LtRxH5aV2XWTFGDj6aIRdZOYeos0?= =?utf-8?q?OemHHUQSMh4Sx9rfFkzmO2ogCpTr/6fXJIiTEUiaFjPP1WJ5b7/PDWP845srDW5g9?= =?utf-8?q?508brc2rKKThXtjM1hpC0Li/7D8PW8ZcEHJ+gE7P3oD2AJ63wpak3EuzGgbJsQaEN?= =?utf-8?q?3zra09/Sf07DplSN+5LMJ6yeMoy8yEOYg5R1WuFCDz2moVtOcZRf5i9E4cmDgKfZ6?= =?utf-8?q?VkHXhTmsPFRh1VX3jdrH/P4Z3HPJE6RCoQ=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91e67a90-696c-4059-5f31-08db67cc5cc2 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 02:59:23.2990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 42ZRx27+5lqSXeQWfgSDjUj11k4QErPl8cyyT5HgzO+Kl1nX+u6iTTEZC9kVCxK/dB7Mj/hyoXno22E3Pp7pBKqw2fLFwEZhk+zledV1gnM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR13MB4691 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Wu Bonding port in mode 4 enables dedicated queues, we will create a flow for this feature. So we need to destroy this flow when we remove the member port. Furthermore if we don't destroy the flow that created for dedicated queues when we remove the member port, maybe we couldn't add the member port to a new bonding port that needed dedicated queues. We add the destroy action in removing member port function. Fixes: 49dad9028e2a ("net/bonding: support flow API") Cc: matan@mellanox.com Cc: stable@dpdk.org Signed-off-by: Long Wu Reviewed-by: Niklas Söderlund Reviewed-by: Chaoyong He Acked-by: Min Hu (Connor) --- drivers/net/bonding/rte_eth_bond_api.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c index c0178369b4..85d0528b7c 100644 --- a/drivers/net/bonding/rte_eth_bond_api.c +++ b/drivers/net/bonding/rte_eth_bond_api.c @@ -712,6 +712,16 @@ __eth_bond_slave_remove_lock_free(uint16_t bonded_port_id, } } + /* Remove the dedicated queues flow */ + if (internals->mode == BONDING_MODE_8023AD && + internals->mode4.dedicated_queues.enabled == 1 && + internals->mode4.dedicated_queues.flow[slave_port_id] != NULL) { + rte_flow_destroy(slave_port_id, + internals->mode4.dedicated_queues.flow[slave_port_id], + &flow_error); + internals->mode4.dedicated_queues.flow[slave_port_id] = NULL; + } + slave_eth_dev = &rte_eth_devices[slave_port_id]; slave_remove(internals, slave_eth_dev); slave_eth_dev->data->dev_flags &= (~RTE_ETH_DEV_BONDED_SLAVE);