From patchwork Thu Jun 8 03:07:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 128363 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4490642C57; Thu, 8 Jun 2023 05:08:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D27C4410D3; Thu, 8 Jun 2023 05:08:24 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2138.outbound.protection.outlook.com [40.107.237.138]) by mails.dpdk.org (Postfix) with ESMTP id F133540042; Thu, 8 Jun 2023 05:08:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AqYKs4+JcwuX7rM4+X0m4a19pfg+zTU9jggQqhWXZWSa3T485pX7gzy8GQcTaq5E7RR5OpGCiRFF+v+47n9l9tD5hTEcwro+PKUBXGZlyHhF6RCmBKe3MMk3gIrKff8OBTjBmVs2sPhgq+cxSIS4VaxBHWUhuKZpt6kIbqmBs/B0tzwQJO20IA1nOPUJWYbyzOYWhH/S3lhxwZoWw9vvWoboWDtw/KQ9O6GflMHwQzOdq/q05w1kewzMoi6SLir4CtbwCY0CtIxxTDekGSZSeUyecFJ1SN7cs9Gz/UaFyEqWI+4ur7vWcig8FVrPkT4rBFiDYyWC+z/LEZrIWDR52g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DsYLJr6DqoUZ8cfftO+YOVDRCYkKRhW0JMnPu4mCAPY=; b=nwh3DD8P44yndr8uA3efutkaZwDbcQ2WeT9VF+AInQh9vxiJm5NS3Hqn0Wgma9PG7M19GXvKpGRzXH+5aWIs2dRAQUDoGgS3aBGQxQ3h8A/+DnCvY7eFFqfx3+F1Mbv7ue4gCYrGukNpshA6XNayl3Lw7Q/DyhPH13tj/Czv6/C9pVfMDulf0Aj3WP1k/R7JwSV5EyO8drdy/Vvg5Lg1Ql4CujfgkXl/QXGXWDjAIrT4RDz98CI8eWEp/VY0D8hUD5a4lUwMTnWObQ/as13nw4yGj+m5/CvKvugmUSSixCR4tQND3zSwCoc9gxcqv8fDG6a4UUl1szTfLVasblsS7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DsYLJr6DqoUZ8cfftO+YOVDRCYkKRhW0JMnPu4mCAPY=; b=KUi0tcmzMda+5HSx+19Aoro53/KgX7fU9BptL/mIyA5D+a15f8saeudR1U1KX3dEY9Q5k2J1kqbjI4J3ZocyI2yt473308smfqwlsN2DrdOvWZXb04FA5Y2XxGCDFcPnLt/qJoU4dkOU0fVM5UCG/ptZUwsdRRFWYUaLqQwHFDA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH0PR13MB5748.namprd13.prod.outlook.com (2603:10b6:510:123::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.31; Thu, 8 Jun 2023 03:08:21 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::d2cb:a650:e1ce:2174]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::d2cb:a650:e1ce:2174%3]) with mapi id 15.20.6455.030; Thu, 8 Jun 2023 03:08:21 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Qin Ke , Chaoyong He , stable@dpdk.org Subject: [PATCH] net/nfp: fix callback function pointer of disabling promisc Date: Thu, 8 Jun 2023 11:07:56 +0800 Message-Id: <20230608030756.814540-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 X-ClientProxiedBy: SG3P274CA0013.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::25) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH0PR13MB5748:EE_ X-MS-Office365-Filtering-Correlation-Id: a97502a2-f5be-46f9-1d64-08db67cd9d42 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kpVCWumn2T9g2q1LG4YzFkyyf05X1rySkuvowsXwso+trMHE262Et4d+FgWmDm9odiEHYMjC4ATBMvuojQcchjW7YN4n6vtCFCqBfzg63LdAfPrT6QjCIcGWDcxZf95ZpXa3iyXb0mAAJ5iaElunf7r2YQOg4lkeKRIkMAz/IJ/+wU0OHnB6BSGnw++kXrrmGJ/xKGcyUv5Up19i1RVKHEXCTNx9/nF2pmKF2rvwIMcdI8uWmiiKKTLMaFonEj7DIavJaGb9Ljlsqo57GnAXY+yUx/U7HWtcbgVZWqvSR9U5kpgCeXfiRc4oMssm5QtOhHd5n+HSffclcaPGmQgK4ckOP7TC701nLHJSHLWECHi2LGFNMVK8CMyMBsHxnt7DkWM/nVc0UldfzhQdAoOtj4c5rrtXmpmax0hgVVFYcMwKDFkJXN8RicolbkQ/E36n+6MxySks9hYbg+G9oLFC3h+OwhyONnrUsiKFLyRGAL+zwfKL91DkduszhRxkE8Bke8CeXSYEMZj+e+laKHA4LaN+cqLhE/y0/zbpQqhktdSTGFdhLrZA4LJ7woz4Dv+ZgFt1qxE/8oupypiuPoSbxlu8MyEAMmxxTsX3iDx2uNTmDIj4r7X675YgSsJ2CCll1uxle81L+6mGU5qaZ0sHsdInf42HuCiH57FVVSjX3rE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(346002)(136003)(366004)(376002)(39840400004)(451199021)(478600001)(2616005)(6486002)(36756003)(26005)(6506007)(186003)(86362001)(1076003)(6666004)(52116002)(6512007)(2906002)(83380400001)(450100002)(6916009)(8936002)(66946007)(66476007)(4326008)(5660300002)(8676002)(66556008)(38100700002)(38350700002)(41300700001)(316002)(54906003)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?DVIGFQvzS60yyD9rBnBrnYA+x7VH?= =?utf-8?q?9qRICauc7ovSZeMJhtUYYXEsoL/J/vd6dUA59BmV70Ju0pDgmwb+7jG1h7GX4Uqx0?= =?utf-8?q?fV+5kg3i/HCQR8E26u5jd+EfF2AnFymkasnwDModSveV6T5f726s6wJTpk191cgkR?= =?utf-8?q?Gqpz7KlvyrWISfeEHO5WBafx5wRoniuZzynix7OrntPdnVcWfH0zl5ZZGP82MsAd2?= =?utf-8?q?6aOh0TdGuxRKGEyK8Uiap2yxYclTaIzFVUWkSJhMKC1RsM2P8gn7gnXgx/HOb2vX3?= =?utf-8?q?0rexOvw90PguKxk9qskuBla5ATsX/+sIkZGgORfB2Vq8kDHQxXIOzXJ4tS98ZBTOR?= =?utf-8?q?PlhYtCM6lquJCaT5VxENGzeh6L5GemstyZvt0oiMFbB6qVyvRBnTsrwkAhI4C+ykU?= =?utf-8?q?gc2kwhbVrK3kMeVy0ccMTTtAIHaSbp00OLqXcHs97TpyiHM5lEiYe7DbTHlY5CsTk?= =?utf-8?q?eAmX0mt0+rohHOXyVzQE/5sEAFsfjUce++PiA/CiiIs+/Li4XtA+bzJSZee30NUWY?= =?utf-8?q?a/via2qTJBbHvMBBSye5vdrwkavYVsmw7sfgW/rMV7w3hW2QU6Mu1tJK6xPKONguS?= =?utf-8?q?gOxSQL0owW9n939rEeN6agxt0COaJ+m0vQmleBFoGBi9PWNU3rZJnFFnkDt0+Nilf?= =?utf-8?q?C+RD4B5aIrUK1d2Ff4PGenD5+bIAaNbgA/xamYbXlIdXQ+hZwG5VQXjBrROPDw0lE?= =?utf-8?q?LpgoNVhlJaWiX+wZanRm5ko5XXiulnsjSh+NBmnVvjOpXPh+HgWlXKN+Cru9T4E5x?= =?utf-8?q?vTZGn6L6EWFbg1vVxuRKsa7So0YzZgBCIlICO2nWdO0sxKKp9tWoJJ47LXiMCrBph?= =?utf-8?q?x3Oy0RXGoI+VVKQpeAyiR/C3qWDRaTgA7jKrtbxyheF+NqdjwnYENAjn5ARj1MsVw?= =?utf-8?q?isatbiWien2zWpNPyy1ldnDnhXWp6zwrspEF7aRZ6QWRsofoVCKv+4FC7DIFJmk/Y?= =?utf-8?q?0oG2OlKkEmSllENKvAytzLD5RSEwdanXkNUtr02hmsEKNCyJM/e4XWKtt/fXCCMiO?= =?utf-8?q?xgms/vUvoXHT0h8k01JlosbCXNokQ9OB+FlMUcx2BqDa8qBgGBG3miQYa7fqXE88Q?= =?utf-8?q?4M9o90b3D2UyExmBqDxWggonSQyN17lBeRaCWiy0tV8O8SQ8BtOXJg9xhlQhuajgc?= =?utf-8?q?hZazShmcUv+lVCFWvdw/GGkgSpmCQ6bwxaYxSv4hq9WDjCydrWuH4gjEAK2QtqufW?= =?utf-8?q?9MQIt1h3jFt9RgH+3F7dibZP3PNWerq4E4TyOVpOpHAol1NwKXlP8+FJfOisCZt/J?= =?utf-8?q?noZJAK5c1pxYLrAaylumjG9jPXHnygJLu/8q8ukZDQg5MXQf1QzJlKu4+6/kwE47m?= =?utf-8?q?nvNbhkPtw/xjtIPIRBRVb/TpOioEHMFZ8Ezo7V6nK4erRO4KzI0bQbH2fC43bv6ul?= =?utf-8?q?7bQDM/UhwyqhX77XKxuJK23OaTjCiJSqElt8Nh/4Lzf849JDbmAk/TuYUCTin7srK?= =?utf-8?q?+cVwcGGs6T/xSqtidmyRCrLpd1qWscVQYO/D7vHVawVAnqYHaCK1vCusAF1pRmCTL?= =?utf-8?q?vv/Fl4SrvVOILcw6UTuvSPU61jg63QuCgQ=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: a97502a2-f5be-46f9-1d64-08db67cd9d42 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 03:08:20.9526 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9TDNJOVegFbWfYvx2lo03cO7rFKWMNomCX3uYhz70dAPgxQMxHDFvEGGgwE39ai/7toiBJWtmKY5/wo1IbkTcL6pi1e8sXftQ8etX0gSYVI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5748 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Qin Ke The callback function of promiscuous_disable in nfp_flower_pf_repr_dev_ops and nfp_flower_repr_dev_ops should be nfp_net_promisc_disable, not nfp_net_promisc_enable, fix it. Fixes: 39d82d2 ("net/nfp: fix promiscuous mode for representor port") Cc: Chaoyong He Cc: stable@dpdk.org Signed-off-by: Qin Ke Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower_representor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c index 6b4ba5b9a2..3225a4b84a 100644 --- a/drivers/net/nfp/flower/nfp_flower_representor.c +++ b/drivers/net/nfp/flower/nfp_flower_representor.c @@ -518,7 +518,7 @@ static const struct eth_dev_ops nfp_flower_pf_repr_dev_ops = { .stats_reset = nfp_flower_repr_stats_reset, .promiscuous_enable = nfp_net_promisc_enable, - .promiscuous_disable = nfp_net_promisc_enable, + .promiscuous_disable = nfp_net_promisc_disable, .mac_addr_set = nfp_flower_repr_mac_addr_set, .fw_version_get = nfp_repr_firmware_version_get, @@ -540,7 +540,7 @@ static const struct eth_dev_ops nfp_flower_repr_dev_ops = { .stats_reset = nfp_flower_repr_stats_reset, .promiscuous_enable = nfp_net_promisc_enable, - .promiscuous_disable = nfp_net_promisc_enable, + .promiscuous_disable = nfp_net_promisc_disable, .mac_addr_set = nfp_flower_repr_mac_addr_set, .fw_version_get = nfp_repr_firmware_version_get,