From patchwork Mon Jul 10 23:51:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Long Li X-Patchwork-Id: 129433 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D85D342DDB; Tue, 11 Jul 2023 01:51:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C800340C35; Tue, 11 Jul 2023 01:51:51 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 885DA4003C for ; Tue, 11 Jul 2023 01:51:49 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1004) id C397E21C4254; Mon, 10 Jul 2023 16:51:48 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C397E21C4254 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxonhyperv.com; s=default; t=1689033108; bh=Y1Thn4Guw5/eNGVkF9e1xfOORJlSBF4g2cFWrpOUuuU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lSsbe/FMP006UJmOvjLoUYp9HiCEvYobmWENCXnwZFHJEZw75QqKTn/+aX2umFNqf Enf5UdTjsmcUMN2Woi5iiLXo0gLF1jKG1trp/inF457db0yLDy9Q/K+8fr8oCZ9lkU 6kQ8OcPWnjXcozVO4aYxap0qi1GmC+1Q7qFr7/Ag= From: longli@linuxonhyperv.com To: Ferruh Yigit , Andrew Rybchenko Cc: dev@dpdk.org, Ajay Sharma , Long Li Subject: [Patch v2] net/mana: use the correct WQE count for ringing RQ doorbell Date: Mon, 10 Jul 2023 16:51:47 -0700 Message-Id: <1689033107-4179-1-git-send-email-longli@linuxonhyperv.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1689024915-18270-1-git-send-email-longli@linuxonhyperv.com> References: <1689024915-18270-1-git-send-email-longli@linuxonhyperv.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Li The hardware specification specifies that WQE_COUNT should set to 0 for the Receive Queue. Although currently the hardware doesn't enforce the check, in the future releases it may check on this value. Signed-off-by: Long Li --- Change log: v2: added "Signed-off-by" drivers/net/mana/mana.h | 2 +- drivers/net/mana/rx.c | 11 +++++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/mana/mana.h b/drivers/net/mana/mana.h index dfeda531eb..5801491d75 100644 --- a/drivers/net/mana/mana.h +++ b/drivers/net/mana/mana.h @@ -457,7 +457,7 @@ extern int mana_logtype_init; int mana_ring_doorbell(void *db_page, enum gdma_queue_types queue_type, uint32_t queue_id, uint32_t tail, uint8_t arm); -int mana_rq_ring_doorbell(struct mana_rxq *rxq, uint8_t arm); +int mana_rq_ring_doorbell(struct mana_rxq *rxq); int gdma_post_work_request(struct mana_gdma_queue *queue, struct gdma_work_request *work_req, diff --git a/drivers/net/mana/rx.c b/drivers/net/mana/rx.c index b840e402f9..4b8aca49ef 100644 --- a/drivers/net/mana/rx.c +++ b/drivers/net/mana/rx.c @@ -22,7 +22,7 @@ static uint8_t mana_rss_hash_key_default[TOEPLITZ_HASH_KEY_SIZE_IN_BYTES] = { }; int -mana_rq_ring_doorbell(struct mana_rxq *rxq, uint8_t arm) +mana_rq_ring_doorbell(struct mana_rxq *rxq) { struct mana_priv *priv = rxq->priv; int ret; @@ -36,10 +36,13 @@ mana_rq_ring_doorbell(struct mana_rxq *rxq, uint8_t arm) db_page = process_priv->db_page; } + /* Hardware Spec specifies that software client should set 0 for + * wqe_cnt for Receive Queues. + */ ret = mana_ring_doorbell(db_page, GDMA_QUEUE_RECEIVE, rxq->gdma_rq.id, rxq->gdma_rq.head * GDMA_WQE_ALIGNMENT_UNIT_SIZE, - arm); + 0); if (ret) DP_LOG(ERR, "failed to ring RX doorbell ret %d", ret); @@ -120,7 +123,7 @@ mana_alloc_and_post_rx_wqes(struct mana_rxq *rxq) } } - mana_rq_ring_doorbell(rxq, rxq->num_desc); + mana_rq_ring_doorbell(rxq); return ret; } @@ -532,7 +535,7 @@ mana_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n) } if (wqe_posted) - mana_rq_ring_doorbell(rxq, wqe_posted); + mana_rq_ring_doorbell(rxq); return pkt_received; }