From patchwork Wed Jul 26 05:55:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rakesh Kudurumalla X-Patchwork-Id: 129706 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 758FF42F4B; Wed, 26 Jul 2023 07:55:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 047C240E25; Wed, 26 Jul 2023 07:55:17 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 012D540A79 for ; Wed, 26 Jul 2023 07:55:15 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36Q3WgZp024292; Tue, 25 Jul 2023 22:55:14 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=ZNTW6OLNjWKbOKjfADBLWp6P6mJ0n8cF78j7PjzVtzM=; b=F8iJZGn3NPD63fqOKkA2pBTuITpjsL87opb3gakSpL/1OWoDLUvhLbDV+9x0vLVjPV1G 3F9L+QHw7DCvalOiph7j5pZzY8EQHjgdDwJkHqLp1SheNkURME3iEjU3Tciq+8QtdgpL 1jNF+AWKEQJTCgR/s7yJ2rTxacnKYvt9TFuju0ghscYP+egUMBg/M0Yai/Oe49Mc4F2+ tM5C494E8G6xN76YtcijHAwk05GxfcuDU79gvQqyocv2iTPoEVI3isg56RQZAB73tUyR DleA5BZ8DzZeAwg5WKzsXH+5V1p1jZ0G9lQ0lhoVaV9oz9sYYHZQzHjQp3POj6SZ4v8B DA== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3s18r292up-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 25 Jul 2023 22:55:14 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 25 Jul 2023 22:55:12 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Tue, 25 Jul 2023 22:55:12 -0700 Received: from localhost.localdomain (unknown [10.28.36.154]) by maili.marvell.com (Postfix) with ESMTP id 6104F3F7075; Tue, 25 Jul 2023 22:55:10 -0700 (PDT) From: Rakesh Kudurumalla To: Olivier Matz CC: , , , "Rakesh Kudurumalla" Subject: [PATCH v2 1/1] app/test: resolve mbuf_test application failure Date: Wed, 26 Jul 2023 11:25:07 +0530 Message-ID: <20230726055507.1183617-1-rkudurumalla@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230426092750.2423850-1-rkudurumalla@marvell.com> References: <20230426092750.2423850-1-rkudurumalla@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: eGdefjk4LGFgHvMaQy3zra9tbPviK47_ X-Proofpoint-ORIG-GUID: eGdefjk4LGFgHvMaQy3zra9tbPviK47_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-25_14,2023-07-25_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org when RTE_ENABLE_ASSERT is defined test_mbuf application is failing because we are trying to attach extbuf to a cloned buffer to which external mbuf is already attached.To make test_mbuf pass CI we have updated ol_flags. This patch fixes the same. Signed-off-by: Rakesh Kudurumalla Acked-by: Olivier Matz --- v2 : Addressed comments by removing extbuf call as mbuf is already attached app/test/test_mbuf.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index efac01806b..722e1ef624 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -2345,16 +2345,13 @@ test_pktmbuf_ext_shinfo_init_helper(struct rte_mempool *pktmbuf_pool) GOTO_FAIL("%s: External buffer is not attached to mbuf\n", __func__); - /* allocate one more mbuf */ + /* allocate one more mbuf, it is attached to the same external buffer */ clone = rte_pktmbuf_clone(m, pktmbuf_pool); if (clone == NULL) GOTO_FAIL("%s: mbuf clone allocation failed!\n", __func__); if (rte_pktmbuf_pkt_len(clone) != 0) GOTO_FAIL("%s: Bad packet length\n", __func__); - /* attach the same external buffer to the cloned mbuf */ - rte_pktmbuf_attach_extbuf(clone, ext_buf_addr, buf_iova, buf_len, - ret_shinfo); if (clone->ol_flags != RTE_MBUF_F_EXTERNAL) GOTO_FAIL("%s: External buffer is not attached to mbuf\n", __func__);