From patchwork Tue Oct 31 14:57:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 133676 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2D4243252; Tue, 31 Oct 2023 15:58:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72C354029E; Tue, 31 Oct 2023 15:58:49 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id E44E040284 for ; Tue, 31 Oct 2023 15:58:47 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 832265C01F5; Tue, 31 Oct 2023 10:58:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 31 Oct 2023 10:58:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm3; t=1698764327; x=1698850727; bh=+WsCh3+pos iBF/7VhbBYY1D/XPySBXH22JWvc/eCJcI=; b=sOZBIMybAU4t1hqIEPzYlsGUHB zgtWM0/pRKGCu2jfr07L0RK4EgP9RlM2D4xUK6MNgbgX/AONvIUQ1quUTMnoMW97 11nGMwTRIAB/1kSTwKPXG43sZ7xJjq2vStwyr+iK9Y75w8t3rJ8iR98nDkqWd7fs RUBjjtT9QRkXvyv7y9BTDr+dIKP63xeKp0B+Y/UDXBiqqcp85wvrl/LqhfSBib9i KYlmSeIgZy56i9IMiuOiSCqnR4l8c5io51Sj6Lk13nVHvGtAe7IbgmDbY4UIrcZG Xhh+T8Vw8vKqExTE/aSuR3Lt6pmGBthpSOW1jr8SaMB5rFO73K062yz5VjVQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1698764327; x=1698850727; bh=+WsCh3+posiBF /7VhbBYY1D/XPySBXH22JWvc/eCJcI=; b=Xo/BKdjvebHojbm2QPBG0mNjX5m5b QUa5ZrYvonHZ7dD7jl1ZrxDSbMglLtdrDaXrku1CY/QA06K9EOvb/6wQgQEfAjdl cmJSVZ3qBEDEaNvCfGVrWsR68EZNZfkxNilKpsOLOzfRYEltxcm3Z3lpPO74zbZw uOxr2y4Y4uP3Y7mkD6WsArpjb0egrosqxv27900FoAvSrD2LTOqeoD98vkGSkKRb sa8iI1sT1D1Q/MNEXW3UGm1FeO5oikQG0X3MBAanXSq1zPBaIeEODwcYkfNFT2ta 8pl0qL+Qk3nmCTSdEV+32zLKUkwIcv7iOO9ZGpLS/n210Nd0b7LU2b6Ew== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddtvddgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeevveefveeiiefhtedukeegkeelieegffeukeevudetueffieduveet iedukeefleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 31 Oct 2023 10:58:45 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Matan Azrad , Viacheslav Ovsiienko , Tyler Retzlaff , Konstantin Ananyev , Andrew Rybchenko , =?utf-8?q?Morten_Br=C3=B8?= =?utf-8?q?rup?= Subject: [PATCH] vdpa/mlx5: revert event thread to normal priority Date: Tue, 31 Oct 2023 15:57:56 +0100 Message-ID: <20231031145756.517091-1-thomas@monjalon.net> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When converting to rte_thread API, the SCHED_RR policy has been translated into RTE_THREAD_PRIORITY_REALTIME_CRITICAL. But SCHED_RR was not effective prior to this conversion because PTHREAD_EXPLICIT_SCHED attribute was missing initially. Using the default priority RTE_THREAD_PRIORITY_NORMAL should revert to the original behaviour. By the way, RTE_THREAD_PRIORITY_REALTIME_CRITICAL is difficult to manage properly and is allowed only on Windows so far. Fixes: a7ba40b2b1bf ("drivers: convert to internal control threads") Signed-off-by: Thomas Monjalon Reviewed-by: Maxime Coquelin --- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c b/drivers/vdpa/mlx5/mlx5_vdpa_event.c index fa26471b18..9557c1042e 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c @@ -514,7 +514,6 @@ mlx5_vdpa_cqe_event_setup(struct mlx5_vdpa_priv *priv) DRV_LOG(ERR, "Failed to initialize thread attributes"); goto out; } - attr.priority = RTE_THREAD_PRIORITY_REALTIME_CRITICAL; if (priv->event_core != -1) CPU_SET(priv->event_core, &attr.cpuset); else