From patchwork Wed Nov 1 07:15:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ruifeng Wang X-Patchwork-Id: 133710 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8C244325D; Wed, 1 Nov 2023 08:16:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCD68402EA; Wed, 1 Nov 2023 08:16:50 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id D7F49400EF; Wed, 1 Nov 2023 08:16:48 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B54472F; Wed, 1 Nov 2023 00:17:29 -0700 (PDT) Received: from net-arm-n1amp-02.shanghai.arm.com (net-arm-n1amp-02.shanghai.arm.com [10.169.210.107]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3A3283F64C; Wed, 1 Nov 2023 00:16:43 -0700 (PDT) From: Ruifeng Wang To: Ori Kam , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Nelio Laranjeiro , Adrien Mazarguil Cc: dev@dpdk.org, honnappa.nagarahalli@arm.com, nd@arm.com, Ruifeng Wang , stable@dpdk.org, Luca Boccassi Subject: [PATCH] ethdev: fix 32-bit build with GCC-13 Date: Wed, 1 Nov 2023 15:15:54 +0800 Message-Id: <20231101071554.1316358-1-ruifeng.wang@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org aarch32 build with gcc-13.0.1 generated following warning: In function 'memcpy', inlined from 'rte_memcpy' at ../lib/eal/arm/include/rte_memcpy_32.h:296:9, inlined from 'rte_flow_conv_action_conf' at ../lib/ethdev/rte_flow.c:726:20, inlined from 'rte_flow_conv_actions' at ../lib/ethdev/rte_flow.c:936:10: warning: '__builtin_memcpy' specified bound 4294967264 exceeds maximum object size 2147483647 [-Wstringop-overflow=] The issue is due to possible wrapping in unsigned arithmetic. The 'size' can be 0. 'off' is 32. When 'tmp' is equal to (unsigned)-32, the copy length is more than half the address space. Hence the warning. Casted variables to 64-bit to avoid wrapping. Fixes: 063911ee1df4 ("ethdev: add flow API object converter") Cc: adrien.mazarguil@6wind.com Cc: stable@dpdk.org Reported-by: Luca Boccassi Signed-off-by: Ruifeng Wang Acked-by: Ori Kam Acked-by: Ferruh Yigit --- lib/ethdev/rte_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index 3a67f1aaba..2a5a057195 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_flow.c @@ -722,7 +722,7 @@ rte_flow_conv_action_conf(void *buf, const size_t size, if (src.rss->key_len && src.rss->key) { off = RTE_ALIGN_CEIL(off, sizeof(*dst.rss->key)); tmp = sizeof(*src.rss->key) * src.rss->key_len; - if (size >= off + tmp) + if (size >= (uint64_t)off + (uint64_t)tmp) dst.rss->key = rte_memcpy ((void *)((uintptr_t)dst.rss + off), src.rss->key, tmp); @@ -731,7 +731,7 @@ rte_flow_conv_action_conf(void *buf, const size_t size, if (src.rss->queue_num) { off = RTE_ALIGN_CEIL(off, sizeof(*dst.rss->queue)); tmp = sizeof(*src.rss->queue) * src.rss->queue_num; - if (size >= off + tmp) + if (size >= (uint64_t)off + (uint64_t)tmp) dst.rss->queue = rte_memcpy ((void *)((uintptr_t)dst.rss + off), src.rss->queue, tmp);