From patchwork Fri Nov 10 10:20:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mingjin Ye X-Patchwork-Id: 134103 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87C23432F3; Fri, 10 Nov 2023 11:31:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57DE440E5E; Fri, 10 Nov 2023 11:31:19 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id AF66C40291; Fri, 10 Nov 2023 11:31:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699612277; x=1731148277; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=TnghH9Q47QP/gt6Wksl17j80boAbrODhqIU0ZSVPulY=; b=jrtjk9EICsMaDBylkdKI7OYuS56DuRfnPhORKpTklNr1Liq/HFyq8lXZ EqGZ12na0IJXg2WjXX2iwh1jV6RBNr7/JRkGl7GK8+fSAEr+Dl0qAzQbc Dn8vvVs38voBGdKO/PmKRHGpLqdTUf8ATz2QOVHs9eYIe0/7SFkF4D3uv ytCruTUlKwZS5QhTWj3FkMC4/aEnqvzdTfYgcsnNTkUyen9NvrT4IVSdZ 8nUUL8gbv9cDRamcM4WoYQ2Ec/zsZOJ8vRC+TvOtoEJ775b9TZHxHxZCC 5zVBurCq3/Iatc/IRKP4NydDuzhZvQ5u/ZggPAJbAl5s4BhyRLtrOcBP8 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10889"; a="393041947" X-IronPort-AV: E=Sophos;i="6.03,291,1694761200"; d="scan'208";a="393041947" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2023 02:31:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10889"; a="757170382" X-IronPort-AV: E=Sophos;i="6.03,291,1694761200"; d="scan'208";a="757170382" Received: from unknown (HELO localhost.localdomain) ([10.239.252.253]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2023 02:31:13 -0800 From: Mingjin Ye To: dev@dpdk.org Cc: qiming.yang@intel.com, Mingjin Ye , stable@dpdk.org, Jingjing Wu , Beilei Xing Subject: [PATCH] net/iavf: fix error devargs parsing Date: Fri, 10 Nov 2023 10:20:15 +0000 Message-Id: <20231110102015.469031-1-mingjinx.ye@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch fixes an unknown parsing result without devarg "no-poll-on-link-down". Fixes: 5b3124a0a6ef ("net/iavf: support no polling when link down") Cc: stable@dpdk.org Signed-off-by: Mingjin Ye --- drivers/net/iavf/iavf_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 0c6ab4ac5a..6448c799e7 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -2294,7 +2294,7 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev) struct rte_kvargs *kvlist; int ret; int watchdog_period = -1; - uint16_t no_poll_on_link_down; + int no_poll_on_link_down = -1; if (!devargs) return 0; @@ -2329,10 +2329,10 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev) ad->devargs.watchdog_period = watchdog_period; ret = rte_kvargs_process(kvlist, IAVF_NO_POLL_ON_LINK_DOWN_ARG, - &parse_u16, &no_poll_on_link_down); + &parse_bool, &no_poll_on_link_down); if (ret) goto bail; - if (no_poll_on_link_down == 0) + if (no_poll_on_link_down == -1) ad->devargs.no_poll_on_link_down = 0; else ad->devargs.no_poll_on_link_down = 1;