From patchwork Mon Nov 13 17:20:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 134176 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D1F64331D; Mon, 13 Nov 2023 18:20:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F06304026F; Mon, 13 Nov 2023 18:20:42 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 993D64026C for ; Mon, 13 Nov 2023 18:20:40 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id E658F20B74C1; Mon, 13 Nov 2023 09:20:39 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E658F20B74C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1699896039; bh=8j9zrBoi2qNke9V2Ky/T5zRIdc7byXKd5lZiiT0U2Gc=; h=From:To:Cc:Subject:Date:From; b=Dnx2/NdHkNntvkgsTISM+wsuVBWt74e3jXAArfm0lxBPvt3p1UumLjYB8IIfLyOuu B0ei/yj3loWj1EFHR2T9RcjBpMUtyXFPmAI7F/cEJW+rtIyNGLT11T0USeorX/Fl4Z e8zN09MS61ZWM8WTAEJZg8+tIs1mw7HDQ1UX99yc= From: Tyler Retzlaff To: dev@dpdk.org Cc: Matan Azrad , Ori Kam , Suanming Mou , Viacheslav Ovsiienko , Tyler Retzlaff Subject: [PATCH] net/mlx5: remove non constant size from type cast Date: Mon, 13 Nov 2023 09:20:38 -0800 Message-Id: <1699896038-28106-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Placing a non-constant size in the subscript [size] of a type cast is causing unnecessary generation of a VLA. Remove size and just provide [] indicating the type is an array of unspecified size. Signed-off-by: Tyler Retzlaff Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxq.c | 5 ++--- drivers/net/mlx5/mlx5_txq.c | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 88b2dc5..f0ab77d 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -1951,9 +1951,8 @@ struct mlx5_rxq_ctrl * tmpl->rxq.mp = rx_seg[0].mp; tmpl->rxq.elts_n = log2above(desc); tmpl->rxq.rq_repl_thresh = MLX5_VPMD_RXQ_RPLNSH_THRESH(desc_n); - tmpl->rxq.elts = (struct rte_mbuf *(*)[desc_n])(tmpl + 1); - tmpl->rxq.mprq_bufs = - (struct mlx5_mprq_buf *(*)[desc])(*tmpl->rxq.elts + desc_n); + tmpl->rxq.elts = (struct rte_mbuf *(*)[])(tmpl + 1); + tmpl->rxq.mprq_bufs = (struct mlx5_mprq_buf *(*)[])(*tmpl->rxq.elts + desc_n); tmpl->rxq.idx = idx; if (conf->share_group > 0) { tmpl->rxq.shared = 1; diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index b584055..3d219c4 100644 --- a/drivers/net/mlx5/mlx5_txq.c +++ b/drivers/net/mlx5/mlx5_txq.c @@ -64,7 +64,7 @@ const uint16_t elts_m = elts_n - 1; uint16_t elts_head = txq_ctrl->txq.elts_head; uint16_t elts_tail = txq_ctrl->txq.elts_tail; - struct rte_mbuf *(*elts)[elts_n] = &txq_ctrl->txq.elts; + struct rte_mbuf *(*elts)[] = &txq_ctrl->txq.elts; DRV_LOG(DEBUG, "port %u Tx queue %u freeing WRs", PORT_ID(txq_ctrl->priv), txq_ctrl->txq.idx);