From patchwork Mon Nov 20 08:24:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dariusz Sosnowski X-Patchwork-Id: 134476 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D89D04337B; Mon, 20 Nov 2023 09:25:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BC1042DC4; Mon, 20 Nov 2023 09:25:38 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2055.outbound.protection.outlook.com [40.107.96.55]) by mails.dpdk.org (Postfix) with ESMTP id 6CF7740266; Mon, 20 Nov 2023 09:25:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QLVOLuLBbXPdXFjD/8uVnmtKNnM9Nn6DNM3hJOXEenHTgTVzPzOyAUlpPVfG8hwREHrhWHctWktHS7d34pNKvI3xX2v8v+PVEKyfGcUil9I47v+pg0HwZ046dZRq2noKmiHayl2KWPCAkRVRq38W23dP//PDPslpaa523eJTurch4kUWpIvnsgbajt/7fKYDDDgL1Van3MmMr4dR/3X1glWlAnCcxDSh4Ybi0+M84fvu+/n6RNoj4cYFOUE06aBSGI0er+tE9uQDxiGXeQ1rj1T+Ax2OOfum1hKeS7Va7jjlnsRUYFWBFIewmj/0UVQTzSe8Il/T6vZyNM24hXxO+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LNn6VdyMFnG7iIlGNzlSZ+RQjPsxJs6AXIVesTr/3rU=; b=ZUBCqIuspNIs0fPNsToDftefXanYKKOU8jSAUkpDP0iU2tDd3UjV7kUpQwar9bv3BVoWjcRM0/jnX9CeBrmWt91ZsfzEijYG2bFIU8U+hmHjwcAv9ALNg+h7EUzrwHckpsUmz+OVrShNd/9VgocCMOFDXAZ1RB6y+t/WIH1LX+fATb+lS+lOvqvXlQfDvs3C2gBrCLJthrY8d66lMlrR1N6i+HlyLdPKS2RK1g130pJfjKPrIB0vjqFtawd5aTcgOnmuJNinsRXaOB0eqXxGfdFVkEZgsLFcQ+wabdc01zeP8OPXSu4NZqbWVAa5gdVKvrnoY7xG2NkCmMMzrXbThQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LNn6VdyMFnG7iIlGNzlSZ+RQjPsxJs6AXIVesTr/3rU=; b=pWpedtXdXkDGFFPwY7BXVcq1OXEBluGzmMnKoQepIdMmr4sJs712sEGnmfbSFIgsEZWIVK5zDtE1K9NVk0Kih/7AXUQ+Zqn4XlYgTUUa2jUZT2lwPiZ9kWTkR70N5xwA36PQinisA+43f3Ata07gUffzjUCZyI3OxZcsjBZrqGumfdLXdz6PYDfa7hcEHjsVJCnrZxa/pF7C/fYtOL9vAf+kLfQZOndqBLbDgi+TnfULfJPQnwBF33lLM/IfivYKzspfGCDA8VMryHvmyVSSqfCANETJ8bzjoW7QLd67df5rV8sBoAvG1f67UYpV5YH7muZsBSM88PF+va8TshKLjw== Received: from CYXPR02CA0025.namprd02.prod.outlook.com (2603:10b6:930:cc::23) by DS0PR12MB7605.namprd12.prod.outlook.com (2603:10b6:8:13d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.27; Mon, 20 Nov 2023 08:25:33 +0000 Received: from CY4PEPF0000E9CD.namprd03.prod.outlook.com (2603:10b6:930:cc:cafe::fa) by CYXPR02CA0025.outlook.office365.com (2603:10b6:930:cc::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.27 via Frontend Transport; Mon, 20 Nov 2023 08:25:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9CD.mail.protection.outlook.com (10.167.241.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.12 via Frontend Transport; Mon, 20 Nov 2023 08:25:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 20 Nov 2023 00:25:19 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 20 Nov 2023 00:25:16 -0800 From: Dariusz Sosnowski To: Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou CC: , Raslan Darawsheh , Subject: [PATCH] net/mlx5: fix offset field size in conntrack action Date: Mon, 20 Nov 2023 10:24:57 +0200 Message-ID: <20231120082458.9020-1-dsosnowski@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9CD:EE_|DS0PR12MB7605:EE_ X-MS-Office365-Filtering-Correlation-Id: 73112818-5975-41ba-5d83-08dbe9a243a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XyFEjYjkY7eVrNhO37PlOB+HpRmd0DaVO6SNd+DFvt83zNb7+IcLAjJMOnr2QuGnNZ3DO6xeRWeg1QwwIPr8mL0dT7QG8yEd7+z7sstqHDzgi58ONCBg3E+zT2vfaoQw4Kat1tT48iUnwVDOd3/ZOmCkkmjEeVSre1lzGa8MOdHNsqPAGsC8uYpNze/3AzQ78wS23rFwgED/g2vB61+27j1lB3KEoojMOzO3JGZlE3LiIwRuiXZjcM6xlA6i7J/t20u6q2fUInnri/fLfmKncS8gWvB6TYHka5iYQsl4gz0s8o/hhCqgrvRxeH/51YeWxNIK0IKOA/DTHFDXK1OW6nWNMdfe0JgSBZFFBSousjPE5bC1wbqZ2dJjeBdG8pNGTXLFJBrWgAUevpeAl/t8nTj4NamQvNFZGCYWb0ittYZGFxJvny6LVrwtTUfTi7DEcJ0RV61z5DInUnGYgz4KZ2yq0+822eD1m8kQG3+WI5v4C+u/Egoz/n9W1RK8wD5g2qehQHWPtVGziYwXuVDGUEpJTVbRP2gqv3jcFaTrEDwAVy+KoIepEB6dnm13Vu6YY3Bg2qGAouGs7oc/ynxZmXYqGvp+OH9jxMDz5kZLyDLexNBbUwfUbqKRtPIrZf9z5Ic5hj78vUdhzUZQsBXuVvP2474mcbdgkT6QDSoollRvPmmz9GPOpCaOV2mxGdnP48x2Y4gOYVwNquzp9INnVPE5hmnOzG5kJnel4KRcDTV4b0JURJ+5DUzKOLuoSH+K X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(39860400002)(346002)(376002)(396003)(136003)(230922051799003)(64100799003)(186009)(82310400011)(1800799012)(451199024)(36840700001)(40470700004)(46966006)(55016003)(82740400003)(356005)(86362001)(40480700001)(40460700003)(110136005)(6666004)(7696005)(6636002)(70206006)(70586007)(316002)(54906003)(36756003)(7636003)(2616005)(1076003)(16526019)(6286002)(26005)(83380400001)(336012)(426003)(2906002)(450100002)(41300700001)(478600001)(5660300002)(47076005)(8936002)(8676002)(36860700001)(4326008); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 08:25:33.0797 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73112818-5975-41ba-5d83-08dbe9a243a9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9CD.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7605 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In mlx5 PMD, struct mlx5_aso_ct_action represents a single ASO CT object inside a ASO CT bulk, which is used to implement conntrack flow action. offset field, which is 16 bits wide, in this struct represents an offset of the given object inside a bulk. When SW Steering flow engine is used, ASO CT bulks are allocated on demand, each having 64 objects. In this case offset field can fit any valid object offset. When HW Steering flow engine is used, a single ASO CT bulk is allocated during flow engine configuration. Since HW supports bulks bigger than 2^16 this offset field is too small to fit all valid values. This causes some ASO CT objects to be incorrectly reused on multiple connections, when more than 2^16 conntrack flow actions are used. This patch fixes this behavior. offset field size is increased to 32 bits. Fixes: 463170a7c934 ("net/mlx5: support connection tracking with HWS") Cc: suanmingm@nvidia.com Cc: stable@dpdk.org Signed-off-by: Dariusz Sosnowski Acked-by: Ori Kam --- drivers/net/mlx5/mlx5.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 76bf7d0f4f..263ebead7f 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -1286,7 +1286,7 @@ struct mlx5_aso_ct_action { /* General action object for reply dir. */ void *dr_action_rply; uint32_t refcnt; /* Action used count in device flows. */ - uint16_t offset; /* Offset of ASO CT in DevX objects bulk. */ + uint32_t offset; /* Offset of ASO CT in DevX objects bulk. */ uint16_t peer; /* The only peer port index could also use this CT. */ enum mlx5_aso_ct_state state; /* ASO CT state. */ bool is_original; /* The direction of the DR action to be used. */