From patchwork Fri Nov 24 07:01:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kaiwen Deng X-Patchwork-Id: 134603 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6096433B5; Fri, 24 Nov 2023 08:43:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 002C542FFF; Fri, 24 Nov 2023 08:43:48 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id C621142F31; Fri, 24 Nov 2023 08:43:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700811827; x=1732347827; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Gh9l+oySqvSlXtuz8VQH/RoX4MvfxExwNWQZ4xmQQGg=; b=cnZcEQxk0aO5nHKpSoHM1DRTLbwTdrkNVMFst+0vIWaZx9T65xvvN+ML xrEeoWzaQX5EfRg+yNWPYpx9H7c3mi+xTTk4i+jEG97Z6XV1lGq8hD/6V SGp4ZekIFAQ/DuZVe7A21Mv+umRXR178xQ4XgGa5IVqfBFDQEu8nL7sFR wDMa+zOWMRBN6xtGEfnyEN+NP2ZQs7Oviv0sZzNg7NY5uVrdLwfcVpCX8 YOHOTbgbSf+KmcHFdX5Slke4hlWrtMRTnOdgc5zHip/cCNA+K0ba5AEQj fStGM47VLZAI52woz3g5OvYBY/7vACQn/131gSG/kXUvl66NluzJjkDNg A==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="458870561" X-IronPort-AV: E=Sophos;i="6.04,223,1695711600"; d="scan'208";a="458870561" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2023 23:43:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="760889629" X-IronPort-AV: E=Sophos;i="6.04,223,1695711600"; d="scan'208";a="760889629" Received: from shwdenpg561.ccr.corp.intel.com (HELO dpdk..) ([10.239.252.3]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2023 23:43:42 -0800 From: Kaiwen Deng To: dev@dpdk.org Cc: stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com, Kaiwen Deng , Yuying Zhang , Beilei Xing , Jingjing Wu Subject: [PATCH] net/i40e: remove redundant judgment in fdir parse Date: Fri, 24 Nov 2023 15:01:03 +0800 Message-Id: <20231124070103.1778196-1-kaiwenx.deng@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org if (eth_spec && eth_mask && next_type == RTE_FLOW_ITEM_TYPE_END) { ... if (next_type == RTE_FLOW_ITEM_TYPE_VLAN || ...) { ... } ... } Clearly, that condition in the inner "if" is always "false". This commit will remove the redundant judgment. Fixes: 7d83c152a207 ("net/i40e: parse flow director filter") Cc: stable@dpdk.org Signed-off-by: Kaiwen Deng Acked-by: Qi Zhang --- drivers/net/i40e/i40e_flow.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index 877e49151e..92165c8422 100644 --- a/drivers/net/i40e/i40e_flow.c +++ b/drivers/net/i40e/i40e_flow.c @@ -1708,8 +1708,7 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev, ether_type = rte_be_to_cpu_16(eth_spec->hdr.ether_type); - if (next_type == RTE_FLOW_ITEM_TYPE_VLAN || - ether_type == RTE_ETHER_TYPE_IPV4 || + if (ether_type == RTE_ETHER_TYPE_IPV4 || ether_type == RTE_ETHER_TYPE_IPV6 || ether_type == i40e_get_outer_vlan(dev)) { rte_flow_error_set(error, EINVAL,