From patchwork Tue Dec 5 11:31:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 134878 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD63143677; Tue, 5 Dec 2023 12:31:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB9CE42E3D; Tue, 5 Dec 2023 12:31:17 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id D45E542E3C; Tue, 5 Dec 2023 12:31:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701775877; x=1733311877; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=yeiOggpgXlGjQxl3RmWCoi7LPhQ9dT20p4nFSOGbYvw=; b=Oc4l2JISToT9mreOD6bgp3md1AuHOXTAodKolAKHRWsINF0j00TElwWF cDwAerDpUWhyfNG0OGwHTSL9B38SK1CYtC0d5DO66XmHYl6xsai4jnKkj HVzHpdEl3rk3CbrEdpCy26RvfAr3vhBT8EmdrerghKY7J3EqFl1tketun EOxP0+/zO6RxiM1ZUPhr4uao90UQDKgHTWUbS/rtMt07nKs7RpP0XH5GQ dhB5nioWN0zoxRt6cVY1zB36wFnUkJHZ4t33WvypT4Ac+hD5P1Zw62Tpl PjqZTajkqEOf1nl/nclc0rwSVfn89l7N5BEC/RtsrUX6StsZRUvMeX2gj g==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="373326989" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="373326989" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 03:31:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="12305884" Received: from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.152]) by orviesa002.jf.intel.com with ESMTP; 05 Dec 2023 03:31:14 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org, Sunil Kumar Kori Subject: [PATCH] buildtools/dpdk-cmdline-gen: fix code gen for IP addresses Date: Tue, 5 Dec 2023 11:31:04 +0000 Message-Id: <20231205113104.473203-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The C code generated for the tokens for matching IP addresses in commandlines was missing the "static" prefix present in the output for the other data-types. Fixes: 37666691e9ed ("buildtools: add a tool to generate cmdline boilerplate") Cc: stable@dpdk.org Reported-by: Sunil Kumar Kori Signed-off-by: Bruce Richardson Acked-by: Sunil Kumar Kori --- buildtools/dpdk-cmdline-gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buildtools/dpdk-cmdline-gen.py b/buildtools/dpdk-cmdline-gen.py index 49b03bee4a..bf1253d949 100755 --- a/buildtools/dpdk-cmdline-gen.py +++ b/buildtools/dpdk-cmdline-gen.py @@ -71,7 +71,7 @@ def process_command(lineno, tokens, comment): elif t_type in ["IP", "IP_ADDR", "IPADDR"]: result_struct.append(f"\tcmdline_ipaddr_t {t_name};") initializers.append( - f"cmdline_parse_token_ipaddr_t cmd_{name}_{t_name}_tok =\n" + f"static cmdline_parse_token_ipaddr_t cmd_{name}_{t_name}_tok =\n" f"\tTOKEN_IPV4_INITIALIZER(struct cmd_{name}_result, {t_name});" ) elif t_type.startswith("(") and t_type.endswith(")"):