From patchwork Wed Jan 17 11:54:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 135928 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06480438EB; Wed, 17 Jan 2024 12:54:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 773624029F; Wed, 17 Jan 2024 12:54:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2A37740298 for ; Wed, 17 Jan 2024 12:54:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705492471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SQsoQ9NYrL6dqCFOAJp8JA8NbVdMBdoeOX2KCON7Irg=; b=ChcMlVA3MHoSCuoC/KNGwHgTL7is2ODWkNKXySyTCAgrtxWh/RgzQPe5fKL8TfQVkk8QPy nHg39UR4wSpVKaDGnN1dJRXABVYmFsAOxp0mm6slAJGPRTPzu+z1vMIO+tdUAMidL+M/z7 ZdXlvvgO/hrMWaNhmcYPNpIAmJ2szSc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-275-hm_htfuMOlC3AloOt1O15Q-1; Wed, 17 Jan 2024 06:54:28 -0500 X-MC-Unique: hm_htfuMOlC3AloOt1O15Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 98E1A8493E6; Wed, 17 Jan 2024 11:54:27 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 081242026D6F; Wed, 17 Jan 2024 11:54:25 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: ktraynor@redhat.com, john.mcnamara@intel.com, ian.stokes@intel.com, stable@dpdk.org, Jingjing Wu , Beilei Xing , Qi Zhang , Mingjin Ye Subject: [PATCH] net/iavf: fix application reset callback calls Date: Wed, 17 Jan 2024 12:54:10 +0100 Message-ID: <20240117115410.3984237-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Don't trigger an application reset callback if the port is not started. Bugzilla ID: 1337 Fixes: 675a104e2e94 ("net/iavf: fix abnormal disable HW interrupt") Cc: stable@dpdk.org Signed-off-by: David Marchand --- drivers/net/iavf/iavf_vchnl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index 0a3e1d082c..14dfe313b7 100644 --- a/drivers/net/iavf/iavf_vchnl.c +++ b/drivers/net/iavf/iavf_vchnl.c @@ -88,7 +88,10 @@ iavf_dev_event_handle(void *param __rte_unused) continue; } - rte_eth_dev_callback_process(pos->dev, pos->event, pos->param); + /* Don't invoke an application reset callback if not started yet. */ + if (pos->event != RTE_ETH_EVENT_INTR_RESET || + pos->dev->data->dev_started != 0) + rte_eth_dev_callback_process(pos->dev, pos->event, pos->param); rte_free(pos); } }