From patchwork Wed Jan 24 18:53:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 136111 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 188CC439B8; Wed, 24 Jan 2024 19:54:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91D4D4027A; Wed, 24 Jan 2024 19:54:30 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2046.outbound.protection.outlook.com [40.107.237.46]) by mails.dpdk.org (Postfix) with ESMTP id 14B3D40262; Wed, 24 Jan 2024 19:54:29 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XMo0C90B/uY7I+wk/xoT/WFwPeg5xH26SwEbHjMT6ap5BSu8Y5AEYzv4AuBU/mrDsGFmF1JOk52kY4lfWrmXeze0+cKs4EPA3L52jquwMCG2iK75L4G46NQPimEWw6msaD5AoIEJjVBcSizzUXazpvbOAz0P5HUhC0bgBCvl68xTkx0FSCfJepmUuYDTEOp8cO2XwFfU9XPyL/6CQsobsrVITQ7TmzmKGWesc2SPrUGe8jI4b+FdSxDk7+2R+Ztn6kK/Dl6o26CkuoNakZQksI6W+FUyU5v942YbQtaj1acOapaHFscgT7pA6wLycJvbzinmpl0hGnTA4YHurXlaRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kplrD0S33HLygz4vlAJXMXefzehZ9GT5aQhV4OtnEpY=; b=Wgf6335vYl3FydI4fe+I4Ea403VJNk0IXS/X5Jx3CEkv00/vX/xh2oIYCVnynF1gOK9a0e5ThuCKD0hlWRC9KcXRU06L8ifSX7QUFw2I16GvGv4BCjLgxDTO3bi5zjiUpuxKloo/xhHburBmNtD1m5qbYXn/R4B2jQCgcjYQwUZhUM2xySGoyAa8kzvP4YoH6iw9AQ4fmtnz4kczofGBQa1an2fLL4BuUhPPfA+j1/SRGLT2tOIMHh66RKxVY4jMlZMXxCyHq+nS1hYgolJVuHnKZQSXwjZgKdtxYxbZSI6JYGpcMy1+l69yDFX4AQ3+NkQ7F4ZHcSyQJhF+z6GOFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kplrD0S33HLygz4vlAJXMXefzehZ9GT5aQhV4OtnEpY=; b=reCWrQpjLh+dLDXKejte6/HLV7y+EP29li85UeLS+1BKuga9KpmLrajdU2AWJevSOVc3NR0LMm/oAjfttfC1cah/OjV7NcO6Pn+/i266YLZv/tqSEFEPdow0Y+2OoDpbGGUnYb/exbTD4WFurwd7A9mRPgEMFK0/RUjrH8ltI6I= Received: from BYAPR01CA0019.prod.exchangelabs.com (2603:10b6:a02:80::32) by MN2PR12MB4093.namprd12.prod.outlook.com (2603:10b6:208:198::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Wed, 24 Jan 2024 18:54:27 +0000 Received: from SJ1PEPF00001CE9.namprd03.prod.outlook.com (2603:10b6:a02:80:cafe::5e) by BYAPR01CA0019.outlook.office365.com (2603:10b6:a02:80::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.38 via Frontend Transport; Wed, 24 Jan 2024 18:54:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE9.mail.protection.outlook.com (10.167.242.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7202.16 via Frontend Transport; Wed, 24 Jan 2024 18:54:26 +0000 Received: from telcodpdk.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 24 Jan 2024 12:54:24 -0600 From: Ferruh Yigit To: Cristian Dumitrescu , Kamalakannan R CC: , Subject: [PATCH v2 1/8] pipeline: fix calloc parameters Date: Wed, 24 Jan 2024 18:53:58 +0000 Message-ID: <20240124185406.3598985-1-ferruh.yigit@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231102130847.3367102-1-ferruh.yigit@amd.com> References: <20231102130847.3367102-1-ferruh.yigit@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE9:EE_|MN2PR12MB4093:EE_ X-MS-Office365-Filtering-Correlation-Id: d257ab8d-64ee-404e-0e77-08dc1d0de339 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3e5Vtdq6zqPNS87E2p6lv92EdLkd7Np6T6wUdU+QVo2447gXhy3CJYkTbGlNI7k1mnLYXSwM5i/feRtIhCixsrtOnKzl32ghpj7iSRE0gix7cQ4VjXEQ82n1IeJEuz2eBcotiB6ZvXHlX09MV7vi5T7UU/4Xg4tWFL2rVjHn80QC23wvpfhXc+838BaL03QIJW6Ws4K/isfjPv8lOMG4dBDU0IBG9sjTGFWRpIW1o1vL61ogucBFSiSnN32voqpJ0/PTgkLYBxGt9m7bVPisprb93ZMrAFEgTu3fC2L2W7S58Mwp6atyV1Hcs2WKhHc4po4N4CBM9N6a4WbWctfGTwalF0/ZRfw993JiLKzS3COIsGGwYot6ch7Tlw1aq3U1DMO3YrvyFaC928pt5sZixVADhoQYvwzwn02PvOZs4vRdSUyLhATj+nlxJe2wfGVDhUcX8wj/H41ygjPFJ02T9hYD9a9rjUnFWXv87+pE6Uqn6qGl05B/PPUsSAKzZlFgC7IMpaau6GsViXVE5mT7vvn+yfmsiPM4mVaAtAStGeUpqlZLHGzbBbblRvT4CbH6vLTzqLQfCZgZXU/Sx/tGZzvjkPfXQ4DWj4E4ZrRdCZsE+L+/ZXqE8le2EkXlfNlE9RjrzkHXpiiHxuQaKizJ940V5AREYPnBCqWu5+GDN/wa4t83ui7tys53xrM/wl3eLUKpIaxJaefva+UxT8EDLNhgU9nUU4WmAWM26C4RCpqtys87frnkjFqqhe/JUTn3F8bMrMSbU2qIETR++SpyWI2eHbkNplqEb5wp0q6ioRJadhAErBThYVbfW3WYUFj0 X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(396003)(136003)(346002)(39860400002)(376002)(230922051799003)(230173577357003)(230273577357003)(451199024)(186009)(1800799012)(82310400011)(64100799003)(40470700004)(46966006)(36840700001)(4326008)(8676002)(8936002)(36756003)(2906002)(7696005)(426003)(336012)(83380400001)(44832011)(2616005)(16526019)(26005)(5660300002)(1076003)(110136005)(478600001)(86362001)(41300700001)(70586007)(70206006)(6666004)(54906003)(356005)(316002)(47076005)(81166007)(40480700001)(40460700003)(36860700001)(82740400003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 18:54:26.2309 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d257ab8d-64ee-404e-0e77-08dc1d0de339 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4093 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.0 20231102 (experimental) [2] Compiling C object .../pipeline_rte_swx_pipeline_spec.c.o .../rte_swx_pipeline_spec.c: In function ‘pipeline_spec_parse’: ../lib/pipeline/rte_swx_pipeline_spec.c:2893:11: warning: allocation of insufficient size ‘1’ for type ‘struct pipeline_spec’ with size ‘144’ [-Walloc-size] 2893 | s = calloc(sizeof(struct pipeline_spec), 1); | ^ .../rte_swx_pipeline_spec.c: In function ‘pipeline_iospec_parse’: ../lib/pipeline/rte_swx_pipeline_spec.c:4244:11: warning: allocation of insufficient size ‘1’ for type ‘struct pipeline_iospec’ with size ‘64’ [-Walloc-size] 4244 | s = calloc(sizeof(struct pipeline_iospec), 1); | ^ Fixes: 30c4abb90942 ("pipeline: rework specification file-based pipeline build") Fixes: 54cae37ef4ef ("pipeline: support I/O specification") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Cristian Dumitrescu Acked-by: Morten Brørup --- Cc: cristian.dumitrescu@intel.com --- lib/pipeline/rte_swx_pipeline_spec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/pipeline/rte_swx_pipeline_spec.c b/lib/pipeline/rte_swx_pipeline_spec.c index 2bba0d0524d0..17419e7b854b 100644 --- a/lib/pipeline/rte_swx_pipeline_spec.c +++ b/lib/pipeline/rte_swx_pipeline_spec.c @@ -2890,7 +2890,7 @@ pipeline_spec_parse(FILE *spec, } /* Memory allocation. */ - s = calloc(sizeof(struct pipeline_spec), 1); + s = calloc(1, sizeof(struct pipeline_spec)); if (!s) { if (err_line) *err_line = n_lines; @@ -4241,7 +4241,7 @@ pipeline_iospec_parse(FILE *spec, } /* Memory allocation. */ - s = calloc(sizeof(struct pipeline_iospec), 1); + s = calloc(1, sizeof(struct pipeline_iospec)); if (!s) { if (err_line) *err_line = n_lines; From patchwork Wed Jan 24 18:53:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 136112 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FE4B439B8; Wed, 24 Jan 2024 19:54:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31B4C42DC0; Wed, 24 Jan 2024 19:54:34 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2064.outbound.protection.outlook.com [40.107.243.64]) by mails.dpdk.org (Postfix) with ESMTP id 47D7B42DE2; Wed, 24 Jan 2024 19:54:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Syj5ySg+ytVVBwfvaN7RVkRX0vHUEv1C3iOj5EfoF9q4hPQ9GX36azFoHO3v921JeNkrvWdDL2VCRPPsomFzRE1hmuVSWoNphKp11V0qlCyjmrhJVXBViMzkuVCL4EOWradjqRecTaf622S1vXwUw2YY+Zt6BBA2sEizrjVyvy72fRmblCWyTKo9aHZ9Ht1aiPCakcwWmONRF76g25Vdb3OsdZ2tyDsNHROXe7LLSaLuE0DCerHBtUeG6zbbkKqzO47dWV80N5xSGxqNSEcggoQRy3GzhVssKN+MybHxtwK2XqZWBphMW+8rgHqG1btvIXDzSatMVAlwCfF9LCvhDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rRUfsuaf7RxC1o1Q9b9gClLEDwHYjXTl2wYg2w8lSTA=; b=VfxgVZSvOwxcL0zMVTdw0utD56D77oejlpJpTZpSzd3Sv1J19DE5t/zjuyc2nFA7aJnysiGnoN6YzEKowQ696mDBcNY+FTskAAt1ufhWj9w7Q9zxPg5u+V4xAys65oRNiNUxbRe/Vnj07Kvr8dNqPFQOZBeCd42njf8u/h1egTUqBzmIZ0JtQA9SM9iBbzS9SOQlR4BSyl6aoOrEIPzJrKTME0MSPudLe8Ud+EjTGTEr6L0KYHLRmk/VbueRj5rjRKd4InFU5rrfyogLcIK05EI04FmewzavmTP8XVW3sSZ//7KQSE8+fkWfyuFnrbreVYaAlHIer0oZyWczBJJrKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=corigine.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rRUfsuaf7RxC1o1Q9b9gClLEDwHYjXTl2wYg2w8lSTA=; b=WQ0tm8rRIjMlOQ9ybOI9mRBhlo0GpI0uYgfAtGbF3VHrPbA+B2PBxBB1+Z9nke9povxv5fDvsVieH9DfY49UPMR9tI3GXUtLsyXIma/A81YUmNaWoFoskLWb7Ih2UbInc7hbQuM7feWjkr4BkR6REjUta2oxYrNLzSQmzq6Ka6k= Received: from BYAPR01CA0007.prod.exchangelabs.com (2603:10b6:a02:80::20) by MW4PR12MB6827.namprd12.prod.outlook.com (2603:10b6:303:20b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Wed, 24 Jan 2024 18:54:27 +0000 Received: from SJ1PEPF00001CE9.namprd03.prod.outlook.com (2603:10b6:a02:80:cafe::3a) by BYAPR01CA0007.outlook.office365.com (2603:10b6:a02:80::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.38 via Frontend Transport; Wed, 24 Jan 2024 18:54:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE9.mail.protection.outlook.com (10.167.242.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7202.16 via Frontend Transport; Wed, 24 Jan 2024 18:54:27 +0000 Received: from telcodpdk.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 24 Jan 2024 12:54:25 -0600 From: Ferruh Yigit To: Chaoyong He , Alejandro Lucero CC: , Subject: [PATCH v2 2/8] net/nfp: fix calloc parameters Date: Wed, 24 Jan 2024 18:53:59 +0000 Message-ID: <20240124185406.3598985-2-ferruh.yigit@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124185406.3598985-1-ferruh.yigit@amd.com> References: <20231102130847.3367102-1-ferruh.yigit@amd.com> <20240124185406.3598985-1-ferruh.yigit@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE9:EE_|MW4PR12MB6827:EE_ X-MS-Office365-Filtering-Correlation-Id: 05aefc40-015b-4ffe-7cda-08dc1d0de3e9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V9po8EGIHoqK9eFdWXRyHoqWNvtQl0xBLej+ygTtB1tVwlvLABLXKSfOv6jaNGS8V0CYPBJUe6TbDpZQqJsFxBV9LCT6usmKr36BRUMEK261Y97dpi4IphOeIRokWIlX3KFfni6/RMt5sTmR51sqS1E+ko333Nd9dEhsUnbl9MFK3xqTOoIhJJl4hbJ3KgbP7bSUwSdAVmSoD2M3n5LZc49qKXUDj4Mr5RpECUVgDH7p0bYFKpICmRxEeJ3vaPkPFmI9bapb3AKHUrXra+XdvftH6vsZti/kv8gQs5gAUqtIRuN3zT+plCmC9QvIvL9CA7bi6gOXMHis77xTPR7gJMv+vkeVUR2zlwlrC3w18XaluZGVEVoyYmf0fIzKPz2oF8EwhXu0PjNXQq6d2rg7GbimULCIfDiKgXXgxMBnFtChxcDE8QCJA4eGbP0mWumx/5ZTAH85cBlAQtr9AakjW9lr7lte7jXWhv0aEPHkutwSgs8oKbvHL5vhJi0vZe5jmroqL2VqHSe4XPN0S6OgGOvv3ES6KRt8CfJZeDFPPEw51bwNoE19yr4XgEI4SSNWyhUYseVG4t6ra9uudlj+ov9mH5aZUonWPlXb0NhLgJJjxwoPwT5E7X1urPCHZ2NdRLUlv8Af8iypQAh648IWGgFDqYc+/VSueBq9mdGpt1QrUlq0kDLHc+/TCM8UHSluounrEv5bR2WEOFmnRbf2uv6WJ5L/SoNDBWSjPcTRBiHOg7tLnCPu+GyQNRT+bOzyvVbEdezwxb7AGTJVEF0khElrg5UYQqVV+VeWKF/hrRJVDOqf/mdUERdqMpK+YuAV X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(376002)(136003)(396003)(39860400002)(346002)(230273577357003)(230173577357003)(230922051799003)(451199024)(64100799003)(1800799012)(82310400011)(186009)(40470700004)(46966006)(36840700001)(36860700001)(41300700001)(47076005)(86362001)(36756003)(82740400003)(81166007)(356005)(4326008)(478600001)(44832011)(54906003)(316002)(70206006)(70586007)(1076003)(8676002)(110136005)(2616005)(8936002)(83380400001)(26005)(2906002)(16526019)(336012)(426003)(6666004)(7696005)(5660300002)(40460700003)(40480700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 18:54:27.3871 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 05aefc40-015b-4ffe-7cda-08dc1d0de3e9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6827 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.0 20231102 (experimental) [2] Compiling C object .../net_nfp_nfpcore_nfp_mutex.c.o .../net/nfp/nfpcore/nfp_mutex.c: In function ‘nfp_cpp_mutex_alloc’: ../drivers/net/nfp/nfpcore/nfp_mutex.c:171:15: warning: allocation of insufficient size ‘1’ for type ‘struct nfp_cpp_mutex’ with size ‘48’ [-Walloc-size] 171 | mutex = calloc(sizeof(*mutex), 1); | ^ Fixes: c7e9729da6b5 ("net/nfp: support CPP") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Chaoyong He Acked-by: Morten Brørup --- Cc: alejandro.lucero@netronome.com --- drivers/net/nfp/nfpcore/nfp_mutex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfpcore/nfp_mutex.c b/drivers/net/nfp/nfpcore/nfp_mutex.c index 3c10c7a090c0..edb78dfdc917 100644 --- a/drivers/net/nfp/nfpcore/nfp_mutex.c +++ b/drivers/net/nfp/nfpcore/nfp_mutex.c @@ -168,7 +168,7 @@ nfp_cpp_mutex_alloc(struct nfp_cpp *cpp, if (tmp != key) return NULL; - mutex = calloc(sizeof(*mutex), 1); + mutex = calloc(1, sizeof(*mutex)); if (mutex == NULL) return NULL; From patchwork Wed Jan 24 18:54:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 136115 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8AC33439B8; Wed, 24 Jan 2024 19:55:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0463C42E0B; Wed, 24 Jan 2024 19:54:38 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2062.outbound.protection.outlook.com [40.107.220.62]) by mails.dpdk.org (Postfix) with ESMTP id CEE0842DED; Wed, 24 Jan 2024 19:54:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AMGbznLP8OKdtv+tQIGHMGasDJHUgQgKmKkM/xsX64tW5Xk/X9o0GBeFt3YyOX7yrZKXf3rZ4bUMgTf6wEXhxY3GXJxGlPfiHKHhv51x5H3vv4twvL654aJ6fzbL/i+AVZfmZzqbBpJ3spYlsJt7HuX+eJ8jdlhWx3s85Kpkn4cfX2nO/OvyOxMZsIGPmRnjIqkvNkziXmfPLJMGlQjAza+NianUaF6oXHB5Xk3t98U3LO3C28ziKhf8lxhZhV4gRcT15fWbhOCmO/79BpCn+HiNs5IqJKhTL/BC6V8pAO9sys6dXIXVhWaB8yZk98O1V9/m5Azy3Xdqlbm96S2NUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=URBG7bvcxDPTQL1AWM8RSpnUkGuKS92/drQ1thPOb7Q=; b=drHj3h7zjV8DpV9r7wCNLPRk4Iw2rnWwaBvgB9AJmzm8YS5rEOQK0kox+u6pQslxUs2+0mIRccM/uajRplxy6QAUJYyJ38xFrhxZ8xrwFenFFx1hCT3wBFF1JTebGOZzY088vBY8e5/0YX6AbZmKes2YmKZOWbVhK+Y0ALKoK+M1fzRU+bnjQYhY8zdaRfVnmDJD+yUP29sJBKZzpqHWvGaJrXLMF1CGhiKCjNm7NRyop9lK6/aGFB+TC0Jw/6oQGjTXikSCA10Fg1YhW9saYrGdGEJ30D7XUv+fcW/+retN0SgpYMaEUl5t2iLcMtYZCSaKVqu5cYW6EQX+/9T0+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nxp.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=URBG7bvcxDPTQL1AWM8RSpnUkGuKS92/drQ1thPOb7Q=; b=O3/8jH1epXneAVg9fXE3urniNwJ3tdE8uupbRMRJPM8Ai9vON4xzWZ1i8SzPI0CfuX2k3ru8HCDT0TtjXkGATzAUs0t+fVT8q+429fsF5AEXm8n2yptRQl11PQXH9dmQ0j3yZR7f51HN7iWUoyJj85EKu1YeU15qed4FjWbeyMc= Received: from BYAPR01CA0004.prod.exchangelabs.com (2603:10b6:a02:80::17) by MN2PR12MB4584.namprd12.prod.outlook.com (2603:10b6:208:24e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Wed, 24 Jan 2024 18:54:28 +0000 Received: from SJ1PEPF00001CE9.namprd03.prod.outlook.com (2603:10b6:a02:80:cafe::9e) by BYAPR01CA0004.outlook.office365.com (2603:10b6:a02:80::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22 via Frontend Transport; Wed, 24 Jan 2024 18:54:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE9.mail.protection.outlook.com (10.167.242.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7202.16 via Frontend Transport; Wed, 24 Jan 2024 18:54:28 +0000 Received: from telcodpdk.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 24 Jan 2024 12:54:26 -0600 From: Ferruh Yigit To: Sachin Saxena , Hemant Agrawal , =?utf-8?q?Morten_Br=C3=B8rup?= , Chengwen Feng CC: , Subject: [PATCH v2 3/8] rawdev: fix calloc parameters Date: Wed, 24 Jan 2024 18:54:00 +0000 Message-ID: <20240124185406.3598985-3-ferruh.yigit@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124185406.3598985-1-ferruh.yigit@amd.com> References: <20231102130847.3367102-1-ferruh.yigit@amd.com> <20240124185406.3598985-1-ferruh.yigit@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE9:EE_|MN2PR12MB4584:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c08892f-4413-4bcb-62be-08dc1d0de471 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EfE7+e0uVf8eRu9nWcNWa2sISNTLonZaxYEdkNmsCedJccl2JIn71DocGZSeUX8ipdQxSlqoehAIfG1WPBVOgraEmCCiF/VoLTj9YVdJR9NJdhvz2N/PAZzAplI49NQKwbt9LW5AhlnqRRzVE27Cbw8eDGYgngJYSnGC/Ewx2zlYRklqLmpJFc0XQx8CXoJXt05iFSjppZ7Iy8qFr3noq7Yb+TGBE/a5021tDUKbcGjL8YUnsSJGtKIAAVPLi5VH51SLyBNSBICJ80X7TQ4pKd7aCPeZpCY0vuD/nlDvNYpYCD92XwIkQYpBzmxEE61JEWx1toKSXjnJ4mt1mc0lk1efvH3+Rj0tKTE3dl+gHhAwzXrvEjV6JDE+PYeLccKs/s7MSAgSPbEpU4eCTtA5WppIyXVxnFkkaqdEZAfSRhITOfn9uhOEYwLQJcNSUxYjvbm0NWRPYO0G2BM8n+OPL+Yt7MpJ4Xtltm5+FR930PQPcws4C/smT5g/miMB4ejDIlKX/ULsUOC6vYReS9qSpcYZoV/wKE4E9/n/ruBURzWArGrxUn6/5bgAgQOSQTsdz3Yt+VNALWTOIV///tgTUxEt1KkPj+F6Iz+i7lO63fWXKyUJDNCUDa9tTXyR4+NqpCQW5roAMMjwfqMEzfKpvQUwKfKorQafnUjpk3R/VAzCfwe/YBUbeZKDm8b2tn9zykyH3jUP+VJMdsr/KuPYrHKQ011UrDKJiOvZ0tH86zfbxzFUf+mrNPblq/bl+F24YxQMzboz+gRa0FaCplp+fFjmb7CKOqQ3pIvC7yHvM+KfBqCInTNR68CpKurdmsOq X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(396003)(136003)(346002)(39860400002)(376002)(230922051799003)(230173577357003)(230273577357003)(451199024)(186009)(1800799012)(82310400011)(64100799003)(40470700004)(46966006)(36840700001)(4326008)(8676002)(8936002)(36756003)(2906002)(7696005)(426003)(336012)(83380400001)(44832011)(2616005)(16526019)(26005)(5660300002)(1076003)(110136005)(478600001)(86362001)(41300700001)(70586007)(70206006)(6666004)(54906003)(356005)(316002)(47076005)(81166007)(40480700001)(40460700003)(36860700001)(82740400003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 18:54:28.2778 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c08892f-4413-4bcb-62be-08dc1d0de471 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4584 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.0 20240108 (experimental) [2] Compiling C object .../lib/librte_rawdev.a.p/rawdev_rte_rawdev.c.o ../lib/rawdev/rte_rawdev.c: In function ‘handle_dev_dump’: ../lib/rawdev/rte_rawdev.c:659:29: error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args] 659 | buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN); | ^~~~ Fixes: e915d404eb72 ("rawdev: support telemetry dump rawdev") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup Reviewed-by: Chengwen Feng Reviewed-by: Hemant Agrawal --- Cc: fengchengwen@huawei.com --- lib/rawdev/rte_rawdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rawdev/rte_rawdev.c b/lib/rawdev/rte_rawdev.c index 474bdc95407f..4f8897b63947 100644 --- a/lib/rawdev/rte_rawdev.c +++ b/lib/rawdev/rte_rawdev.c @@ -656,7 +656,7 @@ handle_dev_dump(const char *cmd __rte_unused, if (!rte_rawdev_pmd_is_valid_dev(dev_id)) return -EINVAL; - buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN); + buf = calloc(RTE_TEL_MAX_SINGLE_STRING_LEN, sizeof(char)); if (buf == NULL) return -ENOMEM; From patchwork Wed Jan 24 18:54:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 136113 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD032439B8; Wed, 24 Jan 2024 19:54:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AAEF42DED; Wed, 24 Jan 2024 19:54:35 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 5BDD742DED; Wed, 24 Jan 2024 19:54:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ivme4sOaT4GYriilmNfkTOTv9pw8pP5DtFJdP3GjSzOPz/fzybps/26+/BQCX2lwuGn879PZv0ewbWQV1fn35MlAi/mbyuA6fwCFaTecyNZLwob1h4WILAnN1BWpsx0ub2AP8l2o8FLahzKfxHJtlb1jZUiCrXIUUaDco8I8/sM3pEwaGTNHHn5MdVF6pk4qhfllwKq0OdplCXm8YjHEZPOHOthMMMs/kp3WhNb7eA/cyviiFear6fTy6zpKUw3P8aYhUwFMUzF8zwv2bgPztzJr53tyN/WYGbvAu+NDfujqm1C3Aj2EJQr9OOEf4ApQ9ho7mYQxtv4WXXvBCwmDxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XM7t+gR6ZlOI+5qAOnQ1rMErFf3l20jTTGOtlY6jbek=; b=mJugPEDExLkFU6soZbMacrPBB4EUaaqwyPHtDFAQ7EEeemWaI4eALeLqHU1ryWDB7w4X171rKXBbGL59AhVbTq3nS3slKwAjeHKUAV3deJfWuUEna0ELn+xf+PRzJ2q5MizIkU7PlH38A7ouu8Edvxdv4vrGTpWBTqlUkZCejfu4s+7uVM797AHpkQt0nbUn7euosBzyW+WYFe4+dfsSiRRUmtkfu3vazXY92U/RDf8xhya7veef6Wtgu/VkEhMMov+3HawOujvj1/FMIRh5gqGtpCBxHuxElvKHT1xXJjHrpgSH9coJjwK4wg+NLvEF0WoXP34d3QUhlBRyGBUmeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=marvell.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XM7t+gR6ZlOI+5qAOnQ1rMErFf3l20jTTGOtlY6jbek=; b=UL7O3ymP2upgPAZf9VG2PwLXOUNaTRlEpPsmlgN4kqOgsBLY3cDwSbk7kZdYgyozldubflj4jtggBePKLlOi0Ohii2iJNyP+61ftUWoG2H/Z+sHxxSDDexDG0mlXYFRX8yYIeXiEblWHQJquKh3bvL+io6lRXtJsgvX64m7/QEQ= Received: from BYAPR01CA0035.prod.exchangelabs.com (2603:10b6:a02:80::48) by DS7PR12MB8290.namprd12.prod.outlook.com (2603:10b6:8:d8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Wed, 24 Jan 2024 18:54:29 +0000 Received: from SJ1PEPF00001CE9.namprd03.prod.outlook.com (2603:10b6:a02:80:cafe::4f) by BYAPR01CA0035.outlook.office365.com (2603:10b6:a02:80::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22 via Frontend Transport; Wed, 24 Jan 2024 18:54:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE9.mail.protection.outlook.com (10.167.242.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7202.16 via Frontend Transport; Wed, 24 Jan 2024 18:54:29 +0000 Received: from telcodpdk.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 24 Jan 2024 12:54:27 -0600 From: Ferruh Yigit To: Jerin Jacob , Chengwen Feng , =?utf-8?q?Morten_Br=C3=B8rup?= CC: , Subject: [PATCH v2 4/8] eventdev: fix calloc parameters Date: Wed, 24 Jan 2024 18:54:01 +0000 Message-ID: <20240124185406.3598985-4-ferruh.yigit@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124185406.3598985-1-ferruh.yigit@amd.com> References: <20231102130847.3367102-1-ferruh.yigit@amd.com> <20240124185406.3598985-1-ferruh.yigit@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE9:EE_|DS7PR12MB8290:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f47a3cf-3bae-48be-21dc-08dc1d0de4f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BpKPyVwF63Ui5XzeiX8kfveAQN9+Hbs1qB/3wQ7kwHo+mWERxtNM0dKERjCj71UUE19suXCDKUjFq8mfkZt3QV4Ga78ldXoULJ9eTvqQxP90u3/0gjS19EscZ1dWv1w1+b9xkoXmdEJQb3Qg34mGMEtfC6mWcxrep4YcnNAzhDRFxqE4HR9QqggH1hepe8AsB08Olss5C1AwMdWtCtI+ngJWnSa/o3dVr1b1W32lliMgeTY2rzW6cAlGeN1MTONOX5Hc0tO1GR052JBSYPMCW2rocRND9y930iakwbb+PA0IBGrHj5MoqEvftUCRnVGVgo0p+ue8y3SppEGHgh/ByP77uMBgpP/wQ5QLU7mBgGny8eSuWJqsbtczB4LjgZlCyTQ6G5XCa5sZo3y+b2QK/FKp2jwuiJU5rBuyyWwDb9s55RsfeORxGeTKLe2mOXjIvaM50VZvuFAFOVxGlJTVSKjEhtyH+AE2pyyrJ2aWfv2wJyqshKrF99t/YZm6MDjVhoU63NgR9ZhixTzRhuzOxvDGKhODdCtl/qjCKq5LJMME1FiiGcffynCDFETB1GlWL5WKlFxwxAK77XiWSw6yosxqm0plS6t2UM92AByIyZ1TgmA4Pw9F3bHhWt73UfXCMwZMOYL4Ox+c3naJxELT3OsLv1IFhb3LM96aN+J/qW0P96Sp3xZJnMtAB3Y/llbWC4uokzW3dOnyfPuluw/BDK1legzUdbBJaE+dxW/WdHA6PWyQ8EDIL59s5S0szAi2aODWdhhCk5XZTkxGa5JARSE19ohyDDLw0yvn5hMxyCbDWimibJ7GkcIAmuOEj8/d X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(396003)(376002)(136003)(39860400002)(346002)(230173577357003)(230922051799003)(230273577357003)(82310400011)(1800799012)(64100799003)(451199024)(186009)(40470700004)(36840700001)(46966006)(40460700003)(40480700001)(83380400001)(47076005)(36756003)(86362001)(356005)(81166007)(26005)(41300700001)(7696005)(1076003)(2616005)(336012)(16526019)(426003)(36860700001)(54906003)(478600001)(6666004)(70206006)(110136005)(70586007)(82740400003)(316002)(4326008)(2906002)(8936002)(44832011)(5660300002)(8676002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 18:54:29.1371 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6f47a3cf-3bae-48be-21dc-08dc1d0de4f2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8290 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.1 20240124 (experimental) [2] Compiling C object lib/librte_eventdev.a.p/eventdev_rte_eventdev.c.o ../lib/eventdev/rte_eventdev.c: In function ‘handle_dev_dump’: ../lib/eventdev/rte_eventdev.c:2005:29: warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Wcalloc-transposed-args] 2005 | buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN); | ^~~~ Fixes: a3b7b476d723 ("eventdev: support telemetry dump eventdev") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup Reviewed-by: Chengwen Feng --- Cc: fengchengwen@huawei.com --- lib/eventdev/rte_eventdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c index 157752868d5b..1c865e993fec 100644 --- a/lib/eventdev/rte_eventdev.c +++ b/lib/eventdev/rte_eventdev.c @@ -2002,7 +2002,7 @@ handle_dev_dump(const char *cmd __rte_unused, RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); - buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN); + buf = calloc(RTE_TEL_MAX_SINGLE_STRING_LEN, sizeof(char)); if (buf == NULL) return -ENOMEM; From patchwork Wed Jan 24 18:54:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 136114 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88EB6439B8; Wed, 24 Jan 2024 19:54:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1DD442DFE; Wed, 24 Jan 2024 19:54:36 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2052.outbound.protection.outlook.com [40.107.220.52]) by mails.dpdk.org (Postfix) with ESMTP id E211742DEE; Wed, 24 Jan 2024 19:54:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BgiAqyQvVPDCX3QwtsZe4+oM3Pm4bjP/TDVLAM4XzvuPivVfzzbiuGg/rnEhh/7SzR2Z0dGwwvl6QAdxq9P4iIaKj+06XcnMP+vEBXtwoDX779xRXzzoX26jREByJRyGI8OatU+WajX2rrP/PTa+VUXI9zbTgpMoNq+q+/hvkcaBQzXEzgPoRNNNtwAtIT3M6Nsg5Qucv6pVQRABfYs/drQGi4EPsknQwz6BbgmEtXdGlz77V8b7dgMElcRWgjgsHomWRehOyvNOJoJ404qI2dBuLu2LRh/t7Ms59PAB437ndAFznDfxhZkpwYPLpIr2ZaUGYEeMr3+H34F7gY6oLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j//QIZ4a1UPHxBjO5L//WvG2RGtIXTnzyHONQn+GSNE=; b=bZZGv1Oipe+BDH2RGktB+G/28E1LEpD25PRTI+XRPqcU+JOTQqBkjXttLmy00pJr3pytYH/HwzM92IgcflP4+GxzJktYI69882X4CXXbiM0y07nPvrq0tL2TWGYmdVOCoCc6ek6Q0njMk9P/msEUpJ9Y4acs0fzAju4RFrc/56pQyuOYYC8ToQzxRZcg5jErkwGBTySQhYrXYxmnA/DGttGEOcoPJ89CFzlk6FJmDf7F4J//SYDImgTlcv7+IADFxvD2PKE4dmDWCXwxGlW8lAjWiFXG/q3NzvceeyUCnJEgRemcZUZGtgwY9vuKlo/WzzMP5JIHoPGknA/PhkqEBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=huawei.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j//QIZ4a1UPHxBjO5L//WvG2RGtIXTnzyHONQn+GSNE=; b=Gacfsrax3eJ7jjlIO75bnFNcGglvBYNfjuYHtp5muoMCX8eleaNY/pSZlB+LPu59XEKVFs1pJtNywpGWsbZwcd6j74h3wHFR9IZvbzGn+TjDlYVRXtzNipPBomR1llric1YesDA1fvCqB2XnRhtDEv5yb7B6EP3UcZux28vcXbM= Received: from BYAPR01CA0017.prod.exchangelabs.com (2603:10b6:a02:80::30) by PH0PR12MB5434.namprd12.prod.outlook.com (2603:10b6:510:d5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Wed, 24 Jan 2024 18:54:31 +0000 Received: from SJ1PEPF00001CE9.namprd03.prod.outlook.com (2603:10b6:a02:80:cafe::23) by BYAPR01CA0017.outlook.office365.com (2603:10b6:a02:80::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22 via Frontend Transport; Wed, 24 Jan 2024 18:54:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE9.mail.protection.outlook.com (10.167.242.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7202.16 via Frontend Transport; Wed, 24 Jan 2024 18:54:29 +0000 Received: from telcodpdk.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 24 Jan 2024 12:54:28 -0600 From: Ferruh Yigit To: Chengwen Feng , Kevin Laatz , Bruce Richardson , =?utf-8?q?Morten_Br=C3=B8rup?= CC: , Subject: [PATCH v2 5/8] dmadev: fix calloc parameters Date: Wed, 24 Jan 2024 18:54:02 +0000 Message-ID: <20240124185406.3598985-5-ferruh.yigit@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124185406.3598985-1-ferruh.yigit@amd.com> References: <20231102130847.3367102-1-ferruh.yigit@amd.com> <20240124185406.3598985-1-ferruh.yigit@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE9:EE_|PH0PR12MB5434:EE_ X-MS-Office365-Filtering-Correlation-Id: 68203232-e58d-4d1c-9319-08dc1d0de564 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AzSP4i+L57CUxLMyK0p8TNldb0fu7BwfKYIBasYLYrlRfbi9Nq9uirmtMG0k6k6maO0+kdS0ivgo2HCIt+jG+hqeSfPr6/9mGoEq2mBIy03ZlBlSX+vfISY13npibDRa6VGgFZqpA9m79nu5Aok4FE9gXN8Ns9b8exVOXNnUYL9cDblhR5e9Rt60TJPxNttDTJqQNt4RfpRE7791dcPDBteedX8M24VrKSFynLzV9HNXDaeSKG34QqX7zuxYhYzOtQKQWikw6cs1fk5+PhSmK89oMYA+gllc2GOQ0LQ2nDJa++2Z6Xh121pHGQTv0j+fAa5Pkoo78/NbE29XTTBd+mLQIomYDyrMqM6uJIvykg9i6incC/c401n6iaWRoli2iv6jnhoLSa0KtCnsTrYmZcunZ9s7ukHJhjazBX7yk1SIqcpvC3xJNwFZiMX2IxokFJ9186UL6ASjVsBjumZ37XpdXlEudJzWKB71e4aZ0o+KG+ZDS32biQNsksgSk3fvBMw1WPJiLmQkqA6IeOlqj/hQ+Qru6drt9LAmkSwxOPnIlu0i2apWmzr9WkvvnwRJvvTPjqFI98dyAhjTr4ymMafwrKBX6oNy3N5NbGCIO8FRisTiFgS0h6tMCgpks/lwJz5FObdeyLV0BVSbEYiX1B+TyE4pMtzaQBTcZ1hdWnTz/sLY9KGKjCQmLVQrk2UfJowex4Jzu2oYlhSefhzbISXIm/FQvxMzl+6zjXMv7Hpkw/xkOj/2wjbCjBM8Ej4Z+SICZBIKJXVhjhhqBFlRfNJUXWDzKLxZmG133MSiQxqZ/IQ++PtQG00i15ZXQrt6 X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(346002)(376002)(39860400002)(396003)(136003)(230922051799003)(230273577357003)(230173577357003)(82310400011)(1800799012)(64100799003)(451199024)(186009)(40470700004)(46966006)(36840700001)(4326008)(8676002)(81166007)(356005)(8936002)(110136005)(70586007)(70206006)(316002)(54906003)(86362001)(36756003)(2906002)(41300700001)(5660300002)(44832011)(40480700001)(40460700003)(7696005)(47076005)(6666004)(16526019)(26005)(478600001)(336012)(36860700001)(83380400001)(426003)(1076003)(82740400003)(2616005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 18:54:29.8871 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68203232-e58d-4d1c-9319-08dc1d0de564 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5434 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.1 20240124 (experimental) [2] Compiling C object lib/librte_dmadev.a.p/dmadev_rte_dmadev.c.o ../lib/dmadev/rte_dmadev.c: In function ‘dmadev_handle_dev_dump’: ../lib/dmadev/rte_dmadev.c:1033:29: warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Wcalloc-transposed-args] 1033 | buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN); | ^~~~ Fixes: 94043b04212a ("dmadev: support telemetry dump dmadev") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup Reviewed-by: Chengwen Feng --- Cc: fengchengwen@huawei.com --- lib/dmadev/rte_dmadev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c index 5953a77bd6f9..c4e909270058 100644 --- a/lib/dmadev/rte_dmadev.c +++ b/lib/dmadev/rte_dmadev.c @@ -1030,7 +1030,7 @@ dmadev_handle_dev_dump(const char *cmd __rte_unused, if (*end_param != '\0') RTE_DMA_LOG(WARNING, "Extra parameters passed to dmadev telemetry command, ignoring"); - buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN); + buf = calloc(RTE_TEL_MAX_SINGLE_STRING_LEN, sizeof(char)); if (buf == NULL) return -ENOMEM; From patchwork Wed Jan 24 18:54:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 136116 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3C0B439B8; Wed, 24 Jan 2024 19:55:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 325E542E11; Wed, 24 Jan 2024 19:54:39 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2058.outbound.protection.outlook.com [40.107.94.58]) by mails.dpdk.org (Postfix) with ESMTP id 51C0F42E00; Wed, 24 Jan 2024 19:54:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PI7JG1IxuVsHynHPLg7JpnwAH0mSQl5b1jyHldWwwnUIVYLRVbsm3FmhhsQzCZXEzAwe3LEump2gAlAhWD8YTCDgOqED1g4H5Phdw8VJh48T+WkfJ1PBz9TxVnpb08ay8Pi3nMa138QDIxADwmpFEclVCR7xbMY6/1Pme7yDLpEsa/zENCL/hGnA761TASYIfKvsKg3rKzSaUm1qG0eyC7z3QYC9+asP4RG/eNkwqlaUZm+p7n4VP4Aol+IwtBTwY/Alxj9j2ra+LlGPARDByODYeYnhITGw9bFZVVplYtk0FaxOqj4FK0x/cf58fbwPOe/RmKDZLBJaqB/+nk3Z1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QTkHxtAAua37OagOJT4nnls1ahCleJbm6gpd8dGM4K0=; b=IKo8WWhRL6bMVqLLN7lcqkIxxo4N4MEeVNG+BUhF4HRzhmWVPuY4y2zT/jHOWJjNn5FTKklUpRXWpgNjs9sk4hOLLFKDgY+a1LKKSUMu8Ds6cnATrvkmJ21FlBwBrU9pMB3+JbXtqj+ow+pQUMpzKaU9zbrCD7KVHTmKgb5XfM6vREDqQCbbVfv6isqyc5E/6j2k+LUeQRtqV2sGGHGvuID7VG0B+j8YKEuDnjGOp5uuOsudAWVdBhP1NS20dYaH90oDGSIwAhrPPlRsrVyyGNMmS+pPjyWRyg8Zv7eCT9CW0d2L3Rx5ehmGndAH9CEQTjj8CfLa7zeUEZB3DgI2mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nvidia.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QTkHxtAAua37OagOJT4nnls1ahCleJbm6gpd8dGM4K0=; b=u3xlQ6txfvd6DIjJ+c96rjStb+LdnFiJvXfTWMFsL1y0QQzH/agSTkNfgYN55O8mW8tMHenAoYjhqQsYO7DpUV9ViktBinaRAxrZHCSURN7F/jh+Ubdj7mrWsEzKEaQ4Lo5uLIpE7xksrJeOwJ5C36imRB3d9Pho1/B10+dxIc0= Received: from BYAPR01CA0021.prod.exchangelabs.com (2603:10b6:a02:80::34) by MN0PR12MB6271.namprd12.prod.outlook.com (2603:10b6:208:3c1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Wed, 24 Jan 2024 18:54:31 +0000 Received: from SJ1PEPF00001CE9.namprd03.prod.outlook.com (2603:10b6:a02:80:cafe::8f) by BYAPR01CA0021.outlook.office365.com (2603:10b6:a02:80::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22 via Frontend Transport; Wed, 24 Jan 2024 18:54:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE9.mail.protection.outlook.com (10.167.242.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7202.16 via Frontend Transport; Wed, 24 Jan 2024 18:54:31 +0000 Received: from telcodpdk.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 24 Jan 2024 12:54:28 -0600 From: Ferruh Yigit To: Dariusz Sosnowski , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad , Dmitry Kozlyuk CC: , , Subject: [PATCH v2 6/8] common/mlx5: fix calloc parameters Date: Wed, 24 Jan 2024 18:54:03 +0000 Message-ID: <20240124185406.3598985-6-ferruh.yigit@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124185406.3598985-1-ferruh.yigit@amd.com> References: <20231102130847.3367102-1-ferruh.yigit@amd.com> <20240124185406.3598985-1-ferruh.yigit@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE9:EE_|MN0PR12MB6271:EE_ X-MS-Office365-Filtering-Correlation-Id: 504b38c0-63db-45ab-9c13-08dc1d0de650 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ulR+KoR10NFLCz/D9tpI5XyLL4h9VV5l5FLCT5/k2ItmryuAwmHmSmy5jvatHf6ZMd0Frgw1DYznQf3VcN20WXUDT5Y8DGNSfQ8WTn74UJlF1KgFMBKEbgSJybM/HbSAo/i3F3ffGVbHMz0kHHm2scx0I7nEXI0Pq4RU7bhkRSi9sCrPfVpaoeINpXk7Uqa889xN3K8Iasg1xtAfSVEi9KU+TvvIBCvyNUws9HMK/Cqs4qsM9g38pK8WnjyvgL2CxDPkgh+UDnWbhgXkPqMRpOr+P/88mY2lwsq/MEoi58Dm9zq+D14Y0JYtV3pi72eX60Pw2/tofXhlpqjNga+CKnHFX5QH1l4O0jGcb7nFSeBFpDptoGSlsQWM6HiftJ2x2V0rakSBH27jiN17PEWjRyDNgA36YwzRLJi105yZqeDB40uUWO5pnHd2RSZmV91s4ZzU3KsgSnqvyWfwR9cMS08KmwaZvyiIvCFIj3IdU3e14eN58tAbrb3OVPqq1AuEKy/OMBX98YhxRHiDpGSOsFxsaj0Q52K8GwmCPm2z8DNfHpCvoBzJAI1jOy7PD5CzxhPwbWIMSp5xjJiYAPqACdvk74gnnf9cNG5AiTnakSCgMHA1k4M3vFnv4amZ02XNtObEkKGZKWoFSqXottRNEujyne5K42U2AwWYWJwp+vZjbszHQReUF88oXn6KbDvvsiUHexCT/ktjeeqFAUOokUSJiaThbqrUFSmflAsmIWW/FgL9+1xU6uwCga0cwVG7o2uSet63oZIYDu8P8c2V5SqF1JXWmmJjflIq80FHdGczLwVFIstscdZiLd/EZe9H X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(376002)(39860400002)(396003)(346002)(136003)(230922051799003)(230173577357003)(230273577357003)(1800799012)(64100799003)(186009)(451199024)(82310400011)(46966006)(40470700004)(36840700001)(86362001)(36756003)(40480700001)(40460700003)(356005)(70586007)(54906003)(316002)(82740400003)(81166007)(1076003)(70206006)(83380400001)(2616005)(7696005)(336012)(6666004)(16526019)(426003)(41300700001)(478600001)(8676002)(44832011)(8936002)(26005)(4326008)(5660300002)(2906002)(36860700001)(110136005)(47076005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 18:54:31.4340 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 504b38c0-63db-45ab-9c13-08dc1d0de650 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6271 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.1 20240124 (experimental) [2] Compiling C object .../common_mlx5_mlx5_common_mr.c.o .../mlx5/mlx5_common_mr.c: In function ‘mlx5_mempool_get_chunks’: .../common/mlx5/mlx5_common_mr.c:1384:29: warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Wcalloc-transposed-args] 1384 | *out = calloc(sizeof(**out), n); | ^ Fixes: 7297d2cdecce ("common/mlx5: fix external memory pool registration") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup Acked-by: Dariusz Sosnowski --- Cc: dkozlyuk@nvidia.com --- drivers/common/mlx5/mlx5_common_mr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/mlx5/mlx5_common_mr.c b/drivers/common/mlx5/mlx5_common_mr.c index 40ff9153bd8e..85ec10d2ee36 100644 --- a/drivers/common/mlx5/mlx5_common_mr.c +++ b/drivers/common/mlx5/mlx5_common_mr.c @@ -1381,7 +1381,7 @@ mlx5_mempool_get_chunks(struct rte_mempool *mp, struct mlx5_range **out, DRV_LOG(DEBUG, "Collecting chunks of regular mempool %s", mp->name); n = mp->nb_mem_chunks; - *out = calloc(sizeof(**out), n); + *out = calloc(n, sizeof(**out)); if (*out == NULL) return -1; rte_mempool_mem_iter(mp, mlx5_range_from_mempool_chunk, *out); From patchwork Wed Jan 24 18:54:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 136117 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E33EC439B8; Wed, 24 Jan 2024 19:55:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCF7242E1E; Wed, 24 Jan 2024 19:54:41 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2088.outbound.protection.outlook.com [40.107.92.88]) by mails.dpdk.org (Postfix) with ESMTP id DD69242E14; Wed, 24 Jan 2024 19:54:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J4yYcc5nANqRq5YFZGL9trXzhcJZPUSa1p5SrwzEEs6ecFB7XAZ6HEVr+Ye8wBNp+wIvnURY1CJHw+zyrZC2gzSj3z66LVDBKx8Jjx4n71dImPwnjH2HYJAWdyUjUk5IFRaCkMiYZ17DgxIc/9lnBrobWMOBRf3t/QAVxrTOvMQ6DWoAUK4XLxqDD9kJdZacvm3XL78T+xWIjuXv0TEYOxY4ot1ck7RyYrenpMf/sOgGvOjMQvFz1Y1ZoJ4iCiy3rm99j3p1oMy148wb6OjO21+k5UTpmv9NBnhpK0R/0O0+ontIEBTSav+/N+4KKoTy8FvqCoBewFw9HHlA24gGvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oqHKkImhplFXkLlBKnf3a2qy5GdOqm7InB6DPifdrww=; b=RO3mpnlgZrhlC2vu9H7Ablu02/HICRZIkNYqnMxibEqEvA2Kh101yaQOhTgNJNz+Nnf8qCbTzo9V1/OroXyiW+bEaSKaJaNFAp7jC4WCwG4gQTDI7VK7KvVleWEQboDThR6oL6O1Jmok1xaF3n1Bbkd21qx1glPLrY+REWaaw3vyvQeX07nxlJhLX7gbVyILkW3QInPoTtrNJxziLv6D4RVjaS+/1jLQVc0j0NkuAQ6Jz34A7yULgBV/u75bCCk2fnjdjEw6X2Wl+/LqfWPgy3rNbtLKRb3UWKU+GtQ5R9n70Oz3txeIl4ztSXi90gPrl/S9CnxPSzBue/lBSKVBsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=jaube.fr smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oqHKkImhplFXkLlBKnf3a2qy5GdOqm7InB6DPifdrww=; b=Tcbf/59ANg+4tSEnkpFq5oRUk650wdLWGlh46thaWhOH82eTF2C2q5dusyoxZimQVxVQ6BAHNC+BK2AZDuPDCwprKSQa5djMei1ZsOoKJZ8iSmls+qrRepy4B8kpVk/L2Q7AZG0/afqbG3r6x1hc8mx1cw8tohh+6n53TcbdSVI= Received: from BYAPR01CA0011.prod.exchangelabs.com (2603:10b6:a02:80::24) by PH7PR12MB7890.namprd12.prod.outlook.com (2603:10b6:510:268::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Wed, 24 Jan 2024 18:54:35 +0000 Received: from SJ1PEPF00001CE9.namprd03.prod.outlook.com (2603:10b6:a02:80:cafe::1d) by BYAPR01CA0011.outlook.office365.com (2603:10b6:a02:80::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.24 via Frontend Transport; Wed, 24 Jan 2024 18:54:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE9.mail.protection.outlook.com (10.167.242.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7202.16 via Frontend Transport; Wed, 24 Jan 2024 18:54:34 +0000 Received: from telcodpdk.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 24 Jan 2024 12:54:30 -0600 From: Ferruh Yigit To: Julien Aube , Harish Patil , Stephen Hemminger CC: , Subject: [PATCH v2 7/8] net/bnx2x: fix calloc parameters Date: Wed, 24 Jan 2024 18:54:04 +0000 Message-ID: <20240124185406.3598985-7-ferruh.yigit@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124185406.3598985-1-ferruh.yigit@amd.com> References: <20231102130847.3367102-1-ferruh.yigit@amd.com> <20240124185406.3598985-1-ferruh.yigit@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE9:EE_|PH7PR12MB7890:EE_ X-MS-Office365-Filtering-Correlation-Id: ba4015e5-cf14-4ef7-8710-08dc1d0de821 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: spp/0wik3mt2L98k9BObvwnyvqGicd4Z1U64NURJkbEqQmQVuEHNbltnA/kzudtPnQpT9z/pMJsMNKf+ZHdFHzyAs6oSTwHfGGMYcLu7XTtC0oD6ROp0SwPSKz2pzneo1rd7SKQb8n82GFzclYfxEc0vTuUzlsFFgJgnFF57ypAs0wCvxE6h+8AJN9DeLhjnK+YOD8bc5Z5fzCs3oM2musAm2GABq4OWRk43azYLJTjUyhLdjrZBAu+kv/MKZ15P3XvBQKT8dnC4ExgNL+jw0k8kiG6kChPQMNGSpF0us1zqWuPuUGK5XOFzdal62EtLJBKIzGraVwk4SThfzKusKufQyYKykoOsfmZITEZNXQiPC4MxyXVS8UkMxsbAjahoko1he7/XsezUd4P47NkZ45VDXMP3ixZ+Y6qiUSX9Y4EwCboNXAfk4d5rh7wcKCao9ScdwtnEpIfFpyH/aOebfJMRZuK+jUnSrD7mRNO41BY8M2mrvtxNEABHTnJwuAGGRTu5qEGW2N/9BKU2sCGRo4PaltGhEeMSXaM9Bsd0NFBHbVWGjMA8tASJmZvtjvQ32SVg7Y/iO7Il0czdx/EEq65CE5EOjWfBDW59tcp6RRR+2FyX0O+YEtBTU2fpsogFYBm27WkSk7yvmXiBuZzCZQQGwPFcuEANC91HZzAbXD9PGM2lHfBDU7rJU/5OAXoTpr5aQKQOwAel9PldFeel7VeC9TELZoHkWDKiWxH2OB9S96SZkSn38+GaSM7B6LLTdUF0vW+jXlqrw/jqAaUXLD2S9UZoGe2DOUcnkDtw7HsMZnuZ1jJZQACnmlXtJ/kT X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(376002)(346002)(396003)(136003)(39860400002)(230273577357003)(230173577357003)(230922051799003)(1800799012)(451199024)(64100799003)(82310400011)(186009)(40470700004)(36840700001)(46966006)(81166007)(1076003)(2616005)(7696005)(70206006)(40460700003)(54906003)(70586007)(316002)(356005)(40480700001)(110136005)(83380400001)(47076005)(4326008)(8936002)(8676002)(44832011)(26005)(16526019)(336012)(6666004)(36860700001)(478600001)(5660300002)(82740400003)(426003)(2906002)(41300700001)(86362001)(36756003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 18:54:34.4340 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ba4015e5-cf14-4ef7-8710-08dc1d0de821 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7890 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org gcc [1] generates warning [2] about rte_calloc usage, because rte_calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.1 20240124 (experimental) [2] Compiling C object drivers/libtmp_rte_net_bnx2x.a.p/net_bnx2x_bnx2x.c.o ../drivers/net/bnx2x/bnx2x.c: In function ‘bnx2x_alloc_ilt_lines_mem’: ../drivers/net/bnx2x/bnx2x.c:2392:44: warning: ‘rte_calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Wcalloc-transposed-args] 2392 | sizeof(struct ilt_line), ILT_MAX_LINES, | ^~~~~~ Fixes: 540a211084a7 ("bnx2x: driver core") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup --- Cc: stephen@networkplumber.org --- drivers/net/bnx2x/bnx2x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index c3283c94f38f..597ee4335977 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -2389,7 +2389,7 @@ int bnx2x_alloc_ilt_mem(struct bnx2x_softc *sc) static int bnx2x_alloc_ilt_lines_mem(struct bnx2x_softc *sc) { sc->ilt->lines = rte_calloc("", - sizeof(struct ilt_line), ILT_MAX_LINES, + ILT_MAX_LINES, sizeof(struct ilt_line), RTE_CACHE_LINE_SIZE); return sc->ilt->lines == NULL; } From patchwork Wed Jan 24 18:54:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 136118 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1C19439B8; Wed, 24 Jan 2024 19:55:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6EF942E22; Wed, 24 Jan 2024 19:54:42 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2076.outbound.protection.outlook.com [40.107.212.76]) by mails.dpdk.org (Postfix) with ESMTP id 742D042E19; Wed, 24 Jan 2024 19:54:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AddnHZbwv5ySGw+4F4ZCM/4iJ458ROly+oJbfm1xEm977BVTEqjgRLg7FokxZfHss84NOa6u3/Gpat0uQG2FHUipgus+PRCoLyF15mSBcPT7K/YaR8revA488aELDznh9pGHIUZ/USrNDmcpT4Gq1OJOCOGYXg7X2j3yZN+WnIsEzRiJLTFcwWtJScibiL+tT/a60HlK1jkIBuUVXOPe4G8690uoHZ89ogKGNAYh1HsiXxrwvY+A+M0oeVNG8MTL+hYeU82vLcMqQLMsoRdHW0Beb415wSujmKY86g4ZxcHGEK0vYlmASUYGbjv0Turqpzkp449e2w3MvTEv6cRBOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IIScUqkbnGcIOTY0hkxPOw4eYFK9e3dlt2pwsxgupJg=; b=I2aq39EXAu/8YY+64LI+LZ67oUjfwW01xzcb/js4xRUaIrjxs+ixhFmWCVasEWjvO4YfFQmGZ0NQC5Tl/e3shenBagQnGHJ6DqTc15yHrHTQGRYYmdIIYdRO3zNbVZjTiXDkYajJuT6YUynm4pPT0QAOim/881dF8/ZZjma71AHnA8sn8CEAgdzB172t7YY27O13jeiVNyVackkKuzRx5GE22mq95J3tY9yQK024uG2QF/ckVqsRxGld5mM4/Opixv6GPxTz2kWTl+MDkDH07Z7JJEep2NlXrjPNrIFrhYok64lFDssrdBILAiwYhSZQbXnpYlXr3MzDXZ+UrASjBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=oktetlabs.ru smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IIScUqkbnGcIOTY0hkxPOw4eYFK9e3dlt2pwsxgupJg=; b=DGXFA1Oat3KFiI8QxDNca5NVNz/UpDCLJ2XA4tmDhG0AByOrymY2tptV9+P3sfS1rUQbJPSqb7uP06rXih6b3mn1r1Z3zCqbwhxQ2125DyQLuRuzHGFJiPJzh3Npd2YvfOWMqYiP8B0vxG+YRPdn/6q+NGa4c3DzMSNlXmg1RvA= Received: from BYAPR01CA0021.prod.exchangelabs.com (2603:10b6:a02:80::34) by CH0PR12MB5281.namprd12.prod.outlook.com (2603:10b6:610:d4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.24; Wed, 24 Jan 2024 18:54:37 +0000 Received: from SJ1PEPF00001CE9.namprd03.prod.outlook.com (2603:10b6:a02:80:cafe::ff) by BYAPR01CA0021.outlook.office365.com (2603:10b6:a02:80::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22 via Frontend Transport; Wed, 24 Jan 2024 18:54:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE9.mail.protection.outlook.com (10.167.242.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7202.16 via Frontend Transport; Wed, 24 Jan 2024 18:54:35 +0000 Received: from telcodpdk.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 24 Jan 2024 12:54:30 -0600 From: Ferruh Yigit To: Andrew Rybchenko , Andy Moreton , Ivan Malov CC: , Subject: [PATCH v2 8/8] net/sfc: fix calloc parameters Date: Wed, 24 Jan 2024 18:54:05 +0000 Message-ID: <20240124185406.3598985-8-ferruh.yigit@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124185406.3598985-1-ferruh.yigit@amd.com> References: <20231102130847.3367102-1-ferruh.yigit@amd.com> <20240124185406.3598985-1-ferruh.yigit@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE9:EE_|CH0PR12MB5281:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b591bdd-5d80-4de6-9473-08dc1d0de8b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A8D4QwXu+oARYvcOQ1iu0TwVgviY7xX1sO0FAXuzFP9syAmgPFouzvtf1kI8/rcip1mhG92OS+Sg5Lwm6LKSAA7h0T+0BgpPbpjb5WMApB/xoAWxhD24zXqaiZvvfe2OERKIQzxfwiHj/uXMLa23tzTOBTFd2esNopUDd1Cg9Eom6PuH4jzQbv/jcRVKr8ymThyiDj3B7Ba8dIOyQtr1mGl5inXoln6fWXejSk1FuuL1whCvxG8o7V2dstNoPAUjUFeBTiBPU91tdzO+omyCNBzWDe74PEZ9BgQx6RwEl+Ekh76oEocoJ3Fb9WP+lDPz3sqycQ8aAjgPUxa3JkNPKnMGIBwHc6yxN3A3XMOBU02BDpy9Nraql4OVTexjzf+8tfu+6XxsAbIDKBmGfS7YCp2m8UyKnNHWxfj8Orh8OGxD+EEHPvKIajlMTSZdDTX8tf78nH5cPW3xmQB0nKG+YfpTq2gye96KmW8bhYbYgrT65XhnF0K8KyisiazYGJIKgcbuk7L6Rz4HRfom3xRaoAeU8FgVX2ubI4dUzrRGtTV1mc3SV3opN22hCsxY8vAkcFLHkhGJJO2E+uqjwdU5wzotsUxteAEBudWi/N5n4xDiPu590/JUHyYB263+gmuTQRjTSq0MSL5xhEI89ejU+UZaGxsCIahC76P+ba/T/IxP8gzUvbx4bMTkzgpdDuB+EZ4UhaDeMPE9cY1uaWYidn8zUawGcc7/PDIGyRRtotYOH+AEeX5vYhjBXeACXwh9CNGrATXQHRnmtx19E4bNPqQZ3DzcOBpBm4Pa7ptEE0q9Andy6muwkLGsyXRPx3Zd X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(396003)(39860400002)(136003)(376002)(346002)(230173577357003)(230922051799003)(230273577357003)(64100799003)(82310400011)(186009)(1800799012)(451199024)(40470700004)(36840700001)(46966006)(26005)(81166007)(356005)(82740400003)(478600001)(41300700001)(86362001)(7696005)(36756003)(8936002)(426003)(6666004)(16526019)(2616005)(4326008)(8676002)(336012)(110136005)(316002)(5660300002)(1076003)(70206006)(70586007)(54906003)(36860700001)(2906002)(44832011)(83380400001)(47076005)(40460700003)(40480700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 18:54:35.4184 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7b591bdd-5d80-4de6-9473-08dc1d0de8b0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5281 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org gcc [1] generates warning [2] about rte_calloc usage, because rte_calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.1 20240124 (experimental) [2] Compiling C object drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_mae.c.o ../net/sfc/sfc_mae.c: In function ‘sfc_mae_action_set_list_add’: ../drivers/net/sfc/sfc_mae.c:1353:35: warning: ‘rte_calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Wcalloc-transposed-args] 1353 | sizeof(struct sfc_mae_action_set *), | ^~~~~~ Fixes: 002f591f54c3 ("net/sfc: support packet replay in transfer flows") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup Reviewed-by: Andrew Rybchenko --- Cc: ivan.malov@arknetworks.am --- drivers/net/sfc/sfc_mae.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c index e5ec0ae49d4d..60ff6d21810a 100644 --- a/drivers/net/sfc/sfc_mae.c +++ b/drivers/net/sfc/sfc_mae.c @@ -1350,8 +1350,8 @@ sfc_mae_action_set_list_add(struct sfc_adapter *sa, action_set_list->action_sets = rte_calloc("sfc_mae_action_set_list_action_sets", - sizeof(struct sfc_mae_action_set *), - action_set_list->nb_action_sets, 0); + action_set_list->nb_action_sets, + sizeof(struct sfc_mae_action_set *), 0); if (action_set_list->action_sets == NULL) { sfc_err(sa, "failed to allocate action set list"); rte_free(action_set_list);