From patchwork Thu Jul 25 14:21:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harman Kalra X-Patchwork-Id: 57115 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4D8731C376; Thu, 25 Jul 2019 16:21:42 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 5803C1C376 for ; Thu, 25 Jul 2019 16:21:40 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6PEKnk7029028; Thu, 25 Jul 2019 07:21:39 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=/lmm1++lXAFtwgyBATtxmZVmGCU2XfqrwYvXTMdbWaI=; b=qpCWh7xz1iORIxBoZQRHAie2x6mvmTntMj9tGPqswdMTIhqHR4km4ZQuvIMC6+CKjdDI u8sOtKj/jhuMMINmpnNQVWsOyMDFmukpnYpsz4U3VYOKuVUNO5/bgNnCIMsVQtsDYo0N a5CV6cJzDfG6uc62Wd3ubtYc5/puOslDsHw2Bg0kUDVHW2z0V1srMIWKENDFGNydwGzr pdOOmChzRdd2jpbAI7hsiSwrQv3006Cha8VNhVw6CEIqF8GjCijOsq7hPRA4i+MiW1Jp ZcaZdlu7iWP9A6ggpquINJxQfeINPGRB02Bcw3PjitTzrn9sAggHgoa9paiHRr5GVZPA 2w== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2tx6251n5x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 25 Jul 2019 07:21:39 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 25 Jul 2019 07:21:38 -0700 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.57) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 25 Jul 2019 07:21:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EqsxqliGg1gUMBdb54AA1Gv2D+9AWvivmQQGhzthEQgpoc48VpSVBOLp54v/+pWl9m3WUtHT1IPcZetesqZerOIOjVcLqutc+pdogRGD1GX4LLDkDUeMZQPNVAQKcpdJ40zdNCSXQ12ZaPiSjfKFfiEjl8NkDJv547i85pkWMP2YZDcvFA1VMWohwjIRl+mVX1EvTZ3jEgSmgJPoDBijubUASO3vwQxKZw1BGYZNFBR3arl3uEpEzh741o6NmIu/KVB/iDVoRwlFkB19HnMUyT2n6nLMfr6R9RQZgQdatMmJwbLDlfXC/dLXbKIZvSNH5NTjH6PjdD4jRSrXiM0DEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/lmm1++lXAFtwgyBATtxmZVmGCU2XfqrwYvXTMdbWaI=; b=D3nIspKht6VsrQHn3MNJch68nlAIoEn7ZyRbD5IYDtZ20oPQgtreS+uAROGzCsfMUjkrgj9sz3TVgm3GC7FXpmBL383/BIf9iJicbeXVLE/2gNfcVM0CO4WVxt0DvNONtBQ2ZDzPHf9FwHAM4LolgTWb6749OqjeAW+fhQ0Zou20P6Cs59kIVBiXNuP9womzRCo1liKTu4/gwDuVuCowvG3l9IhpSCE1/7tjHVSpWhP3D1D3Z9EYpp73sXZdasRlHpXiL7OCCzvSykPMXMRANe831y2K14YpbTGwre7KhkJuFAWd69BVRiP4pqAnq6JgUGztKwARbITkkyrWJq30yQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/lmm1++lXAFtwgyBATtxmZVmGCU2XfqrwYvXTMdbWaI=; b=dl4GdxTDfDiATFJD4jMDXbdx+hXV2PoJx0PJbb/avmehP5EZsvstqFeK5BmX4yjK4jOERatv3naHKOTex1Qt/b2/KQ1D+eX76u9Ex86l+Odb4iZcxu3lkxAKleJCVj/C7wgfIBqHysPRGmGQl1+618fdl2rILlvL1GkKFut+0Qc= Received: from MN2PR18MB2848.namprd18.prod.outlook.com (20.179.21.149) by MN2PR18MB3198.namprd18.prod.outlook.com (10.255.236.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.14; Thu, 25 Jul 2019 14:21:35 +0000 Received: from MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::4447:9459:5386:2e18]) by MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::4447:9459:5386:2e18%7]) with mapi id 15.20.2115.005; Thu, 25 Jul 2019 14:21:35 +0000 From: Harman Kalra To: John McNamara , Pablo de Lara , Bruce Richardson , Harry van Haaren , Xiaoyun Li CC: "dev@dpdk.org" , Harman Kalra Thread-Topic: [PATCH] examples/ptpclient: fix delay request message Thread-Index: AQHVQvRDIpuufYEFRUG2Fbs6j41Xpg== Date: Thu, 25 Jul 2019 14:21:35 +0000 Message-ID: <1564064454-28335-1-git-send-email-hkalra@marvell.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: PN1PR0101CA0043.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::29) To MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:3e::21) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.7.4 x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 43dee6bc-2be0-4f88-895b-08d7110b663a x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB3198; x-ms-traffictypediagnostic: MN2PR18MB3198: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0109D382B0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(136003)(376002)(39860400002)(366004)(189003)(199004)(2616005)(110136005)(486006)(476003)(52116002)(99286004)(54906003)(26005)(25786009)(66066001)(107886003)(71190400001)(71200400001)(6512007)(53936002)(68736007)(8676002)(8936002)(81166006)(316002)(81156014)(186003)(256004)(14444005)(6506007)(386003)(102836004)(50226002)(55236004)(14454004)(86362001)(6436002)(6116002)(3846002)(2906002)(478600001)(36756003)(66556008)(66476007)(64756008)(66446008)(4326008)(5660300002)(7736002)(305945005)(66946007)(15650500001)(6486002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3198; H:MN2PR18MB2848.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: yWw2GLfjbMirSzAt2VYIVwewoEf6okcEmbahPCFGRbEhTxJBZ8g9mKwr+Sc6OOtNEdKvCOQAveh+MKRVHhGrD8vhNBwDZUm61muAnozVXpzofl0PQNloq2kTKY+V8eCrLYJGvpQ+iywQwV27bgIDQ2Rbs1/L563oGbL/yhtt4OE96pCtWm184w/LrIv0idmpz/sIhXOHH1pLgt72QXudxwjNasAbxjaGXg05XEpvzZ13b1Ed1G1jvQGwJO2uQDE0edzEPdVcfwDfGi7fusAXrAtOuZluSVNUeWNsp6LtFFm6fO98H6gQw3sj9lRJ0/qHgKH5JM8dLQB8ksO5JTzRvo64N+hbM/GuSCnsmbgMxKzt9IL0eknF6/+P3cCbxsyz+aW4dXbtkGeGXntNKanVgmf465u5UkgZSyYzYUMfPU8= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 43dee6bc-2be0-4f88-895b-08d7110b663a X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2019 14:21:35.5608 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hkalra@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3198 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-25_05:2019-07-25,2019-07-25 signatures=0 Subject: [dpdk-dev] [PATCH] examples/ptpclient: fix delay request message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Observed an issue with the length and domain number of the delay request message sent out by the client. Due to which delay response from master was not received. Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client") Change-Id: I1031fa630e97709818c4b440e1e5fdc31205ab9c Signed-off-by: Harman Kalra --- examples/ptpclient/ptpclient.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c index 95b0c176e..be101d7ab 100644 --- a/examples/ptpclient/ptpclient.c +++ b/examples/ptpclient/ptpclient.c @@ -233,7 +233,11 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool) return retval; /* Enable timesync timestamping for the Ethernet device */ - rte_eth_timesync_enable(port); + retval = rte_eth_timesync_enable(port); + if (retval < 0) { + printf("timesync enable failed: %d\n", retval); + return retval; + } /* Enable RX in promiscuous mode for the Ethernet device. */ rte_eth_promiscuous_enable(port); @@ -413,6 +417,9 @@ parse_fup(struct ptpv2_data_slave_ordinary *ptp_data) ptp_msg->delay_req.hdr.ver = 2; ptp_msg->delay_req.hdr.control = 1; ptp_msg->delay_req.hdr.log_message_interval = 127; + ptp_msg->delay_req.hdr.message_length = + htons(sizeof(struct delay_req_msg)); + ptp_msg->delay_req.hdr.domain_number = ptp_hdr->domain_number; /* Set up clock id. */ client_clkid =