From patchwork Fri Nov 1 11:38:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Medvedkin X-Patchwork-Id: 62306 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB78CA00BE; Fri, 1 Nov 2019 12:38:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4020A1D424; Fri, 1 Nov 2019 12:38:40 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C795E1D41A for ; Fri, 1 Nov 2019 12:38:38 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Nov 2019 04:38:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,254,1569308400"; d="scan'208";a="190936582" Received: from silpixa00400072.ir.intel.com ([10.237.222.213]) by orsmga007.jf.intel.com with ESMTP; 01 Nov 2019 04:38:36 -0700 From: Vladimir Medvedkin To: dev@dpdk.org Cc: konstantin.ananyev@intel.com, bernard.iremonger@intel.com, akhil.goyal@nxp.com Date: Fri, 1 Nov 2019 11:38:34 +0000 Message-Id: X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH] app: add few sanity checks in test-sad app X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Coverity reported about two division by zero: *** CID 350344: Incorrect expression (DIVIDE_BY_ZERO) Although in fact these dividers will never be equal to 0, adding explicit checks in lookup() to make coverity happy will not affect the execution speed. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- app/test-sad/main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/test-sad/main.c b/app/test-sad/main.c index bd05638..e61e33f 100644 --- a/app/test-sad/main.c +++ b/app/test-sad/main.c @@ -519,6 +519,9 @@ lookup(void *arg) uint32_t burst_sz; struct rte_ipsec_sad *sad = arg; + if (config.nb_tuples == 0) + return 0; + burst_sz = RTE_MIN(config.burst_sz, config.nb_tuples); for (i = 0; i < config.nb_tuples; i += burst_sz) { for (j = 0; j < burst_sz; j++) @@ -534,6 +537,7 @@ lookup(void *arg) print_result(keys[j], vals[j]); } } + acc = (acc == 0) ? UINT64_MAX : acc; printf("Average lookup cycles %.2Lf, lookups/sec: %.2Lf\n", (long double)acc / config.nb_tuples, (long double)config.nb_tuples * rte_get_tsc_hz() / acc);