From patchwork Wed Nov 13 16:10:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Traynor X-Patchwork-Id: 62968 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E97A5A04C3; Wed, 13 Nov 2019 17:11:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B10A7B62; Wed, 13 Nov 2019 17:11:00 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 9E7B32AB for ; Wed, 13 Nov 2019 17:10:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573661458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g5Z6a5vb4QMxQeTNTjmIkDRZEak44mImbhZ2XCu1myE=; b=CCwqC/dP0I02+wnC7daF3ymPwTuED1t7CJgtF82Dvd68DBcRbeCw/NTjRgbYR9hWsSXk6L C3z9ISLy/v1rrawbgbubvACy7X8VqLLNd2YA4zdAQ3Smh4PlvPnE/LiotqSvgui7DIhtPg nJGy4qnAl4MUNSr4AyQrehBaxUrNn+w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-256-GiJBq6j5OfO974dymR20WA-1; Wed, 13 Nov 2019 11:10:55 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F1CC918A3E83; Wed, 13 Nov 2019 16:10:53 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-246.ams2.redhat.com [10.36.117.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7814B10027B9; Wed, 13 Nov 2019 16:10:30 +0000 (UTC) From: Kevin Traynor To: dev@dpdk.org Cc: david.marchand@redhat.com, Kevin Traynor , stable@dpdk.org, anatoly.burakov@intel.com, david.hunt@intel.com, maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com, jianfeng.tan@intel.com, shahafs@mellanox.com, alan.carew@intel.com, liang.j.ma@intel.com Date: Wed, 13 Nov 2019 16:10:14 +0000 Message-Id: <20191113161015.9736-1-ktraynor@redhat.com> In-Reply-To: <20191113154353.7162-1-ktraynor@redhat.com> References: <20191113154353.7162-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: GiJBq6j5OfO974dymR20WA-1 X-Mimecast-Spam-Score: 0 Subject: [dpdk-dev] [PATCH v2 1/2] lib: fix log typos X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix these as they are user visible. Found with codespell. Fixes: bacaa2754017 ("eal: add channel for multi-process communication") Fixes: f05e26051c15 ("eal: add IPC asynchronous request") Fixes: 0cbce3a167f1 ("vfio: skip DMA map failure if already mapped") Fixes: 445c6528b55f ("power: common interface for guest and host") Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") Fixes: 8f972312b8f4 ("vhost: support vhost-user") Cc: stable@dpdk.org Signed-off-by: Kevin Traynor Reviewed-by: David Marchand --- v2: fix checkpatch fail Cc: anatoly.burakov@intel.com Cc: david.hunt@intel.com Cc: maxime.coquelin@redhat.com Cc: tiwei.bie@intel.com Cc: zhihong.wang@intel.com Cc: jianfeng.tan@intel.com Cc: shahafs@mellanox.com Cc: alan.carew@intel.com Cc: liang.j.ma@intel.com --- lib/librte_eal/common/eal_common_proc.c | 4 ++-- lib/librte_eal/linux/eal/eal_vfio.c | 4 ++-- lib/librte_power/power_acpi_cpufreq.c | 4 ++-- lib/librte_power/power_pstate_cpufreq.c | 6 +++--- lib/librte_vhost/socket.c | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c index cbe8d10fc..935e8fefe 100644 --- a/lib/librte_eal/common/eal_common_proc.c +++ b/lib/librte_eal/common/eal_common_proc.c @@ -284,5 +284,5 @@ read_msg(struct mp_msg_internal *m, struct sockaddr_un *s) if (msglen != buflen || (msgh.msg_flags & (MSG_TRUNC | MSG_CTRUNC))) { - RTE_LOG(ERR, EAL, "truncted msg\n"); + RTE_LOG(ERR, EAL, "truncated msg\n"); return -1; } @@ -1072,5 +1072,5 @@ rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts, if (gettimeofday(&now, NULL) < 0) { - RTE_LOG(ERR, EAL, "Faile to get current time\n"); + RTE_LOG(ERR, EAL, "Failed to get current time\n"); rte_errno = errno; return -1; diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c index 28e10cdc4..95f615c2e 100644 --- a/lib/librte_eal/linux/eal/eal_vfio.c +++ b/lib/librte_eal/linux/eal/eal_vfio.c @@ -1295,5 +1295,5 @@ vfio_type1_dma_mem_map(int vfio_container_fd, uint64_t vaddr, uint64_t iova, if (errno == EEXIST) { RTE_LOG(DEBUG, EAL, - " Memory segment is allready mapped," + " Memory segment is already mapped," " skipping"); } else { @@ -1380,5 +1380,5 @@ vfio_spapr_dma_do_map(int vfio_container_fd, uint64_t vaddr, uint64_t iova, if (errno == EBUSY) { RTE_LOG(DEBUG, EAL, - " Memory segment is allready mapped," + " Memory segment is already mapped," " skipping"); } else { diff --git a/lib/librte_power/power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c index 7c386f891..22989244a 100644 --- a/lib/librte_power/power_acpi_cpufreq.c +++ b/lib/librte_power/power_acpi_cpufreq.c @@ -31,5 +31,5 @@ #define FOPEN_OR_ERR_RET(f, retval) do { \ if ((f) == NULL) { \ - RTE_LOG(ERR, POWER, "File not openned\n"); \ + RTE_LOG(ERR, POWER, "File not opened\n"); \ return retval; \ } \ @@ -110,5 +110,5 @@ set_freq_internal(struct rte_power_info *pi, uint32_t idx) return 0; - POWER_DEBUG_TRACE("Freqency[%u] %u to be set for lcore %u\n", + POWER_DEBUG_TRACE("Frequency[%u] %u to be set for lcore %u\n", idx, pi->freqs[idx], pi->lcore_id); if (fseek(pi->f, 0, SEEK_SET) < 0) { diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufreq.c index ecbcb3ac9..8f095e0ab 100644 --- a/lib/librte_power/power_pstate_cpufreq.c +++ b/lib/librte_power/power_pstate_cpufreq.c @@ -34,5 +34,5 @@ #define FOPEN_OR_ERR_RET(f, retval) do { \ if ((f) == NULL) { \ - RTE_LOG(ERR, POWER, "File not openned\n"); \ + RTE_LOG(ERR, POWER, "File not opened\n"); \ return retval; \ } \ @@ -288,5 +288,5 @@ set_freq_internal(struct pstate_power_info *pi, uint32_t idx) } - POWER_DEBUG_TRACE("Freqency '%u' to be set for lcore %u\n", + POWER_DEBUG_TRACE("Frequency '%u' to be set for lcore %u\n", target_freq, pi->lcore_id); @@ -311,5 +311,5 @@ set_freq_internal(struct pstate_power_info *pi, uint32_t idx) } - POWER_DEBUG_TRACE("Freqency '%u' to be set for lcore %u\n", + POWER_DEBUG_TRACE("Frequency '%u' to be set for lcore %u\n", target_freq, pi->lcore_id); diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index a34bc7f9a..ebb2ff6c2 100644 --- a/lib/librte_vhost/socket.c +++ b/lib/librte_vhost/socket.c @@ -133,5 +133,5 @@ read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds, if (msgh.msg_flags & (MSG_TRUNC | MSG_CTRUNC)) { - RTE_LOG(ERR, VHOST_CONFIG, "truncted msg\n"); + RTE_LOG(ERR, VHOST_CONFIG, "truncated msg\n"); return -1; } From patchwork Wed Nov 13 16:10:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Traynor X-Patchwork-Id: 62969 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5500A04C3; Wed, 13 Nov 2019 17:11:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7CF112B86; Wed, 13 Nov 2019 17:11:16 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 548752BC7 for ; Wed, 13 Nov 2019 17:11:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573661473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C4hSIHQOg7WaSfTNCPwqWpT4liM4oSMpEHtVd50CgS8=; b=HcTCgFli/I5oG5ukC/ElI9KLO3K3MrKDYnpUwQU1am1I4a5lN5k0fjK4EuZFzMkddUoXy+ hEa99plms8bIeboSYD/8CfZdSl9JBWuHri98VxLJ3Bc4FcIQGMypBErtfDsaKGltDbKwP7 jwFSxZ0zLSd14rFSiMk2m0L4WD0wlLU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-300-wO-2ak9_PiOmz-TTQ--S-g-1; Wed, 13 Nov 2019 11:11:10 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 39E5E8C3C7D; Wed, 13 Nov 2019 16:11:09 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-246.ams2.redhat.com [10.36.117.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id D2E7010027BF; Wed, 13 Nov 2019 16:10:56 +0000 (UTC) From: Kevin Traynor To: dev@dpdk.org Cc: david.marchand@redhat.com, Kevin Traynor , stable@dpdk.org, anatoly.burakov@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com, david.hunt@intel.com, benjamin.walker@intel.com, olivier.matz@6wind.com, pablo.de.lara.guarch@intel.com, marcinx.hajkowski@intel.com Date: Wed, 13 Nov 2019 16:10:15 +0000 Message-Id: <20191113161015.9736-2-ktraynor@redhat.com> In-Reply-To: <20191113161015.9736-1-ktraynor@redhat.com> References: <20191113154353.7162-1-ktraynor@redhat.com> <20191113161015.9736-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: wO-2ak9_PiOmz-TTQ--S-g-1 X-Mimecast-Spam-Score: 0 Subject: [dpdk-dev] [PATCH v2 2/2] lib: fix Doxygen typos X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix these as they are user visible. Found with codespell. Fixes: af75078fece3 ("first public release") Fixes: c2361bab70c5 ("eal: compute IOVA mode based on PA availability") Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo") Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Fixes: 5a5f3178d4a8 ("power: return error when environment already set") Cc: stable@dpdk.org Signed-off-by: Kevin Traynor --- v2: fix checkpatch fail Cc: anatoly.burakov@intel.com Cc: byron.marohn@intel.com Cc: yipeng1.wang@intel.com Cc: david.hunt@intel.com Cc: benjamin.walker@intel.com Cc: olivier.matz@6wind.com Cc: pablo.de.lara.guarch@intel.com Cc: marcinx.hajkowski@intel.com --- lib/librte_eal/common/eal_common_log.c | 2 +- lib/librte_eal/common/eal_hugepages.h | 2 +- lib/librte_eal/common/include/rte_bus.h | 2 +- lib/librte_eal/common/include/rte_dev.h | 2 +- lib/librte_efd/rte_efd.c | 2 +- lib/librte_power/rte_power.h | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c index e0a7bef03..c0efd5214 100644 --- a/lib/librte_eal/common/eal_common_log.c +++ b/lib/librte_eal/common/eal_common_log.c @@ -46,5 +46,5 @@ static FILE *default_log_stream; /** - * This global structure stores some informations about the message + * This global structure stores some information about the message * that is currently being processed by one lcore */ diff --git a/lib/librte_eal/common/eal_hugepages.h b/lib/librte_eal/common/eal_hugepages.h index 4582f19cf..1b560d337 100644 --- a/lib/librte_eal/common/eal_hugepages.h +++ b/lib/librte_eal/common/eal_hugepages.h @@ -13,5 +13,5 @@ /** - * Structure used to store informations about hugepages that we mapped + * Structure used to store information about hugepages that we mapped * through the files in hugetlbfs. */ diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h index d6a2494f6..d3034d0ed 100644 --- a/lib/librte_eal/common/include/rte_bus.h +++ b/lib/librte_eal/common/include/rte_bus.h @@ -365,5 +365,5 @@ struct rte_bus *rte_bus_find_by_name(const char *busname); /** * Get the common iommu class of devices bound on to buses available in the - * system. RTE_IOVA_DC means that no preferrence has been expressed. + * system. RTE_IOVA_DC means that no preference has been expressed. * * @return diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h index c25e09e3d..a5c35f00c 100644 --- a/lib/librte_eal/common/include/rte_dev.h +++ b/lib/librte_eal/common/include/rte_dev.h @@ -231,5 +231,5 @@ __attribute__((used)) = str * whose vendor id is 0x8086. * - * The format of the kernel modules list is a parenthesed expression + * The format of the kernel modules list is a parenthesized expression * containing logical-and (&) and logical-or (|). * diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c index d3d019578..4deeb1792 100644 --- a/lib/librte_efd/rte_efd.c +++ b/lib/librte_efd/rte_efd.c @@ -182,5 +182,5 @@ struct efd_offline_group_rules { uint8_t bin_id[EFD_MAX_GROUP_NUM_RULES]; - /**< Stores the bin for each correspending key to + /**< Stores the bin for each corresponding key to * avoid having to recompute it */ diff --git a/lib/librte_power/rte_power.h b/lib/librte_power/rte_power.h index 01f88588b..427058b81 100644 --- a/lib/librte_power/rte_power.h +++ b/lib/librte_power/rte_power.h @@ -27,5 +27,5 @@ enum power_management_env {PM_ENV_NOT_SET, PM_ENV_ACPI_CPUFREQ, PM_ENV_KVM_VM, * Set the default power management implementation. If this is not called prior * to rte_power_init(), then auto-detect of the environment will take place. - * It is thread safe. New env can be set only in unitialized state + * It is thread safe. New env can be set only in uninitialized state * (thus rte_power_unset_env must be called if different env was already set). *