From patchwork Mon Apr 13 13:45:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nithin Dabilpuram X-Patchwork-Id: 68270 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8C6FA0577; Mon, 13 Apr 2020 15:45:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3081DFFA; Mon, 13 Apr 2020 15:45:54 +0200 (CEST) Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by dpdk.org (Postfix) with ESMTP id 9B234F72; Mon, 13 Apr 2020 15:45:52 +0200 (CEST) Received: by mail-pj1-f66.google.com with SMTP id q16so3184686pje.1; Mon, 13 Apr 2020 06:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=anD5ljgGS0sSrwF8fqUvbHw3Y9cDt/FslS/2d2p0IoM=; b=i6BMIroig19ZK+Ly2psAhZBMn4F4Nt7WEgp+F7noe47Pu3LcyPkaZ4v9lwvDRMhcBg 3CoTGNg7LNopyTCud5OLR9nJI8XMsEQayjXz0ZXmb8JUyd2XY5SENuAU7ILhCFWVVSfe Igrk2o6S38G179lWl9oMWHw8fHHlmf9d7pCvrehSdmuH2JHm+5sfmEaaWpCd08dnlNAN TXld31WtzWEcGQqh194go2kN0ZfhZS7T5Bvi3B99EhH7YPFwJz+hiiFEisRqL5+rjf9Q vfROcHed3flb94DD5uiAhhnWKm45EWNqMC2HQ+vzMvE+don4ki2lXOAyGMXjCm+Fq5rN K4yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=anD5ljgGS0sSrwF8fqUvbHw3Y9cDt/FslS/2d2p0IoM=; b=ielMbV1Uk2oXI81Qq+t5bdHonoBf+mQhOEJnCnEs7WokfU8unyFYpn4Eu+OClZFW7q Eq2SkF6wrptQE3a2sdYQd9kyxV4L37Au4VKCBnBXtWE7Ek9Ua0/zTfOzqR8A7Z8N0E+g EO4tkWVwJiALcEpHmgrZnso+TV2VBshxbRIDwToCKCOC7xKT0lD3b9hdpgd0LaaNJraF 5Dgj3OCq6IRnVC/k8tKYpdIPY56jWZ3RHx0URxlyfDOwu6VQggFBcKWWYQDD3A8WSTYV sTVpGPY/17p/AGNLZPzMafIqCtNh+0sFt7F8tzOETNNTqSsbTBDhE/yMP4G39AfPXC8Q +n6Q== X-Gm-Message-State: AGi0PuYs698Ju6KJ7SRaHZ/Jpp5hVNxNg6t6BQB1LrrVrqxlztHGc4uK 33ig8FsMY4z73t8A/4QkODY= X-Google-Smtp-Source: APiQypIf1xghNSHuVw2ziag2fCRP8SNqKpQfuKK0QalH8qTxOJclYiXIYip/YTOcbJ8cqXFUmVHzZQ== X-Received: by 2002:a17:90b:300a:: with SMTP id hg10mr21692463pjb.42.1586785551667; Mon, 13 Apr 2020 06:45:51 -0700 (PDT) Received: from hyd1588t430.marvell.com ([115.113.156.2]) by smtp.gmail.com with ESMTPSA id h6sm8662998pfq.200.2020.04.13.06.45.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Apr 2020 06:45:50 -0700 (PDT) From: Nithin Dabilpuram To: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K Cc: dev@dpdk.org, vattunuru@marvell.com, stable@dpdk.org Date: Mon, 13 Apr 2020 19:15:40 +0530 Message-Id: <20200413134540.10992-1-nithind1988@gmail.com> X-Mailer: git-send-email 2.8.4 Subject: [dpdk-dev] [PATCH] net/octeontx2: fix unnecessary error interrupts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Nithin Dabilpuram Disable CQ_DISABLED error interrupt in NIX_LF_ERR_INT to fix spurious interrupts in event dev mode. Also skip configuring RSS when RQ count is '0' because RSS table initialization is done incorrectly due to divide-by-zero error and it is leading to RQ_OOR error in NIX_LF_ERR_INT. Fixes: 83ce2880e22e ("net/octeontx2: support RSS") Cc: vattunuru@marvell.com Cc: stable@dpdk.org Signed-off-by: Nithin Dabilpuram Acked-by: Jerin Jacob --- drivers/net/octeontx2/otx2_ethdev_irq.c | 7 +++++-- drivers/net/octeontx2/otx2_rss.c | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/octeontx2/otx2_ethdev_irq.c b/drivers/net/octeontx2/otx2_ethdev_irq.c index 96b848a..b121488 100644 --- a/drivers/net/octeontx2/otx2_ethdev_irq.c +++ b/drivers/net/octeontx2/otx2_ethdev_irq.c @@ -472,9 +472,12 @@ otx2_nix_err_intr_enb_dis(struct rte_eth_dev *eth_dev, bool enb) { struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev); - /* Enable all nix lf error interrupts except for RQ_DISABLED */ + /* Enable all nix lf error interrupts except + * RQ_DISABLED and CQ_DISABLED. + */ if (enb) - otx2_write64(~BIT_ULL(11), dev->base + NIX_LF_ERR_INT_ENA_W1S); + otx2_write64(~(BIT_ULL(11) | BIT_ULL(24)), + dev->base + NIX_LF_ERR_INT_ENA_W1S); else otx2_write64(~0ull, dev->base + NIX_LF_ERR_INT_ENA_W1C); } diff --git a/drivers/net/octeontx2/otx2_rss.c b/drivers/net/octeontx2/otx2_rss.c index a29441e..5e3f866 100644 --- a/drivers/net/octeontx2/otx2_rss.c +++ b/drivers/net/octeontx2/otx2_rss.c @@ -358,7 +358,7 @@ otx2_nix_rss_config(struct rte_eth_dev *eth_dev) int rc; /* Skip further configuration if selected mode is not RSS */ - if (eth_dev->data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_RSS) + if (eth_dev->data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_RSS || !qcnt) return 0; /* Update default RSS key and cfg */