Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136650/?format=api
{ "id": 136650, "url": "http://patchwork.dpdk.org/api/patches/136650/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240213172246.1094308-1-vignesh.purushotham.srinivas@ericsson.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240213172246.1094308-1-vignesh.purushotham.srinivas@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240213172246.1094308-1-vignesh.purushotham.srinivas@ericsson.com", "date": "2024-02-13T17:22:46", "name": "[RFC] net/bonding: add user callback for bond xmit policy", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "158462b031488e2b6b87de890a7cbe18ab96a235", "submitter": { "id": 3232, "url": "http://patchwork.dpdk.org/api/people/3232/?format=api", "name": "Vignesh Purushotham Srinivas", "email": "vignesh.purushotham.srinivas@ericsson.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240213172246.1094308-1-vignesh.purushotham.srinivas@ericsson.com/mbox/", "series": [ { "id": 31093, "url": "http://patchwork.dpdk.org/api/series/31093/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31093", "date": "2024-02-13T17:22:46", "name": "[RFC] net/bonding: add user callback for bond xmit policy", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31093/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/136650/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/136650/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ED4BF43B0D;\n\tTue, 13 Feb 2024 18:22:59 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D96C242E23;\n\tTue, 13 Feb 2024 18:22:59 +0100 (CET)", "from EUR03-AM7-obe.outbound.protection.outlook.com\n (mail-am7eur03on2083.outbound.protection.outlook.com [40.107.105.83])\n by mails.dpdk.org (Postfix) with ESMTP id 72BE242E17\n for <dev@dpdk.org>; Tue, 13 Feb 2024 18:22:58 +0100 (CET)", "from AS4P195CA0045.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:65a::18)\n by DB9PR07MB9930.eurprd07.prod.outlook.com (2603:10a6:10:4cb::9) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.39; Tue, 13 Feb\n 2024 17:22:57 +0000", "from AM3PEPF0000A792.eurprd04.prod.outlook.com\n (2603:10a6:20b:65a:cafe::b6) by AS4P195CA0045.outlook.office365.com\n (2603:10a6:20b:65a::18) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.39 via Frontend\n Transport; Tue, 13 Feb 2024 17:22:57 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n AM3PEPF0000A792.mail.protection.outlook.com (10.167.16.121) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7292.25 via Frontend Transport; Tue, 13 Feb 2024 17:22:56 +0000", "from seroius18814.sero.gic.ericsson.se (153.88.142.248) by\n smtp-central.internal.ericsson.com (100.87.178.66) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.12; Tue, 13 Feb 2024 18:22:56 +0100", "from seroiuts03116.sero.gic.ericsson.se\n (seroiuts03116.sero.gic.ericsson.se [10.210.134.60])\n by seroius18814.sero.gic.ericsson.se (Postfix) with ESMTP id E6CF9C000090;\n Tue, 13 Feb 2024 18:22:55 +0100 (CET)", "by seroiuts03116.sero.gic.ericsson.se (Postfix, from userid 7401342)\n id B846661A731C; Tue, 13 Feb 2024 18:22:55 +0100 (CET)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=MqBbuiVJ8P9Zd7++SDHsuvoM5OMKWbBFKyyxH8m64ziS8TKOtAai/229LDtvXhUmqrB4QoN0qcUoJj3SOx+k4XEQ/BuxusGwkRzq3yNWDpdSWTVwhFRuTdMDfp/86BasI2tAlsPwSaRNtSNPHtBxCw7GYSn56RyPDHpMEf7wsaGnDyFyQNI3QFZOU0agucl3k6j+rJTs2q0plbZxsTKkYYssFOJ7XOIYPQXwHMlzWnPGOuCLhyZMfhS0EzVpq2VyAfgMhHjpt7DYcFB6jCjk2+SovT+cKKDHCQeiWz516uGZP5M2LXwmOPhzERPxn/aic4Ow+/V1ILWYixhWdmg5HQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=/PneVlzOLnKR8D7nb+ikwSliKvOWZPaORzekO+f5Yvk=;\n b=CEI7gDGW2xp8MdmI2LuS9eHrovmnh19MmtxB0iQz54xUNKkhWrKF+AxIgOs8yie94rHlY+v+cnPdNjuBOGfFK9pT6XOOnMlpB1gNzPezN2MccXfZ3/r4Wj+y6kPggHez4jGPPC3MUKsNhZ/UqRf99wcaJHGryKOuBIHJvDM0RyiGB/h+8eD1NfiNT+7Arulo+RZagcu1taQoaKpFXPkHTJc9C1Ry3CE5bd6pEHnu5KGKwIQhsRHw34R29g+mMt8FAAsw+5++Z9KOLJqg5ICM2oGwySWWl1Iof7ZFEW7qqDrwtH+5qJ/5WSO3rd2JADSt0tWIfmrf8VOaH7h9NcYjfw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=att.com smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=/PneVlzOLnKR8D7nb+ikwSliKvOWZPaORzekO+f5Yvk=;\n b=Yp3XGD/3hm+sqeH2PjSNnT1Jd3s438Uxnd99oRbk+boByQJXgusLopPQRcjRbEIjtgX31GZlTY/v2pm7YBnk7ZlcIZprYe67Q1Uf6uGCATe0ALetotxjWEsotKRDPH2gVJw8RmxO15EiVLAizj2MckbK5K+eh6/NItYKzf7G9vbcj1MTb6ryjTh6zizhZ50k+Cbl2V/wCaGhSPTzZ2Flrr7ZVGGhQ46cdzf87RH9ianmPZLompYbq/D5yPtSI3GN0k7qWH81iqz278oLpGMqzefyJB2ltJgGAfVEaonPyvLNAutzULn8mR1gfyVxAwfPoVyBdFT+BakDdP4gLbI6IA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C", "From": "<vignesh.purushotham.srinivas@ericsson.com>", "To": "<chas3@att.com>, <humin29@huawei.com>", "CC": "<dev@dpdk.org>, Vignesh PS <vignesh.purushotham.srinivas@ericsson.com>", "Subject": "[RFC] net/bonding: add user callback for bond xmit policy", "Date": "Tue, 13 Feb 2024 18:22:46 +0100", "Message-ID": "\n <20240213172246.1094308-1-vignesh.purushotham.srinivas@ericsson.com>", "X-Mailer": "git-send-email 2.40.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AM3PEPF0000A792:EE_|DB9PR07MB9930:EE_", "X-MS-Office365-Filtering-Correlation-Id": "7a6fbb49-a99a-4cfb-11d2-08dc2cb86b8f", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n NfXcKfGOEZG+kXzSOmFX/e917KTn6xFyCHMWBFugUUz+kR4MW1nXzb9XDCZaa9peoDs1A/5KWyjz7WAv8L+Nptx0A+4Jry8NHSbOFdeESD8o49HeHm7qZHjYYS+90GDOPCgOZ9BCTqULuZZY+ImB/Y5fT90PNC+PMoklQZIVbYbT1D8pcG02aAxiEdTZvgTzT7R6Tu236n2wraTGnkjdv8KrkOsICZvJnuEJ1C0dxZLdOZ/uJR6IDKHKbFnIgh1BxTO0OC4M7RXmx6n/rve+zWB58MMg07g399/NvKoMeOzf6J1ezYlhAmBG1ZhsP0oEfHD4yIYg7u1kHn6fwKc/grgEJwbdxpV7XEeJE4nEHRuavuUVYu2aMunVpJ6nylSVFyRnTKgvKS7/71IkYeuo4iNzCwRmLikPGaoRqIurV8tfh8jDS+pxWRinr5m2X49HAdq2arR+8rxs1qJmJlHZCGjIvVsLuNsKprgo2gkyaErl1yrq1OnX6EbgtLkoyilkgGVbGmIHnKD7iNo6gp19qvkiZv3TMd+0c+uCHHDSsj9PcUkR3Y8EU4r3Y9j5qFU1ZyRSgwo4wFAYlc2qZj0jq7j+2z1QboNmsmtDaQI6yUo=", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE;\n SFS:(13230031)(4636009)(136003)(39860400002)(396003)(376002)(346002)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(82310400011)(36840700001)(40470700004)(46966006)(103116003)(41300700001)(6266002)(83380400001)(26005)(336012)(1076003)(2876002)(2906002)(5660300002)(478600001)(316002)(110136005)(42186006)(70586007)(70206006)(54906003)(6666004)(356005)(7636003)(2616005)(82960400001)(107886003)(36756003)(8936002)(4326008)(8676002)(82740400003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "13 Feb 2024 17:22:56.9285 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 7a6fbb49-a99a-4cfb-11d2-08dc2cb86b8f", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n AM3PEPF0000A792.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB9PR07MB9930", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Vignesh PS <vignesh.purushotham.srinivas@ericsson.com>\n\nAdd support to bonding PMD to allow user callback\nfunction registration for TX transmit policy.\n\nSigned-off-by: Vignesh PS <vignesh.purushotham.srinivas@ericsson.com>\n---\n .mailmap | 1 +\n drivers/net/bonding/eth_bond_private.h | 6 ++----\n drivers/net/bonding/rte_eth_bond.h | 17 +++++++++++++++++\n drivers/net/bonding/rte_eth_bond_api.c | 15 +++++++++++++++\n drivers/net/bonding/rte_eth_bond_args.c | 2 ++\n drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-\n drivers/net/bonding/version.map | 1 +\n 7 files changed, 39 insertions(+), 5 deletions(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex de339562f4..6c068d5af3 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -1476,6 +1476,7 @@ Viacheslav Ovsiienko <viacheslavo@nvidia.com> <viacheslavo@mellanox.com>\n Victor Kaplansky <victork@redhat.com>\n Victor Raj <victor.raj@intel.com>\n Vidya Sagar Velumuri <vvelumuri@marvell.com>\n+Vignesh PS <vignesh.purushotham.srinivas@ericsson.com> <vig.vigneshps1995@gmail.com>\n Vignesh Sridhar <vignesh.sridhar@intel.com>\n Vijayakumar Muthuvel Manickam <mmvijay@gmail.com>\n Vijaya Mohan Guvva <vijay1054@gmail.com>\ndiff --git a/drivers/net/bonding/eth_bond_private.h b/drivers/net/bonding/eth_bond_private.h\nindex e688894210..4141b6e09f 100644\n--- a/drivers/net/bonding/eth_bond_private.h\n+++ b/drivers/net/bonding/eth_bond_private.h\n@@ -32,6 +32,7 @@\n #define PMD_BOND_XMIT_POLICY_LAYER2_KVARG\t(\"l2\")\n #define PMD_BOND_XMIT_POLICY_LAYER23_KVARG\t(\"l23\")\n #define PMD_BOND_XMIT_POLICY_LAYER34_KVARG\t(\"l34\")\n+#define PMD_BOND_XMIT_POLICY_USER_KVARG\t(\"user\")\n \n extern int bond_logtype;\n \n@@ -101,9 +102,6 @@ struct rte_flow {\n \tuint8_t rule_data[];\n };\n \n-typedef void (*burst_xmit_hash_t)(struct rte_mbuf **buf, uint16_t nb_pkts,\n-\t\tuint16_t member_count, uint16_t *members);\n-\n /** Link Bonding PMD device private configuration Structure */\n struct bond_dev_private {\n \tuint16_t port_id;\t\t\t/**< Port Id of Bonding Port */\n@@ -118,7 +116,7 @@ struct bond_dev_private {\n \t/**< Flag for whether primary port is user defined or not */\n \n \tuint8_t balance_xmit_policy;\n-\t/**< Transmit policy - l2 / l23 / l34 for operation in balance mode */\n+\t/**< Transmit policy - l2 / l23 / l34 / user for operation in balance mode */\n \tburst_xmit_hash_t burst_xmit_hash;\n \t/**< Transmit policy hash function */\n \ndiff --git a/drivers/net/bonding/rte_eth_bond.h b/drivers/net/bonding/rte_eth_bond.h\nindex f10165f2c6..66bc41097a 100644\n--- a/drivers/net/bonding/rte_eth_bond.h\n+++ b/drivers/net/bonding/rte_eth_bond.h\n@@ -91,6 +91,11 @@ extern \"C\" {\n /**< Layer 2+3 (Ethernet MAC + IP Addresses) transmit load balancing */\n #define BALANCE_XMIT_POLICY_LAYER34\t\t(2)\n /**< Layer 3+4 (IP Addresses + UDP Ports) transmit load balancing */\n+#define BALANCE_XMIT_POLICY_USER\t\t(3)\n+/**< User callback function to transmit load balancing */\n+\n+typedef void (*burst_xmit_hash_t)(struct rte_mbuf **buf, uint16_t nb_pkts,\n+\tuint16_t slave_count, uint16_t *slaves);\n \n /**\n * Create a bonding rte_eth_dev device\n@@ -351,6 +356,18 @@ rte_eth_bond_link_up_prop_delay_set(uint16_t bonding_port_id,\n int\n rte_eth_bond_link_up_prop_delay_get(uint16_t bonding_port_id);\n \n+/**\n+ * Register transmit callback function for bonded device to use when it is operating in\n+ * balance mode. The callback is ignored in other modes of operation.\n+ *\n+ * @param cb_fn User defined callback function to determine the xmit slave\n+ *\n+ * @return\n+ * 0 on success, negative value otherwise.\n+ */\n+__rte_experimental\n+int\n+rte_eth_bond_xmit_policy_cb_register(burst_xmit_hash_t cb_fn);\n \n #ifdef __cplusplus\n }\ndiff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c\nindex 99e496556a..b53038eeda 100644\n--- a/drivers/net/bonding/rte_eth_bond_api.c\n+++ b/drivers/net/bonding/rte_eth_bond_api.c\n@@ -15,6 +15,8 @@\n #include \"eth_bond_private.h\"\n #include \"eth_bond_8023ad_private.h\"\n \n+static burst_xmit_hash_t burst_xmit_user_hash;\n+\n int\n check_for_bonding_ethdev(const struct rte_eth_dev *eth_dev)\n {\n@@ -972,6 +974,13 @@ rte_eth_bond_mac_address_reset(uint16_t bonding_port_id)\n \treturn 0;\n }\n \n+int\n+rte_eth_bond_xmit_policy_cb_register(burst_xmit_hash_t cb_fn)\n+{\n+\tburst_xmit_user_hash = cb_fn;\n+\treturn 0;\n+}\n+\n int\n rte_eth_bond_xmit_policy_set(uint16_t bonding_port_id, uint8_t policy)\n {\n@@ -995,6 +1004,12 @@ rte_eth_bond_xmit_policy_set(uint16_t bonding_port_id, uint8_t policy)\n \t\tinternals->balance_xmit_policy = policy;\n \t\tinternals->burst_xmit_hash = burst_xmit_l34_hash;\n \t\tbreak;\n+\tcase BALANCE_XMIT_POLICY_USER:\n+\t\tif (burst_xmit_user_hash == NULL)\n+\t\t\treturn -1;\n+\t\tinternals->balance_xmit_policy = policy;\n+\t\tinternals->burst_xmit_hash = burst_xmit_user_hash;\n+\t\tbreak;\n \n \tdefault:\n \t\treturn -1;\ndiff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c\nindex bdec5d61d4..eaa313bf73 100644\n--- a/drivers/net/bonding/rte_eth_bond_args.c\n+++ b/drivers/net/bonding/rte_eth_bond_args.c\n@@ -261,6 +261,8 @@ bond_ethdev_parse_balance_xmit_policy_kvarg(const char *key __rte_unused,\n \t\t*xmit_policy = BALANCE_XMIT_POLICY_LAYER23;\n \telse if (strcmp(PMD_BOND_XMIT_POLICY_LAYER34_KVARG, value) == 0)\n \t\t*xmit_policy = BALANCE_XMIT_POLICY_LAYER34;\n+\telse if (strcmp(PMD_BOND_XMIT_POLICY_USER_KVARG, value) == 0)\n+\t\t*xmit_policy = BALANCE_XMIT_POLICY_USER;\n \telse\n \t\treturn -1;\n \ndiff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex c40d18d128..92b0126a6d 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -4251,7 +4251,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_bonding,\n \t\"member=<ifc> \"\n \t\"primary=<ifc> \"\n \t\"mode=[0-6] \"\n-\t\"xmit_policy=[l2 | l23 | l34] \"\n+\t\"xmit_policy=[l2 | l23 | l34 | user] \"\n \t\"agg_mode=[count | stable | bandwidth] \"\n \t\"socket_id=<int> \"\n \t\"mac=<mac addr> \"\ndiff --git a/drivers/net/bonding/version.map b/drivers/net/bonding/version.map\nindex 09ee21c55f..6e82d2c72f 100644\n--- a/drivers/net/bonding/version.map\n+++ b/drivers/net/bonding/version.map\n@@ -35,4 +35,5 @@ EXPERIMENTAL {\n \trte_eth_bond_member_add;\n \trte_eth_bond_member_remove;\n \trte_eth_bond_members_get;\n+\trte_eth_bond_xmit_policy_cb_register;\n };\n", "prefixes": [ "RFC" ] }