Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139078/?format=api
{ "id": 139078, "url": "http://patchwork.dpdk.org/api/patches/139078/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240403101624.2771140-6-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240403101624.2771140-6-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240403101624.2771140-6-haijie1@huawei.com", "date": "2024-04-03T10:16:23", "name": "[5/5] net/hns3: disable SCTP verification Tag for RSS hash input", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "262f05ce8272747f4f5c2d57b15c7ce5ef68af21", "submitter": { "id": 2935, "url": "http://patchwork.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240403101624.2771140-6-haijie1@huawei.com/mbox/", "series": [ { "id": 31665, "url": "http://patchwork.dpdk.org/api/series/31665/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31665", "date": "2024-04-03T10:16:19", "name": "net/hns3: add some bugfix", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31665/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139078/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139078/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1BA0643DE7;\n\tWed, 3 Apr 2024 12:22:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 18D47406A2;\n\tWed, 3 Apr 2024 12:21:52 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 60770402DD\n for <dev@dpdk.org>; Wed, 3 Apr 2024 12:21:46 +0200 (CEST)", "from mail.maildlp.com (unknown [172.19.163.48])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4V8ghK36gqzwR8K\n for <dev@dpdk.org>; Wed, 3 Apr 2024 18:18:57 +0800 (CST)", "from kwepemd100004.china.huawei.com (unknown [7.221.188.31])\n by mail.maildlp.com (Postfix) with ESMTPS id 483F418005D\n for <dev@dpdk.org>; Wed, 3 Apr 2024 18:21:45 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.28; Wed, 3 Apr 2024 18:21:44 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Yisen Zhuang <yisen.zhuang@huawei.com>", "CC": "<lihuisong@huawei.com>, <fengchengwen@huawei.com>,\n <liuyonglong@huawei.com>, <huangdengdui@huawei.com>, <haijie1@huawei.com>", "Subject": "[PATCH 5/5] net/hns3: disable SCTP verification Tag for RSS hash\n input", "Date": "Wed, 3 Apr 2024 18:16:23 +0800", "Message-ID": "<20240403101624.2771140-6-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20240403101624.2771140-1-haijie1@huawei.com>", "References": "<20240403101624.2771140-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n kwepemd100004.china.huawei.com (7.221.188.31)", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When the symmetric RSS algorithm is used, the same packet is\nexpected to be hashed to the same queue in the upstream and\ndownstream directions.\n\nThe problem is that it could map the packets in the same SCTP\nconnection to different NIC RX queues depending on the direction\nof packets. This is because the verification Tag is used as the\nRSS hash input for the SCTP packets, and the value depends on the\npeer end of the SCTP connection and could not be symmetrically\nused in the hardware-implemented RSS algorithm.\n\nIn addition, the ethdev framework doesn't support setting SCTP\nV-tag as the RSS hash input. So disable it for all RSS hash\nalgorithms.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n drivers/net/hns3/hns3_rss.c | 6 ++----\n drivers/net/hns3/hns3_rss.h | 6 ++----\n 2 files changed, 4 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c\nindex 15feb26043af..3eae4caf52a2 100644\n--- a/drivers/net/hns3/hns3_rss.c\n+++ b/drivers/net/hns3/hns3_rss.c\n@@ -153,8 +153,7 @@ static const struct {\n \t BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_IP_S) |\n \t BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_IP_D) |\n \t BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_S) |\n-\t BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_D) |\n-\t BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_VER),\n+\t BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_D),\n \t HNS3_RSS_TUPLE_IPV4_SCTP_M },\n \n \t/* IPV6-FRAG */\n@@ -274,8 +273,7 @@ static const struct {\n \t BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_IP_S) |\n \t BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_IP_D) |\n \t BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_D) |\n-\t BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_S) |\n-\t BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_VER),\n+\t BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_S),\n \t HNS3_RSS_TUPLE_IPV6_SCTP_M },\n };\n \ndiff --git a/drivers/net/hns3/hns3_rss.h b/drivers/net/hns3/hns3_rss.h\nindex 9d182a8025c5..0755760b4513 100644\n--- a/drivers/net/hns3/hns3_rss.h\n+++ b/drivers/net/hns3/hns3_rss.h\n@@ -49,7 +49,6 @@ enum hns3_tuple_field {\n \tHNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_S,\n \tHNS3_RSS_FIELD_IPV4_SCTP_EN_IP_D,\n \tHNS3_RSS_FIELD_IPV4_SCTP_EN_IP_S,\n-\tHNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_VER,\n \n \t/* IPV4 ENABLE FIELD */\n \tHNS3_RSS_FIELD_IPV4_EN_NONFRAG_IP_D = 24,\n@@ -74,7 +73,6 @@ enum hns3_tuple_field {\n \tHNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_S,\n \tHNS3_RSS_FIELD_IPV6_SCTP_EN_IP_D,\n \tHNS3_RSS_FIELD_IPV6_SCTP_EN_IP_S,\n-\tHNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_VER,\n \n \t/* IPV6 ENABLE FIELD */\n \tHNS3_RSS_FIELD_IPV6_NONFRAG_IP_D = 56,\n@@ -96,12 +94,12 @@ enum hns3_tuple_field {\n \n #define HNS3_RSS_TUPLE_IPV4_TCP_M\tGENMASK(3, 0)\n #define HNS3_RSS_TUPLE_IPV4_UDP_M\tGENMASK(11, 8)\n-#define HNS3_RSS_TUPLE_IPV4_SCTP_M\tGENMASK(20, 16)\n+#define HNS3_RSS_TUPLE_IPV4_SCTP_M\tGENMASK(19, 16)\n #define HNS3_RSS_TUPLE_IPV4_NONF_M\tGENMASK(25, 24)\n #define HNS3_RSS_TUPLE_IPV4_FLAG_M\tGENMASK(27, 26)\n #define HNS3_RSS_TUPLE_IPV6_TCP_M\tGENMASK(35, 32)\n #define HNS3_RSS_TUPLE_IPV6_UDP_M\tGENMASK(43, 40)\n-#define HNS3_RSS_TUPLE_IPV6_SCTP_M\tGENMASK(52, 48)\n+#define HNS3_RSS_TUPLE_IPV6_SCTP_M\tGENMASK(51, 48)\n #define HNS3_RSS_TUPLE_IPV6_NONF_M\tGENMASK(57, 56)\n #define HNS3_RSS_TUPLE_IPV6_FLAG_M\tGENMASK(59, 58)\n \n", "prefixes": [ "5/5" ] }