Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139653/?format=api
{ "id": 139653, "url": "http://patchwork.dpdk.org/api/patches/139653/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/577c1cb1250710da2839079d85a8e9e83fa34c7e.1713964708.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<577c1cb1250710da2839079d85a8e9e83fa34c7e.1713964708.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/577c1cb1250710da2839079d85a8e9e83fa34c7e.1713964708.git.anatoly.burakov@intel.com", "date": "2024-04-24T13:21:42", "name": "[v1,08/22] net/ixgbe/base: fix crash while loading driver", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "413598aea034dd8fcec250f27fb4802a1b1f48a3", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 10, "url": "http://patchwork.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/577c1cb1250710da2839079d85a8e9e83fa34c7e.1713964708.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 31814, "url": "http://patchwork.dpdk.org/api/series/31814/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31814", "date": "2024-04-24T13:21:34", "name": "Update IXGBE base driver", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31814/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139653/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139653/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 09C5243EAD;\n\tWed, 24 Apr 2024 15:23:17 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3A343434AA;\n\tWed, 24 Apr 2024 15:22:35 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.9])\n by mails.dpdk.org (Postfix) with ESMTP id A18EC434A6\n for <dev@dpdk.org>; Wed, 24 Apr 2024 15:22:33 +0200 (CEST)", "from fmviesa006.fm.intel.com ([10.60.135.146])\n by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2024 06:22:33 -0700", "from silpixa00401119.ir.intel.com ([10.55.129.167])\n by fmviesa006.fm.intel.com with ESMTP; 24 Apr 2024 06:22:31 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1713964954; x=1745500954;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=l9+PUKAsDi2uqwCxaMcNclP+NWYYilGNGmA3IVK50O0=;\n b=X5Wz5UFaLALxFTGvSvag9wQ4bPKgogA94zKHh2jgxWB0pgQAL9OJjo3x\n z33nnqHJaHMpKpTEpD3Jm+mlEf25R0vIdEROiqxTVPA7yx/Q4vILFM9/B\n dxh9Kb3Nf2im+xXN3uYE1kAMC6BFiSmx6qY9gJW2pk6q/6juzy1AifbNP\n GFCZftcUHo1CJkUDvYN6RI+uYsQIH3/SM2DSM8GRgn4OnCSUmwRgs/R+y\n 72WloWA7w1ySkBZmv8IknIiMmWd7A6wmAJxEAfHoGUh7rmCL1wZGkpdQR\n X9dQSt0elJpnJlv+mSt/Acg+UcsE8xayzM2XXknp9fMtmcSvRd5usi9jZ A==;", "X-CSE-ConnectionGUID": [ "dN5nfcHgRxe0gE2K+WS+Hg==", "64nJ7+rzRNWFkKqgU1zsvQ==" ], "X-CSE-MsgGUID": [ "0DB4yhKHSwOXK35thEozpQ==", "aXCbgSAAQCGItgsW2J7xJw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11054\"; a=\"20289261\"", "E=Sophos;i=\"6.07,226,1708416000\"; d=\"scan'208\";a=\"20289261\"", "E=Sophos;i=\"6.07,226,1708416000\"; d=\"scan'208\";a=\"24749375\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>,\n\tvladimir.medvedkin@intel.com, bruce.richardson@intel.com,\n\tTyl@dpdk.org, RadoslawX <radoslawx.tyl@intel.com>,\n\tSkajewski@dpdk.org, PiotrX <piotrx.skajewski@intel.com>,\n\tnosbuild <nosbuild@intel.com>, Michael@dpdk.org,\n\tAlice <alice.michael@intel.com>", "Subject": "[PATCH v1 08/22] net/ixgbe/base: fix crash while loading driver", "Date": "Wed, 24 Apr 2024 14:21:42 +0100", "Message-ID": "\n <577c1cb1250710da2839079d85a8e9e83fa34c7e.1713964708.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<cover.1713964707.git.anatoly.burakov@intel.com>", "References": "<cover.1713964707.git.anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>\n\nIssue observed: system crash While loading the driver when debug macros\nwere defined.\n\nThe solution removes the debug macro call from\nixgbe_set_mac_type() function which causes the crash.\n\nSo far, the ixgbe_set_mac_type() function has called in the ixgbe driver\nixgbe_probe() function before the struct ixgbe_hw is properly defined.\nIn this case, the field back of the structure that must contain\npointer to an adapter has not yet been defined and should not be used\nto obtain driver information which is needed in debug macros.\nMoreover bearing in mind the recommendations to not print out excessive\namount of information it was decided to remove the debug information.\n\nSigned-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>\nReviewed-by: Tyl, RadoslawX <radoslawx.tyl@intel.com>\nReviewed-by: Skajewski, PiotrX <piotrx.skajewski@intel.com>\nTested-by: nosbuild <nosbuild@intel.com>\nReviewed-by: Michael, Alice <alice.michael@intel.com>\n---\n\nNotes:\n This fix seems to be kernel-specific, so Cc:stable was intentionally omitted.\n\n drivers/net/ixgbe/base/ixgbe_api.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_api.c b/drivers/net/ixgbe/base/ixgbe_api.c\nindex b322c181b4..89e1650d63 100644\n--- a/drivers/net/ixgbe/base/ixgbe_api.c\n+++ b/drivers/net/ixgbe/base/ixgbe_api.c\n@@ -216,8 +216,6 @@ s32 ixgbe_set_mac_type(struct ixgbe_hw *hw)\n \t\tbreak;\n \t}\n \n-\tDEBUGOUT2(\"ixgbe_set_mac_type found mac: %d, returns: %d\\n\",\n-\t\t hw->mac.type, ret_val);\n \treturn ret_val;\n }\n \n", "prefixes": [ "v1", "08/22" ] }