mbox series

[v4,0/4] Select optional libraries

Message ID 20230621170058.2740340-1-david.marchand@redhat.com (mailing list archive)
Headers
Series Select optional libraries |

Message

David Marchand June 21, 2023, 5 p.m. UTC
  This series is one implementation to try and please users who want to
select more easily which parts of DPDK are built.

It introduces a change in behavior for enabling deprecated libraries:
this series is aimed at the next release but sent early as a demo of
what changes are required.

If no strong opposition is met, a deprecation notice will be sent for
v23.07 to announce this change in v23.11.


Changes since v3:
- split kni cleanup,
- split variable rename cleanup,
- introduced a new meson option to control deprecated libraries
  activation,
- simplified the actual implementation of enable_libs to mimic
  enable_drivers behavior,
  

Comments

Bruce Richardson June 22, 2023, 9:09 a.m. UTC | #1
On Wed, Jun 21, 2023 at 07:00:54PM +0200, David Marchand wrote:
> This series is one implementation to try and please users who want to
> select more easily which parts of DPDK are built.
> 
> It introduces a change in behavior for enabling deprecated libraries:
> this series is aimed at the next release but sent early as a demo of
> what changes are required.
> 
> If no strong opposition is met, a deprecation notice will be sent for
> v23.07 to announce this change in v23.11.
> 
> 
> Changes since v3:
> - split kni cleanup,
> - split variable rename cleanup,
> - introduced a new meson option to control deprecated libraries
>   activation,
> - simplified the actual implementation of enable_libs to mimic
>   enable_drivers behavior,
> 
> 
> -- 
> David Marchand
> 
> David Marchand (4):
>   kni: move IOVA build check
>   build: rename enabled libraries list
>   build: select deprecated libraries
>   build: select optional libraries
> 
I think the first 2 patches should definitely go into 23.07. The latter two
cause a change in how one needs to build DPDK with libs enabled, so we may
want to push that out, and flag the change in advance. Since it's a
relatively minor change, and a build-time one only, I'm fine with it going
in either 23.07 or 23.11, as maintainers decide.

Series-reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
  
Thomas Monjalon June 22, 2023, 4:41 p.m. UTC | #2
22/06/2023 11:09, Bruce Richardson:
> On Wed, Jun 21, 2023 at 07:00:54PM +0200, David Marchand wrote:
> > This series is one implementation to try and please users who want to
> > select more easily which parts of DPDK are built.
> > 
> > It introduces a change in behavior for enabling deprecated libraries:
> > this series is aimed at the next release but sent early as a demo of
> > what changes are required.
> > 
> > If no strong opposition is met, a deprecation notice will be sent for
> > v23.07 to announce this change in v23.11.
> > 
> > 
> > Changes since v3:
> > - split kni cleanup,
> > - split variable rename cleanup,
> > - introduced a new meson option to control deprecated libraries
> >   activation,
> > - simplified the actual implementation of enable_libs to mimic
> >   enable_drivers behavior,
> > 
> > 
> I think the first 2 patches should definitely go into 23.07. The latter two
> cause a change in how one needs to build DPDK with libs enabled, so we may
> want to push that out, and flag the change in advance. Since it's a
> relatively minor change, and a build-time one only, I'm fine with it going
> in either 23.07 or 23.11, as maintainers decide.
> 
> Series-reviewed-by: Bruce Richardson <bruce.richardson@intel.com>

Applied first 2 patches, thanks.