Message ID | 20200303175938.14292-1-stephen@networkplumber.org (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F778A0571; Tue, 3 Mar 2020 18:59:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9274C1BFF0; Tue, 3 Mar 2020 18:59:43 +0100 (CET) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by dpdk.org (Postfix) with ESMTP id 5873F1BFE9 for <dev@dpdk.org>; Tue, 3 Mar 2020 18:59:42 +0100 (CET) Received: by mail-pj1-f52.google.com with SMTP id k36so680164pje.5 for <dev@dpdk.org>; Tue, 03 Mar 2020 09:59:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=egckYYR5fKW08HSBjGhs1DIsGQCUxY/kTJhaD1YjtX8=; b=qQYe5vmRCo/w3f9WgrU1Kn42fXvcsSvpNhycQUJ//w627J1SGyt/JlydNMR1TPoMoj lzdB43KBNmy//y8uo70fLDaN5ILuXU7tlPmtb9MI+ToF0mBm1GVLYwHGSXbGuQu/OqRq UX6wnU9K+1IEo9OIOHIqcGpavae+C36eQ4Vb8K2cHOCng5BqLsLr0VKS0ogqf8U7cH5K YmgwxSdz6FGFqU7lcTQHFj52ZAWkslPYX4pln//emfZLelJcdKxRHtPmvurKC/btWG5I kCD4yW6HadHzR4GVXH13371TRjjHL0Rj1N6RGhMTOv7fys+coPHYdn8W4ltqGmVQ/OYC yLyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=egckYYR5fKW08HSBjGhs1DIsGQCUxY/kTJhaD1YjtX8=; b=nks6OagPi2AbZqFvI1s8wIcHka7btCbShzr5rlFyywPGew9fLmQvlNv2mu3cguXj6d EJW2uSdTXJaUCyPdHpNWzMrldYY448ecl8Krc3Q10yQBIApE6JIm4GZ/4Zj07VUjZkns Gzwe4JJIhkg7Y9GcS1RPqQzIr1B3hoHcSdS1LqGQRlU20pPcWdiklM2WmCJJAju51sz3 2FHUsROQ+CxTmnMl+zaKCqySJyxbCrvt6ABdz/RizppEH7Xu8rIUyUb9jm0DsG6rcICe MsBwLHGiYejyUPDlEYH/8p6S+Xs97tNEOhDux/F/ssmrqB37ZD6x8arIQsw/7w9y9ZGW o9Pw== X-Gm-Message-State: ANhLgQ38vDwJmwPZnwbe9jzlj8TmEoHTa0Mxl+KuLClzqxAVSvsN/3oQ nC8Oi4UJz7o2JEPCCInJ0Y9g1Q== X-Google-Smtp-Source: ADFU+vvkk+ZqLEAz/9ICPwA42CaNXmMr9+yKCmMmJpUZ+vCyZNnRhVXWEhE9X5TTmlFLywFSgiXKIw== X-Received: by 2002:a17:90a:7bce:: with SMTP id d14mr5084019pjl.170.1583258381249; Tue, 03 Mar 2020 09:59:41 -0800 (PST) Received: from hermes.corp.microsoft.com (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w195sm22012158pfd.65.2020.03.03.09.59.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2020 09:59:40 -0800 (PST) From: Stephen Hemminger <stephen@networkplumber.org> To: ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org> Date: Tue, 3 Mar 2020 09:59:32 -0800 Message-Id: <20200303175938.14292-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 0/6] net/bnxt: bounds checking patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
net/bnxt: bounds checking patches
|
|
Message
Stephen Hemminger
March 3, 2020, 5:59 p.m. UTC
This set of patches came from security review of bnxt driver. It introduces a set of overflow macros that could be more widely used in other places in DPDK to check for math overflows. Stephen Hemminger (6): eal: add portable way to check for math overflow net/bnxt: fix potential data race net/bnxt: avoid potential out of bounds read net/bnxt: check for integer overflow in buffer sizing net/bnxt: add integer underflow check net/bnxt: sanitize max_l2_ctx drivers/net/bnxt/bnxt_hwrm.c | 31 ++++++-- lib/librte_eal/common/Makefile | 2 +- lib/librte_eal/common/include/rte_overflow.h | 74 ++++++++++++++++++++ 3 files changed, 101 insertions(+), 6 deletions(-) create mode 100644 lib/librte_eal/common/include/rte_overflow.h
Comments
On 3/3/2020 5:59 PM, Stephen Hemminger wrote: > This set of patches came from security review of bnxt driver. > It introduces a set of overflow macros that could be more widely > used in other places in DPDK to check for math overflows. > > Stephen Hemminger (6): > eal: add portable way to check for math overflow > net/bnxt: fix potential data race > net/bnxt: avoid potential out of bounds read > net/bnxt: check for integer overflow in buffer sizing > net/bnxt: add integer underflow check > net/bnxt: sanitize max_l2_ctx > Hi Ajit, I can see this patchset has been merged into your tree, although the note in the mail list is missing. Since it has eal changes, I believe they should be reviewed first before merging into brcm tree, can you separate the eal and dependent patch for review, we can proceed with rest? Regards, ferruh
On Tue, Mar 31, 2020 at 5:23 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > On 3/3/2020 5:59 PM, Stephen Hemminger wrote: > > This set of patches came from security review of bnxt driver. > > It introduces a set of overflow macros that could be more widely > > used in other places in DPDK to check for math overflows. > > > > Stephen Hemminger (6): > > eal: add portable way to check for math overflow > > net/bnxt: fix potential data race > > net/bnxt: avoid potential out of bounds read > > net/bnxt: check for integer overflow in buffer sizing > > net/bnxt: add integer underflow check > > net/bnxt: sanitize max_l2_ctx > > > > Hi Ajit, > > I can see this patchset has been merged into your tree, although the note > in the > mail list is missing. Since it has eal changes, I believe they should be > reviewed first before merging into brcm tree, can you separate the eal and > dependent patch for review, we can proceed with rest? > I don't mind. But being original owner - Stephen, do you want to go ahead? Thanks Ajit > > Regards, > ferruh >
On Tue, 31 Mar 2020 10:52:47 -0700 Ajit Khaparde <ajit.khaparde@broadcom.com> wrote: > On Tue, Mar 31, 2020 at 5:23 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > > > On 3/3/2020 5:59 PM, Stephen Hemminger wrote: > > > This set of patches came from security review of bnxt driver. > > > It introduces a set of overflow macros that could be more widely > > > used in other places in DPDK to check for math overflows. > > > > > > Stephen Hemminger (6): > > > eal: add portable way to check for math overflow > > > net/bnxt: fix potential data race > > > net/bnxt: avoid potential out of bounds read > > > net/bnxt: check for integer overflow in buffer sizing > > > net/bnxt: add integer underflow check > > > net/bnxt: sanitize max_l2_ctx > > > > > > > Hi Ajit, > > > > I can see this patchset has been merged into your tree, although the note > > in the > > mail list is missing. Since it has eal changes, I believe they should be > > reviewed first before merging into brcm tree, can you separate the eal and > > dependent patch for review, we can proceed with rest? > > > I don't mind. > But being original owner - Stephen, do you want to go ahead? > > Thanks > Ajit > > > > > Regards, > > ferruh > > Sure, I expected normal review cycle on this. Hoped that other drivers and eal core would also add overflow checks
Why there was no progress on this during 6 months? Ajit, it was out of my radar because delegated to you. Please restart fresh with a separate patch for EAL, addressing comments. Thanks 31/03/2020 20:04, Stephen Hemminger: > On Tue, 31 Mar 2020 10:52:47 -0700 > Ajit Khaparde <ajit.khaparde@broadcom.com> wrote: > > > On Tue, Mar 31, 2020 at 5:23 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > > > > > On 3/3/2020 5:59 PM, Stephen Hemminger wrote: > > > > This set of patches came from security review of bnxt driver. > > > > It introduces a set of overflow macros that could be more widely > > > > used in other places in DPDK to check for math overflows. > > > > > > > > Stephen Hemminger (6): > > > > eal: add portable way to check for math overflow > > > > net/bnxt: fix potential data race > > > > net/bnxt: avoid potential out of bounds read > > > > net/bnxt: check for integer overflow in buffer sizing > > > > net/bnxt: add integer underflow check > > > > net/bnxt: sanitize max_l2_ctx > > > > > > > > > > Hi Ajit, > > > > > > I can see this patchset has been merged into your tree, although the note > > > in the > > > mail list is missing. Since it has eal changes, I believe they should be > > > reviewed first before merging into brcm tree, can you separate the eal and > > > dependent patch for review, we can proceed with rest? > > > > > I don't mind. > > But being original owner - Stephen, do you want to go ahead? > > > > Thanks > > Ajit > > > > > > > > Regards, > > > ferruh > > > > > Sure, I expected normal review cycle on this. > Hoped that other drivers and eal core would also add overflow checks >