| Message ID | 20211007032353.93579-1-ajit.khaparde@broadcom.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8AFFFA0C4D; Thu, 7 Oct 2021 05:24:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03DCC410E7; Thu, 7 Oct 2021 05:24:00 +0200 (CEST) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id B0DEB40685 for <dev@dpdk.org>; Thu, 7 Oct 2021 05:23:58 +0200 (CEST) Received: by mail-pj1-f47.google.com with SMTP id nn3-20020a17090b38c300b001a03bb6c4ebso1542346pjb.1 for <dev@dpdk.org>; Wed, 06 Oct 2021 20:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:subject:date:message-id:mime-version; bh=WdxCbjAsKUXnweTttPTP7qYxLJiYj+REn9k+XjD+laY=; b=KtoF4VnH3akG3nZZfTqO9D8HodOie1vRYCpSrvobCePHWhzs44ACDgxjTgaUwwH8kr tmQy9J+35nHURNdZJ23FA5doAmOwAY8J7DiEMpe8egQWh/8+ZBfqJN5ZF9RUw7Lam4B7 pO8JTehDOKM/jjsSqeC+ol67rYBBmGtqZJF5I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=WdxCbjAsKUXnweTttPTP7qYxLJiYj+REn9k+XjD+laY=; b=YR/JhH1f1urYJVgL7tjpQ2I13s+4hh8Ro9J4/Ru3PscZCNKyrgmqpeiCcJZmA584eB Aavm3YczbCGZNfGe2gZAvRvkKy9l8uiHF5JWMMBngtgeZKodrdlBqyc9E6N8czW5+Of7 WD27lrXLxrDj70THgVfmuvVnzV1P022sVy1JCPoPubBKNvE4b72uHAL7s/sc+hDjFCPV WcU28/UbjO0lYpdwJ6k9hGzfpG93UY9rV36gdTY56BkAj9gBaDt/j2auU+9P+xgU1J7/ BUicNEziernlHM2m6mqkU7GRP7E6DW53AScMC2isrBtFd2Vg0HXmWPYjCsgp3s9X+RWR dQfg== X-Gm-Message-State: AOAM533XZi9SHQH8lcfrs3evKoOpUgYweVB0Z9A9ojm5QmTg+2rYLvuJ QASin1PgnypcryXQLXql0GoWoTMg7fLGz4wR2//KmyD8ojJSFfAaW+iFlG00e/KzZrPX9sUzkNn qDSmu3HKUTlFvKOA9n86sIyM5dEIrwEbFsQcH2MnbWdY6HuX6S4u/1FTiavyfbjw= X-Google-Smtp-Source: ABdhPJzm6wQt6H8bjgIi9VN0+b907Oi7/kQkYnHWHSyQhjeiKMW4lNiCZeDWjRivJBzkJEu3O+CrqA== X-Received: by 2002:a17:90a:17cd:: with SMTP id q71mr2616098pja.129.1633577037390; Wed, 06 Oct 2021 20:23:57 -0700 (PDT) Received: from localhost.localdomain ([2600:8802:3300:145:493f:a3ef:de16:5144]) by smtp.gmail.com with ESMTPSA id y15sm16807320pfa.64.2021.10.06.20.23.56 for <dev@dpdk.org> (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Oct 2021 20:23:57 -0700 (PDT) From: Ajit Khaparde <ajit.khaparde@broadcom.com> To: dev@dpdk.org Date: Wed, 6 Oct 2021 20:23:50 -0700 Message-Id: <20211007032353.93579-1-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000000ec20e05cdbacba2" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-dev] [PATCH 0/3] patchset for bnxt PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series | patchset for bnxt PMD | |
Message
Ajit Khaparde
Oct. 7, 2021, 3:23 a.m. UTC
Apart from fixing an issue with Rx queue state at startup, this patchset enhances support for RSS action and optimizes the mbuf requirement at startup by creating the aggregation rings only when needed (rx_scatter is enabled). Please apply! Ajit Khaparde (3): net/bnxt: create aggregration rings when needed net/bnxt: fix Rx queue state on start net/bnxt: enhance support for RSS action drivers/net/bnxt/bnxt_ethdev.c | 16 +-- drivers/net/bnxt/bnxt_filter.h | 1 + drivers/net/bnxt/bnxt_flow.c | 190 ++++++++++++++++++++++++++++++++- drivers/net/bnxt/bnxt_hwrm.c | 9 ++ drivers/net/bnxt/bnxt_ring.c | 148 +++++++++++++++---------- drivers/net/bnxt/bnxt_rxq.c | 71 +++++++----- drivers/net/bnxt/bnxt_rxq.h | 2 + drivers/net/bnxt/bnxt_rxr.c | 111 +++++++++++-------- 8 files changed, 416 insertions(+), 132 deletions(-)
Comments
On Wed, Oct 6, 2021 at 8:23 PM Ajit Khaparde <ajit.khaparde@broadcom.com> wrote: > Apart from fixing an issue with Rx queue state at startup, > this patchset enhances support for RSS action and > optimizes the mbuf requirement at startup by creating the > aggregation rings only when needed (rx_scatter is enabled). > > Please apply! > Patchset applied to dpdk-next-net-brcm. > > Ajit Khaparde (3): > net/bnxt: create aggregration rings when needed > net/bnxt: fix Rx queue state on start > net/bnxt: enhance support for RSS action > > drivers/net/bnxt/bnxt_ethdev.c | 16 +-- > drivers/net/bnxt/bnxt_filter.h | 1 + > drivers/net/bnxt/bnxt_flow.c | 190 ++++++++++++++++++++++++++++++++- > drivers/net/bnxt/bnxt_hwrm.c | 9 ++ > drivers/net/bnxt/bnxt_ring.c | 148 +++++++++++++++---------- > drivers/net/bnxt/bnxt_rxq.c | 71 +++++++----- > drivers/net/bnxt/bnxt_rxq.h | 2 + > drivers/net/bnxt/bnxt_rxr.c | 111 +++++++++++-------- > 8 files changed, 416 insertions(+), 132 deletions(-) > > -- > 2.30.1 (Apple Git-130) > >
On 10/7/2021 5:54 PM, Ajit Khaparde wrote: > On Wed, Oct 6, 2021 at 8:23 PM Ajit Khaparde <ajit.khaparde@broadcom.com> > wrote: > >> Apart from fixing an issue with Rx queue state at startup, >> this patchset enhances support for RSS action and >> optimizes the mbuf requirement at startup by creating the >> aggregation rings only when needed (rx_scatter is enabled). >> >> Please apply! >> > Patchset applied to dpdk-next-net-brcm. > > Hi Ajit, dpdk-next-net-brcm conflicts with next-net because of some patches updating bnxt in next-net. Can you please rebase 'dpdk-next-net-brcm' on top of latest next-net? Thanks, ferruh > >> >> Ajit Khaparde (3): >> net/bnxt: create aggregration rings when needed >> net/bnxt: fix Rx queue state on start >> net/bnxt: enhance support for RSS action >> >> drivers/net/bnxt/bnxt_ethdev.c | 16 +-- >> drivers/net/bnxt/bnxt_filter.h | 1 + >> drivers/net/bnxt/bnxt_flow.c | 190 ++++++++++++++++++++++++++++++++- >> drivers/net/bnxt/bnxt_hwrm.c | 9 ++ >> drivers/net/bnxt/bnxt_ring.c | 148 +++++++++++++++---------- >> drivers/net/bnxt/bnxt_rxq.c | 71 +++++++----- >> drivers/net/bnxt/bnxt_rxq.h | 2 + >> drivers/net/bnxt/bnxt_rxr.c | 111 +++++++++++-------- >> 8 files changed, 416 insertions(+), 132 deletions(-) >> >> -- >> 2.30.1 (Apple Git-130) >> >>
On Tue, Oct 12, 2021 at 11:14 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > > On 10/7/2021 5:54 PM, Ajit Khaparde wrote: > > On Wed, Oct 6, 2021 at 8:23 PM Ajit Khaparde <ajit.khaparde@broadcom.com> > > wrote: > > > >> Apart from fixing an issue with Rx queue state at startup, > >> this patchset enhances support for RSS action and > >> optimizes the mbuf requirement at startup by creating the > >> aggregation rings only when needed (rx_scatter is enabled). > >> > >> Please apply! > >> > > Patchset applied to dpdk-next-net-brcm. > > > > > > Hi Ajit, > > dpdk-next-net-brcm conflicts with next-net because of some patches > updating bnxt in next-net. > Can you please rebase 'dpdk-next-net-brcm' on top of latest next-net? Sure. I will send an email once it's ready. Thanks Ajit > > Thanks, > ferruh > > > > >> > >> Ajit Khaparde (3): > >> net/bnxt: create aggregration rings when needed > >> net/bnxt: fix Rx queue state on start > >> net/bnxt: enhance support for RSS action > >> > >> drivers/net/bnxt/bnxt_ethdev.c | 16 +-- > >> drivers/net/bnxt/bnxt_filter.h | 1 + > >> drivers/net/bnxt/bnxt_flow.c | 190 ++++++++++++++++++++++++++++++++- > >> drivers/net/bnxt/bnxt_hwrm.c | 9 ++ > >> drivers/net/bnxt/bnxt_ring.c | 148 +++++++++++++++---------- > >> drivers/net/bnxt/bnxt_rxq.c | 71 +++++++----- > >> drivers/net/bnxt/bnxt_rxq.h | 2 + > >> drivers/net/bnxt/bnxt_rxr.c | 111 +++++++++++-------- > >> 8 files changed, 416 insertions(+), 132 deletions(-) > >> > >> -- > >> 2.30.1 (Apple Git-130) > >> > >> >
On Tue, Oct 12, 2021 at 11:16 AM Ajit Khaparde <ajit.khaparde@broadcom.com> wrote: > > On Tue, Oct 12, 2021 at 11:14 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > > > > On 10/7/2021 5:54 PM, Ajit Khaparde wrote: > > > On Wed, Oct 6, 2021 at 8:23 PM Ajit Khaparde <ajit.khaparde@broadcom.com> > > > wrote: > > > > > >> Apart from fixing an issue with Rx queue state at startup, > > >> this patchset enhances support for RSS action and > > >> optimizes the mbuf requirement at startup by creating the > > >> aggregation rings only when needed (rx_scatter is enabled). > > >> > > >> Please apply! > > >> > > > Patchset applied to dpdk-next-net-brcm. > > > > > > > > > > Hi Ajit, > > > > dpdk-next-net-brcm conflicts with next-net because of some patches > > updating bnxt in next-net. > > Can you please rebase 'dpdk-next-net-brcm' on top of latest next-net? > Sure. I will send an email once it's ready. Done. I have rebased the repo to the latest next-net/main and merged the patches. Please try now. Thanks Ajit > > Thanks > Ajit > > > > > Thanks, > > ferruh > > > > > > > >> > > >> Ajit Khaparde (3): > > >> net/bnxt: create aggregration rings when needed > > >> net/bnxt: fix Rx queue state on start > > >> net/bnxt: enhance support for RSS action > > >> > > >> drivers/net/bnxt/bnxt_ethdev.c | 16 +-- > > >> drivers/net/bnxt/bnxt_filter.h | 1 + > > >> drivers/net/bnxt/bnxt_flow.c | 190 ++++++++++++++++++++++++++++++++- > > >> drivers/net/bnxt/bnxt_hwrm.c | 9 ++ > > >> drivers/net/bnxt/bnxt_ring.c | 148 +++++++++++++++---------- > > >> drivers/net/bnxt/bnxt_rxq.c | 71 +++++++----- > > >> drivers/net/bnxt/bnxt_rxq.h | 2 + > > >> drivers/net/bnxt/bnxt_rxr.c | 111 +++++++++++-------- > > >> 8 files changed, 416 insertions(+), 132 deletions(-) > > >> > > >> -- > > >> 2.30.1 (Apple Git-130) > > >> > > >> > >
On 10/12/2021 8:03 PM, Ajit Khaparde wrote: > On Tue, Oct 12, 2021 at 11:16 AM Ajit Khaparde > <ajit.khaparde@broadcom.com> wrote: >> >> On Tue, Oct 12, 2021 at 11:14 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote: >>> >>> On 10/7/2021 5:54 PM, Ajit Khaparde wrote: >>>> On Wed, Oct 6, 2021 at 8:23 PM Ajit Khaparde <ajit.khaparde@broadcom.com> >>>> wrote: >>>> >>>>> Apart from fixing an issue with Rx queue state at startup, >>>>> this patchset enhances support for RSS action and >>>>> optimizes the mbuf requirement at startup by creating the >>>>> aggregation rings only when needed (rx_scatter is enabled). >>>>> >>>>> Please apply! >>>>> >>>> Patchset applied to dpdk-next-net-brcm. >>>> >>>> >>> >>> Hi Ajit, >>> >>> dpdk-next-net-brcm conflicts with next-net because of some patches >>> updating bnxt in next-net. >>> Can you please rebase 'dpdk-next-net-brcm' on top of latest next-net? >> Sure. I will send an email once it's ready. > Done. I have rebased the repo to the latest next-net/main > and merged the patches. Please try now. > Hi Ajit, I am getting lots of checkpatch warnings on the patches in your tree, but I don't see them in the patchwork. Warnings can be because of the updates during rebase. If there is code change during rebase, to not have a diverge between the patch in the patchwork and what we are merging, can you please send and updated version of the effected patches first? This lets us see the CI results and later they can be merge in your tree again.
On Tue, Oct 12, 2021 at 12:49 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > > On 10/12/2021 8:03 PM, Ajit Khaparde wrote: > > On Tue, Oct 12, 2021 at 11:16 AM Ajit Khaparde > > <ajit.khaparde@broadcom.com> wrote: > >> > >> On Tue, Oct 12, 2021 at 11:14 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > >>> > >>> On 10/7/2021 5:54 PM, Ajit Khaparde wrote: > >>>> On Wed, Oct 6, 2021 at 8:23 PM Ajit Khaparde <ajit.khaparde@broadcom.com> > >>>> wrote: > >>>> > >>>>> Apart from fixing an issue with Rx queue state at startup, > >>>>> this patchset enhances support for RSS action and > >>>>> optimizes the mbuf requirement at startup by creating the > >>>>> aggregation rings only when needed (rx_scatter is enabled). > >>>>> > >>>>> Please apply! > >>>>> > >>>> Patchset applied to dpdk-next-net-brcm. > >>>> > >>>> > >>> > >>> Hi Ajit, > >>> > >>> dpdk-next-net-brcm conflicts with next-net because of some patches > >>> updating bnxt in next-net. > >>> Can you please rebase 'dpdk-next-net-brcm' on top of latest next-net? > >> Sure. I will send an email once it's ready. > > Done. I have rebased the repo to the latest next-net/main > > and merged the patches. Please try now. > > > > Hi Ajit, > > I am getting lots of checkpatch warnings on the patches in your tree, > but I don't see them in the patchwork. Warnings can be because of the > updates during rebase. > > If there is code change during rebase, to not have a diverge between > the patch in the patchwork and what we are merging, can you please send > and updated version of the effected patches first? There is no code change made during the rebase. My checkpatch run did not point out anything. But let me try again. Thanks Ferruh. Thanks Ajit > This lets us see the CI results and later they can be merge in your tree > again. >
On Tue, Oct 12, 2021 at 1:30 PM Ajit Khaparde <ajit.khaparde@broadcom.com> wrote: > > On Tue, Oct 12, 2021 at 12:49 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > > > > On 10/12/2021 8:03 PM, Ajit Khaparde wrote: > > > On Tue, Oct 12, 2021 at 11:16 AM Ajit Khaparde > > > <ajit.khaparde@broadcom.com> wrote: > > >> > > >> On Tue, Oct 12, 2021 at 11:14 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > > >>> > > >>> On 10/7/2021 5:54 PM, Ajit Khaparde wrote: > > >>>> On Wed, Oct 6, 2021 at 8:23 PM Ajit Khaparde <ajit.khaparde@broadcom.com> > > >>>> wrote: > > >>>> > > >>>>> Apart from fixing an issue with Rx queue state at startup, > > >>>>> this patchset enhances support for RSS action and > > >>>>> optimizes the mbuf requirement at startup by creating the > > >>>>> aggregation rings only when needed (rx_scatter is enabled). > > >>>>> > > >>>>> Please apply! > > >>>>> > > >>>> Patchset applied to dpdk-next-net-brcm. > > >>>> > > >>>> > > >>> > > >>> Hi Ajit, > > >>> > > >>> dpdk-next-net-brcm conflicts with next-net because of some patches > > >>> updating bnxt in next-net. > > >>> Can you please rebase 'dpdk-next-net-brcm' on top of latest next-net? > > >> Sure. I will send an email once it's ready. > > > Done. I have rebased the repo to the latest next-net/main > > > and merged the patches. Please try now. > > > > > > > Hi Ajit, > > > > I am getting lots of checkpatch warnings on the patches in your tree, > > but I don't see them in the patchwork. Warnings can be because of the > > updates during rebase. > > > > If there is code change during rebase, to not have a diverge between > > the patch in the patchwork and what we are merging, can you please send > > and updated version of the effected patches first? > There is no code change made during the rebase. > My checkpatch run did not point out anything. > But let me try again. Thanks Ferruh. Ok, got it. I had done the merge on a new system which did not have the checkpatch setup correctly. I have fixed the issues and updated the tree. Apologies for the trouble. Thanks Ajit > > Thanks > Ajit > > > > > This lets us see the CI results and later they can be merge in your tree > > again. > >