[-v1] bbdev: update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk

Message ID 1637114132-250109-2-git-send-email-mingshan.zhang@intel.com (mailing list archive)
State Changes Requested, archived
Delegated to: akhil goyal
Headers
Series [-v1] bbdev: update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation warning apply issues
ci/iol-testing warning apply patch failure

Commit Message

Zhang, Mingshan Nov. 17, 2021, 1:55 a.m. UTC
  From: Mingshan Zhang <mingshan.zhang@intel.com>

update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk
 
Signed-off-by: Mingshan Zhang <mingshan.zhang@intel.com>
---
 doc/guides/prog_guide/bbdev.rst | 4 ++--
 lib/bbdev/rte_bbdev_op.h        | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
  

Comments

Akhil Goyal Nov. 18, 2021, 7:20 a.m. UTC | #1
> From: Mingshan Zhang <mingshan.zhang@intel.com>

Title is too big. Please run ./devtools/check-git-log.sh.
> 
> update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk
Explain the need for this change. We only take critical fixes in the APIs for RC4.
Bbdev APIs are not experimental anymore. Please rebase on TOT.
This change is an API change which may need deprecation notice from next release.

> 
> Signed-off-by: Mingshan Zhang <mingshan.zhang@intel.com>
> ---
>  doc/guides/prog_guide/bbdev.rst | 4 ++--
>  lib/bbdev/rte_bbdev_op.h        | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/doc/guides/prog_guide/bbdev.rst
> b/doc/guides/prog_guide/bbdev.rst
> index 70fa01a..c330e08 100644
> --- a/doc/guides/prog_guide/bbdev.rst
> +++ b/doc/guides/prog_guide/bbdev.rst
> @@ -387,10 +387,10 @@ allocate bbdev operations of a specific type from a
> given bbdev operation mempoo
>  .. code-block:: c
> 
>      int rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
> -            struct rte_bbdev_enc_op **ops, uint16_t num_ops)
> +            struct rte_bbdev_enc_op **ops, uint32_t num_ops)
> 
>      int rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
> -            struct rte_bbdev_dec_op **ops, uint16_t num_ops)
> +            struct rte_bbdev_dec_op **ops, uint32_t num_ops)
> 
>  ``rte_bbdev_*_op_free_bulk()`` is called by the application to return an
>  operation to its allocating pool.
> diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h
> index 5512859..f074b35 100644
> --- a/lib/bbdev/rte_bbdev_op.h
> +++ b/lib/bbdev/rte_bbdev_op.h
> @@ -867,7 +867,7 @@ struct rte_mempool *
>  __rte_experimental
>  static inline int
>  rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
> -		struct rte_bbdev_enc_op **ops, uint16_t num_ops)
> +		struct rte_bbdev_enc_op **ops, uint32_t num_ops)
>  {
>  	struct rte_bbdev_op_pool_private *priv;
>  	int ret;
> @@ -904,7 +904,7 @@ struct rte_mempool *
>  __rte_experimental
>  static inline int
>  rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
> -		struct rte_bbdev_dec_op **ops, uint16_t num_ops)
> +		struct rte_bbdev_dec_op **ops, uint32_t num_ops)
>  {
>  	struct rte_bbdev_op_pool_private *priv;
>  	int ret;
> --
> 1.8.3.1
  
Chautru, Nicolas Nov. 18, 2021, 3:16 p.m. UTC | #2
Hi Akhil, 
The change below from Mingshan is not for 21.11, this is targeting following release. It should have been mentioned in cover letter. 
Thanks
Nic


> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Wednesday, November 17, 2021 11:21 PM
> To: Zhang, Mingshan <mingshan.zhang@intel.com>; dev@dpdk.org;
> akhil.goyal@nxp.com
> Cc: Chautru, Nicolas <nicolas.chautru@intel.com>
> Subject: RE: [EXT] [PATCH -v1] bbdev: update num_ops type to be uint32_t in
> rte_bbdev_enc_op_alloc_bulk
> 
> > From: Mingshan Zhang <mingshan.zhang@intel.com>
> 
> Title is too big. Please run ./devtools/check-git-log.sh.
> >
> > update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk
> Explain the need for this change. We only take critical fixes in the APIs for
> RC4.
> Bbdev APIs are not experimental anymore. Please rebase on TOT.
> This change is an API change which may need deprecation notice from next
> release.
> 
> >
> > Signed-off-by: Mingshan Zhang <mingshan.zhang@intel.com>
> > ---
> >  doc/guides/prog_guide/bbdev.rst | 4 ++--
> >  lib/bbdev/rte_bbdev_op.h        | 4 ++--
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/doc/guides/prog_guide/bbdev.rst
> > b/doc/guides/prog_guide/bbdev.rst index 70fa01a..c330e08 100644
> > --- a/doc/guides/prog_guide/bbdev.rst
> > +++ b/doc/guides/prog_guide/bbdev.rst
> > @@ -387,10 +387,10 @@ allocate bbdev operations of a specific type
> > from a given bbdev operation mempoo  .. code-block:: c
> >
> >      int rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
> > -            struct rte_bbdev_enc_op **ops, uint16_t num_ops)
> > +            struct rte_bbdev_enc_op **ops, uint32_t num_ops)
> >
> >      int rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
> > -            struct rte_bbdev_dec_op **ops, uint16_t num_ops)
> > +            struct rte_bbdev_dec_op **ops, uint32_t num_ops)
> >
> >  ``rte_bbdev_*_op_free_bulk()`` is called by the application to return
> > an  operation to its allocating pool.
> > diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h index
> > 5512859..f074b35 100644
> > --- a/lib/bbdev/rte_bbdev_op.h
> > +++ b/lib/bbdev/rte_bbdev_op.h
> > @@ -867,7 +867,7 @@ struct rte_mempool *  __rte_experimental  static
> > inline int  rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
> > -		struct rte_bbdev_enc_op **ops, uint16_t num_ops)
> > +		struct rte_bbdev_enc_op **ops, uint32_t num_ops)
> >  {
> >  	struct rte_bbdev_op_pool_private *priv;
> >  	int ret;
> > @@ -904,7 +904,7 @@ struct rte_mempool *  __rte_experimental  static
> > inline int  rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
> > -		struct rte_bbdev_dec_op **ops, uint16_t num_ops)
> > +		struct rte_bbdev_dec_op **ops, uint32_t num_ops)
> >  {
> >  	struct rte_bbdev_op_pool_private *priv;
> >  	int ret;
> > --
> > 1.8.3.1
  

Patch

diff --git a/doc/guides/prog_guide/bbdev.rst b/doc/guides/prog_guide/bbdev.rst
index 70fa01a..c330e08 100644
--- a/doc/guides/prog_guide/bbdev.rst
+++ b/doc/guides/prog_guide/bbdev.rst
@@ -387,10 +387,10 @@  allocate bbdev operations of a specific type from a given bbdev operation mempoo
 .. code-block:: c
 
     int rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
-            struct rte_bbdev_enc_op **ops, uint16_t num_ops)
+            struct rte_bbdev_enc_op **ops, uint32_t num_ops)
 
     int rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
-            struct rte_bbdev_dec_op **ops, uint16_t num_ops)
+            struct rte_bbdev_dec_op **ops, uint32_t num_ops)
 
 ``rte_bbdev_*_op_free_bulk()`` is called by the application to return an
 operation to its allocating pool.
diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h
index 5512859..f074b35 100644
--- a/lib/bbdev/rte_bbdev_op.h
+++ b/lib/bbdev/rte_bbdev_op.h
@@ -867,7 +867,7 @@  struct rte_mempool *
 __rte_experimental
 static inline int
 rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
-		struct rte_bbdev_enc_op **ops, uint16_t num_ops)
+		struct rte_bbdev_enc_op **ops, uint32_t num_ops)
 {
 	struct rte_bbdev_op_pool_private *priv;
 	int ret;
@@ -904,7 +904,7 @@  struct rte_mempool *
 __rte_experimental
 static inline int
 rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
-		struct rte_bbdev_dec_op **ops, uint16_t num_ops)
+		struct rte_bbdev_dec_op **ops, uint32_t num_ops)
 {
 	struct rte_bbdev_op_pool_private *priv;
 	int ret;