diff mbox series

common/cnxk: fix missing null check in IPv6 flow parsing

Message ID 20220125041248.905732-1-psatheesh@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series common/cnxk: fix missing null check in IPv6 flow parsing |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing warning apply patch failure
ci/Intel-compilation fail Compilation issues
ci/intel-Testing success Testing PASS

Commit Message

Satheesh Paul Antonysamy Jan. 25, 2022, 4:12 a.m. UTC 
  From: Satheesh Paul <psatheesh@marvell.com>

Added null check in IPv6 flow pattern parsing.

Fixes: a55dc02af5 ("common/cnxk: support extensions attributes in IPv6 item")
Cc: stable@dpdk.org

Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
---
 drivers/common/cnxk/roc_npc_parse.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Jerin Jacob Feb. 17, 2022, 4:34 a.m. UTC | #1 
On Tue, Jan 25, 2022 at 9:43 AM <psatheesh@marvell.com> wrote:
>
> From: Satheesh Paul <psatheesh@marvell.com>
>
> Added null check in IPv6 flow pattern parsing.
>
> Fixes: a55dc02af5 ("common/cnxk: support extensions attributes in IPv6 item")

The changeset is not correct.

> Cc: stable@dpdk.org
>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Jerin Jacob Kollanukkaran <jerinj@marvell.com>


Updated the git commit as follows and Applied to
dpdk-next-net-mrvl/for-next-net. Thanks

    common/cnxk: fix null access in IPv6 flow parsing

    Added null check in IPv6 flow pattern parsing.

    Fixes: 474e275b1bc6 ("common/cnxk: support extensions attributes
in IPv6 item")
    Cc: stable@dpdk.org

    Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
    Reviewed-by: Jerin Jacob <jerinj@marvell.com>


> ---
>  drivers/common/cnxk/roc_npc_parse.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_npc_parse.c b/drivers/common/cnxk/roc_npc_parse.c
> index 1f21693369..302ab66efc 100644
> --- a/drivers/common/cnxk/roc_npc_parse.c
> +++ b/drivers/common/cnxk/roc_npc_parse.c
> @@ -562,9 +562,11 @@ npc_parse_lc(struct npc_parse_state *pst)
>                 ipv6_spec = pst->pattern->spec;
>                 lid = NPC_LID_LC;
>                 lt = NPC_LT_LC_IP6;
> -               rc = npc_handle_ipv6ext_attr(ipv6_spec, pst, &flags);
> -               if (rc)
> -                       return rc;
> +               if (ipv6_spec) {
> +                       rc = npc_handle_ipv6ext_attr(ipv6_spec, pst, &flags);
> +                       if (rc)
> +                               return rc;
> +               }
>                 info.len = sizeof(ipv6_spec->hdr);
>                 break;
>         case ROC_NPC_ITEM_TYPE_ARP_ETH_IPV4:
> --
> 2.25.4
>
diff mbox series

Patch

diff --git a/drivers/common/cnxk/roc_npc_parse.c b/drivers/common/cnxk/roc_npc_parse.c
index 1f21693369..302ab66efc 100644
--- a/drivers/common/cnxk/roc_npc_parse.c
+++ b/drivers/common/cnxk/roc_npc_parse.c
@@ -562,9 +562,11 @@  npc_parse_lc(struct npc_parse_state *pst)
 		ipv6_spec = pst->pattern->spec;
 		lid = NPC_LID_LC;
 		lt = NPC_LT_LC_IP6;
-		rc = npc_handle_ipv6ext_attr(ipv6_spec, pst, &flags);
-		if (rc)
-			return rc;
+		if (ipv6_spec) {
+			rc = npc_handle_ipv6ext_attr(ipv6_spec, pst, &flags);
+			if (rc)
+				return rc;
+		}
 		info.len = sizeof(ipv6_spec->hdr);
 		break;
 	case ROC_NPC_ITEM_TYPE_ARP_ETH_IPV4: