diff mbox series

net/nfp: remove unneeded header inclusion

Message ID 20220408094116.6542-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/nfp: remove unneeded header inclusion |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-aarch64-unit-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-compile-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

David Marchand April 8, 2022, 9:41 a.m. UTC 
  Looking at this driver history, there was never a need for including
execinfo.h.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Niklas Söderlund April 21, 2022, 11:14 a.m. UTC | #1 
Hi David,

Thanks for your work.

On 2022-04-08 11:41:16 +0200, David Marchand wrote:
> Looking at this driver history, there was never a need for including
> execinfo.h.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>

> ---
>  drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> index bad80a5a1c..08bc4e8ef2 100644
> --- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> +++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> @@ -16,9 +16,6 @@
>  
>  #include <assert.h>
>  #include <stdio.h>
> -#if defined(RTE_BACKTRACE)
> -#include <execinfo.h>
> -#endif
>  #include <stdlib.h>
>  #include <unistd.h>
>  #include <stdint.h>
> -- 
> 2.23.0
>
Ferruh Yigit May 4, 2022, 12:31 p.m. UTC | #2 
On 4/21/2022 12:14 PM, Niklas Soderlund wrote:
> Hi David,
> 
> Thanks for your work.
> 
> On 2022-04-08 11:41:16 +0200, David Marchand wrote:
>> Looking at this driver history, there was never a need for including
>> execinfo.h.
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
> 
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> 

     Fixes: bdbf45c24b07 ("net/nfp: fix build with musl libc")
     Cc: stable@dpdk.org

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
index bad80a5a1c..08bc4e8ef2 100644
--- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
+++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
@@ -16,9 +16,6 @@ 
 
 #include <assert.h>
 #include <stdio.h>
-#if defined(RTE_BACKTRACE)
-#include <execinfo.h>
-#endif
 #include <stdlib.h>
 #include <unistd.h>
 #include <stdint.h>