diff mbox series

[v6,2/3] app/testpmd: add skip cman support for testpmd

Message ID 20230210082623.1005496-2-rkudurumalla@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series [v6,1/3] ethdev: skip congestion management configuration |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Rakesh Kudurumalla Feb. 10, 2023, 8:26 a.m. UTC 
  added support for testpmd application to accept
skip_cman action while configuring policy action

Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
---
 app/test-pmd/cmdline_flow.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Ferruh Yigit Feb. 10, 2023, 11:08 p.m. UTC | #1 
On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote:
> added support for testpmd application to accept
> skip_cman action while configuring policy action
> 

Can you please give some sample testpmd commands with new action in
commit log, it helps.

> Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> ---
>  app/test-pmd/cmdline_flow.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 88108498e0..fc003e0096 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -472,6 +472,7 @@ enum index {
>  	ACTION_END,
>  	ACTION_VOID,
>  	ACTION_PASSTHRU,
> +	ACTION_SKIP_CMAN,
>  	ACTION_JUMP,
>  	ACTION_JUMP_GROUP,
>  	ACTION_MARK,
> @@ -1825,6 +1826,7 @@ static const enum index next_action[] = {
>  	ACTION_END,
>  	ACTION_VOID,
>  	ACTION_PASSTHRU,
> +	ACTION_SKIP_CMAN,
>  	ACTION_JUMP,
>  	ACTION_MARK,
>  	ACTION_FLAG,
> @@ -5159,6 +5161,13 @@ static const struct token token_list[] = {
>  		.next = NEXT(NEXT_ENTRY(ACTION_NEXT)),
>  		.call = parse_vc,
>  	},
> +	[ACTION_SKIP_CMAN] = {
> +		.name = "skip_cman",
> +		.help = "bypass cman on received packets",
> +		.priv = PRIV_ACTION(SKIP_CMAN, 0),
> +		.next = NEXT(NEXT_ENTRY(ACTION_NEXT)),
> +		.call = parse_vc,
> +	},
>  	[ACTION_JUMP] = {
>  		.name = "jump",
>  		.help = "redirect traffic to a given group",
Ferruh Yigit Feb. 14, 2023, 1:12 p.m. UTC | #2 
On 2/10/2023 11:08 PM, Ferruh Yigit wrote:
> On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote:
>> added support for testpmd application to accept
>> skip_cman action while configuring policy action
>>
> 
> Can you please give some sample testpmd commands with new action in
> commit log, it helps.
> 

reminder of this comment, v8 doesn't have this.

please check following as sample:
"app/testpmd: add shared indirect action support"
https://git.dpdk.org/next/dpdk-next-net/commit/?id=c13f2654cd3c67e526be0

>> Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
>> ---
>>  app/test-pmd/cmdline_flow.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
>> index 88108498e0..fc003e0096 100644
>> --- a/app/test-pmd/cmdline_flow.c
>> +++ b/app/test-pmd/cmdline_flow.c
>> @@ -472,6 +472,7 @@ enum index {
>>  	ACTION_END,
>>  	ACTION_VOID,
>>  	ACTION_PASSTHRU,
>> +	ACTION_SKIP_CMAN,
>>  	ACTION_JUMP,
>>  	ACTION_JUMP_GROUP,
>>  	ACTION_MARK,
>> @@ -1825,6 +1826,7 @@ static const enum index next_action[] = {
>>  	ACTION_END,
>>  	ACTION_VOID,
>>  	ACTION_PASSTHRU,
>> +	ACTION_SKIP_CMAN,
>>  	ACTION_JUMP,
>>  	ACTION_MARK,
>>  	ACTION_FLAG,
>> @@ -5159,6 +5161,13 @@ static const struct token token_list[] = {
>>  		.next = NEXT(NEXT_ENTRY(ACTION_NEXT)),
>>  		.call = parse_vc,
>>  	},
>> +	[ACTION_SKIP_CMAN] = {
>> +		.name = "skip_cman",
>> +		.help = "bypass cman on received packets",
>> +		.priv = PRIV_ACTION(SKIP_CMAN, 0),
>> +		.next = NEXT(NEXT_ENTRY(ACTION_NEXT)),
>> +		.call = parse_vc,
>> +	},
>>  	[ACTION_JUMP] = {
>>  		.name = "jump",
>>  		.help = "redirect traffic to a given group",
>
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 88108498e0..fc003e0096 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -472,6 +472,7 @@  enum index {
 	ACTION_END,
 	ACTION_VOID,
 	ACTION_PASSTHRU,
+	ACTION_SKIP_CMAN,
 	ACTION_JUMP,
 	ACTION_JUMP_GROUP,
 	ACTION_MARK,
@@ -1825,6 +1826,7 @@  static const enum index next_action[] = {
 	ACTION_END,
 	ACTION_VOID,
 	ACTION_PASSTHRU,
+	ACTION_SKIP_CMAN,
 	ACTION_JUMP,
 	ACTION_MARK,
 	ACTION_FLAG,
@@ -5159,6 +5161,13 @@  static const struct token token_list[] = {
 		.next = NEXT(NEXT_ENTRY(ACTION_NEXT)),
 		.call = parse_vc,
 	},
+	[ACTION_SKIP_CMAN] = {
+		.name = "skip_cman",
+		.help = "bypass cman on received packets",
+		.priv = PRIV_ACTION(SKIP_CMAN, 0),
+		.next = NEXT(NEXT_ENTRY(ACTION_NEXT)),
+		.call = parse_vc,
+	},
 	[ACTION_JUMP] = {
 		.name = "jump",
 		.help = "redirect traffic to a given group",