ipsec_mb: expect ENOTSUP in ipsec_mb_create()

  Commit b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request
handler") is part of DPDK 22.11 release and it enforces usage of shared
config and multiprocess mode.

DPDK is not required to be run with more than one
process in general, so instead of erroring out,
catch the error and proceed with ipsec_mb device
creation normally.

Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
---
 .mailmap                                   | 1 +
 drivers/crypto/ipsec_mb/ipsec_mb_private.c | 9 ++-------
 2 files changed, 3 insertions(+), 7 deletions(-)
  

> Subject: [EXT] [PATCH] ipsec_mb: expect ENOTSUP in ipsec_mb_create()

Title should start with crypto/ipsec_mb:
Avoid using function names in patch titles.

> 
> Commit b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request
> handler") is part of DPDK 22.11 release and it enforces usage of shared
> config and multiprocess mode.
> 
> DPDK is not required to be run with more than one
> process in general, so instead of erroring out,
> catch the error and proceed with ipsec_mb device
> creation normally.

This seems to be a fix, kindly adhere to the guidelines for fixes patches.
> 
> Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>


Kai/Pablo,
Acks please?

> ---
>  .mailmap                                   | 1 +
>  drivers/crypto/ipsec_mb/ipsec_mb_private.c | 9 ++-------
>  2 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/.mailmap b/.mailmap
> index a9f4f28fba..dad475b9d0 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -1583,3 +1583,4 @@ Ziye Yang <ziye.yang@intel.com>
>  Zoltan Kiss <zoltan.kiss@schaman.hu> <zoltan.kiss@linaro.org>
>  Zorik Machulsky <zorik@amazon.com>
>  Zyta Szpak <zyta@marvell.com> <zr@semihalf.com>
> <zyta.szpak@semihalf.com>
> +Krzysztof Karas <krzysztof.karas@intel.com>
> diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_private.c
> b/drivers/crypto/ipsec_mb/ipsec_mb_private.c
> index 50b789a29b..9eebf9bbc9 100644
> --- a/drivers/crypto/ipsec_mb/ipsec_mb_private.c
> +++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.c
> @@ -170,13 +170,8 @@ ipsec_mb_create(struct rte_vdev_device *vdev,
> 
>  	if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
>  		retval = ipsec_mb_mp_request_register();
> -		if (retval && (rte_errno == EEXIST))
> -			/* Safe to proceed, return 0 */
> -			return 0;
> -
> -		if (retval)
> -			IPSEC_MB_LOG(ERR,
> -				"IPSec Multi-buffer register MP request
> failed.\n");
> +		if (retval != 0 && rte_errno == ENOTSUP)
> +			retval = 0;
>  	}
>  	return retval;
>  }
> --
> 2.34.1
> 
> ---------------------------------------------------------------------
> Intel Technology Poland sp. z o.o.
> ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII
> Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-
> 52-316 | Kapital zakladowy 200.000 PLN.
> Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy
> z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w
> transakcjach handlowych.
> 
> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i
> moze zawierac informacje poufne. W razie przypadkowego otrzymania tej
> wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie;
> jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
> This e-mail and any attachments may contain confidential material for the sole
> use of the intended recipient(s). If you are not the intended recipient, please
> contact the sender and delete all copies; any review or distribution by others is
> strictly prohibited.
  

Is there any validation to this changes ? I Can't remember the exact reason why EEXIST
 returned, somehow we need to handle that case. 

Regards

Kai 

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Monday, February 27, 2023 6:27 PM
> To: Karas, Krzysztof <krzysztof.karas@intel.com>; Thomas Monjalon
> <thomas@monjalon.net>; Ji, Kai <kai.ji@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [EXT] [PATCH] ipsec_mb: expect ENOTSUP in ipsec_mb_create()
> 
> > Subject: [EXT] [PATCH] ipsec_mb: expect ENOTSUP in ipsec_mb_create()
> 
> Title should start with crypto/ipsec_mb:
> Avoid using function names in patch titles.
> 
> >
> > Commit b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request
> > handler") is part of DPDK 22.11 release and it enforces usage of
> > shared config and multiprocess mode.
> >
> > DPDK is not required to be run with more than one process in general,
> > so instead of erroring out, catch the error and proceed with ipsec_mb
> > device creation normally.
> 
> This seems to be a fix, kindly adhere to the guidelines for fixes patches.
> >
> > Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
> 
> 
> Kai/Pablo,
> Acks please?
>