app/testpmd: fix unpassed RSS algorithm
Checks
Commit Message
The RSS algorithm from user is parased but not passed to the
rte_eth_dev_rss_hash_update() API as we wanted, this patch
fixes it.
Fixes: 3da59f30a23f ("app/testpmd: set RSS hash algorithm")
Cc: stable@dpdk.org
Signed-off-by: Jie Hai <haijie1@huawei.com>
---
app/test-pmd/cmdline.c | 1 +
1 file changed, 1 insertion(+)
Comments
On 3/15/2024 3:00 AM, Jie Hai wrote:
> The RSS algorithm from user is parased but not passed to the
> rte_eth_dev_rss_hash_update() API as we wanted, this patch
> fixes it.
>
> Fixes: 3da59f30a23f ("app/testpmd: set RSS hash algorithm")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jie Hai <haijie1@huawei.com>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
Sorry to see we missed something this simple, wasn't this tested when
command is added?
On 2024/3/15 19:17, Ferruh Yigit wrote:
> On 3/15/2024 3:00 AM, Jie Hai wrote:
>> The RSS algorithm from user is parased but not passed to the
>> rte_eth_dev_rss_hash_update() API as we wanted, this patch
>> fixes it.
>>
>> Fixes: 3da59f30a23f ("app/testpmd: set RSS hash algorithm")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Jie Hai <haijie1@huawei.com>
>>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
> Applied to dpdk-next-net/main, thanks.
>
>
> Sorry to see we missed something this simple, wasn't this tested when
> command is added?
>
> .
I'm sorry for my mistake.
After the first round of functional tests passed,
I didn't double check it carefully after the second round of changes.
@@ -2319,6 +2319,7 @@ cmd_config_rss_hash_algo_parsed(void *parsed_result,
return;
}
+ rss_conf.algorithm = algorithm;
ret = rte_eth_dev_rss_hash_update(res->port_id, &rss_conf);
if (ret != 0) {
fprintf(stderr, "failed to set port %u RSS hash algorithm\n",