[dpdk-dev,v2,3/3] logs: remove log level config option
Checks
Commit Message
Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
option for controlling datapath log level.
RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
control global and module specific log levels.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
config/common_base | 1 -
devtools/test-build.sh | 2 +-
doc/guides/faq/faq.rst | 3 ---
drivers/net/ena/base/ena_plat_dpdk.h | 2 +-
drivers/net/sfc/sfc_debug.h | 2 +-
examples/l3fwd-acl/main.c | 2 +-
6 files changed, 4 insertions(+), 8 deletions(-)
Comments
On Sat, Dec 09, 2017 at 06:53:58PM +0530, Pavan Nikhilesh wrote:
> Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
> option for controlling datapath log level.
> RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
> control global and module specific log levels.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
12/12/2017 17:36, Olivier MATZ:
> On Sat, Dec 09, 2017 at 06:53:58PM +0530, Pavan Nikhilesh wrote:
> > Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
> > option for controlling datapath log level.
> > RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
> > control global and module specific log levels.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
It breaks compilation of test/ directory.
Please check git grep RTE_LOG_LEVEL
Hi Thomas,
The patchset depends on the following patchset
http://dpdk.org/dev/patchwork/patch/32038/
Thanks,
Pavan
On Fri, Jan 12, 2018 at 04:46:47PM +0100, Thomas Monjalon wrote:
> 12/12/2017 17:36, Olivier MATZ:
> > On Sat, Dec 09, 2017 at 06:53:58PM +0530, Pavan Nikhilesh wrote:
> > > Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
> > > option for controlling datapath log level.
> > > RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
> > > control global and module specific log levels.
> > >
> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> >
> > Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
>
> It breaks compilation of test/ directory.
> Please check git grep RTE_LOG_LEVEL
12/01/2018 16:52, Pavan Nikhilesh:
> Hi Thomas,
>
> The patchset depends on the following patchset
> http://dpdk.org/dev/patchwork/patch/32038/
OK thanks !
12/12/2017 17:36, Olivier MATZ:
> On Sat, Dec 09, 2017 at 06:53:58PM +0530, Pavan Nikhilesh wrote:
> > Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
> > option for controlling datapath log level.
> > RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
> > control global and module specific log levels.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
Series applied, thanks
@@ -94,7 +94,6 @@ CONFIG_RTE_MAX_MEMSEG=256
CONFIG_RTE_MAX_MEMZONE=2560
CONFIG_RTE_MAX_TAILQ=32
CONFIG_RTE_ENABLE_ASSERT=n
-CONFIG_RTE_LOG_LEVEL=RTE_LOG_INFO
CONFIG_RTE_LOG_DP_LEVEL=RTE_LOG_INFO
CONFIG_RTE_LOG_HISTORY=256
CONFIG_RTE_BACKTRACE=y
@@ -157,7 +157,7 @@ config () # <directory> <target> <options>
! echo $3 | grep -q '+shared' || \
sed -ri 's,(SHARED_LIB=)n,\1y,' $1/.config
! echo $3 | grep -q '+debug' || ( \
- sed -ri 's,(RTE_LOG_LEVEL=).*,\1RTE_LOG_DEBUG,' $1/.config
+ sed -ri 's,(RTE_LOG_DP_LEVEL=).*,\1RTE_LOG_DEBUG,' $1/.config
sed -ri 's,(_DEBUG.*=)n,\1y,' $1/.config
sed -ri 's,(_STAT.*=)n,\1y,' $1/.config
sed -ri 's,(TEST_PMD_RECORD_.*=)n,\1y,' $1/.config )
@@ -103,9 +103,6 @@ Yes, the option ``--log-level=`` accepts one of these numbers:
#define RTE_LOG_INFO 7U /* Informational. */
#define RTE_LOG_DEBUG 8U /* Debug-level messages. */
-It is also possible to change the default level at compile time
-with ``CONFIG_RTE_LOG_LEVEL``.
-
How can I tune my network application to achieve lower latency?
---------------------------------------------------------------
@@ -96,7 +96,7 @@ typedef uint64_t dma_addr_t;
#define ENA_GET_SYSTEM_USECS() \
(rte_get_timer_cycles() * US_PER_S / rte_get_timer_hz())
-#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
#define ENA_ASSERT(cond, format, arg...) \
do { \
if (unlikely(!(cond))) { \
@@ -35,7 +35,7 @@
#include <rte_debug.h>
#ifdef RTE_LIBRTE_SFC_EFX_DEBUG
-/* Avoid dependency from RTE_LOG_LEVEL to be able to enable debug check
+/* Avoid dependency from RTE_LOG_DP_LEVEL to be able to enable debug check
* in the driver only.
*/
#define SFC_ASSERT(exp) RTE_VERIFY(exp)
@@ -68,7 +68,7 @@
#include <rte_string_fns.h>
#include <rte_acl.h>
-#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
#define L3FWDACL_DEBUG
#endif
#define DO_RFC_1812_CHECKS