[dpdk-dev,v2,1/1] test: fix build with GCC 4.8.5

Message ID 1525720372-1063-1-git-send-email-erik.g.carrillo@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Carrillo, Erik G May 7, 2018, 7:12 p.m. UTC
  Build errors occur on CentOS 7 with GCC 4.8.5 20150623 in the
event_timer_adapter_test autotest; the
-Werror=missing-field-initializers option causes the compiler to emit
messages like "error: missing initializer for field ‘priority’ of
‘struct <anonymous>’" in several places.

Add -Wno-missing-field-initializers to the test's CFLAGS to allow the
current syntax if we are using GCC 5.0 or lower.

Fixes: d1f3385d0076 ("test: add event timer adapter auto-test")

Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---

v2:
- Add the 'Fixes' tag. (Jerin)

 test/test/Makefile | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Jerin Jacob May 9, 2018, 9:07 a.m. UTC | #1
-----Original Message-----
> Date: Mon, 7 May 2018 14:12:52 -0500
> From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org
> Subject: [PATCH v2 1/1] test: fix build with GCC 4.8.5
> X-Mailer: git-send-email 1.7.10
> 
> Build errors occur on CentOS 7 with GCC 4.8.5 20150623 in the
> event_timer_adapter_test autotest; the
> -Werror=missing-field-initializers option causes the compiler to emit
> messages like "error: missing initializer for field ‘priority’ of
> ‘struct <anonymous>’" in several places.
> 
> Add -Wno-missing-field-initializers to the test's CFLAGS to allow the
> current syntax if we are using GCC 5.0 or lower.
> 
> Fixes: d1f3385d0076 ("test: add event timer adapter auto-test")
> 
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied to dpdk-next-eventdev/master. Thanks.

> ---
> 
> v2:
> - Add the 'Fixes' tag. (Jerin)
> 
>  test/test/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/test/Makefile b/test/test/Makefile
> index 2630ab4..2011857 100644
> --- a/test/test/Makefile
> +++ b/test/test/Makefile
> @@ -211,6 +211,7 @@ CFLAGS_test_memcpy_perf.o += -fno-var-tracking-assignments
>  # designated initializers.
>  ifeq ($(shell test $(GCC_VERSION) -le 50 && echo 1), 1)
>  CFLAGS_test_eventdev_sw.o += -Wno-missing-field-initializers
> +CFLAGS_test_event_timer_adapter.o += -Wno-missing-field-initializers
>  endif
>  endif
>  endif
> -- 
> 2.6.4
>
  

Patch

diff --git a/test/test/Makefile b/test/test/Makefile
index 2630ab4..2011857 100644
--- a/test/test/Makefile
+++ b/test/test/Makefile
@@ -211,6 +211,7 @@  CFLAGS_test_memcpy_perf.o += -fno-var-tracking-assignments
 # designated initializers.
 ifeq ($(shell test $(GCC_VERSION) -le 50 && echo 1), 1)
 CFLAGS_test_eventdev_sw.o += -Wno-missing-field-initializers
+CFLAGS_test_event_timer_adapter.o += -Wno-missing-field-initializers
 endif
 endif
 endif